@markw65/monkeyc-optimizer 1.0.17 → 1.0.18

package/README.md

@@ -193,3 +193,8 @@ More fixes found via open source projects.
 
 - Bug Fixes
   - Fix a bug affecting lookup of types, which could cause definitions, references and links to the api docs to be missed in the vscode extension
+
+### 1.0.18
+
+- Bug Fixes
+  - The new inliner was too agressive at constant propagating literal parameters to their point of use.

package/build/api.cjs

@@ -181,7 +181,7 @@ function getArgSafety(state, func, args, requireAll) {
     })) {
         return false;
     }
-    if (allSafe)
+    if (allSafe && requireAll)
         return true;
     let callSeen = false;
     let ok = true;
@@ -204,10 +204,16 @@ function getArgSafety(state, func, args, requireAll) {
             .map(([key]) => key);
     }, (node) => {
         switch (node.type) {
+            case "AssignmentExpression":
+            case "UpdateExpression": {
+                const v = node.type == "UpdateExpression" ? node.argument : node.left;
+                if (v.type === "Identifier" && hasProperty(params, v.name)) {
+                    safeArgs[params[v.name]] = null;
+                }
+            }
+            // fall through
             case "CallExpression":
             case "NewExpression":
-            case "AssignmentExpression":
-            case "UpdateExpression":
                 callSeen = true;
                 break;
             case "Identifier":

package/build/optimizer.cjs

@@ -10902,7 +10902,7 @@ function getArgSafety(state, func, args, requireAll) {
     })) {
         return false;
     }
-    if (allSafe)
+    if (allSafe && requireAll)
         return true;
     let callSeen = false;
     let ok = true;
@@ -10925,10 +10925,16 @@ function getArgSafety(state, func, args, requireAll) {
             .map(([key]) => key);
     }, (node) => {
         switch (node.type) {
+            case "AssignmentExpression":
+            case "UpdateExpression": {
+                const v = node.type == "UpdateExpression" ? node.argument : node.left;
+                if (v.type === "Identifier" && (0,external_api_cjs_namespaceObject.hasProperty)(params, v.name)) {
+                    safeArgs[params[v.name]] = null;
+                }
+            }
+            // fall through
             case "CallExpression":
             case "NewExpression":
-            case "AssignmentExpression":
-            case "UpdateExpression":
                 callSeen = true;
                 break;
             case "Identifier":
@@ -12571,7 +12577,7 @@ async function generateOneConfig(buildConfig, dependencyFiles, config) {
         // the oldest optimized file, we don't need to regenerate
         const source_time = await (0,external_util_cjs_namespaceObject.last_modified)(Object.keys(fnMap).concat(dependencyFiles));
         const opt_time = await (0,external_util_cjs_namespaceObject.first_modified)(Object.values(fnMap).map((v) => v.output));
-        if (source_time < opt_time && 1654384985724 < opt_time) {
+        if (source_time < opt_time && 1654389404778 < opt_time) {
             return hasTests;
         }
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@markw65/monkeyc-optimizer",
   "type": "module",
-  "version": "1.0.17",
+  "version": "1.0.18",
   "description": "Source to source optimizer for Garmin Monkey C code",
   "main": "build/optimizer.cjs",
   "types": "build/src/optimizer.d.ts",