@markuplint/rules 3.10.0 → 3.12.0

package/lib/attr-check.d.ts

@@ -2,14 +2,14 @@ import type { Translator } from '@markuplint/i18n';
 import type { Attribute as AttrSpec, AttributeType } from '@markuplint/ml-spec';
 import type { ReadonlyDeep } from 'type-fest';
 type Invalid = {
-	invalidType: 'non-existent' | 'invalid-value' | 'disallowed-attr';
-	message: string;
-	loc?: Loc;
+    invalidType: 'non-existent' | 'invalid-value' | 'disallowed-attr';
+    message: string;
+    loc?: Loc;
 };
 type Loc = {
-	raw: string;
-	line: number;
-	col: number;
+    raw: string;
+    line: number;
+    col: number;
 };
 /**
  * Use in rules `invalid-attr` and `wai-aria`
@@ -19,17 +19,6 @@ type Loc = {
  * @param isCustomRule
  * @param spec
  */
-export declare function attrCheck(
-	t: Translator,
-	name: string,
-	value: string,
-	isCustomRule: boolean,
-	spec?: AttrSpec,
-): Invalid | false;
-export declare function valueCheck(
-	t: Translator,
-	name: string,
-	value: string,
-	type: ReadonlyDeep<AttributeType>,
-): [string, Loc] | false;
+export declare function attrCheck(t: Translator, name: string, value: string, isCustomRule: boolean, spec?: AttrSpec): Invalid | false;
+export declare function valueCheck(t: Translator, name: string, value: string, type: ReadonlyDeep<AttributeType>): [string, Loc] | false;
 export {};

package/lib/character-reference/index.js

@@ -43,7 +43,7 @@ exports.default = (0, ml_core_1.createRule)({
             if (!('scope' in targetNode && 'line' in targetNode && targetNode.line != null)) {
                 continue;
             }
-            const escapedText = targetNode.raw.replace(/&(?:[a-z]+|#[0-9]+|x[0-9]);/gi, $0 => '*'.repeat($0.length));
+            const escapedText = targetNode.raw.replace(/&(?:[a-z]+|#[0-9]+|#x[0-9a-f]+);/gi, $0 => '*'.repeat($0.length));
             (0, ml_core_1.getLocationFromChars)(defaultChars, escapedText, targetNode.line, targetNode.col).forEach(location => {
                 report({
                     scope: targetNode.scope,

package/lib/permitted-contents/utils.d.ts

@@ -29,7 +29,7 @@ export declare function mergeHints(a: Readonly<Hints>, b: Readonly<Hints>): Part
         need?: string | undefined;
     }> | undefined;
     max?: number | undefined;
-    not?: import("packages/@markuplint/ml-core/lib").DocumentType<import("./types").TagRule[], import("./types").Options> | import("packages/@markuplint/ml-core/lib/ml-dom/node/character-data").MLCharacterData<import("./types").TagRule[], import("./types").Options, import("packages/@markuplint/ml-ast/lib").MLASTAbstractNode> | import("packages/@markuplint/ml-core/lib").Element<import("./types").TagRule[], import("./types").Options> | import("packages/@markuplint/ml-core/lib").Block<import("./types").TagRule[], import("./types").Options> | undefined;
+    not?: ChildNode | undefined;
     transparent?: Element | undefined;
 }>;
 export declare function cleanObject<T extends Object>(object: T): Partial<T>;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@markuplint/rules",
-	"version": "3.10.0",
+	"version": "3.12.0",
 	"description": "Built-in rules of markuplint",
 	"repository": "git@github.com:markuplint/markuplint.git",
 	"author": "Yusuke Hirao <yusukehirao@me.com>",
@@ -20,19 +20,19 @@
 		"./lib/permitted-contents/debug.js": "./lib/permitted-contents/debug.browser.js"
 	},
 	"dependencies": {
-		"@markuplint/html-spec": "3.9.0",
-		"@markuplint/ml-core": "3.10.0",
-		"@markuplint/ml-spec": "3.9.0",
-		"@markuplint/selector": "3.9.0",
-		"@markuplint/shared": "3.6.0",
-		"@markuplint/types": "3.7.0",
-		"@types/debug": "^4.1.7",
+		"@markuplint/html-spec": "3.11.0",
+		"@markuplint/ml-core": "3.12.0",
+		"@markuplint/ml-spec": "3.11.0",
+		"@markuplint/selector": "3.11.0",
+		"@markuplint/shared": "3.8.0",
+		"@markuplint/types": "3.9.0",
+		"@types/debug": "^4.1.8",
 		"@ungap/structured-clone": "^1.2.0",
 		"ansi-colors": "^4.1.3",
 		"chrono-node": "^2.6.3",
 		"debug": "^4.3.4",
-		"tslib": "^2.5.0",
-		"type-fest": "^3.10.0"
+		"tslib": "^2.6.0",
+		"type-fest": "^3.12.0"
 	},
-	"gitHead": "af370797bfc887e5a5a2ff57fbaa8392ac98ead2"
+	"gitHead": "4ab20276db48a6acb29a923ea8666890ca853442"
 }

package/test/character-reference/index.spec.js

@@ -55,3 +55,18 @@ test('in EJS', async () => {
 	});
 	expect(violations.length).toBe(0);
 });
+
+describe('Issues', () => {
+	test('#1074', async () => {
+		const { violations } = await mlRuleTest(rule, '<span>&#9660;</span><span>&#x25BC;</span><span>&x25BC;</span>');
+		expect(violations).toStrictEqual([
+			{
+				severity: 'error',
+				message: 'Illegal characters must escape in character reference',
+				line: 1,
+				col: 48,
+				raw: '&',
+			},
+		]);
+	});
+});

package/test/deprecated-element/index.spec.js

@@ -33,16 +33,3 @@ test('deprecated', async () => {
 		},
 	]);
 });
-
-test('svg', async () => {
-	const { violations } = await mlRuleTest(rule, '<svg><altGlyph>text</altGlyph></svg>');
-	expect(violations).toStrictEqual([
-		{
-			severity: 'error',
-			message: 'The "altGlyph" element is obsolete',
-			line: 1,
-			col: 6,
-			raw: '<altGlyph>',
-		},
-	]);
-});

package/test/invalid-attr/index.spec.js

@@ -1629,4 +1629,13 @@ ol(itemscope itemtype="https://schema.org/BreadcrumbList")
 			).violations,
 		).toStrictEqual([]);
 	});
+
+	test('#1078', async () => {
+		expect(
+			(await mlRuleTest(rule, '<script src="foo.js" referrerpolicy="no-referrer"></script>')).violations,
+		).toStrictEqual([]);
+		expect(
+			(await mlRuleTest(rule, '<img src="foo.png" referrerpolicy="no-referrer"></img>')).violations,
+		).toStrictEqual([]);
+	});
 });

package/test/permitted-contents/index.spec.js

@@ -1368,4 +1368,28 @@ describe('Issues', () => {
 				.violations,
 		).toStrictEqual([]);
 	});
+
+	test('#1046', async () => {
+		const sourceCode = '<span><div></div></span>';
+		expect(
+			(
+				await mlRuleTest(rule, sourceCode, {
+					rule: {
+						severity: 'warning',
+					},
+					parser: {
+						'.*': '@markuplint/jsx-parser',
+					},
+				})
+			).violations,
+		).toStrictEqual([
+			{
+				severity: 'warning',
+				line: 1,
+				col: 7,
+				message: 'The "div" element is not allowed in the "span" element in this context',
+				raw: '<div>',
+			},
+		]);
+	});
 });

package/test/require-accessible-name/index.spec.js

@@ -392,22 +392,7 @@ describe('Issues', () => {
 	test('#592', async () => {
 		expect(
 			(await mlRuleTest(rule, '<svg aria-label="i-have-name"><path /><rect><path /></rect></svg>')).violations,
-		).toStrictEqual([
-			{
-				col: 31,
-				line: 1,
-				message: 'Require accessible name',
-				raw: '<path />',
-				severity: 'error',
-			},
-			{
-				col: 39,
-				line: 1,
-				message: 'Require accessible name',
-				raw: '<rect>',
-				severity: 'error',
-			},
-		]);
+		).toStrictEqual([]);
 		expect(
 			(await mlRuleTest(rule, '<svg role="img" aria-label="i-have-name"><path /><rect><path /></rect></svg>'))
 				.violations,
@@ -419,15 +404,7 @@ describe('Issues', () => {
 					'<svg aria-label="i-have-name"><path aria-label="i-have-name" /><rect><path /></rect></svg>',
 				)
 			).violations,
-		).toStrictEqual([
-			{
-				col: 64,
-				line: 1,
-				message: 'Require accessible name',
-				raw: '<rect>',
-				severity: 'error',
-			},
-		]);
+		).toStrictEqual([]);
 		expect(
 			(
 				await mlRuleTest(
@@ -443,4 +420,25 @@ describe('Issues', () => {
 		expect((await mlRuleTest(rule, '<dialog></dialog>')).violations.length).toBe(1);
 		expect((await mlRuleTest(rule, '<div role="dialog"></div>')).violations.length).toBe(1);
 	});
+
+	test('#1018', async () => {
+		expect(
+			(
+				await mlRuleTest(rule, '<button><slot /></button>', {
+					parser: {
+						'.*': '@markuplint/svelte-parser',
+					},
+				})
+			).violations.length,
+		).toBe(0);
+		expect(
+			(
+				await mlRuleTest(rule, '<button></button>', {
+					parser: {
+						'.*': '@markuplint/svelte-parser',
+					},
+				})
+			).violations.length,
+		).toBe(1);
+	});
 });

package/test/wai-aria/index.spec.js

@@ -1170,4 +1170,34 @@ describe('Issues', () => {
 			},
 		]);
 	});
+
+	test('#1084', async () => {
+		const { violations } = await mlRuleTest(
+			rule,
+			`
+			<select multiple aria-label="some label text">
+				<option>foo</option>
+				<option>bar</option>
+			</select>
+
+			<select aria-label="some label text">
+				<option>foo</option>
+				<option>bar</option>
+			</select>
+
+			<select aria-label="some label text">
+				<option>foo</option>
+				<optgroup label="group">
+					<option>bar</option>
+				</optgroup>
+			</select>
+
+			<datalist>
+				<option>foo</option>
+				<option>bar</option>
+			</datalist>
+		`,
+		);
+		expect(violations).toStrictEqual([]);
+	});
 });

package/lib/wai-aria/checkings/_.d.ts

@@ -1,15 +0,0 @@
-import type { Options } from '../types';
-import type { ElementChecker } from '@markuplint/ml-core';
-import type { ARIAProperty, ARIARole } from '@markuplint/ml-spec';
-export declare const checkingRequiredProp: ElementChecker<
-	boolean,
-	Options,
-	{
-		role?:
-			| (ARIARole & {
-					isImplicit?: boolean;
-			  })
-			| null;
-		propSpecs: readonly ARIAProperty[];
-	}
->;

package/lib/wai-aria/checkings/_.js

@@ -1,27 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.checkingRequiredProp = void 0;
-const checkingRequiredProp = ({ el, role, propSpecs }) => t => {
-    var _a;
-    if (!role) {
-        return;
-    }
-    if (role.isImplicit) {
-        return;
-    }
-    const requiredProps = role.ownedProperties.filter(s => s.required).map(s => s.name);
-    for (const requiredProp of requiredProps) {
-        const has = el.attributes.some(attr => {
-            const attrName = attr.name.toLowerCase();
-            return attrName === requiredProp;
-        });
-        if (!has) {
-            const propSpec = propSpecs.find(p => p.name === requiredProp);
-            return {
-                scope: el,
-                message: t('{0:c} on {1}', t('Require {0}', t('the "{0*}" {1}', requiredProp, `ARIA ${(_a = propSpec === null || propSpec === void 0 ? void 0 : propSpec.type) !== null && _a !== void 0 ? _a : 'property'}`)), t('the "{0*}" {1}', role.name, 'role')),
-            };
-        }
-    }
-};
-exports.checkingRequiredProp = checkingRequiredProp;

package/lib/wai-aria/checkings/required-prop copy.d.ts

@@ -1,15 +0,0 @@
-import type { Options } from '../types';
-import type { ElementChecker } from '@markuplint/ml-core';
-import type { ARIAProperty, ARIARole } from '@markuplint/ml-spec';
-export declare const checkingRequiredProp: ElementChecker<
-	boolean,
-	Options,
-	{
-		role?:
-			| (ARIARole & {
-					isImplicit?: boolean;
-			  })
-			| null;
-		propSpecs: readonly ARIAProperty[];
-	}
->;

package/lib/wai-aria/checkings/required-prop copy.js

@@ -1,27 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.checkingRequiredProp = void 0;
-const checkingRequiredProp = ({ el, role, propSpecs }) => t => {
-    var _a;
-    if (!role) {
-        return;
-    }
-    if (role.isImplicit) {
-        return;
-    }
-    const requiredProps = role.ownedProperties.filter(s => s.required).map(s => s.name);
-    for (const requiredProp of requiredProps) {
-        const has = el.attributes.some(attr => {
-            const attrName = attr.name.toLowerCase();
-            return attrName === requiredProp;
-        });
-        if (!has) {
-            const propSpec = propSpecs.find(p => p.name === requiredProp);
-            return {
-                scope: el,
-                message: t('{0:c} on {1}', t('Require {0}', t('the "{0*}" {1}', requiredProp, `ARIA ${(_a = propSpec === null || propSpec === void 0 ? void 0 : propSpec.type) !== null && _a !== void 0 ? _a : 'property'}`)), t('the "{0*}" {1}', role.name, 'role')),
-            };
-        }
-    }
-};
-exports.checkingRequiredProp = checkingRequiredProp;

package/lib/wai-aria/checkings/unadopted-explicit-roles.d.ts

@@ -1,15 +0,0 @@
-import type { Options } from '../types';
-import type { ElementChecker } from '@markuplint/ml-core';
-import type { ARIAProperty, ARIARole } from '@markuplint/ml-spec';
-export declare const checkingUnadoptedExplicitRoles: ElementChecker<
-	boolean,
-	Options,
-	{
-		role?:
-			| (ARIARole & {
-					isImplicit?: boolean;
-			  })
-			| null;
-		propSpecs: readonly ARIAProperty[];
-	}
->;

package/lib/wai-aria/checkings/unadopted-explicit-roles.js

@@ -1,17 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.checkingUnadoptedExplicitRoles = void 0;
-const checkingUnadoptedExplicitRoles = ({ el, role, propSpecs }) => t => {
-    if (!role) {
-        return;
-    }
-    if (role.name) {
-        console.log(el.localName, role.name);
-        return {
-            scope: el,
-            message: '',
-        };
-    }
-    return;
-};
-exports.checkingUnadoptedExplicitRoles = checkingUnadoptedExplicitRoles;

package/lib/xxx/index.d.ts

@@ -1,2 +0,0 @@
-declare const _default: Readonly<import('@markuplint/ml-core').RuleSeed<boolean, null>>;
-export default _default;

package/lib/xxx/index.js

@@ -1,32 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const ml_core_1 = require("@markuplint/ml-core");
-exports.default = (0, ml_core_1.createRule)({
-    defaultValue: true,
-    defaultOptions: null,
-    async verify({ document, report, t }) {
-        // Element
-        await document.walkOn("Element", (el) => {
-            const raw = el.raw.trim();
-            if (/./i.test(raw)) {
-                report({
-                    scope: el,
-                    message: t("It is {0}", "issue"),
-                });
-            }
-        });
-        // Attribute
-        await document.walkOn("Attr", (attr) => {
-            var _a, _b, _c;
-            if (/./i.test(attr.name)) {
-                report({
-                    scope: attr,
-                    line: (_a = attr.nameNode) === null || _a === void 0 ? void 0 : _a.startLine,
-                    col: (_b = attr.nameNode) === null || _b === void 0 ? void 0 : _b.startCol,
-                    raw: (_c = attr.nameNode) === null || _c === void 0 ? void 0 : _c.raw,
-                    message: t("It is {0}", "issue"),
-                });
-            }
-        });
-    },
-});