@markuplint/pug-parser 5.4.0 → 5.5.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.5.0](https://github.com/markuplint/markuplint/compare/v5.4.0...v5.5.0) (2026-11-10)
+
+### Bug Fixes
+
+* **pug-parser:** count a leading BOM in the positions ([6d47ba9](https://github.com/markuplint/markuplint/commit/6d47ba911af99c3c4c7cc5848ef1b168f0719e33)), closes [#4488](https://github.com/markuplint/markuplint/issues/4488)
+
+### Features
+
+* **pug-parser:** record every value after `=` as the code that it is ([58ae2d8](https://github.com/markuplint/markuplint/commit/58ae2d8a7866aee37a1932d51a05e4feead02435))
+
+
 # [5.4.0](https://github.com/markuplint/markuplint/compare/v5.3.0...v5.4.0) (2026-10-29)
 
 **Note:** Version bump only for package @markuplint/pug-parser

package/lib/literal-values.d.ts

@@ -0,0 +1,28 @@
+import type { LiteralValueDeclaration } from '@markuplint/ml-ast';
+/**
+ * How Pug renders a literal in an attribute value (`pug_attr` of `pug-runtime`, which `pug-attrs` uses to
+ * fold a constant too), where it differs from the default of `@markuplint/ml-core`. Pug has no spec
+ * package, so the parser says it. Names are in lower case.
+ *
+ * Pug has no list of boolean attributes and decides by the value alone:
+ *
+ * - `true` is the attribute with its name as the value (`checked="checked"`, or `checked` under
+ *   `doctype html`), whichever attribute it is, `data-x=true` included: it is `""` here, as the attribute
+ *   is present
+ * - `false`, `null` and `undefined` remove the attribute
+ * - `class` and `style` are also removed for a falsy value, `""` and `0`
+ * - Any other value is written with `JSON.stringify`, so `0` is `"0"` on any attribute, a boolean attribute
+ *   included (`disabled=0` is `disabled="0"`, which is present)
+ *
+ * What it does not tell, which does not affect a rule:
+ *
+ * - A boolean attribute has its name as the value (`disabled="disabled"`) unless `doctype html`
+ * - A string on a boolean attribute is `""` in the default, and Pug writes the string
+ * - A quoted attribute name (`'data-x'="y"`) and an unescaped one (`data-x!="y"`) are read as code
+ *   whose value is not known
+ *
+ * @see https://pugjs.org/language/attributes.html#boolean-attributes
+ * @see https://pugjs.org/language/doctype.html#doctype-shortcuts
+ * @see https://github.com/pugjs/pug/blob/master/packages/pug-runtime/index.js#pug_attr
+ */
+export declare const PUG_LITERAL_VALUES: LiteralValueDeclaration;

package/lib/literal-values.js

@@ -0,0 +1,37 @@
+/**
+ * How Pug renders a literal in an attribute value (`pug_attr` of `pug-runtime`, which `pug-attrs` uses to
+ * fold a constant too), where it differs from the default of `@markuplint/ml-core`. Pug has no spec
+ * package, so the parser says it. Names are in lower case.
+ *
+ * Pug has no list of boolean attributes and decides by the value alone:
+ *
+ * - `true` is the attribute with its name as the value (`checked="checked"`, or `checked` under
+ *   `doctype html`), whichever attribute it is, `data-x=true` included: it is `""` here, as the attribute
+ *   is present
+ * - `false`, `null` and `undefined` remove the attribute
+ * - `class` and `style` are also removed for a falsy value, `""` and `0`
+ * - Any other value is written with `JSON.stringify`, so `0` is `"0"` on any attribute, a boolean attribute
+ *   included (`disabled=0` is `disabled="0"`, which is present)
+ *
+ * What it does not tell, which does not affect a rule:
+ *
+ * - A boolean attribute has its name as the value (`disabled="disabled"`) unless `doctype html`
+ * - A string on a boolean attribute is `""` in the default, and Pug writes the string
+ * - A quoted attribute name (`'data-x'="y"`) and an unescaped one (`data-x!="y"`) are read as code
+ *   whose value is not known
+ *
+ * @see https://pugjs.org/language/attributes.html#boolean-attributes
+ * @see https://pugjs.org/language/doctype.html#doctype-shortcuts
+ * @see https://github.com/pugjs/pug/blob/master/packages/pug-runtime/index.js#pug_attr
+ */
+export const PUG_LITERAL_VALUES = {
+    booleanAttrs: { '""': '', '0': '0' },
+    ariaAttrs: { true: '', false: null },
+    dataAttrs: { true: '', false: null },
+    otherAttrs: { true: '', false: null },
+    attrs: {
+        class: { '""': null, '0': null },
+        style: { '""': null, '0': null },
+        hidden: { '0': '0' },
+    },
+};

package/lib/parser.js

@@ -1,5 +1,6 @@
 import { HtmlParser } from '@markuplint/html-parser';
-import { ParserError, Parser, AttrState, scriptParser, getNamespace } from '@markuplint/parser-utils';
+import { ParserError, Parser, AttrState, getNamespace } from '@markuplint/parser-utils';
+import { PUG_LITERAL_VALUES } from './literal-values.js';
 import { pugParse } from './pug-parser/index.js';
 class HtmlInPugParser extends HtmlParser {
     constructor() {
@@ -32,6 +33,11 @@ class PugParser extends Parser {
         super({
             // Pug expresses nesting through indentation and never emits explicit closing tags.
             endTagType: 'never',
+            // A value of `=` is JavaScript ("their values are just regular JavaScript")
+            attrExpressionLanguage: 'javascript',
+            literalValues: PUG_LITERAL_VALUES,
+            // pug-lexer strips a leading BOM itself, and a space in its place would be indentation
+            leadingBom: 'strip',
         });
     }
     tokenize(options) {
@@ -301,41 +307,16 @@ class PugParser extends Parser {
                 potentialName: attr.name.raw.slice(0, -1),
             });
         }
-        const valueCodeTokens = scriptParser(attr.value.raw.trim());
-        if (valueCodeTokens.length === 1) {
-            const token = valueCodeTokens[0];
-            switch (token.type) {
-                case 'Numeric': {
-                    return {
-                        ...attr,
-                        valueType: 'number',
-                    };
-                }
-                case 'Boolean': {
-                    return {
-                        ...attr,
-                        valueType: 'boolean',
-                    };
-                }
-                case 'String':
-                case 'Template': {
-                    const value = super.visitAttr(attr.value, {
-                        startState: AttrState.BeforeValue,
-                        noQuoteValueType: 'script',
-                    });
-                    if (value.type === 'spread') {
-                        throw new ParserError('Unexpected attribute value', value);
-                    }
-                    return {
-                        ...attr,
-                        startQuote: value.startQuote,
-                        value: value.value,
-                        endQuote: value.endQuote,
-                        ...(attr.name.raw.endsWith('!') ? { valueType: 'code' } : {}),
-                    };
-                }
-            }
+        // An attribute without a value (`disabled`) is `true` and is not written as code, while any value after
+        // `=` is JavaScript (the introduction of the page below, which has no heading to cite, says that the
+        // values of the attributes are regular JavaScript): whether it is a literal, and what Pug renders it
+        // as, is up to `@markuplint/ml-core`, which reads it as it reads the code of any language.
+        // @see https://pugjs.org/language/attributes.html
+        if (attr.equal.raw === '') {
+            return attr;
         }
+        // The value is code. A literal that `@markuplint/ml-core` reads is a string there, and any other code
+        // (and an unescaped one, `href!="x"`) stays code.
         return {
             ...attr,
             isDynamicValue: true,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@markuplint/pug-parser",
-	"version": "5.4.0",
+	"version": "5.5.0",
 	"description": "Pug parser for markuplint",
 	"repository": {
 		"type": "git",
@@ -28,11 +28,11 @@
 		"clean": "tsc --build --clean tsconfig.build.json"
 	},
 	"dependencies": {
-		"@markuplint/html-parser": "5.4.0",
-		"@markuplint/ml-ast": "5.3.0",
-		"@markuplint/parser-utils": "5.4.0",
+		"@markuplint/html-parser": "5.5.0",
+		"@markuplint/ml-ast": "5.5.0",
+		"@markuplint/parser-utils": "5.5.0",
 		"pug-lexer": "^5.0.1",
 		"pug-parser": "^6.0.0"
 	},
-	"gitHead": "647f6fb5d5743f060678599c97e9c84b58970747"
+	"gitHead": "fedebcfd56eaec4642e68643b2f9e10750d810e1"
 }