@markuplint/ml-core 5.0.0-rc.6 → 5.0.0-rc.7

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.0.0-rc.7](https://github.com/markuplint/markuplint/compare/v5.0.0-rc.6...v5.0.0-rc.7) (2026-08-31)
+
+### Bug Fixes
+
+- **ml-core:** fix named rule group disable propagation and validation ([139f466](https://github.com/markuplint/markuplint/commit/139f4661a12ac10b15ade305c30bbd8234b07b0f))
+
 # [5.0.0-rc.6](https://github.com/markuplint/markuplint/compare/v5.0.0-rc.5...v5.0.0-rc.6) (2026-08-30)
 
 ### Features

package/lib/ml-core.js

@@ -94,6 +94,11 @@ export class MLCore {
             nodeRules: nodeRuleResult.transformedNodeRules,
             childNodeRules: childNodeRuleResult.transformedNodeRules,
             baseRuleToVirtualNames: buildBaseRuleToVirtualNames(namedRulesResult.virtualRules),
+            baseRuleToScopedVirtualNames: buildBaseRuleToVirtualNames([
+                ...nodeRuleResult.virtualRules,
+                ...childNodeRuleResult.virtualRules,
+            ]),
+            knownNamedRuleGroupKeys: ruleset.knownNamedRuleGroupKeys ?? new Set(),
             mappingErrors: [],
         };
         this.#disabledNamespaces = extractDisabledNamespaces(resolvedRules);
@@ -151,6 +156,11 @@ export class MLCore {
             nodeRules: nodeRuleResult.transformedNodeRules,
             childNodeRules: childNodeRuleResult.transformedNodeRules,
             baseRuleToVirtualNames: buildBaseRuleToVirtualNames(namedRulesResult.virtualRules),
+            baseRuleToScopedVirtualNames: buildBaseRuleToVirtualNames([
+                ...nodeRuleResult.virtualRules,
+                ...childNodeRuleResult.virtualRules,
+            ]),
+            knownNamedRuleGroupKeys: ruleset?.knownNamedRuleGroupKeys ?? this.#ruleset.knownNamedRuleGroupKeys,
             mappingErrors: [],
         };
         this.#disabledNamespaces = extractDisabledNamespaces(resolvedRules);
@@ -191,6 +201,15 @@ export class MLCore {
             if (setRuleName.endsWith('/*')) {
                 continue;
             }
+            // Skip a named rule group disabled via top-level `rules` (e.g. "html-standard/foo": false).
+            // `expandNamedRules` intentionally doesn't instantiate a virtual rule when the merged value
+            // already resolved to `false` (there's nothing to run), so it never appears in `definedRuleName`.
+            // `knownNamedRuleGroupKeys` (threaded from config merge — see its JSDoc) tells a genuine
+            // named-group disable apart from a typo'd/nonexistent rule name that also happens to be
+            // set to `false` with a `/` in its key; only the former is exempt from this check.
+            if (this.#ruleset.rules[setRuleName] === false && this.#ruleset.knownNamedRuleGroupKeys.has(setRuleName)) {
+                continue;
+            }
             if (!definedRuleName.has(setRuleName)) {
                 configViolations.push({
                     ruleId: CONFIG_ERROR_RULE_ID,

package/lib/ml-dom/node/document.js

@@ -2440,7 +2440,9 @@ export class MLDocument extends MLParentNode {
                         specificity: matches.specificity,
                         rule: mergedRule,
                     });
-                    // Propagate to virtual rules that wrap this base rule
+                    // Propagate to top-level-group virtual rules that wrap this base rule. These
+                    // wrappers have no selector scope of their own (they mirror the base rule
+                    // globally), so any matched value is safe to forward.
                     const virtualNames = ruleset.baseRuleToVirtualNames.get(ruleName);
                     if (virtualNames) {
                         for (const vName of virtualNames) {
@@ -2453,6 +2455,26 @@ export class MLDocument extends MLParentNode {
                             });
                         }
                     }
+                    // Propagate a disable to selector-scoped (nodeRules/childNodeRules-named) virtual
+                    // rules that wrap this base rule. Limited to `false`: unlike the top-level-group
+                    // case above, these wrappers DO have their own selector scope, so forwarding a
+                    // non-false value would apply their semantics (e.g. a required attribute name) to
+                    // every node this (unrelated) nodeRule matches, even where the virtual rule's own
+                    // selector never matched — see issue #4023's fix history for the regression this caused.
+                    if (convertedRule === false) {
+                        const scopedVirtualNames = ruleset.baseRuleToScopedVirtualNames.get(ruleName);
+                        if (scopedVirtualNames) {
+                            for (const vName of scopedVirtualNames) {
+                                // No merge needed: mergeRule(_, false) always returns false, so the
+                                // disable is unconditional regardless of any global config for vName.
+                                ruleMapper.set(node, vName, {
+                                    from: 'nodeRules',
+                                    specificity: matches.specificity,
+                                    rule: false,
+                                });
+                            }
+                        }
+                    }
                 }
             }
             // overwrite rule to child node
@@ -2518,7 +2540,8 @@ export class MLDocument extends MLParentNode {
                                 rule: mergedRule,
                             });
                         }
-                        // Propagate to virtual rules that wrap this base rule
+                        // Propagate to top-level-group virtual rules — see the matching nodeRules
+                        // propagation above for why any value is safe to forward here.
                         const virtualNames = ruleset.baseRuleToVirtualNames.get(ruleName);
                         if (virtualNames) {
                             for (const vName of virtualNames) {
@@ -2533,6 +2556,25 @@ export class MLDocument extends MLParentNode {
                                 }
                             }
                         }
+                        // Propagate a disable to selector-scoped virtual rules. Limited to `false` —
+                        // see the matching nodeRules propagation above for why a non-false value must
+                        // not be forwarded to a virtual rule whose own selector didn't match.
+                        if (convertedRule === false) {
+                            const scopedVirtualNames = ruleset.baseRuleToScopedVirtualNames.get(ruleName);
+                            if (scopedVirtualNames) {
+                                for (const vName of scopedVirtualNames) {
+                                    // No merge needed: mergeRule(_, false) always returns false, so the
+                                    // disable is unconditional regardless of any global config for vName.
+                                    for (const descendant of targetDescendants) {
+                                        ruleMapper.set(descendant, vName, {
+                                            from: 'childNodeRules',
+                                            specificity: matches.specificity,
+                                            rule: false,
+                                        });
+                                    }
+                                }
+                            }
+                        }
                     }
                 }
             }

package/lib/ruleset/index.d.ts

@@ -5,14 +5,31 @@ import type { ChildNodeRule, Config, NodeRule, Rules } from '@markuplint/ml-conf
  */
 export declare class Ruleset {
     /**
-     * Maps base rule names to their virtual rule names created by NamedRuleGroups.
-     * For example, if `a11y/landmark-roles` wraps `no-nested-top-level-landmark`, this maps
-     * `"no-nested-top-level-landmark"` → `["a11y/landmark-roles"]`.
-     * Used by nodeRules/childNodeRules to propagate settings to virtual rules.
+     * Maps base rule names to the virtual rule names created by top-level `rules`
+     * NamedRuleGroups (e.g. `"a11y/landmark-roles": { rules: { "no-nested-top-level-landmark": true } }`).
+     * These wrappers have no selector scope of their own — they mirror the base rule
+     * globally — so nodeRules/childNodeRules may propagate *any* matched value to them,
+     * not just a disable.
      */
     readonly baseRuleToVirtualNames: ReadonlyMap<string, readonly string[]>;
+    /**
+     * Maps base rule names to the virtual rule names created by `nodeRules[].name` /
+     * `childNodeRules[].name` (selector-scoped named groups), as opposed to
+     * {@link baseRuleToVirtualNames}'s top-level `rules` groups. Because these wrappers
+     * DO have their own selector scope, only a disable (`false`) may be propagated to
+     * them from an unrelated nodeRules/childNodeRules entry — forwarding a non-false
+     * value would apply the wrapper's semantics to nodes its own selector never matched
+     * (see issue #4023's fix history).
+     */
+    readonly baseRuleToScopedVirtualNames: ReadonlyMap<string, readonly string[]>;
     /** Rule overrides that apply to child nodes matching specific selectors */
     readonly childNodeRules: readonly ChildNodeRule[];
+    /**
+     * `rules` keys that are a genuine NamedRuleGroup in some layer of the
+     * `extends`/override chain, carried over from {@link Config.knownNamedRuleGroupKeys}
+     * even where the final merged value collapsed to `false`. See that field's JSDoc.
+     */
+    readonly knownNamedRuleGroupKeys: ReadonlySet<string>;
     /**
      * Errors collected during rule mapping (e.g., invalid wildcard usage).
      * Consumed by MLCore and reported as config-error violations.
@@ -24,7 +41,8 @@ export declare class Ruleset {
     readonly rules: Rules;
     /**
      * @param config - The markuplint configuration to extract rules from
-     * @param baseRuleToVirtualNames - Mapping from base rule names to virtual rule names
+     * @param baseRuleToVirtualNames - Mapping from base rule names to top-level-group virtual rule names
+     * @param baseRuleToScopedVirtualNames - Mapping from base rule names to selector-scoped (nodeRules/childNodeRules) virtual rule names
      */
-    constructor(config: Config, baseRuleToVirtualNames?: ReadonlyMap<string, readonly string[]>);
+    constructor(config: Config, baseRuleToVirtualNames?: ReadonlyMap<string, readonly string[]>, baseRuleToScopedVirtualNames?: ReadonlyMap<string, readonly string[]>);
 }

package/lib/ruleset/index.js

@@ -4,14 +4,31 @@
  */
 export class Ruleset {
     /**
-     * Maps base rule names to their virtual rule names created by NamedRuleGroups.
-     * For example, if `a11y/landmark-roles` wraps `no-nested-top-level-landmark`, this maps
-     * `"no-nested-top-level-landmark"` → `["a11y/landmark-roles"]`.
-     * Used by nodeRules/childNodeRules to propagate settings to virtual rules.
+     * Maps base rule names to the virtual rule names created by top-level `rules`
+     * NamedRuleGroups (e.g. `"a11y/landmark-roles": { rules: { "no-nested-top-level-landmark": true } }`).
+     * These wrappers have no selector scope of their own — they mirror the base rule
+     * globally — so nodeRules/childNodeRules may propagate *any* matched value to them,
+     * not just a disable.
      */
     baseRuleToVirtualNames;
+    /**
+     * Maps base rule names to the virtual rule names created by `nodeRules[].name` /
+     * `childNodeRules[].name` (selector-scoped named groups), as opposed to
+     * {@link baseRuleToVirtualNames}'s top-level `rules` groups. Because these wrappers
+     * DO have their own selector scope, only a disable (`false`) may be propagated to
+     * them from an unrelated nodeRules/childNodeRules entry — forwarding a non-false
+     * value would apply the wrapper's semantics to nodes its own selector never matched
+     * (see issue #4023's fix history).
+     */
+    baseRuleToScopedVirtualNames;
     /** Rule overrides that apply to child nodes matching specific selectors */
     childNodeRules;
+    /**
+     * `rules` keys that are a genuine NamedRuleGroup in some layer of the
+     * `extends`/override chain, carried over from {@link Config.knownNamedRuleGroupKeys}
+     * even where the final merged value collapsed to `false`. See that field's JSDoc.
+     */
+    knownNamedRuleGroupKeys;
     /**
      * Errors collected during rule mapping (e.g., invalid wildcard usage).
      * Consumed by MLCore and reported as config-error violations.
@@ -23,12 +40,15 @@ export class Ruleset {
     rules;
     /**
      * @param config - The markuplint configuration to extract rules from
-     * @param baseRuleToVirtualNames - Mapping from base rule names to virtual rule names
+     * @param baseRuleToVirtualNames - Mapping from base rule names to top-level-group virtual rule names
+     * @param baseRuleToScopedVirtualNames - Mapping from base rule names to selector-scoped (nodeRules/childNodeRules) virtual rule names
      */
-    constructor(config, baseRuleToVirtualNames) {
+    constructor(config, baseRuleToVirtualNames, baseRuleToScopedVirtualNames) {
         this.rules = config.rules ?? {};
         this.nodeRules = config.nodeRules ?? [];
         this.childNodeRules = config.childNodeRules ?? [];
         this.baseRuleToVirtualNames = baseRuleToVirtualNames ?? new Map();
+        this.baseRuleToScopedVirtualNames = baseRuleToScopedVirtualNames ?? new Map();
+        this.knownNamedRuleGroupKeys = new Set(config.knownNamedRuleGroupKeys);
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@markuplint/ml-core",
-	"version": "5.0.0-rc.6",
+	"version": "5.0.0-rc.7",
 	"description": "The core module of markuplint",
 	"repository": {
 		"type": "git",
@@ -34,20 +34,20 @@
 		"./lib/configs.js": "./lib/configs.browser.js"
 	},
 	"dependencies": {
-		"@markuplint/config-presets": "5.0.0-rc.6",
-		"@markuplint/html-parser": "5.0.0-rc.6",
-		"@markuplint/html-spec": "5.0.0-rc.6",
-		"@markuplint/i18n": "5.0.0-rc.6",
-		"@markuplint/ml-ast": "5.0.0-rc.6",
-		"@markuplint/ml-config": "5.0.0-rc.6",
-		"@markuplint/ml-spec": "5.0.0-rc.6",
-		"@markuplint/parser-utils": "5.0.0-rc.6",
-		"@markuplint/selector": "5.0.0-rc.6",
-		"@markuplint/shared": "5.0.0-rc.6",
+		"@markuplint/config-presets": "5.0.0-rc.7",
+		"@markuplint/html-parser": "5.0.0-rc.7",
+		"@markuplint/html-spec": "5.0.0-rc.7",
+		"@markuplint/i18n": "5.0.0-rc.7",
+		"@markuplint/ml-ast": "5.0.0-rc.7",
+		"@markuplint/ml-config": "5.0.0-rc.7",
+		"@markuplint/ml-spec": "5.0.0-rc.7",
+		"@markuplint/parser-utils": "5.0.0-rc.7",
+		"@markuplint/selector": "5.0.0-rc.7",
+		"@markuplint/shared": "5.0.0-rc.7",
 		"@types/debug": "4.1.13",
 		"debug": "4.4.3",
 		"is-plain-object": "5.0.0",
 		"type-fest": "5.6.0"
 	},
-	"gitHead": "c02c3a0783eac6b2fb4707be2dc00b88f6219641"
+	"gitHead": "8d7a3b801e0f5f88438c003e7eee2bd45e6aedd0"
 }