@markuplint/file-resolver 5.5.0 → 5.6.1

package/CHANGELOG.md

@@ -3,6 +3,21 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.6.1](https://github.com/markuplint/markuplint/compare/v5.6.0...v5.6.1) (2026-11-13)
+
+**Note:** Version bump only for package @markuplint/file-resolver
+
+
+
+
+
+# [5.6.0](https://github.com/markuplint/markuplint/compare/v5.5.0...v5.6.0) (2026-11-12)
+
+### Bug Fixes
+
+* **file-resolver:** validate every selector of every configuration before they are merged ([be2611c](https://github.com/markuplint/markuplint/commit/be2611ca18243bee59676c81e409a070ce9af7ab))
+
+
 # [5.5.0](https://github.com/markuplint/markuplint/compare/v5.4.0...v5.5.0) (2026-11-10)
 
 ### Bug Fixes

package/lib/config-provider.js

@@ -17,6 +17,9 @@ import { cacheClear, resolvePlugins } from './resolve-plugins.js';
 import { fileExists, uuid } from './utils.js';
 const cpLog = log.extend('config-provider');
 const KEY_SEPARATOR = '__ML_CONFIG_MERGE__';
+function isPretenderList(pretenders) {
+    return Array.isArray(pretenders);
+}
 /**
  * Manages loading, caching, and resolving markuplint configuration files.
  *
@@ -231,10 +234,7 @@ export class ConfigProvider {
                 filePath: referrer,
             });
         }
-        const errors = this.#validateConfig(configSet.config, filePath);
-        configSet.errs.push(...errors);
         const { plugins, errors: pluginErrors } = await resolvePlugins(configSet.config.plugins);
-        configSet.errs.push(...pluginErrors);
         if (this.#held.size > 0) {
             const extendHelds = [...this.#held.values()];
             for (const held of extendHelds) {
@@ -253,6 +253,9 @@ export class ConfigProvider {
             configSet = await this.#mergeConfigs([...keys, ...extendHelds], cache, referrer);
             this.#held.clear();
         }
+        // After the plugins' configurations are merged in: that merge makes a new `errs`, which would lose
+        // these.
+        configSet.errs.push(...pluginErrors);
         return {
             ...configSet,
             plugins,
@@ -422,13 +425,19 @@ export class ConfigProvider {
             }
             errs.push(...keySet.errs);
         }
-        const configs = [...resolvedKeys].map(name => this.#store.get(name)).filter(nonNullableFilter);
         let resultConfig = {};
-        for (const config of configs) {
+        for (const name of resolvedKeys) {
+            const config = this.#store.get(name);
+            if (!config) {
+                continue;
+            }
             if (config instanceof ConfigLoadError) {
                 errs.push(config);
                 continue;
             }
+            // Each configuration is validated as it is, before the merge loses which one holds a selector,
+            // so that an error names the file (or the plugin configuration) that the user has to fix.
+            errs.push(...this.#validateConfig(config, name));
             resultConfig = mergeConfig(resultConfig, config);
         }
         return {
@@ -451,28 +460,56 @@ export class ConfigProvider {
                 : undefined,
         };
     }
+    /**
+     * Creates every selector that one configuration holds, so that an invalid one is in
+     * {@link ConfigSet.errs} wherever it is written: the top level, and the value of each `overrides` entry
+     * (whether or not its glob matches the target file, as the result is cached for every file of `names`).
+     * It runs on each configuration before they are merged, because the merge loses which one holds a selector.
+     * The selectors are those of `nodeRules`, `childNodeRules`, and the pretenders written in the
+     * configuration itself (`pretenders.data`; the merge has turned an array into it), including those
+     * that a plugin provides. Those that a pretender scan or a file produces are not known here;
+     * `MLDocument` reports them when it meets them. An error names the file of the pretender
+     * (`Pretender#filePath`) when it has one, and `filePath`, the key of the configuration (its file, or
+     * `plugin:<name>/<config>`), otherwise.
+     */
     #validateConfig(config, filePath) {
         const errors = [];
-        if (config.nodeRules)
-            for (const rule of config.nodeRules) {
-                if (rule.selector) {
-                    try {
-                        createSelector(rule.selector);
-                    }
-                    catch (error) {
-                        // Anything but an `InvalidSelectorError` is not a fault of the selector string the user wrote
-                        // (a bug, or an argument that only an extended pseudo-class reads), so it must propagate
-                        // instead of being reported as a configuration error.
-                        if (isFatalError(error) || !(error instanceof InvalidSelectorError)) {
-                            throw error;
-                        }
-                        errors.push(new ConfigParserError(error.message, {
-                            filePath,
-                            raw: rule.selector,
-                        }));
-                    }
+        const check = (selector, from = filePath) => {
+            if (!selector) {
+                return;
+            }
+            try {
+                createSelector(selector);
+            }
+            catch (error) {
+                // Anything but an `InvalidSelectorError` is not a fault of the selector string the user wrote
+                // (a bug), so it must propagate instead of being reported as a configuration error.
+                if (isFatalError(error) || !(error instanceof InvalidSelectorError)) {
+                    throw error;
                 }
+                errors.push(new ConfigParserError(error.message, {
+                    filePath: from,
+                    raw: selector,
+                }));
+            }
+        };
+        const checkSelectors = (holder) => {
+            for (const rule of holder.nodeRules ?? []) {
+                check(rule.selector);
             }
+            for (const rule of holder.childNodeRules ?? []) {
+                check(rule.selector);
+            }
+            const pretenders = holder.pretenders;
+            for (const pretender of isPretenderList(pretenders) ? pretenders : (pretenders?.data ?? [])) {
+                // The file that declares the component is where the user fixes the entry
+                check(pretender.selector, pretender.filePath ?? filePath);
+            }
+        };
+        checkSelectors(config);
+        for (const override of Object.values(config.overrides ?? {})) {
+            checkSelectors(override);
+        }
         return errors;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@markuplint/file-resolver",
-	"version": "5.5.0",
+	"version": "5.6.1",
 	"description": "The file resolver of markuplint",
 	"repository": {
 		"type": "git",
@@ -22,16 +22,13 @@
 	"publishConfig": {
 		"access": "public"
 	},
-	"typedoc": {
-		"entryPoint": "./src/index.ts"
-	},
 	"scripts": {
 		"build": "tsc --project tsconfig.build.json",
 		"dev": "tsc --watch --project tsconfig.build.json",
 		"clean": "tsc --build --clean"
 	},
 	"devDependencies": {
-		"@markuplint/pretenders": "5.5.0",
+		"@markuplint/pretenders": "5.6.1",
 		"@types/node": "24.19.2"
 	},
 	"peerDependencies": {
@@ -43,14 +40,14 @@
 		}
 	},
 	"dependencies": {
-		"@markuplint/html-parser": "5.5.0",
-		"@markuplint/ml-ast": "5.5.0",
-		"@markuplint/ml-config": "5.5.0",
-		"@markuplint/ml-core": "5.5.0",
-		"@markuplint/ml-spec": "5.5.0",
-		"@markuplint/parser-utils": "5.5.0",
-		"@markuplint/selector": "5.5.0",
-		"@markuplint/shared": "5.5.0",
+		"@markuplint/html-parser": "5.6.1",
+		"@markuplint/ml-ast": "5.6.0",
+		"@markuplint/ml-config": "5.6.1",
+		"@markuplint/ml-core": "5.6.1",
+		"@markuplint/ml-spec": "5.6.1",
+		"@markuplint/parser-utils": "5.6.1",
+		"@markuplint/selector": "5.6.1",
+		"@markuplint/shared": "5.6.0",
 		"cosmiconfig": "^10.0.1",
 		"debug": "^4.4.3",
 		"glob": "^14.0.3",
@@ -59,5 +56,5 @@
 		"jsonc": "^3.0.0",
 		"minimatch": "^11.0.4"
 	},
-	"gitHead": "fedebcfd56eaec4642e68643b2f9e10750d810e1"
+	"gitHead": "a9245162df3699c4880469f493aaaf6103343d83"
 }