@markuplint/astro-parser 5.4.0 → 5.5.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.5.0](https://github.com/markuplint/markuplint/compare/v5.4.0...v5.5.0) (2026-11-10)
+
+### Bug Fixes
+
+* **astro-parser:** render popover on a custom element as a boolean attribute ([7c0ba29](https://github.com/markuplint/markuplint/commit/7c0ba29da70a7e90fff84164867317d28e9ff3ea))
+
+### Features
+
+* **astro-parser:** declare how Astro renders a literal written as code ([8989d17](https://github.com/markuplint/markuplint/commit/8989d179527a8d94e29ff4ed8bece36aafaa6315))
+
+
 # [5.4.0](https://github.com/markuplint/markuplint/compare/v5.3.0...v5.4.0) (2026-10-29)
 
 **Note:** Version bump only for package @markuplint/astro-parser

package/lib/component-scanner.js

@@ -71,7 +71,8 @@ function extractAttrs(el) {
         }
         const value = attr.value.raw;
         if (attr.isDynamicValue) {
-            const expression = value.trim();
+            // An expression that the parser kept apart from its quotes is `potentialValue`
+            const expression = (attr.potentialValue ?? value).trim();
             addAttr(attrs, { name: attr.nodeName, dynamic: true, ...(expression === '' ? {} : { expression }) });
         }
         else if (/^`.*`$/s.test(value)) {

package/lib/literal-values.d.ts

@@ -0,0 +1,27 @@
+import type { LiteralValueDeclaration } from '@markuplint/ml-ast';
+/**
+ * How Astro renders a literal in `{…}` (`addAttribute` of `astro/runtime/server/render/util.ts`),
+ * where it differs from the default of `@markuplint/ml-core`. Astro has no spec package, so the
+ * parser says it. Names are in lower case.
+ *
+ * - A boolean attribute (`htmlBooleanAttributes`) is present for a truthy value, which is `""`: `disabled={""}`
+ *   has no `disabled`. Any other value is a string (`title={true}` is `title="true"`, as the default says)
+ * - `download` and `popover` are present for `true` and absent for `false`; `hidden` is present for `true`,
+ *   absent for `false`, and a number is a string (`hidden={0}` is `hidden="0"`)
+ * - A custom element takes every boolean as a string (`handleBooleanAttribute`): `disabled={false}` is
+ *   `disabled="false"`, except `popover`, which is rendered as on any element (present for `true`, absent for
+ *   `false`):
+ *
+ * > The Popover API only accepts "auto", "manual", or the attribute being absent.
+ *
+ * What it does not tell, which does not affect a rule:
+ *
+ * - `hidden` and `popover` take a string as it is (`hidden="until-found"`), which the default does too
+ * - `scoped` and `seamless`, obsolete attributes that Astro renders as boolean, are not in the spec
+ *
+ * @see https://docs.astro.build/en/reference/astro-syntax/#dynamic-attributes
+ * @see https://github.com/withastro/astro/blob/main/packages/runtime/src/internal/server/render/util.ts#addAttribute
+ * @see https://github.com/withastro/astro/blob/main/packages/runtime/src/internal/server/render/util.ts#htmlBooleanAttributes
+ * @see https://github.com/withastro/astro/blob/main/packages/runtime/src/internal/server/render/util.ts#handleBooleanAttribute
+ */
+export declare const ASTRO_LITERAL_VALUES: LiteralValueDeclaration;

package/lib/literal-values.js

@@ -0,0 +1,65 @@
+/**
+ * The rendering of the attribute that Astro does not render as a boolean, whose spec is Boolean: it
+ * is rendered as a string, with the empty string as its name alone (`addAttribute`).
+ */
+const AS_STRING = { true: 'true', false: 'false', '0': '0', '""': '' };
+/**
+ * The rendering of the attribute that Astro renders as a boolean and the spec does not know as one:
+ * present for a truthy value.
+ */
+const AS_BOOLEAN = { true: '', false: null, '0': null, '""': null };
+/**
+ * How Astro renders a literal in `{…}` (`addAttribute` of `astro/runtime/server/render/util.ts`),
+ * where it differs from the default of `@markuplint/ml-core`. Astro has no spec package, so the
+ * parser says it. Names are in lower case.
+ *
+ * - A boolean attribute (`htmlBooleanAttributes`) is present for a truthy value, which is `""`: `disabled={""}`
+ *   has no `disabled`. Any other value is a string (`title={true}` is `title="true"`, as the default says)
+ * - `download` and `popover` are present for `true` and absent for `false`; `hidden` is present for `true`,
+ *   absent for `false`, and a number is a string (`hidden={0}` is `hidden="0"`)
+ * - A custom element takes every boolean as a string (`handleBooleanAttribute`): `disabled={false}` is
+ *   `disabled="false"`, except `popover`, which is rendered as on any element (present for `true`, absent for
+ *   `false`):
+ *
+ * > The Popover API only accepts "auto", "manual", or the attribute being absent.
+ *
+ * What it does not tell, which does not affect a rule:
+ *
+ * - `hidden` and `popover` take a string as it is (`hidden="until-found"`), which the default does too
+ * - `scoped` and `seamless`, obsolete attributes that Astro renders as boolean, are not in the spec
+ *
+ * @see https://docs.astro.build/en/reference/astro-syntax/#dynamic-attributes
+ * @see https://github.com/withastro/astro/blob/main/packages/runtime/src/internal/server/render/util.ts#addAttribute
+ * @see https://github.com/withastro/astro/blob/main/packages/runtime/src/internal/server/render/util.ts#htmlBooleanAttributes
+ * @see https://github.com/withastro/astro/blob/main/packages/runtime/src/internal/server/render/util.ts#handleBooleanAttribute
+ */
+export const ASTRO_LITERAL_VALUES = {
+    booleanAttrs: { '""': null },
+    attrs: {
+        download: { true: '', false: null },
+        popover: { true: '', false: null },
+        hidden: { '0': '0' },
+        // Booleans of Astro that the spec does not know as boolean
+        disablepictureinpicture: AS_BOOLEAN,
+        disableremoteplayback: AS_BOOLEAN,
+        // Boolean attributes of the spec that Astro does not render as boolean
+        alpha: AS_STRING,
+        focusgroupstart: AS_STRING,
+        headingreset: AS_STRING,
+        ismap: AS_STRING,
+        multiple: AS_STRING,
+        shadowrootclonable: AS_STRING,
+        shadowrootcustomelementregistry: AS_STRING,
+        shadowrootdelegatesfocus: AS_STRING,
+        shadowrootserializable: AS_STRING,
+        switch: AS_STRING,
+    },
+    customElements: {
+        booleanAttrs: AS_STRING,
+        attrs: {
+            hidden: { true: 'true', false: 'false', '0': '0' },
+            popover: { true: '', false: null },
+            download: { true: 'true', false: 'false' },
+        },
+    },
+};

package/lib/parser.d.ts

@@ -101,7 +101,7 @@ declare class AstroParser extends Parser<Node> {
      * > Variable names must be capitalized. For example, use `Element`, not `element`.
      * > Otherwise, Astro will try to render your variable name as a literal HTML tag.
      *
-     * @see https://docs.astro.build/en/basics/astro-syntax/#dynamic-html
+     * @see https://docs.astro.build/en/reference/astro-syntax/#dynamic-tags
      * @param nodeName
      * @param defaultPattern
      */

package/lib/parser.js

@@ -1,6 +1,7 @@
 import { AttrState, Parser, ParserError, isPotentialCustomElementName } from '@markuplint/parser-utils';
 import { astroParse } from './astro-parser.js';
 import { detectBlockBehavior } from './detect-block-behavior.js';
+import { ASTRO_LITERAL_VALUES } from './literal-values.js';
 import { extractSpreadAttribute } from './spread-attr.js';
 import { toNodes } from './to-nodes.js';
 /**
@@ -23,6 +24,9 @@ class AstroParser extends Parser {
             selfCloseType: 'html+xml',
             // Distinguishes components (`<MyComp>`) from HTML elements (`<div>`).
             tagNameCaseSensitive: true,
+            // A value in `{…}` is JavaScript
+            attrExpressionLanguage: 'javascript',
+            literalValues: ASTRO_LITERAL_VALUES,
         });
     }
     tokenize() {
@@ -303,7 +307,7 @@ class AstroParser extends Parser {
      * > Variable names must be capitalized. For example, use `Element`, not `element`.
      * > Otherwise, Astro will try to render your variable name as a literal HTML tag.
      *
-     * @see https://docs.astro.build/en/basics/astro-syntax/#dynamic-html
+     * @see https://docs.astro.build/en/reference/astro-syntax/#dynamic-tags
      * @param nodeName
      * @param defaultPattern
      */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@markuplint/astro-parser",
-	"version": "5.4.0",
+	"version": "5.5.0",
 	"description": "astro parser for markuplint",
 	"repository": {
 		"type": "git",
@@ -32,9 +32,9 @@
 		"clean": "tsc --build --clean tsconfig.build.json"
 	},
 	"dependencies": {
-		"@markuplint/ml-ast": "5.3.0",
-		"@markuplint/parser-utils": "5.4.0",
+		"@markuplint/ml-ast": "5.5.0",
+		"@markuplint/parser-utils": "5.5.0",
 		"astro-eslint-parser": "^3.2.0"
 	},
-	"gitHead": "647f6fb5d5743f060678599c97e9c84b58970747"
+	"gitHead": "fedebcfd56eaec4642e68643b2f9e10750d810e1"
 }