@marktiderman/genesis-ui 2.3.0 → 2.3.1

package/dist/components/data/index.d.ts

@@ -451,7 +451,20 @@ type ResourcePageSlotMap<T extends Record<string, unknown> = Record<string, unkn
     /** The create / edit form. */
     form: ComponentProps<typeof ResourceForm>;
 };
-type ResourcePageSlots<T extends Record<string, unknown> = Record<string, unknown>> = Slots<ResourcePageSlotMap<T>>;
+/**
+ * `slots` for {@link ResourcePage}, with one asymmetry the map cannot express:
+ * every part may be ejected with `null` EXCEPT `shell`.
+ *
+ * The shell is not an interior part, it is the page — `Shell` is what the
+ * render returns, so ejecting it does not remove a piece, it removes the
+ * component (`const Shell = slots?.shell ?? DataPageShell` would become
+ * `null`, and React throws on the element). A caller who wants no shell wants
+ * rung 3 of the ladder, not a `null` here. Replacing it stays supported, which
+ * is the way to wrap it and change one thing.
+ */
+type ResourcePageSlots<T extends Record<string, unknown> = Record<string, unknown>> = Omit<Slots<ResourcePageSlotMap<T>>, "shell"> & {
+    shell?: ComponentType<ComponentProps<typeof DataPageShell>>;
+};
 interface ResourcePageProps<T extends Record<string, unknown> = Record<string, unknown>> {
     /** Client-side mode: resource name passed to useResource / DataProvider. */
     resource?: string;

package/dist/components/data/index.js

@@ -87,7 +87,7 @@ function DataPageShell({
   header
 }) {
   const entity = entityName || title.toLowerCase();
-  const collapseFilters = filtersCollapsible && filters != null;
+  const collapseFilters = filtersCollapsible && filters != null && header !== null;
   const mergedOptions = {
     defaultDetailsOpen: defaultFiltersOpen,
     detailsLabel: filtersLabel,