@marktiderman/genesis-forms 0.4.1 → 0.4.2

package/dist/index.d.cts

@@ -581,7 +581,7 @@ declare function formatCalculated(value: Json | undefined, field: FieldBlock): s
 declare const MAX_FORMULA_ITEMS = 10000;
 /**
  * Most list items and table rows all of a form's formulas read in one go
- * (each answer and column counted once, in form order). A formula that reads
+ * (each list or table counted once, however many of its columns are read, in form order). A formula that reads
  * an answer past the limit, or one over `MAX_FORMULA_ITEMS`, has no value
  * (blank, never a partial total), so many big answers can't make working
  * the values out slow either.

package/dist/index.d.ts

@@ -581,7 +581,7 @@ declare function formatCalculated(value: Json | undefined, field: FieldBlock): s
 declare const MAX_FORMULA_ITEMS = 10000;
 /**
  * Most list items and table rows all of a form's formulas read in one go
- * (each answer and column counted once, in form order). A formula that reads
+ * (each list or table counted once, however many of its columns are read, in form order). A formula that reads
  * an answer past the limit, or one over `MAX_FORMULA_ITEMS`, has no value
  * (blank, never a partial total), so many big answers can't make working
  * the values out slow either.

package/dist/index.js

@@ -415,7 +415,9 @@ var round = (n, decimals) => {
   return Object.is(r, -0) ? 0 : r;
 };
 function calculatedValue(result, field2) {
-  const { format, decimals } = calculatedProps(field2);
+  return valueAs(result, calculatedProps(field2));
+}
+function valueAs(result, { format, decimals }) {
   if (result === null || Array.isArray(result)) return void 0;
   if (format === "number" || format === "percent") {
     const n = formulaNumber(result);
@@ -442,19 +444,6 @@ var extract = (value, column) => column !== void 0 ? value.flatMap((row) => {
   const cell = row[column];
   return typeof cell === "string" || typeof cell === "number" ? [cell] : [];
 }) : value.flatMap((v) => typeof v === "string" || typeof v === "number" || typeof v === "boolean" ? [v] : []);
-var extracted = /* @__PURE__ */ new WeakMap();
-function cachedList(value, column) {
-  let byColumn = extracted.get(value);
-  if (!byColumn) extracted.set(value, byColumn = /* @__PURE__ */ new Map());
-  const key = column ?? "";
-  let list = byColumn.get(key);
-  if (!list) byColumn.set(key, list = ownFormulaList(extract(value, column)));
-  return list;
-}
-function readAnswer(value, column) {
-  if (Array.isArray(value)) return cachedList(value, column);
-  return column !== void 0 ? null : formulaInput(value);
-}
 function formulaInput(value, column) {
   if (value === void 0 || value === null) return null;
   if (Array.isArray(value) && value.length > MAX_FORMULA_ITEMS) return null;
@@ -473,9 +462,19 @@ function refNodes(node, out = []) {
   else if (node.kind === "call") for (const a of node.args) refNodes(a, out);
   return out;
 }
+function formulaSize(node) {
+  if (node.kind === "unary") return 1 + formulaSize(node.arg);
+  if (node.kind === "binary") return 1 + formulaSize(node.left) + formulaSize(node.right);
+  if (node.kind === "if") return 1 + formulaSize(node.test) + formulaSize(node.then) + formulaSize(node.else);
+  if (node.kind === "call") return node.args.reduce((n, a) => n + formulaSize(a), 1);
+  return 1;
+}
+function spend(budget, amount) {
+  return;
+}
 var UNREAD = /* @__PURE__ */ Symbol("unread");
 var OVER = /* @__PURE__ */ Symbol("over");
-function calculator(definition) {
+function calculator(definition, work) {
   const compiled = [];
   const idByKey = /* @__PURE__ */ new Map();
   for (const block of definition.blocks) {
@@ -484,7 +483,8 @@ function calculator(definition) {
   }
   for (const block of definition.blocks) {
     if (block.kind !== "field" || !isCalculated(block)) continue;
-    const parsed = parseFormula(calculatedProps(block).formula);
+    const props2 = calculatedProps(block);
+    const parsed = parseFormula(props2.formula);
     const reads = [];
     const slots = /* @__PURE__ */ new Map();
     const byKey = /* @__PURE__ */ new Map();
@@ -498,33 +498,64 @@ function calculator(definition) {
       }
       slots.set(ref, slot);
     }
-    compiled.push({ field: block, ast: parsed.ok ? parsed.ast : null, reads, slots, last: null });
+    compiled.push({ field: block, props: props2, ast: parsed.ok ? parsed.ast : null, size: parsed.ok ? formulaSize(parsed.ast) : 0, reads, slots, last: null });
   }
+  const extracted = /* @__PURE__ */ new WeakMap();
+  const cachedList = (value, column) => {
+    let byColumn = extracted.get(value);
+    if (!byColumn) extracted.set(value, byColumn = /* @__PURE__ */ new Map());
+    const key = column ?? "";
+    let list = byColumn.get(key);
+    if (!list) {
+      byColumn.set(key, list = ownFormulaList(extract(value, column)));
+    }
+    return list;
+  };
+  const readAnswer = (value, column) => {
+    if (Array.isArray(value)) return cachedList(value, column);
+    return column !== void 0 ? null : formulaInput(value);
+  };
+  const forget = (value) => {
+    if (!value || typeof value !== "object") return;
+    if (Array.isArray(value)) extracted.delete(value);
+    for (const entry of compiled) if (entry.last?.inputs.includes(value)) entry.last = null;
+  };
   const withCalculated = (values, path) => {
     if (!compiled.length) return values;
     const visible = new Set(path);
     let next = values;
+    let copied = false;
     let budget = MAX_SETTLE_ITEMS;
     const within = /* @__PURE__ */ new Map();
-    const input = ({ id, key }) => {
+    const input = ({ id }) => {
       if (id === void 0 || !visible.has(id) || !Object.prototype.hasOwnProperty.call(next, id)) return UNREAD;
       const value = next[id];
       if (!Array.isArray(value)) return value;
-      let ok = within.get(key);
+      let ok = within.get(id);
       if (ok === void 0) {
         ok = value.length <= MAX_FORMULA_ITEMS && value.length <= budget;
         if (ok) budget -= value.length;
-        within.set(key, ok);
+        within.set(id, ok);
       }
       return ok ? value : OVER;
     };
     for (const entry of compiled) {
       const { field: field2, ast } = entry;
-      const inputs = entry.reads.map(input);
+      const { reads } = entry;
+      const inputs = new Array(reads.length);
+      let over = false;
+      let same = entry.last !== null;
+      for (let i = 0; i < reads.length; i++) {
+        const v = input(reads[i]);
+        inputs[i] = v;
+        if (v === OVER) over = true;
+        if (same && entry.last.inputs[i] !== v) same = false;
+      }
       let value;
-      if (entry.last && entry.last.inputs.length === inputs.length && entry.last.inputs.every((v, i) => v === inputs[i])) {
+      if (same) {
         value = entry.last.value;
       } else {
+        spend(work, entry.size);
         const resolved = new Array(inputs.length);
         const read = (ref) => {
           const slot = entry.slots.get(ref);
@@ -532,19 +563,25 @@ function calculator(definition) {
           let v = resolved[slot];
           if (v === void 0) {
             const raw = inputs[slot];
-            v = resolved[slot] = raw === UNREAD ? null : readAnswer(raw, entry.reads[slot].column);
+            v = resolved[slot] = raw === UNREAD ? null : readAnswer(raw, reads[slot].column);
           }
           return v;
         };
-        value = ast && !inputs.includes(OVER) ? calculatedValue(evaluateFormula(ast, read), field2) : void 0;
+        value = ast && !over ? valueAs(evaluateFormula(ast, read), entry.props) : void 0;
         entry.last = { inputs, value };
       }
       const current = Object.prototype.hasOwnProperty.call(next, field2.id) ? next[field2.id] : void 0;
-      if (current !== value) next = { ...next, [field2.id]: value };
+      if (current !== value) {
+        if (!copied) {
+          next = { ...next };
+          copied = true;
+        }
+        next[field2.id] = value;
+      }
     }
     return next;
   };
-  return { active: compiled.length > 0, withCalculated };
+  return { active: compiled.length > 0, ids: new Set(compiled.map((c) => c.field.id)), withCalculated, forget };
 }
 var numberOps = ["eq", "neq", "lt", "lte", "gt", "gte", "in", "answered", "empty"];
 var calculatedFieldType = {
@@ -1179,8 +1216,8 @@ function rulesAllow(def, blockId, scope) {
 }
 function walkPath(def, scope) {
   const list = steps(def);
-  const index = new Map(list.map((b, i2) => [b.id, i2]));
-  const position = new Map(def.blocks.map((b, i2) => [b.id, i2]));
+  let index;
+  let position;
   const jumps = (def.logic ?? []).filter(
     (r) => r.effect === "jump"
   );
@@ -1204,6 +1241,7 @@ function walkPath(def, scope) {
         ending = jump.to.ending;
         break;
       }
+      index ??= new Map(list.map((b, at) => [b.id, at]));
       const target = index.get(jump.to);
       if (target !== void 0 && target > i) {
         i = nextVisible(target);
@@ -1213,6 +1251,7 @@ function walkPath(def, scope) {
     i = nextVisible(i + 1);
   }
   const scopeAt = (blockId, inclusive = false) => {
+    position ??= new Map(def.blocks.map((b, i2) => [b.id, i2]));
     const at = position.get(blockId) ?? -1;
     const values = /* @__PURE__ */ Object.create(null);
     for (const id of path) {
@@ -2024,10 +2063,19 @@ function validateField(field2, value, options = {}) {
 }
 
 // src/engine.ts
+function readsAny(node, ids) {
+  if (Array.isArray(node)) return node.some((n) => readsAny(n, ids));
+  if (!node || typeof node !== "object") return false;
+  for (const [k, v] of Object.entries(node)) {
+    if (k === "field" && typeof v === "string" && ids.has(v)) return true;
+    if (typeof v === "object" && readsAny(v, ids)) return true;
+  }
+  return false;
+}
 function createForm(definition, options = {}) {
   return build(definition, options).engine;
 }
-function build(definition, options, replaying = false) {
+function build(definition, options, replaying = false, budget) {
   const fields = fieldMap(definition);
   const byKey = new Map([...fields.values()].map((f2) => [f2.key, f2]));
   const blocks = new Map(definition.blocks.map((b) => [b.id, b]));
@@ -2045,15 +2093,24 @@ function build(definition, options, replaying = false) {
     if (!declared.has(name)) initialHidden[name] = value;
   }
   Object.assign(initialHidden, coerceHidden(definition, options.hidden).values);
-  const calc = calculator(definition);
+  const calc = calculator(definition, budget);
+  const pathOf = (values, hidden) => {
+    spend(budget, definition.blocks.length);
+    return computePath(definition, scopeOf(values, hidden));
+  };
+  const logicReadsCalculated = calc.active && readsAny(definition.logic, calc.ids);
   const settle = (values, hidden) => {
-    let { path } = computePath(definition, scopeOf(values, hidden));
+    let { path } = pathOf(values, hidden);
     if (!calc.active) return { values, path };
+    if (!logicReadsCalculated) return { values: calc.withCalculated(values, path), path };
     for (let round2 = 0; round2 < 4; round2++) {
       const next = calc.withCalculated(values, path);
       if (next === values) break;
       values = next;
-      path = computePath(definition, scopeOf(values, hidden)).path;
+      const again = pathOf(values, hidden).path;
+      const same = again.length === path.length && again.every((id, i) => id === path[i]);
+      path = again;
+      if (same) break;
     }
     return { values, path };
   };
@@ -2095,14 +2152,30 @@ function build(definition, options, replaying = false) {
     return errors;
   };
   let unsettled = false;
-  const settleNow = () => {
-    if (!unsettled) return;
-    unsettled = false;
-    const { values, path } = settle(state.values, state.hidden);
-    state = { ...state, values, path };
+  let formulasStale = false;
+  const settleNow = (needValues = true) => {
+    if (unsettled && calc.active && !logicReadsCalculated && !needValues) {
+      unsettled = false;
+      formulasStale = true;
+      state = { ...state, path: pathOf(state.values, state.hidden).path };
+      return;
+    }
+    if (unsettled) {
+      unsettled = false;
+      formulasStale = false;
+      const { values, path } = settle(state.values, state.hidden);
+      state = { ...state, values, path };
+    } else if (formulasStale && needValues) {
+      formulasStale = false;
+      state = { ...state, values: calc.withCalculated(state.values, state.path) };
+    }
   };
   const answer = (id, value, event) => {
-    if (state.status === "completed" || own(state.values, id) === value || isCalculated(fields.get(id))) return;
+    if (state.status === "completed" || isCalculated(fields.get(id))) return;
+    if (own(state.values, id) === value) {
+      if (value === null || typeof value !== "object") return;
+      calc.forget(value);
+    }
     const errors = { ...state.errors };
     delete errors[id];
     if (batch) {
@@ -2168,7 +2241,7 @@ function build(definition, options, replaying = false) {
         emit({ ...state, errors, current: firstError, events });
         return false;
       }
-      const { ending } = computePath(definition, scopeOf(state.values, state.hidden));
+      const { ending } = pathOf(state.values, state.hidden);
       emit({ ...state, errors: {}, status: "completed", ending, events });
       return true;
     },
@@ -2200,10 +2273,11 @@ function build(definition, options, replaying = false) {
         answer(event.field, event.value, logged);
       }
     } else if (event.type === "next") {
-      settleNow();
+      settleNow(false);
+      if (formulasStale && isCalculated(fields.get(state.current ?? ""))) settleNow(true);
       engine.next();
     } else if (event.type === "back") {
-      settleNow();
+      settleNow(false);
       engine.back();
     } else if (event.type === "submit") {
       settleNow();
@@ -2218,9 +2292,16 @@ function build(definition, options, replaying = false) {
   return { engine, apply, finish };
 }
 function replay(definition, events, options = {}) {
-  const { engine, apply, finish } = build(definition, { ...options, initialValues: void 0, clock: () => void 0 }, true);
-  for (const event of events) apply(event);
-  finish();
+  return replayWithin(definition, events, options);
+}
+function replayWithin(definition, events, options, maxWork) {
+  const budget = void 0 ;
+  const { engine, apply, finish } = build(definition, { ...options, initialValues: void 0, clock: () => void 0 }, true, budget);
+  try {
+    for (const event of events) apply(event);
+    finish();
+  } finally {
+  }
   return engine;
 }