@marko/runtime-tags 6.0.129 → 6.0.130

package/dist/translator/index.js

@@ -3290,16 +3290,17 @@ function getScopeExpression(section, targetSection) {
   }
   return scope;
 }
-function createScopeReadExpression(reference, section) {
+function createScopeReadExpression(reference, section = reference.section) {
   const propName = toPropertyName(getScopeAccessor(reference));
-  const scope = section && reference.type !== 4 /* local */ ? getScopeExpression(section, reference.section) : scopeIdentifier;
   const expr = import_compiler19.types.memberExpression(
-    scope,
+    reference.type === 4 /* local */ ? scopeIdentifier : getScopeExpression(section, reference.section),
     propName,
     propName.type !== "Identifier"
   );
-  if (scope === scopeIdentifier) {
-    (expr.extra ??= {}).read = createRead(reference, void 0);
+  if (section === reference.section && reference.type !== 0 /* dom */) {
+    const exprExtra = expr.extra ??= {};
+    exprExtra.read = createRead(reference, void 0);
+    exprExtra.section = section;
   }
   return expr;
 }
@@ -3431,9 +3432,13 @@ function getSignal(section, referencedBindings, name2 = generateSignalName(refer
         renderReferencedBindings: void 0,
         effect: [],
         effectReferencedBindings: void 0,
-        subscribers: [],
         build: void 0,
-        export: !!exportName
+        export: !!exportName,
+        hasSideEffect: !!(referencedBindings && (Array.isArray(referencedBindings) || referencedBindings.type === 0 /* dom */ || referencedBindings.type === 1 /* let */ || referencedBindings.section !== section || referencedBindings.closureSections || referencedBindings.hoists.size)),
+        hasDynamicSubscribers: false,
+        extraArgs: void 0,
+        prependStatements: void 0,
+        buildAssignment: void 0
       }
     );
     if (isOutputHTML()) {
@@ -3678,7 +3683,6 @@ function getSignalFn(signal) {
   }
   if (signal.effect.length) {
     const effectIdentifier = import_compiler22.types.identifier(`${signal.identifier.name}__script`);
-    signal.hasSideEffect = true;
     signal.render.push(
       import_compiler22.types.expressionStatement(
         import_compiler22.types.callExpression(effectIdentifier, [scopeIdentifier])
@@ -3735,6 +3739,7 @@ function subscribe(references, subscriber) {
       if (binding.type !== 7 /* constant */) {
         const source = binding.property === void 0 && binding.excludeProperties === void 0 && binding.upstreamAlias || binding;
         const providerSignal = getSignal(subscriber.section, source);
+        providerSignal.hasSideEffect = true;
         providerSignal.intersection = push(
           providerSignal.intersection,
           subscriber
@@ -3897,12 +3902,6 @@ function writeSignals(section) {
       traverseReplace(value, "value", replaceRenderNode);
     }
     forEach(signal.intersection, writeSignal);
-    if (!signal.hasSideEffect) {
-      const binding = signal.referencedBindings;
-      if (binding && (signal.intersection || Array.isArray(binding) || binding.type === 1 /* let */ || binding.closureSections || binding.hoists.size || binding.section !== signal.section)) {
-        signal.hasSideEffect = true;
-      }
-    }
     let effectDeclarator;
     if (signal.effect.length) {
       traverseReplace(signal, "effect", replaceEffectNode);
@@ -6946,7 +6945,7 @@ function translateAttrs(tag, propTree, skip2, statements = [], contentKey = "con
   if (attrTagLookup) {
     for (const name2 in attrTagLookup) {
       const attrTagMeta = attrTagLookup[name2];
-      if (!seen.has(name2) && usesExport(templateExports, attrTagMeta.name)) {
+      if (!seen.has(attrTagMeta.name) && usesExport(templateExports, attrTagMeta.name)) {
         seen.add(attrTagMeta.name);
         if (attrTagMeta.dynamic) {
           statements.push(
@@ -6969,6 +6968,7 @@ function translateAttrs(tag, propTree, skip2, statements = [], contentKey = "con
       if (child.isMarkoTag()) {
         if ((0, import_babel_utils24.isAttributeTag)(child)) {
           const attrTagMeta = attrTagLookup[getTagName(child)];
+          if (skip2?.has(attrTagMeta.name)) continue;
           if (attrTagMeta.dynamic) {
             i = addDynamicAttrTagStatements(
               attrTags2,
@@ -7712,7 +7712,9 @@ function analyzeAttrs(rootTagExtra, section, tag, propTree, rootAttrExprs) {
     } else if (import_compiler37.types.isMarkoSpreadAttribute(attr)) {
       knownSpreadBinding = getSingleKnownSpreadBinding(attributes);
       if (knownSpreadBinding) {
-        dropRead(attr.value.extra);
+        if (!propTree.rest || propTree.rest.props) {
+          dropRead(attr.value.extra);
+        }
       } else {
         spreadReferenceNodes = [attr.value];
       }
@@ -7730,7 +7732,6 @@ function analyzeAttrs(rootTagExtra, section, tag, propTree, rootAttrExprs) {
         known[prop] = { value: propExtra };
         rootAttrExprs.add(propExtra);
         addRead(propExtra, propExtra, propBinding, section);
-        setBindingDownstream(propBinding, propExtra);
       }
     }
   } else if (spreadReferenceNodes) {
@@ -7753,14 +7754,15 @@ function analyzeAttrs(rootTagExtra, section, tag, propTree, rootAttrExprs) {
     );
   }
   if (propTree.rest) {
-    setBindingDownstream(
-      propTree.binding,
-      inputExpr.value = mergeReferences(
-        section,
-        tag.node,
-        unknownReferences.flat()
-      )
+    const restExtra = inputExpr.value = mergeReferences(
+      section,
+      tag.node,
+      unknownReferences.flat()
     );
+    setBindingDownstream(propTree.binding, restExtra);
+    if (knownSpreadBinding && !propTree.rest.props) {
+      addRead(restExtra, void 0, knownSpreadBinding, section);
+    }
   } else {
     unknownReferences.forEach(dropReferences);
   }
@@ -8178,7 +8180,9 @@ function writeAttrsToSignals(tag, propTree, importAlias, info) {
           createScopeReadExpression(info.childScopeBinding, info.tagSection),
           translatedProps
         ])
-      )
+      ),
+      void 0,
+      true
     );
   }
 }
@@ -8306,7 +8310,9 @@ function trackDomVarReferences(tag, binding) {
     const refSection = getOrCreateSection(ref);
     setReferencesScope(ref);
     if (isSameOrChildSection(binding.section, refSection)) {
-      (ref.node.extra ??= {}).read = createRead(binding, void 0);
+      const refExtra = ref.node.extra ??= {};
+      refExtra.read = createRead(binding, void 0);
+      refExtra.section = refSection;
       if (!isInvokedFunction(ref)) {
         section.domGetterBindings.set(
           binding,
@@ -9597,6 +9603,7 @@ function getAllSerializeReasonsForExtra(extra) {
     if (extra === (0, import_babel_utils26.getProgram)().node.extra?.returnValueExpr) {
       reason = true;
     } else {
+      serializeReasonCache.set(extra, false);
       forEach(extra.downstream, (binding) => {
         reason = mergeSerializeReasons(
           reason,
@@ -9604,7 +9611,9 @@ function getAllSerializeReasonsForExtra(extra) {
         );
       });
     }
-    serializeReasonCache.set(extra, reason || false);
+    if (reason) {
+      serializeReasonCache.set(extra, reason);
+    }
   }
   return reason;
 }
@@ -9614,6 +9623,9 @@ function getAllSerializeReasonsForBinding(binding) {
   if (reason === void 0) {
     reason = getSerializeReason(binding.section, binding);
     if (reason !== true) {
+      if (!reason) {
+        serializeReasonCache.set(binding, false);
+      }
       for (const expr of binding.downstreamExpressions) {
         reason = expr.isEffect || mergeSerializeReasons(reason, getAllSerializeReasonsForExtra(expr));
         if (reason === true) break;
@@ -9637,7 +9649,9 @@ function getAllSerializeReasonsForBinding(binding) {
         }
       }
     }
-    serializeReasonCache.set(binding, reason || false);
+    if (reason) {
+      serializeReasonCache.set(binding, reason);
+    }
   }
   return reason;
 }
@@ -10040,15 +10054,18 @@ var define_default = {
             }
           }
           if (hasDirectReferences) {
-            const signal = getSignal(node.body.extra.section, void 0);
-            signal.build = () => {
-              if (signalHasStatements(signal)) {
-                return callRuntime("_child_setup", getSignalFn(signal));
+            const bodySection = getSectionForBody(tag.get("body"));
+            if (bodySection) {
+              const signal = getSignal(bodySection, void 0);
+              signal.build = () => {
+                if (signalHasStatements(signal)) {
+                  return callRuntime("_child_setup", getSignalFn(signal));
+                }
+              };
+              if (allDirectReferences) {
+                tag.remove();
+                return;
               }
-            };
-            if (allDirectReferences) {
-              tag.remove();
-              return;
             }
           }
         }

package/dist/translator/util/scope-read.d.ts

@@ -3,4 +3,4 @@ import { type Binding, type ReferencedBindings } from "./references";
 import type { Section } from "./sections";
 export declare function createScopeReadPattern(section: Section, referencedBindings: ReferencedBindings): t.ObjectPattern;
 export declare function getScopeExpression(section: Section, targetSection: Section): t.Identifier | t.MemberExpression;
-export declare function createScopeReadExpression(reference: Binding, section?: Section | undefined): t.MemberExpression;
+export declare function createScopeReadExpression(reference: Binding, section?: Section): t.MemberExpression;

package/dist/translator/util/signals.d.ts

@@ -3,7 +3,7 @@ import { type AccessorPrefix, AccessorProp } from "../../common/types";
 import { type Opt } from "./optional";
 import { type Binding, type ReferencedBindings } from "./references";
 import { type Section } from "./sections";
-export type Signal = {
+export interface Signal {
     identifier: t.Identifier;
     referencedBindings: ReferencedBindings;
     section: Section;
@@ -18,13 +18,13 @@ export type Signal = {
     renderReferencedBindings: ReferencedBindings;
     effect: t.Statement[];
     effectReferencedBindings: ReferencedBindings;
-    hasDynamicSubscribers?: true;
-    hasSideEffect?: true;
+    hasDynamicSubscribers: boolean;
+    hasSideEffect: boolean;
     export: boolean;
-    extraArgs?: t.Expression[];
-    prependStatements?: t.Statement[];
-    buildAssignment?: (valueSection: Section, value: t.Expression) => t.Expression | undefined;
-};
+    extraArgs: t.Expression[] | undefined;
+    prependStatements: t.Statement[] | undefined;
+    buildAssignment: ((valueSection: Section, value: t.Expression) => t.Expression | undefined) | undefined;
+}
 type closureSignalBuilder = (closure: Binding, render: t.Expression) => t.Expression;
 export declare function setClosureSignalBuilder(tag: t.NodePath<t.MarkoTag>, builder: closureSignalBuilder): void;
 export declare const getTryHasPlaceholder: (section: Section) => true | undefined, setTryHasPlaceholder: (section: Section, value: true | undefined) => void;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@marko/runtime-tags",
-  "version": "6.0.129",
+  "version": "6.0.130",
   "description": "Optimized runtime for Marko templates.",
   "keywords": [
     "api",