@marko/language-tools 2.3.1 → 2.4.0

package/dist/index.js

@@ -53,8 +53,7 @@ var import_htmljs_parser = require("htmljs-parser");
 // src/util/get-node-at-offset.ts
 function getNodeAtOffset(offset, program) {
   const childNode = childAtOffset(offset, program.body);
-  if (childNode)
-    return visitChildNode(offset, childNode);
+  if (childNode) return visitChildNode(offset, childNode);
   return childAtOffset(offset, program.static) || program;
 }
 function visitChildNode(offset, child) {
@@ -118,8 +117,7 @@ function visitAttrNode(offset, attr) {
 }
 function childAtOffset(offset, children) {
   let max = children.length - 1;
-  if (max === -1)
-    return void 0;
+  if (max === -1) return void 0;
   let min = 0;
   while (min < max) {
     const mid = 1 + min + max >>> 1;
@@ -297,6 +295,7 @@ var Builder = class {
     }
     if (!range.expressions.length) {
       switch (nameText = this.#code.slice(range.start, range.end)) {
+        // All statement types will early return.
         case "style": {
           styleBlockReg.lastIndex = range.end;
           const styleBlockMatch = styleBlockReg.exec(this.#code);
@@ -371,6 +370,8 @@ var Builder = class {
           );
           this.#comments = void 0;
           return import_htmljs_parser.TagType.statement;
+        // The following are all still tags,
+        // but with a different body type.
         case "area":
         case "base":
         case "br":
@@ -630,8 +631,7 @@ var Builder = class {
   }
   onCloseTagEnd(range) {
     const parent = this.#parentNode;
-    if (hasCloseTag(parent))
-      parent.close.end = range.end;
+    if (hasCloseTag(parent)) parent.close.end = range.end;
     parent.end = range.end;
     this.#parentNode = parent.parent;
   }
@@ -730,8 +730,7 @@ var Extracted = class {
   }
   sourcePositionAt(generatedOffset) {
     const sourceOffset = this.sourceOffsetAt(generatedOffset);
-    if (sourceOffset !== void 0)
-      return this.parsed.positionAt(sourceOffset);
+    if (sourceOffset !== void 0) return this.parsed.positionAt(sourceOffset);
   }
   sourceLocationAt(generatedStart, generatedEnd) {
     const sourceRange = this.#generatedToSource.rangeAt(
@@ -807,8 +806,7 @@ var TokenView = class {
     }
     const startToken = this.#tokens[max];
     const startTokenInStart = this.inStart(startToken);
-    if (startTokenInStart >= inEnd)
-      return;
+    if (startTokenInStart >= inEnd) return;
     max = this.#last;
     while (min < max) {
       const mid = 1 + min + max >>> 1;
@@ -823,8 +821,7 @@ var TokenView = class {
     const endToken = this.#tokens[min];
     const endTokenInStart = this.inStart(endToken);
     const endTokenInEnd = endTokenInStart + endToken.length;
-    if (endTokenInEnd < inStart)
-      return;
+    if (endTokenInEnd < inStart) return;
     const startIndex = inStart - startTokenInStart;
     const endIndex = inEnd - endTokenInStart;
     const start = this.outStart(startToken) + Math.max(0, startIndex);
@@ -983,12 +980,6 @@ var ScriptParser = class {
   }
 };
 
-// src/extractors/script/util/is-valid-identifier.ts
-var import_helper_validator_identifier = require("@babel/helper-validator-identifier");
-function isValidIdentifier(name) {
-  return (0, import_helper_validator_identifier.isIdentifierName)(name) && !(0, import_helper_validator_identifier.isKeyword)(name) && !(0, import_helper_validator_identifier.isStrictBindReservedWord)(name, true);
-}
-
 // src/extractors/script/util/attach-scopes.ts
 var t = __toESM(require("@babel/types"));
 var ATTR_UNAMED = "value";
@@ -1359,6 +1350,10 @@ function* getVarIdentifiers(parsed, lVal, objectPath, sourceName) {
 function trackMutationsInClosures(root, scope, mutations) {
   traverse(root, (node) => {
     switch (node.type) {
+      // Since the root will always be an expression it's impossible
+      // to hit a "FunctionDeclaration" without first going through
+      // a a different function context. So we don't need to track it.
+      // case "FunctionDeclaration":
       case "FunctionExpression":
       case "ObjectMethod":
       case "ArrowFunctionExpression":
@@ -1370,8 +1365,7 @@ function trackMutationsInClosures(root, scope, mutations) {
   });
 }
 function trackMutations(node, scope, mutations, parentBlock, parentBlockShadows, parentBlockMutations) {
-  if (!node)
-    return;
+  if (!node) return;
   let block = parentBlock;
   let blockShadows = parentBlockShadows;
   let blockMutations = parentBlockMutations;
@@ -1494,8 +1488,7 @@ function trackMutations(node, scope, mutations, parentBlock, parentBlockShadows,
   }
   if (block !== parentBlock && blockMutations.length) {
     for (const { name, start } of blockMutations) {
-      if (blockShadows.has(name))
-        continue;
+      if (blockShadows.has(name)) continue;
       const binding = resolveWritableVar(scope, name);
       if (binding) {
         binding.mutated = true;
@@ -1512,10 +1505,8 @@ function trackShadows(node, scope, shadows) {
   }
 }
 function traverse(node, enter) {
-  if (!node)
-    return;
-  if (enter(node))
-    return;
+  if (!node) return;
+  if (enter(node)) return;
   for (const key of t.VISITOR_KEYS[node.type]) {
     const child = node[key];
     if (Array.isArray(child)) {
@@ -1613,8 +1604,7 @@ function getRuntimeOverrides(runtimeTypes, generics, applyGenerics) {
 var MaybeInputTypedefReg = /@typedef\b[\s\S]*\bInput\b/;
 function getJSDocInputType(comment, ts) {
   var _a, _b, _c, _d;
-  if (!MaybeInputTypedefReg.test(comment))
-    return;
+  if (!MaybeInputTypedefReg.test(comment)) return;
   const sourceFile = ts.createSourceFile(
     "_.js",
     comment,
@@ -1623,8 +1613,7 @@ function getJSDocInputType(comment, ts) {
     ts.ScriptKind.JS
   );
   const tags = (_b = (_a = sourceFile.endOfFileToken.jsDoc) == null ? void 0 : _a[0]) == null ? void 0 : _b.tags;
-  if (!(tags && hasInputTypeDef(ts, sourceFile, tags)))
-    return;
+  if (!(tags && hasInputTypeDef(ts, sourceFile, tags))) return;
   let typeParameters;
   for (const tag of tags) {
     if (isTemplateTag(ts, tag)) {
@@ -1674,10 +1663,11 @@ var REG_EXT = /(?<=[/\\][^/\\]+)\.[^.]+$/;
 var REG_BLOCK = /\s*{/y;
 var REG_NEW_LINE = /^|(\r?\n)/g;
 var REG_ATTR_ARG_LITERAL = /(?<=\s*)(["'])((?:[^"'\\]+|\\.|(?!\1))*)\1\s*([,)])/my;
-var REG_TAG_IMPORT = /(?<=(['"]))<([^\1>]+)>(?=\1)/;
+var REG_TAG_IMPORT = /(?<=(['"]))<([^'">]+)>(?=\1)/;
 var REG_INPUT_TYPE = /\s*(interface|type)\s+Input\b/y;
 var REG_OBJECT_PROPERTY = /^[_$a-z][_$a-z0-9]*$/i;
 var REG_COMMENT_PRAGMA = /\/\/(?:\s*@ts-|\/\s*<)/y;
+var REG_TAG_NAME_IDENTIFIER = /^[A-Z][a-zA-Z_$]+$/;
 var IF_TAG_ALTERNATES = /* @__PURE__ */ new WeakMap();
 var WROTE_COMMENT = /* @__PURE__ */ new WeakSet();
 var START_OF_FILE = { start: 0, end: 0 };
@@ -1992,8 +1982,7 @@ constructor(_?: Return) {}
               let renderId = this.#getRenderId(child);
               if (!renderId && alternates) {
                 for (const { node } of alternates) {
-                  if (renderId = this.#getRenderId(node))
-                    break;
+                  if (renderId = this.#getRenderId(node)) break;
                 }
               }
               if (renderId) {
@@ -2164,7 +2153,7 @@ constructor(_?: Return) {}
       if (def) {
         const importPath = resolveTagImport(this.#filename, def);
         const renderer = (importPath == null ? void 0 : importPath.endsWith(".marko")) ? `renderTemplate(import("${importPath}"))` : def.html ? `renderNativeTag("${def.name}")` : "missingTag";
-        if (!def.html && isValidIdentifier(tagName)) {
+        if (!def.html && REG_TAG_NAME_IDENTIFIER.test(tagName)) {
           this.#extractor.write(
             `${varShared("renderPreferLocal")}(
 // @ts-expect-error We expect the compiler to error because we are checking if the tag is defined.
@@ -2174,7 +2163,7 @@ ${varShared(renderer)})`);
         } else {
           this.#extractor.write(varShared(renderer));
         }
-      } else if (isValidIdentifier(tagName)) {
+      } else if (REG_TAG_NAME_IDENTIFIER.test(tagName)) {
         this.#extractor.write(`${varShared("renderDynamicTag")}(
 `).copy(tag.name).write("\n)");
       } else {
@@ -2396,13 +2385,11 @@ ${isMutatedVar(tag.parent, valueLiteral) ? `${varLocal("return")}.mutate.` : ""}
     }
     if (dynamicAttrTagParents) {
       this.#writeDynamicAttrTagParents(dynamicAttrTagParents);
-      if (wasMerge)
-        this.#extractor.write(`)${SEP_COMMA_NEW_LINE}`);
+      if (wasMerge) this.#extractor.write(`)${SEP_COMMA_NEW_LINE}`);
     }
   }
   #writeStaticAttrTags(staticAttrTags, wasMerge) {
-    if (!wasMerge)
-      this.#extractor.write("...{");
+    if (!wasMerge) this.#extractor.write("...{");
     this.#extractor.write(
       `[${varShared("never")}](){
 const attrTags = ${varShared(
@@ -2418,27 +2405,27 @@ const attrTags = ${varShared(
       }
     }
     this.#extractor.write("\n}");
-    if (!wasMerge)
-      this.#extractor.write("}");
+    if (!wasMerge) this.#extractor.write("}");
     this.#extractor.write(SEP_COMMA_NEW_LINE);
     for (const nameText in staticAttrTags) {
       const attrTag = staticAttrTags[nameText];
       const attrTagDef = this.#lookup.getTag(nameText);
-      const isRepeated = attrTag.length > 1 ? true : attrTagDef == null ? void 0 : attrTagDef.isRepeated;
+      const isRepeated = attrTag.length > 1;
       const [firstAttrTag] = attrTag;
       const name = (attrTagDef == null ? void 0 : attrTagDef.targetProperty) || nameText.slice(nameText.lastIndexOf(":") + 1);
       this.#extractor.write(`["${name}"`);
       this.#writeTagNameComment(firstAttrTag);
       this.#extractor.write("]: ");
       if (isRepeated) {
-        this.#extractor.write("[\n");
+        this.#extractor.write(`${varShared("repeatedAttrTag")}(
+`);
       }
       for (const childNode of attrTag) {
         this.#writeTagInputObject(childNode);
         this.#extractor.write(SEP_COMMA_NEW_LINE);
       }
       if (isRepeated) {
-        this.#extractor.write(`]${SEP_COMMA_NEW_LINE}`);
+        this.#extractor.write(`)${SEP_COMMA_NEW_LINE}`);
       }
     }
   }
@@ -2477,8 +2464,7 @@ const attrTags = ${varShared(
         case "for": {
           this.#extractor.write(`${varShared("forAttrTag")}({
 `);
-          if (!this.#writeAttrs(tag))
-            this.#writeTagNameComment(tag);
+          if (!this.#writeAttrs(tag)) this.#writeTagNameComment(tag);
           this.#extractor.write("}, \n");
           this.#writeComments(tag);
           this.#extractor.copy(tag.typeParams).write("(\n").copy((_b = tag.params) == null ? void 0 : _b.value).write("\n) => (");
@@ -2488,12 +2474,11 @@ const attrTags = ${varShared(
         }
         case "while": {
           this.#writeComments(tag);
-          this.#extractor.write(`${varShared("mergeAttrTags")}((
-`).copy(
+          this.#extractor.write("((\n").copy(
             this.#getRangeWithoutTrailingComma((_c = tag.args) == null ? void 0 : _c.value) || "undefined"
-          ).write("\n) ? [");
+          ).write("\n) ? ");
           this.#writeDynamicAttrTagBody(tag);
-          this.#extractor.write("] : [])");
+          this.#extractor.write(" : {})");
           break;
         }
       }
@@ -2501,24 +2486,24 @@ const attrTags = ${varShared(
     }
   }
   #writeTagInputObject(tag) {
-    if (!tag.params)
-      this.#writeComments(tag);
+    if (!tag.params) this.#writeComments(tag);
+    const body = this.#processBody(tag);
+    let writeInputObj = true;
     let hasInput = false;
-    this.#extractor.write("{\n");
     if (tag.args) {
       hasInput = true;
-      this.#extractor.write("[").copy({
-        start: tag.args.start,
-        end: tag.args.start + 1
-      }).write('"value"').copy({
-        start: tag.args.end - 1,
-        end: tag.args.end
-      }).write(`]: ${varShared("tuple")}(`).copy(tag.args.value).write(")").write(",\n");
+      this.#extractor.copy(tag.args.value);
+      if (body || tag.attrs || tag.shorthandId || tag.shorthandClassNames) {
+        this.#extractor.write(",\n{\n");
+      } else {
+        writeInputObj = false;
+      }
+    } else {
+      this.#extractor.write("{\n");
     }
     if (this.#writeAttrs(tag)) {
       hasInput = true;
     }
-    const body = this.#processBody(tag);
     let hasRenderBody = false;
     if (body) {
       hasInput = true;
@@ -2564,7 +2549,9 @@ const attrTags = ${varShared(
     if (!hasInput) {
       this.#writeTagNameComment(tag);
     }
-    this.#extractor.write("\n}");
+    if (writeInputObj) {
+      this.#extractor.write("\n}");
+    }
   }
   #writeObjectKeys(keys) {
     this.#extractor.write("{");
@@ -2578,8 +2565,7 @@ const attrTags = ${varShared(
   }
   #copyWithMutationsReplaced(range) {
     const mutations = this.#mutationOffsets;
-    if (!mutations)
-      return this.#extractor.copy(range);
+    if (!mutations) return this.#extractor.copy(range);
     const len = mutations.length;
     let curOffset = range.start;
     let minIndex = 0;
@@ -2629,8 +2615,7 @@ const attrTags = ${varShared(
   #processBody(parent) {
     var _a;
     const { body } = parent;
-    if (!body)
-      return;
+    if (!body) return;
     const last = body.length - 1;
     let renderBody;
     let staticAttrTags;
@@ -2663,56 +2648,55 @@ const attrTags = ${varShared(
             case "if": {
               let alternates;
               hasDynamicAttrTags ||= child.hasAttrTags;
-              loop:
-                while (i <= last) {
-                  const nextChild = body[i++];
-                  switch (nextChild.type) {
-                    case 17 /* Text */:
-                      if (this.#isEmptyText(nextChild)) {
+              loop: while (i <= last) {
+                const nextChild = body[i++];
+                switch (nextChild.type) {
+                  case 17 /* Text */:
+                    if (this.#isEmptyText(nextChild)) {
+                      continue loop;
+                    } else {
+                      break;
+                    }
+                  case 1 /* Tag */:
+                    switch (nextChild.nameText) {
+                      case "else-if": {
+                        const alternate = {
+                          condition: this.#getRangeWithoutTrailingComma(
+                            (_a = nextChild.args) == null ? void 0 : _a.value
+                          ) || this.#getAttrValue(nextChild, ATTR_UNAMED2),
+                          node: nextChild
+                        };
+                        hasDynamicAttrTags ||= nextChild.hasAttrTags;
+                        if (alternates) {
+                          alternates.push(alternate);
+                        } else {
+                          alternates = [alternate];
+                        }
                         continue loop;
-                      } else {
-                        break;
                       }
-                    case 1 /* Tag */:
-                      switch (nextChild.nameText) {
-                        case "else-if": {
-                          const alternate = {
-                            condition: this.#getRangeWithoutTrailingComma(
-                              (_a = nextChild.args) == null ? void 0 : _a.value
-                            ) || this.#getAttrValue(nextChild, ATTR_UNAMED2),
-                            node: nextChild
-                          };
-                          hasDynamicAttrTags ||= nextChild.hasAttrTags;
-                          if (alternates) {
-                            alternates.push(alternate);
-                          } else {
-                            alternates = [alternate];
-                          }
-                          continue loop;
+                      case "else": {
+                        const alternate = {
+                          condition: this.#getAttrValue(nextChild, "if"),
+                          node: nextChild
+                        };
+                        hasDynamicAttrTags ||= nextChild.hasAttrTags;
+                        if (alternates) {
+                          alternates.push(alternate);
+                        } else {
+                          alternates = [alternate];
                         }
-                        case "else": {
-                          const alternate = {
-                            condition: this.#getAttrValue(nextChild, "if"),
-                            node: nextChild
-                          };
-                          hasDynamicAttrTags ||= nextChild.hasAttrTags;
-                          if (alternates) {
-                            alternates.push(alternate);
-                          } else {
-                            alternates = [alternate];
-                          }
-                          if (alternate.condition) {
-                            continue loop;
-                          } else {
-                            break loop;
-                          }
+                        if (alternate.condition) {
+                          continue loop;
+                        } else {
+                          break loop;
                         }
                       }
-                      break;
-                  }
-                  i--;
-                  break;
+                    }
+                    break;
                 }
+                i--;
+                break;
+              }
               IF_TAG_ALTERNATES.set(child, alternates);
             }
           }
@@ -2780,8 +2764,7 @@ const attrTags = ${varShared(
     }
   }
   #getRangeWithoutTrailingComma(range) {
-    if (!range)
-      return void 0;
+    if (!range) return void 0;
     const { start } = range;
     let end = range.end - 1;
     while (end >= start) {
@@ -2836,8 +2819,7 @@ const attrTags = ${varShared(
       const code = this.#read(node);
       code;
       const info = this.#getJSDocInputTypeFromNode(node);
-      if (info)
-        return info;
+      if (info) return info;
     }
   }
   #getJSDocInputTypeFromNode(node) {
@@ -2872,8 +2854,7 @@ const attrTags = ${varShared(
     const start = attr.name.start + 1;
     const end = attr.name.end - 1;
     for (let i = end; i-- > start; ) {
-      if (this.#code.charAt(i) === ":")
-        return i;
+      if (this.#code.charAt(i) === ":") return i;
     }
     return false;
   }
@@ -2965,8 +2946,7 @@ function getTypeLibs(rootDir, ts, host) {
   var _a;
   const config = getConfig(rootDir);
   let typeLibs = config.cache.get(getTypeLibs);
-  if (typeLibs)
-    return typeLibs;
+  if (typeLibs) return typeLibs;
   const resolveTypeCompilerOptions = {
     moduleResolution: ts.ModuleResolutionKind.Bundler
   };
@@ -3011,8 +2991,7 @@ function getTypeLibs(rootDir, ts, host) {
   return typeLibs;
 }
 function getScriptLang(fileName, defaultScriptLang, ts, host) {
-  if (fileName.endsWith(".d.marko"))
-    return "ts" /* ts */;
+  if (fileName.endsWith(".d.marko")) return "ts" /* ts */;
   const dir = import_path2.default.dirname(fileName);
   const config = getConfig(dir);
   const cache = config.cache.get(getScriptLang);
@@ -3167,8 +3146,7 @@ __export(processors_exports, {
 // src/util/get-ext.ts
 function getExt(fileName) {
   const extIndex = fileName.lastIndexOf(".");
-  if (extIndex !== -1)
-    return fileName.slice(extIndex);
+  if (extIndex !== -1) return fileName.slice(extIndex);
 }
 
 // src/processors/marko.ts
@@ -3298,8 +3276,7 @@ var marko_default = {
             statement,
             sourceFile
           );
-          if (!/^(?:import|export) /.test(printed))
-            code += "static ";
+          if (!/^(?:import|export) /.test(printed)) code += "static ";
           code += printed + nlChar;
         }
         if (componentImpl == null ? void 0 : componentImpl.members.length) {
@@ -3347,7 +3324,7 @@ var marko_default = {
       return ts.isTypeAliasDeclaration(statement) && statement.name.escapedText === "Input" && ts.isTypeLiteralNode(statement.type) && !statement.typeParameters && statement.type.members.length === 0 || ts.isInterfaceDeclaration(statement) && statement.name.escapedText === "Input" && !statement.heritageClauses && !statement.typeParameters && statement.members.length === 0;
     }
     function isExportComponentType(statement) {
-      return ts.isExportDeclaration(statement) && statement.exportClause && ts.isNamedExports(statement.exportClause) && statement.exportClause.elements.length === 1 && statement.exportClause.elements[0].name.escapedText === "Component";
+      return ts.isExportDeclaration(statement) && statement.exportClause && ts.isNamedExports(statement.exportClause) && statement.exportClause.elements.length === 1 && ts.isIdentifier(statement.exportClause.elements[0].name) && statement.exportClause.elements[0].name.escapedText === "Component";
     }
     function isVariableStatementForName(statement, name) {
       if (ts.isVariableStatement(statement)) {
@@ -3390,8 +3367,7 @@ function isHTMLTag(tag) {
   return builtinTagsRegex.test(tag);
 }
 function getAttributeValueType(value) {
-  if (value === void 0 || value[0] !== "=")
-    return void 0;
+  if (value === void 0 || value[0] !== "=") return void 0;
   value = value.substring(1).trim();
   switch (value) {
     case "NaN":
@@ -3449,8 +3425,7 @@ var HTMLExtractor = class {
     switch (node.type) {
       case 16 /* AttrTag */:
         (_a = node.body) == null ? void 0 : _a.forEach((child) => {
-          if (this.#visitNode(child))
-            hasDynamicBody = true;
+          if (this.#visitNode(child)) hasDynamicBody = true;
         });
         break;
       case 1 /* Tag */: {
@@ -3492,16 +3467,13 @@ var HTMLExtractor = class {
     this.#extractor.copy(node.name);
     this.#extractor.write(` data-marko-node-id="${id}"`);
     (_a = node.attrs) == null ? void 0 : _a.forEach((attr) => {
-      if (attr.type === 10 /* AttrNamed */)
-        this.#writeAttrNamed(attr);
-      else if (attr.type === 15 /* AttrSpread */)
-        hasDynamicAttrs = true;
+      if (attr.type === 10 /* AttrNamed */) this.#writeAttrNamed(attr);
+      else if (attr.type === 15 /* AttrSpread */) hasDynamicAttrs = true;
     });
     this.#extractor.write(">");
     if (!isVoidTag(node.nameText)) {
       (_b = node.body) == null ? void 0 : _b.forEach((child) => {
-        if (this.#visitNode(child))
-          hasDynamicBody = true;
+        if (this.#visitNode(child)) hasDynamicBody = true;
       });
       this.#extractor.write(`</${node.nameText}>`);
     }
@@ -3530,8 +3502,7 @@ var HTMLExtractor = class {
     }
     const valueString = this.#read(attr.value);
     const valueType = getAttributeValueType(valueString);
-    if (valueType === void 0)
-      return;
+    if (valueType === void 0) return;
     switch (valueType) {
       case 0 /* True */:
         break;