@markjaquith/agency 3.2.14 → 3.3.0

package/src/services/EpicService.test.ts

@@ -1,74 +0,0 @@
-import { afterEach, beforeEach, describe, expect, test } from "bun:test"
-import { mkdir } from "node:fs/promises"
-import { join } from "node:path"
-import { cleanupTempDir, createTempDir, runTestEffect } from "../test-utils"
-import { Effect } from "effect"
-import { EpicService } from "./EpicService"
-
-describe("EpicService", () => {
-	let root: string
-
-	beforeEach(async () => {
-		root = await createTempDir()
-		await Bun.write(join(root, "agency.json"), '{"version":2}\n')
-		await mkdir(join(root, "repos/agency"), { recursive: true })
-	})
-
-	afterEach(async () => {
-		await cleanupTempDir(root)
-	})
-
-	test("creates, lists, and shows epics", async () => {
-		const created = await runTestEffect(
-			EpicService.pipe(
-				Effect.flatMap((service) =>
-					service.create(
-						"workspace-orchestration",
-						"https://example.com/tickets/epic",
-						[{ repo: "agency", ref: "main" }],
-						root,
-					),
-				),
-			),
-		)
-
-		expect(created.content).toContain("ticketUrl:")
-		expect(created.content).toContain("tasks: []")
-		expect(created.content).toContain(
-			"# Workspace Orchestration\n\n## Outcome\n\nDescribe the epic outcome.\n\n## Plan\n\nDescribe the current approach.\n\n## Important Decisions\n\nRecord consequential decisions and their rationale.",
-		)
-
-		const records = await runTestEffect(
-			EpicService.pipe(Effect.flatMap((service) => service.list(root))),
-		)
-		expect(records.map((record) => record.id)).toEqual([
-			"workspace-orchestration",
-		])
-
-		const shown = await runTestEffect(
-			EpicService.pipe(
-				Effect.flatMap((service) =>
-					service.show("workspace-orchestration", root),
-				),
-			),
-		)
-		expect(shown.path).toBe(join(root, "epics/workspace-orchestration/EPIC.md"))
-	})
-
-	test("rejects unknown repository aliases", async () => {
-		await expect(
-			runTestEffect(
-				EpicService.pipe(
-					Effect.flatMap((service) =>
-						service.create(
-							"example",
-							"https://example.com/tickets/epic",
-							[{ repo: "missing", ref: "main" }],
-							root,
-						),
-					),
-				),
-			),
-		).rejects.toThrow("Unknown repository alias 'missing'")
-	})
-})

package/src/services/FileSystemService.test.ts

@@ -1,81 +0,0 @@
-import { afterEach, describe, expect, test } from "bun:test"
-import { Effect } from "effect"
-import { mkdir } from "node:fs/promises"
-import { join } from "node:path"
-import { cleanupTempDir, createTempDir } from "../test-utils"
-import { FileSystemService } from "./FileSystemService"
-
-const runFileSystem = <A, E>(effect: Effect.Effect<A, E, FileSystemService>) =>
-	Effect.runPromise(effect.pipe(Effect.provide(FileSystemService.Default)))
-
-describe("FileSystemService", () => {
-	const roots: string[] = []
-
-	afterEach(async () => {
-		await Promise.all(roots.splice(0).map(cleanupTempDir))
-	})
-
-	test("distinguishes missing files from other read failures", async () => {
-		const root = await createTempDir()
-		roots.push(root)
-		const directory = join(root, "document")
-		await mkdir(directory)
-
-		const missing = await runFileSystem(
-			FileSystemService.pipe(
-				Effect.flatMap((service) => service.readFile(join(root, "missing"))),
-				Effect.either,
-			),
-		)
-		expect(missing).toMatchObject({
-			_tag: "Left",
-			left: { _tag: "FileNotFoundError" },
-		})
-
-		const unreadable = await runFileSystem(
-			FileSystemService.pipe(
-				Effect.flatMap((service) => service.readFile(directory)),
-				Effect.either,
-			),
-		)
-		expect(unreadable).toMatchObject({
-			_tag: "Left",
-			left: {
-				_tag: "FileSystemError",
-				message: `Failed to read file: ${directory}`,
-			},
-		})
-	})
-
-	test("only treats a missing symlink path as absent", async () => {
-		const root = await createTempDir()
-		roots.push(root)
-		const regularFile = join(root, "regular")
-		await Bun.write(regularFile, "content")
-
-		await expect(
-			runFileSystem(
-				FileSystemService.pipe(
-					Effect.flatMap((service) =>
-						service.readSymlinkTarget(join(root, "missing")),
-					),
-				),
-			),
-		).resolves.toBeNull()
-		const unreadable = await runFileSystem(
-			FileSystemService.pipe(
-				Effect.flatMap((service) =>
-					service.readSymlinkTarget(join(regularFile, "child")),
-				),
-				Effect.either,
-			),
-		)
-		expect(unreadable).toMatchObject({
-			_tag: "Left",
-			left: {
-				_tag: "FileSystemError",
-				message: `Failed to read symlink target: ${join(regularFile, "child")}`,
-			},
-		})
-	})
-})

package/src/services/GraphMutationService.test.ts

@@ -1,486 +0,0 @@
-import { afterEach, beforeEach, describe, expect, test } from "bun:test"
-import { mkdir } from "node:fs/promises"
-import { join } from "node:path"
-import { Effect } from "effect"
-import { cleanupTempDir, createTempDir, runTestEffect } from "../test-utils"
-import { EpicService } from "./EpicService"
-import { GraphMutationService } from "./GraphMutationService"
-import { PhaseService } from "./PhaseService"
-import { TaskService } from "./TaskService"
-import {
-	formatMarkdownDocument,
-	parseFrontmatter,
-} from "../workbase/frontmatter"
-
-describe("GraphMutationService", () => {
-	let root: string
-
-	beforeEach(async () => {
-		root = await createTempDir()
-		await Bun.write(join(root, "agency.json"), '{"version":2}\n')
-		await mkdir(join(root, "repos/agency"), { recursive: true })
-		await mkdir(join(root, "repos/docs"), { recursive: true })
-		await runTestEffect(
-			Effect.gen(function* () {
-				const epics = yield* EpicService
-				const tasks = yield* TaskService
-				const phases = yield* PhaseService
-				yield* epics.create(
-					"first-epic",
-					"https://example.com/first",
-					[{ repo: "agency", ref: "main" }],
-					root,
-				)
-				yield* epics.create(
-					"second-epic",
-					"https://example.com/second",
-					[{ repo: "agency", ref: "main" }],
-					root,
-				)
-				for (const id of ["alpha", "beta", "gamma"]) {
-					yield* tasks.create(
-						{
-							id,
-							ticketUrl: null,
-							epic: "first-epic",
-							repo: "agency",
-							branch: `task/${id}`,
-							base: "main",
-						},
-						root,
-					)
-				}
-				yield* tasks.create(
-					{
-						id: "multi",
-						ticketUrl: "https://example.com/multi",
-						multiPhase: true,
-					},
-					root,
-				)
-				yield* phases.create(
-					{
-						taskId: "multi",
-						id: "build",
-						repo: "agency",
-						branch: "task/multi-build",
-						base: "main",
-					},
-					root,
-				)
-				yield* phases.create(
-					{
-						taskId: "multi",
-						id: "ship",
-						repo: "agency",
-						branch: "task/multi-ship",
-						base: "main",
-					},
-					root,
-				)
-			}),
-		)
-	})
-
-	afterEach(async () => cleanupTempDir(root))
-
-	test("updates descriptions, tickets, repositories, and execution metadata", async () => {
-		const output = await runTestEffect(
-			Effect.gen(function* () {
-				const mutations = yield* GraphMutationService
-				yield* mutations.updateEpic(
-					"first-epic",
-					{
-						description: "Updated epic",
-						ticketUrl: "https://example.com/revised",
-						repos: [{ repo: "docs", ref: "trunk" }],
-					},
-					root,
-				)
-				yield* mutations.updateTask(
-					"alpha",
-					{
-						description: "Updated task",
-						ticketUrl: "https://example.com/alpha",
-						repos: [{ repo: "docs", ref: "main" }],
-						branch: "feature/alpha",
-						base: "develop",
-						pr: "https://github.com/example/agency/pull/12",
-					},
-					root,
-				)
-				return yield* mutations.updatePhase(
-					"multi",
-					"build",
-					{
-						description: "Updated phase",
-						repo: "docs",
-						branch: "feature/build",
-						base: "develop",
-					},
-					root,
-				)
-			}),
-		)
-
-		expect(output).toMatchObject({
-			operation: "phase.update",
-			changed: true,
-			validation: { valid: true },
-		})
-		await runTestEffect(
-			Effect.gen(function* () {
-				const epics = yield* EpicService
-				const tasks = yield* TaskService
-				const phases = yield* PhaseService
-				expect((yield* epics.show("first-epic", root)).data).toMatchObject({
-					description: "Updated epic",
-					ticketUrl: "https://example.com/revised",
-					repos: [{ repo: "docs", ref: "trunk" }],
-				})
-				expect((yield* tasks.show("alpha", root)).data).toMatchObject({
-					description: "Updated task",
-					ticketUrl: "https://example.com/alpha",
-					repos: [{ repo: "docs", ref: "main" }],
-					branch: "feature/alpha",
-					base: "develop",
-					pr: "https://github.com/example/agency/pull/12",
-				})
-				expect((yield* phases.show("multi", "build", root)).data).toMatchObject(
-					{
-						description: "Updated phase",
-						repo: "docs",
-						branch: "feature/build",
-						base: "develop",
-					},
-				)
-			}),
-		)
-	})
-
-	test("sets and clears pull request metadata with materialized code", async () => {
-		await mkdir(join(root, "tasks/alpha/code/agency"), { recursive: true })
-		await mkdir(join(root, "tasks/multi/phases/build/code/agency"), {
-			recursive: true,
-		})
-		const taskPr = "https://github.com/example/agency/pull/12"
-		const phasePr = "https://github.com/example/agency/pull/13"
-
-		await runTestEffect(
-			Effect.gen(function* () {
-				const mutations = yield* GraphMutationService
-				yield* mutations.updateTask("alpha", { pr: taskPr }, root)
-				yield* mutations.updatePhase("multi", "build", { pr: phasePr }, root)
-				const tasks = yield* TaskService
-				const phases = yield* PhaseService
-				expect((yield* tasks.show("alpha", root)).data).toMatchObject({
-					pr: taskPr,
-				})
-				expect((yield* phases.show("multi", "build", root)).data.pr).toBe(
-					phasePr,
-				)
-
-				yield* mutations.updateTask("alpha", { pr: null }, root)
-				yield* mutations.updatePhase("multi", "build", { pr: null }, root)
-				expect((yield* tasks.show("alpha", root)).data).toMatchObject({
-					pr: null,
-				})
-				expect((yield* phases.show("multi", "build", root)).data.pr).toBeNull()
-			}),
-		)
-	})
-
-	test("rejects checkout topology updates with materialized code", async () => {
-		await mkdir(join(root, "tasks/alpha/code/agency"), { recursive: true })
-		await mkdir(join(root, "tasks/multi/phases/build/code/agency"), {
-			recursive: true,
-		})
-		const topologyUpdates = [
-			{ repo: "docs" },
-			{ repos: [{ repo: "docs", ref: "main" }] },
-			{ branch: "feature/materialized" },
-			{ base: "develop" },
-		]
-
-		for (const updates of topologyUpdates) {
-			await expect(
-				runTestEffect(
-					Effect.gen(function* () {
-						return yield* (yield* GraphMutationService).updateTask(
-							"alpha",
-							updates,
-							root,
-						)
-					}),
-				),
-			).rejects.toThrow("materialized code")
-			await expect(
-				runTestEffect(
-					Effect.gen(function* () {
-						return yield* (yield* GraphMutationService).updatePhase(
-							"multi",
-							"build",
-							updates,
-							root,
-						)
-					}),
-				),
-			).rejects.toThrow("materialized code")
-		}
-	})
-
-	test("preserves dependency order and rejects cycles", async () => {
-		await runTestEffect(
-			Effect.gen(function* () {
-				const mutations = yield* GraphMutationService
-				yield* mutations.mutateTaskDependency("add", "beta", "alpha", root)
-				yield* mutations.mutateTaskDependency("add", "beta", "gamma", root)
-				yield* mutations.mutateTaskDependency("remove", "beta", "alpha", root)
-				yield* mutations.mutatePhaseDependency(
-					"add",
-					"multi",
-					"ship",
-					"build",
-					root,
-				)
-			}),
-		)
-		await expect(
-			runTestEffect(
-				Effect.gen(function* () {
-					return yield* (yield* GraphMutationService).mutateTaskDependency(
-						"add",
-						"gamma",
-						"beta",
-						root,
-					)
-				}),
-			),
-		).rejects.toThrow("dependency cycle")
-
-		await expect(
-			runTestEffect(
-				Effect.gen(function* () {
-					return yield* (yield* GraphMutationService).mutateTaskDependency(
-						"add",
-						"beta",
-						"gamma",
-						root,
-					)
-				}),
-			),
-		).rejects.toThrow("already depends")
-
-		await runTestEffect(
-			Effect.gen(function* () {
-				const epics = yield* EpicService
-				const tasks = yield* TaskService
-				const declarations = (yield* epics.show("first-epic", root)).data.tasks
-				expect(
-					declarations.find((item) => item.id === "beta")?.dependsOn,
-				).toEqual(["gamma"])
-				expect((yield* tasks.show("multi", root)).data).toMatchObject({
-					phases: [{ id: "build" }, { id: "ship", dependsOn: ["build"] }],
-				})
-			}),
-		)
-	})
-
-	test("renames entities and rewrites every structured reference", async () => {
-		await runTestEffect(
-			Effect.gen(function* () {
-				const mutations = yield* GraphMutationService
-				yield* mutations.mutateTaskDependency("add", "beta", "alpha", root)
-				yield* mutations.mutatePhaseDependency(
-					"add",
-					"multi",
-					"ship",
-					"build",
-					root,
-				)
-				yield* mutations.renameTask("alpha", "renamed-alpha", root)
-				yield* mutations.renamePhase("multi", "build", "compile", root)
-				yield* mutations.renameEpic("first-epic", "renamed-epic", root)
-			}),
-		)
-
-		await runTestEffect(
-			Effect.gen(function* () {
-				const epics = yield* EpicService
-				const tasks = yield* TaskService
-				const phases = yield* PhaseService
-				const epic = yield* epics.show("renamed-epic", root)
-				expect(
-					epic.data.tasks.find((item) => item.id === "beta")?.dependsOn,
-				).toEqual(["renamed-alpha"])
-				expect((yield* tasks.show("renamed-alpha", root)).data.epic).toBe(
-					"renamed-epic",
-				)
-				expect((yield* tasks.show("multi", root)).data).toMatchObject({
-					phases: [{ id: "compile" }, { id: "ship", dependsOn: ["compile"] }],
-				})
-				expect((yield* phases.show("multi", "compile", root)).id).toBe(
-					"compile",
-				)
-			}),
-		)
-	})
-
-	test("preserves historical handoff provenance across source and destination renames", async () => {
-		await runTestEffect(
-			Effect.gen(function* () {
-				const tasks = yield* TaskService
-				yield* tasks.create(
-					{
-						id: "investigation",
-						ticketUrl: null,
-						repo: "agency",
-						branch: "task/investigation",
-						base: "main",
-						purpose: "investigation",
-					},
-					root,
-				)
-				yield* tasks.handoff(
-					{
-						sourceTaskId: "investigation",
-						id: "implementation",
-						ticketUrl: null,
-						repo: "docs",
-						branch: "task/implementation",
-						base: "main",
-					},
-					root,
-				)
-				const before = yield* tasks.show("implementation", root)
-				const mutations = yield* GraphMutationService
-				yield* mutations.renameTask(
-					"investigation",
-					"investigation-renamed",
-					root,
-				)
-				yield* mutations.renameTask(
-					"implementation",
-					"implementation-renamed",
-					root,
-				)
-				const after = yield* tasks.show("implementation-renamed", root)
-				expect(after.data.handoff).toEqual(before.data.handoff)
-				expect(after.data.handoff?.source).toEqual({
-					kind: "task",
-					taskId: "investigation",
-				})
-			}),
-		)
-	})
-
-	test("moves task membership in both directions", async () => {
-		await runTestEffect(
-			Effect.gen(function* () {
-				yield* (yield* GraphMutationService).moveTask(
-					"alpha",
-					"second-epic",
-					root,
-				)
-				const epics = yield* EpicService
-				const tasks = yield* TaskService
-				expect(
-					(yield* epics.show("first-epic", root)).data.tasks.map(
-						(item) => item.id,
-					),
-				).not.toContain("alpha")
-				expect(
-					(yield* epics.show("second-epic", root)).data.tasks.map(
-						(item) => item.id,
-					),
-				).toEqual(["alpha"])
-				expect((yield* tasks.show("alpha", root)).data.epic).toBe("second-epic")
-			}),
-		)
-	})
-
-	test("rejects stale guarded moves before changing any document", async () => {
-		const paths = [
-			join(root, "tasks/alpha/TASK.md"),
-			join(root, "epics/first-epic/EPIC.md"),
-			join(root, "epics/second-epic/EPIC.md"),
-		]
-		const before = await Promise.all(paths.map((path) => Bun.file(path).text()))
-		let conflict: unknown
-		try {
-			await runTestEffect(
-				Effect.gen(function* () {
-					return yield* (yield* GraphMutationService).moveTask(
-						"alpha",
-						"second-epic",
-						root,
-						"0".repeat(64),
-					)
-				}),
-			)
-		} catch (error) {
-			conflict = error
-		}
-
-		expect(String(conflict)).toContain(
-			"Revision conflict for tasks/alpha/TASK.md",
-		)
-		expect(
-			await Promise.all(paths.map((path) => Bun.file(path).text())),
-		).toEqual(before)
-	})
-
-	test("refuses a rename that would invalidate a materialized worktree", async () => {
-		await mkdir(join(root, "tasks/alpha/code/agency"), { recursive: true })
-		await expect(
-			runTestEffect(
-				Effect.gen(function* () {
-					return yield* (yield* GraphMutationService).renameTask(
-						"alpha",
-						"renamed-alpha",
-						root,
-					)
-				}),
-			),
-		).rejects.toThrow("materialized worktree")
-		expect(await Bun.file(join(root, "tasks/alpha/TASK.md")).exists()).toBe(
-			true,
-		)
-		expect(
-			await Bun.file(join(root, "tasks/renamed-alpha/TASK.md")).exists(),
-		).toBe(false)
-	})
-
-	test("refuses rename when the parent backlink is inconsistent", async () => {
-		await runTestEffect(
-			Effect.gen(function* () {
-				const epic = yield* (yield* EpicService).show("first-epic", root)
-				const parsed = yield* parseFrontmatter(epic.content, epic.path)
-				yield* Effect.promise(() =>
-					Bun.write(
-						epic.path,
-						formatMarkdownDocument(
-							{
-								...epic.data,
-								tasks: epic.data.tasks.filter((item) => item.id !== "alpha"),
-							},
-							parsed.body,
-						),
-					),
-				)
-			}),
-		)
-
-		await expect(
-			runTestEffect(
-				Effect.gen(function* () {
-					return yield* (yield* GraphMutationService).renameTask(
-						"alpha",
-						"renamed-alpha",
-						root,
-					)
-				}),
-			),
-		).rejects.toThrow("parent epic 'first-epic' does not list it")
-	})
-})