@markjaquith/agency 2.71.21 → 2.71.23

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@markjaquith/agency",
-  "version": "2.71.21",
+  "version": "2.71.23",
   "description": "Manage agentic work across repositories with durable workbases",
   "keywords": [
     "agents",
@@ -83,10 +83,12 @@
     "benchmark:graph": "bun scripts/benchmark-graph.ts",
     "benchmark:push": "bun scripts/benchmark-push.ts",
     "benchmark:archive": "bun scripts/benchmark-archive.ts",
+    "benchmark:vcs": "bun scripts/benchmark-vcs.ts",
     "benchmark:sync": "bun scripts/benchmark-sync.ts",
     "benchmark:task": "bun scripts/benchmark-task.ts",
     "benchmark:validate": "bun scripts/benchmark-validate.ts",
     "benchmark:worktree": "bun scripts/benchmark-worktree.ts",
+    "benchmark:review": "bun scripts/benchmark-review.ts",
     "test": "find src \\( -name '*.test.ts' -o -name '*.test.tsx' \\) -print0 | xargs -0 -n 1 -P 4 bun test",
     "test:opencode": "AGENCY_TEST_OPENCODE=1 bun test src/cli.test.ts --test-name-pattern 'provides effective whole-workbase OpenCode access'",
     "format": "oxfmt",

package/src/services/ReviewService.ts

@@ -23,7 +23,10 @@ import {
 	runLifecycleTransaction,
 	type TransactionStep,
 } from "./LifecycleTransaction"
-import { RevisionConflictError } from "../workbase/document-revision"
+import {
+	documentRevision,
+	RevisionConflictError,
+} from "../workbase/document-revision"
 import {
 	formatMarkdownDocument,
 	parseFrontmatter,
@@ -359,24 +362,33 @@ export class ReviewService extends Effect.Service<ReviewService>()(
 									message: `Cannot refresh review task '${taskId}'; its checkout is dirty or structurally unexpected`,
 								})
 							}
-							const latest = yield* service.resolve(
+							const repository = yield* repositories.show(
 								task.data.review.repo,
-								task.data.review.source.kind === "pull-request"
-									? { pullRequest: task.data.review.source.url }
-									: { ref: task.data.review.source.ref },
 								root,
 							)
+							if (!repository.remote || repository.states.includes("missing")) {
+								return yield* new ReviewError({
+									message: `Repository alias '${task.data.review.repo}' must be materialized with an origin remote`,
+								})
+							}
+							const versionControl = yield* VersionControlService
+							const backend = yield* versionControl.forWorkbase(root)
+							const latest = {
+								...task.data.review,
+								commit: yield* fetchCommit(
+									repository.path,
+									task.data.review.source.kind === "pull-request"
+										? task.data.review.source.fetchRef
+										: task.data.review.source.ref,
+									backend,
+								),
+								refreshedAt: new Date().toISOString(),
+							} satisfies ReviewRecord
 							const parsed = yield* parseFrontmatter(task.content, task.path)
 							const content = formatMarkdownDocument(
 								{ ...task.data, review: latest },
 								parsed.body,
 							)
-							const repository = yield* repositories.show(
-								task.data.review.repo,
-								root,
-							)
-							const versionControl = yield* VersionControlService
-							const backend = yield* versionControl.forWorkbase(root)
 							const gitEnvironment = yield* backend.gitEnvironment(
 								repository.path,
 							)
@@ -456,7 +468,7 @@ export class ReviewService extends Effect.Service<ReviewService>()(
 								commit: latest.commit,
 								changed: latest.commit !== task.data.review.commit,
 								refreshedAt: latest.refreshedAt,
-								revision: (yield* tasks.show(taskId, root)).revision,
+								revision: documentRevision(content),
 							}
 						}),
 					)

package/src/services/TaskService.ts

@@ -594,12 +594,13 @@ export class TaskService extends Effect.Service<TaskService>()("TaskService", {
 				}
 				const content = yield* fs.readFile(path)
 				const parsed = yield* parseFrontmatter(content, path)
+				const data: TaskData = yield* decodeTask(parsed.data)
 				return {
 					id: validId,
 					path,
 					content,
 					revision: documentRevision(content),
-					data: yield* decodeTask(parsed.data),
+					data,
 				} satisfies TaskRecord
 			}),
 

package/src/services/VcsMigrationService.ts

@@ -263,15 +263,24 @@ const inspectMigration = (startPath: string, requestedTarget?: VcsKind) =>
 		const repositoryRecords = yield* repositories.list(root)
 		const repositoryPlans: RepositoryPlan[] = []
 		const repositoryStatus: MigrationState["repositories"][number][] = []
-		for (const repository of repositoryRecords) {
-			const initialized = yield* fs.exists(
-				join(
-					repository.kind === "symlink"
-						? yield* fs.realPath(repository.path)
-						: repository.path,
-					".jj",
-				),
-			)
+		const repositoryInspections = yield* Effect.forEach(
+			repositoryRecords,
+			(repository) =>
+				Effect.gen(function* () {
+					const targetPath =
+						repository.kind === "symlink"
+							? yield* fs.realPath(repository.path)
+							: repository.path
+					const initialized = yield* fs.exists(join(targetPath, ".jj"))
+					return { repository, initialized, targetPath }
+				}),
+			{ concurrency: 8 },
+		)
+		for (const {
+			repository,
+			initialized,
+			targetPath,
+		} of repositoryInspections) {
 			repositoryStatus.push({
 				alias: repository.alias,
 				path: repository.path,
@@ -297,10 +306,6 @@ const inspectMigration = (startPath: string, requestedTarget?: VcsKind) =>
 					message: `Repository '${repository.alias}' is not initialized for the configured jj backend`,
 				})
 			}
-			const targetPath =
-				repository.kind === "symlink"
-					? yield* fs.realPath(repository.path)
-					: repository.path
 			repositoryPlans.push({
 				alias: repository.alias,
 				path: repository.path,
@@ -353,6 +358,23 @@ const inspectMigration = (startPath: string, requestedTarget?: VcsKind) =>
 		}
 
 		const workspacePlans: WorkspacePlan[] = []
+		const sourceWorkspaces = new Map<
+			string,
+			Effect.Effect<
+				readonly import("./VersionControlService").RegisteredWorkspace[],
+				unknown,
+				any
+			>
+		>()
+		const listSourceWorkspaces = (repositoryPath: string) => {
+			const existing = sourceWorkspaces.get(repositoryPath)
+			if (existing) return existing
+			const workspaces = sourceBackend
+				.listWorkspaces(repositoryPath)
+				.pipe(Effect.cached, Effect.flatten)
+			sourceWorkspaces.set(repositoryPath, workspaces)
+			return workspaces
+		}
 		const inspected = yield* Effect.either(
 			worktrees.list(root, {
 				materializedOnly: !blockers.some(
@@ -400,7 +422,7 @@ const inspectMigration = (startPath: string, requestedTarget?: VcsKind) =>
 					}
 					const sourceName =
 						source !== target && source === "jj"
-							? ((yield* sourceBackend.listWorkspaces(
+							? ((yield* listSourceWorkspaces(
 									join(root, "repos", checkout.repo),
 								)).find((item) => item.path === checkout.registeredPath)
 									?.name ?? null)