@markjaquith/agency 2.71.21 → 2.71.22

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@markjaquith/agency",
-  "version": "2.71.21",
+  "version": "2.71.22",
   "description": "Manage agentic work across repositories with durable workbases",
   "keywords": [
     "agents",
@@ -87,6 +87,7 @@
     "benchmark:task": "bun scripts/benchmark-task.ts",
     "benchmark:validate": "bun scripts/benchmark-validate.ts",
     "benchmark:worktree": "bun scripts/benchmark-worktree.ts",
+    "benchmark:review": "bun scripts/benchmark-review.ts",
     "test": "find src \\( -name '*.test.ts' -o -name '*.test.tsx' \\) -print0 | xargs -0 -n 1 -P 4 bun test",
     "test:opencode": "AGENCY_TEST_OPENCODE=1 bun test src/cli.test.ts --test-name-pattern 'provides effective whole-workbase OpenCode access'",
     "format": "oxfmt",

package/src/services/ReviewService.ts

@@ -23,7 +23,10 @@ import {
 	runLifecycleTransaction,
 	type TransactionStep,
 } from "./LifecycleTransaction"
-import { RevisionConflictError } from "../workbase/document-revision"
+import {
+	documentRevision,
+	RevisionConflictError,
+} from "../workbase/document-revision"
 import {
 	formatMarkdownDocument,
 	parseFrontmatter,
@@ -359,24 +362,33 @@ export class ReviewService extends Effect.Service<ReviewService>()(
 									message: `Cannot refresh review task '${taskId}'; its checkout is dirty or structurally unexpected`,
 								})
 							}
-							const latest = yield* service.resolve(
+							const repository = yield* repositories.show(
 								task.data.review.repo,
-								task.data.review.source.kind === "pull-request"
-									? { pullRequest: task.data.review.source.url }
-									: { ref: task.data.review.source.ref },
 								root,
 							)
+							if (!repository.remote || repository.states.includes("missing")) {
+								return yield* new ReviewError({
+									message: `Repository alias '${task.data.review.repo}' must be materialized with an origin remote`,
+								})
+							}
+							const versionControl = yield* VersionControlService
+							const backend = yield* versionControl.forWorkbase(root)
+							const latest = {
+								...task.data.review,
+								commit: yield* fetchCommit(
+									repository.path,
+									task.data.review.source.kind === "pull-request"
+										? task.data.review.source.fetchRef
+										: task.data.review.source.ref,
+									backend,
+								),
+								refreshedAt: new Date().toISOString(),
+							} satisfies ReviewRecord
 							const parsed = yield* parseFrontmatter(task.content, task.path)
 							const content = formatMarkdownDocument(
 								{ ...task.data, review: latest },
 								parsed.body,
 							)
-							const repository = yield* repositories.show(
-								task.data.review.repo,
-								root,
-							)
-							const versionControl = yield* VersionControlService
-							const backend = yield* versionControl.forWorkbase(root)
 							const gitEnvironment = yield* backend.gitEnvironment(
 								repository.path,
 							)
@@ -456,7 +468,7 @@ export class ReviewService extends Effect.Service<ReviewService>()(
 								commit: latest.commit,
 								changed: latest.commit !== task.data.review.commit,
 								refreshedAt: latest.refreshedAt,
-								revision: (yield* tasks.show(taskId, root)).revision,
+								revision: documentRevision(content),
 							}
 						}),
 					)

package/src/services/TaskService.ts

@@ -594,12 +594,13 @@ export class TaskService extends Effect.Service<TaskService>()("TaskService", {
 				}
 				const content = yield* fs.readFile(path)
 				const parsed = yield* parseFrontmatter(content, path)
+				const data: TaskData = yield* decodeTask(parsed.data)
 				return {
 					id: validId,
 					path,
 					content,
 					revision: documentRevision(content),
-					data: yield* decodeTask(parsed.data),
+					data,
 				} satisfies TaskRecord
 			}),