@markjaquith/agency 2.10.0 → 2.12.0

package/src/services/PhaseService.ts

@@ -15,6 +15,7 @@ import {
 	formatMarkdownDocument,
 	parseFrontmatter,
 } from "../workbase/frontmatter"
+import { canTransitionStatus } from "../readiness"
 
 class PhaseError extends Data.TaggedError("PhaseError")<{
 	readonly message: string
@@ -340,6 +341,11 @@ export class PhaseService extends Effect.Service<PhaseService>()(
 					const service = yield* PhaseService
 					const validStatus = yield* decodeStatus(status)
 					const record = yield* service.show(taskId, id, startPath)
+					if (!canTransitionStatus(record.data.status, validStatus)) {
+						return yield* new PhaseError({
+							message: `Cannot transition phase '${id}' from ${record.data.status} to ${validStatus}; reopen it first`,
+						})
+					}
 					const parsed = yield* parseFrontmatter(record.content, record.path)
 					const data = { ...record.data, status: validStatus }
 					const content = formatMarkdownDocument(data, parsed.body)

package/src/services/TaskPhaseService.test.ts

@@ -244,6 +244,22 @@ describe("task and phase services", () => {
 		expect(task.data.status).toBe("delegated")
 		expect(task.content).toContain("status: delegated")
 		expect(task.content).toContain("Describe the task outcome.")
+		await runTestEffect(
+			TaskService.pipe(
+				Effect.flatMap((service) =>
+					service.setStatus("single-status", "done", root),
+				),
+			),
+		)
+		await expect(
+			runTestEffect(
+				TaskService.pipe(
+					Effect.flatMap((service) =>
+						service.setStatus("single-status", "dropped", root),
+					),
+				),
+			),
+		).rejects.toThrow("reopen it first")
 
 		await runTestEffect(
 			TaskService.pipe(
@@ -283,6 +299,33 @@ describe("task and phase services", () => {
 			),
 		)
 		expect(phase.data.status).toBe("dropped")
+		await expect(
+			runTestEffect(
+				PhaseService.pipe(
+					Effect.flatMap((service) =>
+						service.setStatus("multi-status", "implementation", "done", root),
+					),
+				),
+			),
+		).rejects.toThrow("reopen it first")
+		await runTestEffect(
+			PhaseService.pipe(
+				Effect.flatMap((service) =>
+					service.setStatus("multi-status", "implementation", "open", root),
+				),
+			),
+		)
+		expect(
+			(
+				await runTestEffect(
+					PhaseService.pipe(
+						Effect.flatMap((service) =>
+							service.setStatus("multi-status", "implementation", "done", root),
+						),
+					),
+				)
+			).data.status,
+		).toBe("done")
 		await expect(
 			runTestEffect(
 				TaskService.pipe(

package/src/services/TaskService.ts

@@ -15,6 +15,7 @@ import {
 	formatMarkdownDocument,
 	parseFrontmatter,
 } from "../workbase/frontmatter"
+import { canTransitionStatus } from "../readiness"
 
 class TaskError extends Data.TaggedError("TaskError")<{
 	readonly message: string
@@ -212,6 +213,11 @@ export class TaskService extends Effect.Service<TaskService>()("TaskService", {
 						message: `Task '${id}' has multiple phases; set status on a phase instead`,
 					})
 				}
+				if (!canTransitionStatus(record.data.status, validStatus)) {
+					return yield* new TaskError({
+						message: `Cannot transition task '${id}' from ${record.data.status} to ${validStatus}; reopen it first`,
+					})
+				}
 				const parsed = yield* parseFrontmatter(record.content, record.path)
 				const data = { ...record.data, status: validStatus }
 				const content = formatMarkdownDocument(data, parsed.body)

package/src/test-utils.ts

@@ -14,6 +14,7 @@ import { PullRequestService } from "./services/PullRequestService"
 import { ArchiveService } from "./services/ArchiveService"
 import { IntegrationService } from "./services/IntegrationService"
 import { ContextService } from "./services/ContextService"
+import { GraphService } from "./services/GraphService"
 
 export const createTempDir = () => mkdtemp(join(tmpdir(), "agency-test-"))
 
@@ -32,6 +33,7 @@ const TestLayer = Layer.mergeAll(
 	ArchiveService.Default,
 	IntegrationService.Default,
 	ContextService.Default,
+	GraphService.Default,
 )
 
 export async function runTestEffect<A, E>(