@marimo-team/islands 0.25.3-dev275 → 0.25.3-dev279

package/src/core/cells/__tests__/__snapshots__/cells.test.ts.snap

@@ -11,13 +11,10 @@ exports[`cell reducer > can initialize stdin > initial state 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": null,
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -32,13 +29,10 @@ exports[`cell reducer > can initialize stdin > prepared for run 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -53,13 +47,10 @@ exports[`cell reducer > can initialize stdin > queued message received 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -74,13 +65,10 @@ exports[`cell reducer > can initialize stdin > running message received 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -117,14 +105,11 @@ exports[`cell reducer > can initialize stdin > second stdin requested 1`] = `
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
   "interrupted": false,
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -154,14 +139,11 @@ exports[`cell reducer > can initialize stdin > stdin answered 1`] = `
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
   "interrupted": false,
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -190,13 +172,10 @@ exports[`cell reducer > can initialize stdin > stdin requested 1`] = `
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -218,13 +197,10 @@ exports[`cell reducer > can initialize stdin > stdout received 1`] = `
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -246,13 +222,10 @@ exports[`cell reducer > can initialize stdin > stdout verified 1`] = `
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -267,13 +240,10 @@ exports[`cell reducer > can receive console when the cell is idle and will clear
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -295,13 +265,10 @@ exports[`cell reducer > can receive console when the cell is idle and will clear
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -316,13 +283,10 @@ exports[`cell reducer > can receive console when the cell is idle and will clear
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": null,
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -344,13 +308,10 @@ exports[`cell reducer > can receive console when the cell is idle and will clear
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -372,13 +333,10 @@ exports[`cell reducer > can receive console when the cell is idle and will clear
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -393,13 +351,10 @@ exports[`cell reducer > can run a stale cell > queued message received 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "1",
-  "lastCodeRun": "mo.slider()",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -414,13 +369,10 @@ exports[`cell reducer > can run a stale cell > stale inputs received 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "1",
-  "lastCodeRun": "mo.slider()",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": true,
 }
 `;
 
@@ -435,9 +387,7 @@ exports[`cell reducer > can run a stopped cell > ancestor stopped 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "mo.md('This has an ancestor that was stopped')",
   "name": "_",
   "outline": null,
   "output": {
@@ -452,7 +402,6 @@ exports[`cell reducer > can run a stopped cell > ancestor stopped 1`] = `
     "mimetype": "application/vnd.marimo+error",
     "timestamp": 20,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -467,13 +416,10 @@ exports[`cell reducer > can run a stopped cell > idle message received 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "mo.md('This has an ancestor that was stopped')",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -488,9 +434,7 @@ exports[`cell reducer > can run a stopped cell > queued after stop 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "mo.md('This has an ancestor that was stopped')",
   "name": "_",
   "outline": null,
   "output": {
@@ -505,7 +449,6 @@ exports[`cell reducer > can run a stopped cell > queued after stop 1`] = `
     "mimetype": "application/vnd.marimo+error",
     "timestamp": 20,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -520,13 +463,10 @@ exports[`cell reducer > can run a stopped cell > queued message received 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "mo.md('This has an ancestor that was stopped')",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -541,13 +481,10 @@ exports[`cell reducer > can run a stopped cell > running after stop 1`] = `
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "mo.md('This has an ancestor that was stopped')",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -570,9 +507,7 @@ import numpy",
     },
   ],
   "debuggerActive": false,
-  "edited": true,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": {
@@ -581,7 +516,6 @@ import numpy",
     "mimetype": "text/plain",
     "timestamp": 0,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -596,13 +530,10 @@ exports[`cell reducer > can run cell and receive cell messages > code edited 1`]
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": true,
   "id": "0",
-  "lastCodeRun": null,
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -625,9 +556,7 @@ import numpy",
     },
   ],
   "debuggerActive": false,
-  "edited": true,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": {
@@ -636,7 +565,6 @@ import numpy",
     "mimetype": "text/plain",
     "timestamp": 0,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -658,9 +586,7 @@ exports[`cell reducer > can run cell and receive cell messages > code reverted 1
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": {
@@ -669,7 +595,6 @@ exports[`cell reducer > can run cell and receive cell messages > code reverted 1
     "mimetype": "text/plain",
     "timestamp": 0,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -691,13 +616,10 @@ exports[`cell reducer > can run cell and receive cell messages > console message
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -720,10 +642,7 @@ import numpy",
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo
-import numpy",
   "name": "_",
   "outline": null,
   "output": {
@@ -738,7 +657,6 @@ import numpy",
     "mimetype": "application/vnd.marimo+error",
     "timestamp": 0,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -753,13 +671,10 @@ exports[`cell reducer > can run cell and receive cell messages > initial state 1
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": null,
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -782,10 +697,7 @@ import numpy",
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo
-import numpy",
   "name": "_",
   "outline": null,
   "output": {
@@ -798,7 +710,6 @@ import numpy",
     "mimetype": "application/vnd.marimo+error",
     "timestamp": 0,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -820,9 +731,7 @@ exports[`cell reducer > can run cell and receive cell messages > output received
     },
   ],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": {
@@ -831,7 +740,6 @@ exports[`cell reducer > can run cell and receive cell messages > output received
     "mimetype": "text/plain",
     "timestamp": 0,
   },
-  "staleInputs": false,
 }
 `;
 
@@ -846,13 +754,10 @@ exports[`cell reducer > can run cell and receive cell messages > prepared for ru
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -867,13 +772,10 @@ exports[`cell reducer > can run cell and receive cell messages > queued message
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;
 
@@ -888,12 +790,9 @@ exports[`cell reducer > can run cell and receive cell messages > running message
   },
   "consoleOutputs": [],
   "debuggerActive": false,
-  "edited": false,
   "id": "0",
-  "lastCodeRun": "import marimo as mo",
   "name": "_",
   "outline": null,
   "output": null,
-  "staleInputs": false,
 }
 `;

package/src/core/cells/__tests__/actions.test.ts

@@ -384,7 +384,6 @@ describe("undoDeleteCellAtom", () => {
     expect(store.get(restoredEditorStatesAtom).get(c2)).toMatchObject({
       doc: "y = 2",
     });
-    expect(notebook().cellData[c2].edited).toBe(true);
     expect(notebook().scrollKey).toBe(c2);
     expect(notebook().history).toEqual([]);
   });

package/src/core/cells/__tests__/cell.test.ts

@@ -1,15 +1,29 @@
 /* Copyright 2026 Marimo. All rights reserved. */
 import { describe, expect, it } from "vitest";
-import type { CellExecutionView, CellRunStatus } from "@/core/executions";
+import type {
+  CellExecutionView,
+  CellFreshness,
+  CellRunStatus,
+} from "@/core/executions";
 import type { CellMessage, OutputMessage } from "@/core/kernel/messages";
 import type { Milliseconds, Seconds } from "@/utils/time";
-import { outputIsLoading, outputIsStale, transitionCell } from "../cell";
+import {
+  consoleOutputIsStale,
+  outputIsLoading,
+  outputIsStale,
+  transitionCell,
+} from "../cell";
 import { createCellRuntimeState } from "../types";
 
 const STATUSES: CellRunStatus[] = ["queued", "running", "idle"];
 
 const NOW = Date.now() as Milliseconds;
 
+const CURRENT: CellFreshness = { sourceChanged: false, inputsChanged: false };
+const EDITED: CellFreshness = { sourceChanged: true, inputsChanged: false };
+const REPLACED: CellFreshness = { sourceChanged: false, inputsChanged: true };
+const BOTH: CellFreshness = { sourceChanged: true, inputsChanged: true };
+
 type View = Pick<
   CellExecutionView,
   "status" | "outcome" | "startedAt" | "rendered"
@@ -43,54 +57,104 @@ describe("outputIsStale", () => {
   it.each(STATUSES)(
     "should return true if the cell is edited and status is %s",
     (status) => {
-      expect(outputIsStale(view({ status }), true, true)).toBe(true);
+      expect(outputIsStale(view({ status }), EDITED, true)).toBe(true);
     },
   );
 
   it("should return true if the cell is loading", () => {
-    expect(outputIsStale(view({ status: "running" }), false, false)).toBe(true);
+    expect(outputIsStale(view({ status: "running" }), CURRENT, false)).toBe(
+      true,
+    );
   });
 
   it("should return false if the cell is running and has shown output", () => {
     const running = view({ status: "running", rendered: true });
-    expect(outputIsStale(running, false, false)).toBe(false);
+    expect(outputIsStale(running, CURRENT, false)).toBe(false);
   });
 
   it("should return true if the cell has stale inputs", () => {
-    expect(outputIsStale(view({}), true, false)).toBe(true);
+    expect(outputIsStale(view({}), REPLACED, false)).toBe(true);
   });
 
   it("should return false if the cell is interrupted", () => {
-    expect(outputIsStale(view({ outcome: "interrupted" }), false, false)).toBe(
-      false,
-    );
+    expect(
+      outputIsStale(view({ outcome: "interrupted" }), CURRENT, false),
+    ).toBe(false);
   });
 
   it("should return false if the cell is idle and not edited", () => {
-    expect(outputIsStale(view({}), false, false)).toBe(false);
+    expect(outputIsStale(view({}), CURRENT, false)).toBe(false);
+  });
+
+  it("should return true if the source changed while editing", () => {
+    expect(outputIsStale(view({}), EDITED, true)).toBe(true);
+  });
+
+  it("should keep showing the last result of edited source in a read view", () => {
+    expect(outputIsStale(view({}), EDITED, false)).toBe(false);
   });
 
   it("should return true if the cell is queued", () => {
-    expect(outputIsStale(view({ status: "queued" }), false, false)).toBe(true);
+    expect(outputIsStale(view({ status: "queued" }), CURRENT, false)).toBe(
+      true,
+    );
   });
 
   it("should return true if the cell is running but no output is received", () => {
     const running = view({ status: "running", startedAt: NOW });
-    expect(outputIsStale(running, false, false)).toBe(true);
+    expect(outputIsStale(running, CURRENT, false)).toBe(true);
+  });
+
+  it("should return true if the cell is interrupted and edited since", () => {
+    expect(outputIsStale(view({ outcome: "interrupted" }), EDITED, true)).toBe(
+      true,
+    );
+  });
+
+  it("should not dim output the rerun of edited code has already shown", () => {
+    const running = view({ status: "running", rendered: true });
+    expect(outputIsStale(running, EDITED, true)).toBe(false);
+  });
+
+  it("should dim while the rerun of edited code has shown nothing", () => {
+    expect(outputIsStale(view({ status: "running" }), EDITED, true)).toBe(true);
+  });
+
+  it("should still dim for changed inputs in a read view when the source also changed", () => {
+    expect(outputIsStale(view({}), BOTH, false)).toBe(true);
   });
+});
 
-  it("should return false if the cell is interrupted but also edited", () => {
-    // We likely don't get in this state since before a cell is interrupted, it is run and we remove the edited state
-    expect(outputIsStale(view({ outcome: "interrupted" }), false, true)).toBe(
+describe("consoleOutputIsStale", () => {
+  it("is stale while queued, since the run clears the console", () => {
+    expect(consoleOutputIsStale(view({ status: "queued" }), CURRENT)).toBe(
+      true,
+    );
+  });
+
+  it("is not stale while the rerun of edited code is producing it", () => {
+    expect(consoleOutputIsStale(view({ status: "running" }), EDITED)).toBe(
       false,
     );
   });
 
-  it("should return false if the cell is interrupted but has stale inputs", () => {
-    expect(outputIsStale(view({ outcome: "interrupted" }), true, false)).toBe(
+  it("is stale once the settled result is outdated", () => {
+    expect(consoleOutputIsStale(view({}), EDITED)).toBe(true);
+    expect(consoleOutputIsStale(view({}), REPLACED)).toBe(true);
+    expect(consoleOutputIsStale(view({}), CURRENT)).toBe(false);
+  });
+
+  it("is not stale after an interruption", () => {
+    expect(consoleOutputIsStale(view({ outcome: "interrupted" }), EDITED)).toBe(
       false,
     );
   });
+
+  it("should return false if the cell is interrupted but has stale inputs", () => {
+    expect(
+      outputIsStale(view({ outcome: "interrupted" }), REPLACED, false),
+    ).toBe(false);
+  });
 });
 
 describe("transitionCell serialization", () => {