@marimo-team/islands 0.25.1-dev26 → 0.25.1-dev28

package/src/core/codemirror/lsp/notebook-lsp.ts

@@ -42,7 +42,7 @@ class Snapshotter {
     codes: Record<CellId, string>;
   };
 
-  constructor(
+  public constructor(
     getNotebookCode: () => {
       cellIds: CellId[];
       codes: Record<CellId, string>;
@@ -226,7 +226,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
   private latestDiagnosticsVersion: number | null = null;
   private forwardedDiagnosticsVersion = 0;
 
-  constructor(
+  public constructor(
     client: ILanguageServerClient,
     initialSettings: Record<string, unknown>,
     getNotebookEditors: () => Record<
@@ -254,7 +254,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     this.snapshotter = new Snapshotter(this.getNotebookCode.bind(this));
   }
 
-  onNotification(
+  public onNotification(
     listener: (n: {
       jsonrpc: "2.0";
       id?: null | undefined;
@@ -265,44 +265,44 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     return this.client.onNotification(listener);
   }
 
-  get ready(): boolean {
+  public get ready(): boolean {
     return this.client.ready;
   }
 
-  set ready(value: boolean) {
+  public set ready(value: boolean) {
     this.client.ready = value;
   }
 
-  get capabilities(): LSP.ServerCapabilities | null {
+  public get capabilities(): LSP.ServerCapabilities | null {
     return this.client.capabilities;
   }
 
-  set capabilities(value: LSP.ServerCapabilities) {
+  public set capabilities(value: LSP.ServerCapabilities) {
     this.client.capabilities = value;
   }
 
-  get initializePromise(): Promise<void> {
+  public get initializePromise(): Promise<void> {
     return this.client.initializePromise;
   }
 
-  set initializePromise(value: Promise<void>) {
+  public set initializePromise(value: Promise<void>) {
     this.client.initializePromise = value;
   }
 
-  get clientCapabilities() {
+  public get clientCapabilities() {
     return this.client.clientCapabilities;
   }
 
-  async initialize(): Promise<void> {
+  public async initialize(): Promise<void> {
     await this.client.initialize();
   }
 
-  close(): void {
+  public close(): void {
     this.openCellDocumentCounts.clear();
     this.client.close();
   }
 
-  hasCapability(method: string): boolean {
+  public hasCapability(method: string): boolean {
     return this.client.hasCapability(method);
   }
 
@@ -430,7 +430,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
    * This ensures the caller uses the same lens that was sent to the server,
    * avoiding race conditions if cells change between sync and subsequent operations.
    */
-  async sync(): Promise<{
+  public async sync(): Promise<{
     params: LSP.DidChangeTextDocumentParams;
     lens: NotebookLens;
   }> {
@@ -499,7 +499,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     });
   }
 
-  async textDocumentDefinition(
+  public async textDocumentDefinition(
     params: LSP.DefinitionParams,
   ): Promise<LSP.Definition | LSP.LocationLink[] | null> {
     // Get the cell document URI from the params
@@ -525,7 +525,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     });
   }
 
-  async textDocumentSignatureHelp(
+  public async textDocumentSignatureHelp(
     params: LSP.SignatureHelpParams,
   ): Promise<LSP.SignatureHelp | null> {
     const cellDocumentUri = params.textDocument.uri;
@@ -572,7 +572,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
    *
    * See textDocumentRename for a similar workaround that manually applies edits.
    */
-  textDocumentCodeAction(
+  public textDocumentCodeAction(
     params: LSP.CodeActionParams,
   ): Promise<(LSP.Command | LSP.CodeAction)[] | null> {
     const disabledCodeAction = true;
@@ -582,7 +582,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     return this.client.textDocumentCodeAction(params);
   }
 
-  codeActionResolve(action: LSP.CodeAction): Promise<LSP.CodeAction> {
+  public codeActionResolve(action: LSP.CodeAction): Promise<LSP.CodeAction> {
     return Promise.resolve(action);
   }
 
@@ -646,7 +646,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
    * LSP edit application flow. The trade-off is that we lose undo grouping
    * across cells.
    */
-  async textDocumentRename(
+  public async textDocumentRename(
     params: LSP.RenameParams,
   ): Promise<LSP.WorkspaceEdit | null> {
     // Get the cell document URI from the params
@@ -784,7 +784,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     };
   }
 
-  async completionItemResolve(
+  public async completionItemResolve(
     params: LSP.CompletionItem,
   ): Promise<LSP.CompletionItem> {
     // Used cached result to avoid jitter while typing in the same completion item
@@ -801,7 +801,7 @@ export class NotebookLanguageServerClient implements ILanguageServerClient {
     return resolved;
   }
 
-  async textDocumentPrepareRename(
+  public async textDocumentPrepareRename(
     params: LSP.PrepareRenameParams,
   ): Promise<LSP.PrepareRenameResult | null> {
     // Get the cell document URI from the params

package/src/core/codemirror/misc/__tests__/dnd.test.ts

@@ -66,11 +66,11 @@ describe("dnd", () => {
 });
 
 class DragEvent extends Event {
-  dataTransfer: DataTransfer;
-  clientX: number;
-  clientY: number;
+  public dataTransfer: DataTransfer;
+  public clientX: number;
+  public clientY: number;
 
-  constructor(
+  public constructor(
     type: string,
     {
       dataTransfer,
@@ -86,14 +86,14 @@ class DragEvent extends Event {
 }
 
 class DataTransfer {
-  data: Record<string, string> = {};
-  _items: File[] = [];
+  public data: Record<string, string> = {};
+  public _items: File[] = [];
 
-  setData(type: string, data: string) {
+  public setData(type: string, data: string) {
     this.data[type] = data;
   }
 
-  get items() {
+  public get items() {
     return {
       add: (file: File) => {
         this._items.push(file);
@@ -101,11 +101,11 @@ class DataTransfer {
     };
   }
 
-  get files() {
+  public get files() {
     return this._items;
   }
 
-  getData(type: string) {
+  public getData(type: string) {
     return this.data[type];
   }
 }

package/src/core/codemirror/misc/__tests__/paste.test.ts

@@ -320,17 +320,20 @@ def foo():
 // Mock ClipboardEvent and DataTransfer
 class MockDataTransfer {
   private data: Record<string, string> = {};
-  setData(format: string, data: string) {
+  public setData(format: string, data: string) {
     this.data[format] = data;
   }
-  getData(format: string) {
+  public getData(format: string) {
     return this.data[format];
   }
 }
 
 class MockClipboardEvent extends Event {
-  clipboardData: MockDataTransfer;
-  constructor(type: string, init?: { clipboardData?: MockDataTransfer }) {
+  public clipboardData: MockDataTransfer;
+  public constructor(
+    type: string,
+    init?: { clipboardData?: MockDataTransfer },
+  ) {
     super(type);
     this.clipboardData = init?.clipboardData || new MockDataTransfer();
   }

package/src/core/codemirror/reactive-references/extension.ts

@@ -50,7 +50,7 @@ class ReactiveReferencesPlugin {
   // Debounced function to trigger highlighting
   private readonly scheduleHighlighting: DebouncedFunc<() => void>;
 
-  constructor(view: EditorView, cellId: CellId) {
+  public constructor(view: EditorView, cellId: CellId) {
     this.view = view;
     this.cellId = cellId;
 
@@ -67,13 +67,13 @@ class ReactiveReferencesPlugin {
     this.scheduleHighlighting();
   }
 
-  update(update: ViewUpdate) {
+  public update(update: ViewUpdate) {
     if (update.docChanged || update.focusChanged) {
       this.scheduleHighlighting();
     }
   }
 
-  destroy() {
+  public destroy() {
     this.scheduleHighlighting.cancel();
     this.variablesUnsubscribe();
   }

package/src/core/codemirror/rtc/loro/awareness.ts

@@ -208,7 +208,7 @@ export class RemoteCursorMarker implements LayerMarker {
   private name: string;
   private colorClassName: string;
 
-  constructor(
+  public constructor(
     left: number,
     top: number,
     height: number,
@@ -222,18 +222,18 @@ export class RemoteCursorMarker implements LayerMarker {
     this.colorClassName = colorClassName;
   }
 
-  draw(): HTMLElement {
+  public draw(): HTMLElement {
     const elt = document.createElement("div");
     this.adjust(elt);
     return elt;
   }
 
-  update(elt: HTMLElement): boolean {
+  public update(elt: HTMLElement): boolean {
     this.adjust(elt);
     return true;
   }
 
-  adjust(element: HTMLElement) {
+  public adjust(element: HTMLElement) {
     element.style.left = `${this.left}px`;
     element.style.top = `${this.top}px`;
     element.style.height = `${this.height}px`;
@@ -241,7 +241,7 @@ export class RemoteCursorMarker implements LayerMarker {
     element.style.setProperty("--rtc-name", `"${this.name}"`);
   }
 
-  eq(other: RemoteCursorMarker): boolean {
+  public eq(other: RemoteCursorMarker): boolean {
     return (
       this.left === other.left &&
       this.top === other.top &&
@@ -364,7 +364,7 @@ export interface CursorPosition {
 }
 
 export class AwarenessPlugin implements PluginValue {
-  sub: Subscription;
+  public sub: Subscription;
   public view: EditorView;
   public doc: LoroDoc;
   public user: UserState;
@@ -373,7 +373,7 @@ export class AwarenessPlugin implements PluginValue {
   private scopeId: ScopeId;
   private getUserId?: () => Uid;
 
-  constructor(
+  public constructor(
     view: EditorView,
     doc: LoroDoc,
     user: UserState,
@@ -421,7 +421,7 @@ export class AwarenessPlugin implements PluginValue {
     });
   }
 
-  update(update: ViewUpdate): void {
+  public update(update: ViewUpdate): void {
     if (!update.selectionSet && !update.focusChanged && !update.docChanged) {
       return;
     }
@@ -450,7 +450,7 @@ export class AwarenessPlugin implements PluginValue {
     }
   }
 
-  destroy(): void {
+  public destroy(): void {
     this.sub?.();
     this.awareness.setLocalState({
       type: "delete",
@@ -460,13 +460,13 @@ export class AwarenessPlugin implements PluginValue {
   }
 }
 export class RemoteAwarenessPlugin implements PluginValue {
-  _awarenessListener?: AwarenessListener;
+  public _awarenessListener?: AwarenessListener;
   public view: EditorView;
   public doc: LoroDoc;
   public awareness: Awareness<AwarenessState>;
   private scopeId: ScopeId;
 
-  constructor(
+  public constructor(
     view: EditorView,
     doc: LoroDoc,
     awareness: Awareness<AwarenessState>,
@@ -493,7 +493,7 @@ export class RemoteAwarenessPlugin implements PluginValue {
     this.awareness.addListener(listener);
   }
 
-  destroy(): void {
+  public destroy(): void {
     if (this._awarenessListener) {
       this.awareness.removeListener(this._awarenessListener);
     }

package/src/core/codemirror/rtc/loro/sync.ts

@@ -38,14 +38,14 @@ export const loroSyncPlugin = (
 export const loroSyncAnnotation = Annotation.define();
 
 export class LoroSyncPluginValue implements PluginValue {
-  sub?: Subscription;
+  public sub?: Subscription;
   private isInitDispatch = false;
   private view: EditorView;
   private doc: LoroDoc;
   private docPath: string[];
   private getTextFromDoc: (doc: LoroDoc) => LoroText;
 
-  constructor(
+  public constructor(
     view: EditorView,
     doc: LoroDoc,
     docPath: string[],
@@ -77,7 +77,7 @@ export class LoroSyncPluginValue implements PluginValue {
     });
   }
 
-  onRemoteUpdate = (e: LoroEventBatch) => {
+  public onRemoteUpdate = (e: LoroEventBatch) => {
     if (e.by === "local") {
       return;
     }
@@ -133,7 +133,7 @@ export class LoroSyncPluginValue implements PluginValue {
     }
   };
 
-  update(update: ViewUpdate): void {
+  public update(update: ViewUpdate): void {
     if (this.isInitDispatch) {
       this.isInitDispatch = false;
       return;
@@ -161,7 +161,7 @@ export class LoroSyncPluginValue implements PluginValue {
     this.doc.commit();
   }
 
-  destroy(): void {
+  public destroy(): void {
     this.sub?.();
     this.sub = undefined;
   }

package/src/core/codemirror/vim/cursor-visibility.ts

@@ -23,7 +23,7 @@ export class VimCursorVisibilityPlugin implements PluginValue {
   private view: EditorView;
   private abortController = new AbortController();
 
-  constructor(options: VimCursorVisibilityPluginOptions) {
+  public constructor(options: VimCursorVisibilityPluginOptions) {
     this.view = options.view;
     this.view.dom.addEventListener(
       "focus",
@@ -38,7 +38,7 @@ export class VimCursorVisibilityPlugin implements PluginValue {
     this.update();
   }
 
-  update() {
+  public update() {
     const vimCursorLayer = this.view.dom.querySelector(".cm-vimCursorLayer");
     if (vimCursorLayer instanceof HTMLElement) {
       // Hide all vim cursors when in command mode
@@ -52,7 +52,7 @@ export class VimCursorVisibilityPlugin implements PluginValue {
     }
   }
 
-  destroy(): void {
+  public destroy(): void {
     this.abortController.abort();
   }
 }

package/src/core/dom/ui-element.ts

@@ -137,7 +137,7 @@ export function initializeUIElement() {
       this.initialized = true;
     }
 
-    connectedCallback() {
+    public connectedCallback() {
       this.init();
 
       if (this.initialized) {
@@ -157,7 +157,7 @@ export function initializeUIElement() {
       }
     }
 
-    disconnectedCallback() {
+    public disconnectedCallback() {
       if (this.initialized) {
         // Unregister everything
         document.removeEventListener(
@@ -175,7 +175,7 @@ export function initializeUIElement() {
     /**
      * Reset the value of the child element to its initial value.
      */
-    reset() {
+    public reset() {
       const child = this.firstElementChild;
       if (isCustomMarimoElement(child)) {
         child.reset();
@@ -189,11 +189,11 @@ export function initializeUIElement() {
     // We look for changes to the random-id attribute, which is effectively
     // used like a React key. If the random-id changes, we need to unmount and
     // remount its child.
-    static get observedAttributes() {
+    public static get observedAttributes() {
       return [RANDOM_ID_ATTR];
     }
 
-    attributeChangedCallback(
+    public attributeChangedCallback(
       name: string,
       oldValue: string | null,
       newValue: string | null,

package/src/core/dom/uiregistry.ts

@@ -45,12 +45,12 @@ interface UIElementEntry {
  */
 export class UIElementRegistry {
   // maps UIElement objectIds to entries.
-  entries: Map<UIElementId, UIElementEntry>;
+  public entries: Map<UIElementId, UIElementEntry>;
 
   /**
    * Shared instance of UIElementRegistry since this must be a singleton.
    */
-  static get INSTANCE(): UIElementRegistry {
+  public static get INSTANCE(): UIElementRegistry {
     const KEY = "_marimo_private_UIElementRegistry";
     if (!window[KEY]) {
       window[KEY] = new UIElementRegistry();
@@ -62,11 +62,11 @@ export class UIElementRegistry {
     this.entries = new Map();
   }
 
-  has(objectId: UIElementId): boolean {
+  public has(objectId: UIElementId): boolean {
     return this.entries.has(objectId);
   }
 
-  set(objectId: UIElementId, value: ValueType): void {
+  public set(objectId: UIElementId, value: ValueType): void {
     if (this.entries.has(objectId)) {
       Logger.debug(
         "UIElementRegistry overwriting entry for objectId.",
@@ -86,7 +86,7 @@ export class UIElementRegistry {
    * @param objectId - id of the UIElement
    * @param instance - the HTMLElement that the UIElement wraps
    */
-  registerInstance(objectId: UIElementId, instance: HTMLElement) {
+  public registerInstance(objectId: UIElementId, instance: HTMLElement) {
     const entry = this.entries.get(objectId);
     if (entry === undefined) {
       this.entries.set(objectId, {
@@ -109,7 +109,7 @@ export class UIElementRegistry {
    * @param instance - the HTMLElement to remove
    *
    */
-  removeInstance(objectId: UIElementId, instance: HTMLElement) {
+  public removeInstance(objectId: UIElementId, instance: HTMLElement) {
     const entry = this.entries.get(objectId);
     // The UIElement can be removed from the registry before all
     // instances are removed: UIElement removal is triggered
@@ -129,7 +129,7 @@ export class UIElementRegistry {
    *
    * @param cellId - stringified cellId
    */
-  removeElementsByCell(cellId: CellId) {
+  public removeElementsByCell(cellId: CellId) {
     const objectIds = [...this.entries.keys()].filter((objectId) =>
       objectId.startsWith(`${cellId}-`),
     );
@@ -145,12 +145,12 @@ export class UIElementRegistry {
    * @param objectId - id of the UIElement
    * @returns the value for `objectId`, or `undefined` if the object was not found.
    */
-  lookupValue(objectId: UIElementId): ValueType {
+  public lookupValue(objectId: UIElementId): ValueType {
     const entry = this.entries.get(objectId);
     return entry === undefined ? undefined : entry.value;
   }
 
-  broadcastMessage(
+  public broadcastMessage(
     objectId: UIElementId,
     message: unknown,
     buffers: readonly DataView[],
@@ -202,7 +202,7 @@ export class UIElementRegistry {
    * @param objectId - id of the UIElement
    * @param value - value to broadcast
    */
-  broadcastValueUpdate(
+  public broadcastValueUpdate(
     initiator: HTMLElement,
     objectId: UIElementId,
     value: ValueType,

package/src/core/hotkeys/hotkeys.ts

@@ -510,13 +510,13 @@ export class HotkeyProvider implements IHotkeyProvider {
   /**
    * @param platform - See {@link HotkeyProviderOptions.platform}.
    */
-  static create(platform?: Platform): HotkeyProvider {
+  public static create(platform?: Platform): HotkeyProvider {
     return new HotkeyProvider(DEFAULT_HOT_KEY, { platform });
   }
 
   private hotkeys: Record<HotkeyAction, Hotkey>;
 
-  constructor(
+  public constructor(
     hotkeys: Record<HotkeyAction, Hotkey>,
     options: HotkeyProviderOptions = {},
   ) {
@@ -525,11 +525,11 @@ export class HotkeyProvider implements IHotkeyProvider {
     this.mod = this.platform === "mac" ? "Cmd" : "Ctrl";
   }
 
-  iterate(): HotkeyAction[] {
+  public iterate(): HotkeyAction[] {
     return Objects.keys(this.hotkeys);
   }
 
-  getHotkey(action: HotkeyAction): ResolvedHotkey {
+  public getHotkey(action: HotkeyAction): ResolvedHotkey {
     const { name, key, additionalKeywords } = this.hotkeys[action];
     if (typeof key === "string") {
       return {
@@ -553,15 +553,15 @@ export class HotkeyProvider implements IHotkeyProvider {
     };
   }
 
-  getHotkeyDisplay(action: HotkeyAction): string {
+  public getHotkeyDisplay(action: HotkeyAction): string {
     return this.hotkeys[action].name;
   }
 
-  isEditable(action: HotkeyAction): boolean {
+  public isEditable(action: HotkeyAction): boolean {
     return this.hotkeys[action].editable !== false;
   }
 
-  getHotkeyGroups(): Record<HotkeyGroup, HotkeyAction[]> {
+  public getHotkeyGroups(): Record<HotkeyGroup, HotkeyAction[]> {
     return Objects.groupBy(
       Objects.entries(this.hotkeys),
       ([, hotkey]) => hotkey.group,
@@ -573,7 +573,7 @@ export class HotkeyProvider implements IHotkeyProvider {
 export class OverridingHotkeyProvider extends HotkeyProvider {
   private readonly overrides: Partial<Record<HotkeyAction, string | undefined>>;
 
-  constructor(
+  public constructor(
     overrides: Partial<Record<HotkeyAction, string | undefined>>,
     options: HotkeyProviderOptions = {},
   ) {
@@ -581,7 +581,7 @@ export class OverridingHotkeyProvider extends HotkeyProvider {
     this.overrides = overrides;
   }
 
-  override getHotkey(action: HotkeyAction): ResolvedHotkey {
+  public override getHotkey(action: HotkeyAction): ResolvedHotkey {
     const base = super.getHotkey(action);
     const override = this.overrides[action];
     return {

package/src/core/islands/__tests__/bridge.test.ts

@@ -38,12 +38,12 @@ vi.stubGlobal(
 
 // Create a mock URL class that works as a constructor
 class MockURL {
-  href: string;
-  constructor(url: string, base?: string | URL) {
+  public href: string;
+  public constructor(url: string, base?: string | URL) {
     this.href = base ? `${base}/${url}` : url;
   }
-  static createObjectURL = vi.fn(() => "blob:mock-url");
-  static revokeObjectURL = vi.fn();
+  public static createObjectURL = vi.fn(() => "blob:mock-url");
+  public static revokeObjectURL = vi.fn();
 }
 vi.stubGlobal("URL", MockURL);
 

package/src/core/islands/__tests__/test-utils.tsx

@@ -236,11 +236,11 @@ export class MockWorkerFactory implements WorkerFactory {
   public workers: Worker[] = [];
   private readonly mockWorker?: Worker;
 
-  constructor(mockWorker?: Worker) {
+  public constructor(mockWorker?: Worker) {
     this.mockWorker = mockWorker;
   }
 
-  create(): Worker {
+  public create(): Worker {
     const worker = this.mockWorker || this.createMockWorker();
     this.workers.push(worker);
     return worker;
@@ -259,11 +259,11 @@ export class MockWorkerFactory implements WorkerFactory {
     } as unknown as Worker;
   }
 
-  getCreatedWorkers(): Worker[] {
+  public getCreatedWorkers(): Worker[] {
     return this.workers;
   }
 
-  terminateAll(): void {
+  public terminateAll(): void {
     for (const worker of this.workers) {
       worker.terminate();
     }