@marimo-team/islands 0.24.3-dev5 → 0.24.3-dev52

package/src/components/editor/connections/database/__tests__/as-code.test.ts

@@ -353,7 +353,9 @@ describe("generateDatabaseCode", () => {
     ];
 
     it.each(testCases)("%s", (_name, connection, orm) => {
-      expect(generateDatabaseCode(connection, orm)).toMatchSnapshot();
+      expect(generateDatabaseCode(connection, orm)).toMatchSnapshot(
+        "generated code",
+      );
     });
   });
 
@@ -458,7 +460,7 @@ describe("generateDatabaseCode", () => {
     ])("%s", (_name, connection, orm) => {
       expect(
         generateDatabaseCode(connection, orm as ConnectionLibrary),
-      ).toMatchSnapshot();
+      ).toMatchSnapshot("generated code");
     });
   });
 
@@ -703,7 +705,7 @@ describe("generateDatabaseCode", () => {
     it.each(testCases)("%s", (_name, connection, orm) => {
       expect(
         generateDatabaseCode(connection, orm as ConnectionLibrary),
-      ).toMatchSnapshot();
+      ).toMatchSnapshot("generated code");
     });
   });
 
@@ -745,8 +747,12 @@ describe("generateDatabaseCode", () => {
         },
       ],
     ])("%s", (_name, connection) => {
-      expect(generateDatabaseCode(connection, "sqlmodel")).toMatchSnapshot();
-      expect(generateDatabaseCode(connection, "sqlalchemy")).toMatchSnapshot();
+      expect(generateDatabaseCode(connection, "sqlmodel")).toMatchSnapshot(
+        "sqlmodel",
+      );
+      expect(generateDatabaseCode(connection, "sqlalchemy")).toMatchSnapshot(
+        "sqlalchemy",
+      );
     });
   });
 

package/src/components/editor/dynamic-favicon.tsx

@@ -22,6 +22,19 @@ async function getFaviconUrl(key: FaviconKey): Promise<string> {
   return FAVICON_PATHS[key];
 }
 
+function getOrCreateFavicon(): HTMLLinkElement {
+  const existingFavicon =
+    document.querySelector<HTMLLinkElement>("link[rel~='icon']");
+  if (existingFavicon) {
+    return existingFavicon;
+  }
+
+  const favicon = document.createElement("link");
+  favicon.rel = "icon";
+  document.head.append(favicon);
+  return favicon;
+}
+
 interface Props {
   isRunning: boolean;
 }
@@ -64,16 +77,9 @@ export const DynamicFavicon = (props: Props) => {
   const { isRunning } = props;
   const errors = useCellErrors();
 
-  let favicon: HTMLLinkElement | null =
-    document.querySelector("link[rel~='icon']");
-
-  if (!favicon) {
-    favicon = document.createElement("link");
-    favicon.rel = "icon";
-    document.getElementsByTagName("head")[0].append(favicon);
-  }
-
   useEffect(() => {
+    const favicon = getOrCreateFavicon();
+
     // No change on startup (autorun enabled or not)
     // Treat the default marimo favicon as "idle"
     if (!isRunning && favicon.href.includes("favicon")) {
@@ -105,7 +111,7 @@ export const DynamicFavicon = (props: Props) => {
     };
 
     updateFavicon();
-  }, [isRunning, errors, favicon]);
+  }, [isRunning, errors]);
 
   // Send user notification when run has completed
   const prevRunning = usePrevious(isRunning) ?? isRunning;
@@ -118,6 +124,7 @@ export const DynamicFavicon = (props: Props) => {
   // When notebook comes back in focus, reset favicon
   useEventListener(window, "focus", async (_) => {
     if (!isRunning) {
+      const favicon = getOrCreateFavicon();
       favicon.href = await getFaviconUrl("idle");
     }
   });

package/src/components/editor/file-tree/__tests__/tree-actions.test.tsx

@@ -0,0 +1,54 @@
+/* Copyright 2026 Marimo. All rights reserved. */
+
+import { act, fireEvent, render, screen } from "@testing-library/react";
+import type React from "react";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { RefreshIconButton } from "../tree-actions";
+
+vi.mock("@/components/ui/tooltip", () => ({
+  Tooltip: ({ children }: { children: React.ReactNode }) => children,
+}));
+
+describe("RefreshIconButton", () => {
+  beforeEach(() => {
+    vi.useFakeTimers();
+  });
+
+  afterEach(() => {
+    vi.useRealTimers();
+  });
+
+  it("spins for at least 500ms after a refresh completes", async () => {
+    const onClick = vi.fn().mockResolvedValue(undefined);
+    const { container } = render(<RefreshIconButton onClick={onClick} />);
+
+    fireEvent.click(screen.getByRole("button"));
+
+    expect(onClick).toHaveBeenCalledOnce();
+    expect(container.querySelector("svg")).toHaveClass("animate-[spin_0.5s]");
+
+    await act(async () => {
+      await vi.advanceTimersByTimeAsync(500);
+    });
+
+    expect(container.querySelector("svg")).not.toHaveClass(
+      "animate-[spin_0.5s]",
+    );
+  });
+
+  it("uses the latest refresh callback after a rerender", async () => {
+    const initialOnClick = vi.fn().mockResolvedValue(undefined);
+    const updatedOnClick = vi.fn().mockResolvedValue(undefined);
+    const { rerender } = render(<RefreshIconButton onClick={initialOnClick} />);
+
+    rerender(<RefreshIconButton onClick={updatedOnClick} />);
+    fireEvent.click(screen.getByRole("button"));
+
+    expect(initialOnClick).not.toHaveBeenCalled();
+    expect(updatedOnClick).toHaveBeenCalledOnce();
+
+    await act(async () => {
+      await vi.advanceTimersByTimeAsync(500);
+    });
+  });
+});

package/src/components/editor/file-tree/tree-actions.tsx

@@ -7,7 +7,7 @@ import {
   MoreVerticalIcon,
   RefreshCwIcon,
 } from "lucide-react";
-import React, { useCallback, useState } from "react";
+import React, { useState } from "react";
 import { Button, type ButtonProps } from "@/components/ui/button";
 import { Tooltip } from "@/components/ui/tooltip";
 import { cn } from "@/utils/cn";
@@ -41,19 +41,16 @@ export const RefreshIconButton: React.FC<{
 }> = ({ onClick, tooltip = "Refresh", className, iconClassName }) => {
   const [isSpinning, setIsSpinning] = useState(false);
 
-  const handleClick = useCallback(
-    async (e: React.MouseEvent) => {
-      setIsSpinning(true);
-      // Artificially spin for 500ms to show the user that the button is working.
-      const minDelay = new Promise<void>((r) => setTimeout(r, 500));
-      try {
-        await Promise.all([onClick(e), minDelay]);
-      } finally {
-        setIsSpinning(false);
-      }
-    },
-    [onClick],
-  );
+  const handleClick = async (e: React.MouseEvent) => {
+    setIsSpinning(true);
+    // Artificially spin for 500ms to show the user that the button is working.
+    const minDelay = new Promise<void>((r) => setTimeout(r, 500));
+    try {
+      await Promise.all([onClick(e), minDelay]);
+    } finally {
+      setIsSpinning(false);
+    }
+  };
 
   const button = (
     <Button

package/src/components/editor/header/__tests__/status.test.tsx

@@ -66,24 +66,12 @@ describe("StatusOverlay disconnect indicator", () => {
     expect((button as HTMLButtonElement).disabled).toBe(true);
   });
 
-  it.each([
-    [
-      WebSocketClosedReason.KERNEL_STARTUP_ERROR,
-      "Failed to start kernel sandbox",
-    ],
-  ])(
-    "renders a disabled button for non-recoverable close reason %s",
-    (code, reason) => {
-      const onReconnect = vi.fn();
-      const { getByTestId } = renderOverlay(
-        { state: WebSocketState.CLOSED, code, reason },
-        onReconnect,
-      );
-
-      const button = getByTestId("disconnected-indicator") as HTMLButtonElement;
-      expect(button.disabled).toBe(true);
-      fireEvent.click(button);
-      expect(onReconnect).not.toHaveBeenCalled();
-    },
-  );
+  it("leaves editor startup failures to the inline notice", () => {
+    const { queryByTestId } = renderOverlay({
+      state: WebSocketState.CLOSED,
+      code: WebSocketClosedReason.KERNEL_STARTUP_ERROR,
+      reason: "Failed to start kernel sandbox",
+    });
+    expect(queryByTestId("disconnected-indicator")).not.toBeInTheDocument();
+  });
 });

package/src/components/editor/header/filename-input.tsx

@@ -53,6 +53,8 @@ export const FilenameInput = ({
   const skipReset = useRef<boolean>(false);
 
   useEffect(() => {
+    // TODO: Reset the editable draft without synchronizing state in an effect.
+    // oxlint-disable-next-line react/no-deriving-state-in-effects -- Reset the editable draft when the external filename changes.
     setSearchValue(initialValue);
   }, [initialValue]);
 

package/src/components/editor/header/status.tsx

@@ -20,10 +20,12 @@ export const StatusOverlay: React.FC<{
   onReconnect?: () => void;
 }> = ({ connection, isRunning, onReconnect }) => {
   const { mode } = useAtomValue(viewStateAtom);
-  const isClosed = connection.state === WebSocketState.CLOSED;
+  const isClosed =
+    connection.state === WebSocketState.CLOSED &&
+    (mode === "read" ||
+      connection.code !== WebSocketClosedReason.KERNEL_STARTUP_ERROR);
   const isOpen = connection.state === WebSocketState.OPEN;
-  // Only KERNEL_DISCONNECTED is recoverable by a retry. KERNEL_STARTUP_ERROR
-  // would deterministically fail the same way.
+  // Editor startup failures have their own recovery UI.
   const canReconnect =
     isClosed && connection.code === WebSocketClosedReason.KERNEL_DISCONNECTED;
 

package/src/components/editor/notebook-cell.tsx

@@ -451,7 +451,8 @@ const EditableCellComponent = ({
       cellRuntime.staleInputs) &&
     !cellRuntime.interrupted;
 
-  // Callback to get the editor view.
+  // This getter is called during render, so useEvent cannot be used here.
+  // oxlint-disable-next-line react/preserve-manual-memoization
   const getEditorView = useCallback(() => editorView.current, [editorView]);
 
   // Use the extracted hooks
@@ -1096,7 +1097,8 @@ const SetupCellComponent = ({
       cellRuntime.staleInputs) &&
     !cellRuntime.interrupted;
 
-  // Callback to get the editor view.
+  // This getter is called during render, so useEvent cannot be used here.
+  // oxlint-disable-next-line react/preserve-manual-memoization
   const getEditorView = useCallback(() => editorView.current, [editorView]);
 
   const { isCellCodeShown, showHiddenCode } = useCellHiddenLogic({