@marimo-team/islands 0.23.16-dev9 → 0.23.17-dev0

package/src/core/codemirror/lsp/__tests__/log-messages.test.ts

@@ -0,0 +1,53 @@
+/* Copyright 2026 Marimo. All rights reserved. */
+
+import type { JSONRPCMessage } from "@marimo-team/codemirror-languageserver";
+import { beforeEach, describe, expect, it } from "vitest";
+import { initialNotebookState, notebookAtom } from "@/core/cells/cells";
+import { store } from "@/core/state/jotai";
+import { handleLogMessage } from "../log-messages";
+
+function logMessage(type: number, message: string): JSONRPCMessage {
+  return {
+    jsonrpc: "2.0",
+    method: "window/logMessage",
+    params: { type, message },
+  } as JSONRPCMessage;
+}
+
+describe("handleLogMessage", () => {
+  beforeEach(() => {
+    store.set(notebookAtom, initialNotebookState());
+  });
+
+  it("adds a log for each message, erroring on Error and Warning", () => {
+    handleLogMessage("pylsp", logMessage(1, "failed to start"));
+    handleLogMessage("pylsp", logMessage(2, "plugin not installed"));
+    handleLogMessage("pylsp", logMessage(3, "indexing"));
+
+    expect(store.get(notebookAtom).cellLogs).toMatchObject([
+      { level: "stderr", message: "failed to start" },
+      { level: "stderr", message: "plugin not installed" },
+      {
+        level: "stdout",
+        message: "indexing",
+        source: { type: "lsp", name: "pylsp" },
+      },
+    ]);
+  });
+
+  it("ignores messages that aren't logs", () => {
+    handleLogMessage("pylsp", { jsonrpc: "2.0", id: 1 } as JSONRPCMessage);
+    handleLogMessage("pylsp", {
+      jsonrpc: "2.0",
+      method: "textDocument/publishDiagnostics",
+      params: { uri: "file:///a", diagnostics: [] },
+    } as JSONRPCMessage);
+    handleLogMessage("pylsp", {
+      jsonrpc: "2.0",
+      method: "window/logMessage",
+      params: { type: 1 },
+    } as JSONRPCMessage);
+
+    expect(store.get(notebookAtom).cellLogs).toEqual([]);
+  });
+});

package/src/core/codemirror/lsp/__tests__/normalize-markdown-math.test.ts

@@ -90,6 +90,31 @@ Use \`:math:\` as text and :math:\`z\` as math.
     expect(normalized).not.toContain(":math:`z`");
     expect(normalized).toContain("||(z||)");
   });
+
+  it("leaves markdown-escaped brackets in type annotations alone", () => {
+    const markdown =
+      'on\\_change (Optional\\[Callable\\]) and editable\\_columns (Union\\[list\\[str\\], Literal\\["all"\\]\\])';
+
+    expect(normalizeMarkdownMath(markdown)).toBe(markdown);
+  });
+
+  it("keeps the newlines around fenced code blocks", () => {
+    const markdown = `
+\`\`\`python
+class data_editor()
+\`\`\`
+---
+Inline \\[z^2\\] math forces normalization.
+
+Done.
+`.trim();
+
+    // A closing fence glued to the next line stops closing the block, and the
+    // rest of the document is swallowed into it.
+    expect(normalizeMarkdownMath(markdown)).toContain(
+      "class data_editor()\n```\n---\n",
+    );
+  });
 });
 
 describe("normalizeLspDocumentation", () => {