@marimo-team/islands 0.23.16-dev28 → 0.23.16-dev29

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@marimo-team/islands",
3
- "version": "0.23.16-dev28",
3
+ "version": "0.23.16-dev29",
4
4
  "main": "dist/main.js",
5
5
  "types": "dist/index.d.ts",
6
6
  "type": "module",
@@ -0,0 +1,40 @@
1
+ /* Copyright 2026 Marimo. All rights reserved. */
2
+
3
+ import { render } from "@testing-library/react";
4
+ import { describe, expect, it } from "vitest";
5
+ import { cellId } from "@/__tests__/branded";
6
+ import { TooltipProvider } from "@/components/ui/tooltip";
7
+ import { CellOutputId } from "@/core/cells/ids";
8
+ import { createCell, createCellRuntimeState } from "@/core/cells/types";
9
+ import { CellOutputBlock } from "../reveal-component";
10
+
11
+ describe("CellOutputBlock", () => {
12
+ it("renders the cell's data-cell-id and data-cell-name so it can be targeted by custom CSS", () => {
13
+ const id = cellId("test");
14
+ const cell = {
15
+ ...createCell({ id, name: "title" }),
16
+ ...createCellRuntimeState({
17
+ output: {
18
+ channel: "output",
19
+ mimetype: "text/plain",
20
+ data: "hello",
21
+ timestamp: 0,
22
+ },
23
+ }),
24
+ };
25
+
26
+ const { container } = render(
27
+ <TooltipProvider>
28
+ <CellOutputBlock cell={cell} />
29
+ </TooltipProvider>,
30
+ );
31
+
32
+ const cellElement = container.querySelector(`[data-cell-id="${id}"]`);
33
+ expect(cellElement).toBeTruthy();
34
+ expect(cellElement?.getAttribute("data-cell-name")).toBe("title");
35
+
36
+ // The wrapper's `data-cell-id` must coexist with the output's own
37
+ // `CellOutputId`-derived id, without colliding.
38
+ expect(document.getElementById(CellOutputId.create(id))).toBeTruthy();
39
+ });
40
+ });
@@ -0,0 +1,33 @@
1
+ /* Copyright 2026 Marimo. All rights reserved. */
2
+
3
+ import { render } from "@testing-library/react";
4
+ import { beforeAll, describe, expect, it } from "vitest";
5
+ import { SetupMocks } from "@/__mocks__/common";
6
+ import { cellId } from "@/__tests__/branded";
7
+ import { TooltipProvider } from "@/components/ui/tooltip";
8
+ import { createCell, createCellRuntimeState } from "@/core/cells/types";
9
+ import { SlideCellReadOnlyView } from "../slide-cell-view";
10
+
11
+ beforeAll(() => {
12
+ SetupMocks.resizeObserver();
13
+ });
14
+
15
+ describe("SlideCellReadOnlyView", () => {
16
+ it("renders the cell's data-cell-id and data-cell-name so it can be targeted by custom CSS", () => {
17
+ const id = cellId("test");
18
+ const cell = {
19
+ ...createCell({ id, name: "title", code: "x = 1" }),
20
+ ...createCellRuntimeState(),
21
+ };
22
+
23
+ const { container } = render(
24
+ <TooltipProvider>
25
+ <SlideCellReadOnlyView cell={cell} />
26
+ </TooltipProvider>,
27
+ );
28
+
29
+ const cellElement = container.querySelector(`[data-cell-id="${id}"]`);
30
+ expect(cellElement).toBeTruthy();
31
+ expect(cellElement?.getAttribute("data-cell-name")).toBe("title");
32
+ });
33
+ });
@@ -13,6 +13,7 @@ import useEvent from "react-use-event-hook";
13
13
  import { CodeIcon, ExpandIcon, EyeOffIcon } from "lucide-react";
14
14
  import { Deck, Fragment, Slide, Stack } from "@revealjs/react";
15
15
  import { Panel, PanelGroup, PanelResizeHandle } from "react-resizable-panels";
16
+ import { cellDomProps } from "@/components/editor/common";
16
17
  import { Slide as CellOutputSlide } from "@/components/slides/slide";
17
18
  import { SlideScrollContainer } from "@/components/slides/slide-scroll-hint";
18
19
  import { Button } from "@/components/ui/button";
@@ -304,6 +305,25 @@ function resolveSlideContentStyle(
304
305
  }
305
306
  }
306
307
 
308
+ /**
309
+ * Renders a cell's output wrapped in a `data-cell-id`/`data-cell-name` div
310
+ * (see `cellDomProps`), so it can be targeted by custom CSS in the slides
311
+ * view just like it can in the vertical layout. The wrapper is required
312
+ * because `CellOutputSlide` sets its own `id` from `CellOutputId` (a
313
+ * different scheme than `HTMLCellId`) and its inner `OutputArea` uses
314
+ * `display: contents`, which can't be targeted for background/border styling.
315
+ */
316
+ export const CellOutputBlock = ({ cell }: { cell: RuntimeCell }) => (
317
+ <div className="flex flex-col" {...cellDomProps(cell.id, cell.name)}>
318
+ <CellOutputSlide
319
+ cellId={cell.id}
320
+ status={cell.status}
321
+ output={cell.output}
322
+ stale={outputIsStale(cell, false)}
323
+ />
324
+ </div>
325
+ );
326
+
307
327
  const SubslideView = ({
308
328
  subslide,
309
329
  resolveShowCode,
@@ -340,15 +360,7 @@ const SubslideView = ({
340
360
  {subslide.blocks.map((block, i) => {
341
361
  const rendered = block.cells.map((cell) => {
342
362
  if (!resolveShowCode(cell.id)) {
343
- return (
344
- <CellOutputSlide
345
- key={cell.id}
346
- cellId={cell.id}
347
- status={cell.status}
348
- output={cell.output}
349
- stale={outputIsStale(cell, false)}
350
- />
351
- );
363
+ return <CellOutputBlock key={cell.id} cell={cell} />;
352
364
  }
353
365
  return isEditable ? (
354
366
  <SlideCellView key={cell.id} cell={cell} />
@@ -406,14 +418,7 @@ const ParkedPreviewContent = ({
406
418
  <SlideCellReadOnlyView cell={cell} />
407
419
  );
408
420
  }
409
- return (
410
- <CellOutputSlide
411
- cellId={cell.id}
412
- status={cell.status}
413
- output={cell.output}
414
- stale={outputIsStale(cell, false)}
415
- />
416
- );
421
+ return <CellOutputBlock cell={cell} />;
417
422
  };
418
423
 
419
424
  // There is an upstream react bug in dev mode (https://github.com/facebook/react/issues/34840)
@@ -202,7 +202,7 @@ export const SlideCellReadOnlyView = ({ cell }: { cell: RuntimeCell }) => {
202
202
  );
203
203
 
204
204
  const editor = (
205
- <div className="marimo-cell">
205
+ <div className="marimo-cell" {...cellDomProps(cell.id, cell.name)}>
206
206
  <ReadonlyCode
207
207
  code={display.code}
208
208
  language={display.language}
@@ -15,8 +15,10 @@
15
15
  width: unset;
16
16
  }
17
17
 
18
- /* If the first output is the only child, make it flex 1 */
19
- > *:only-child > .output:only-child {
18
+ /* If the first output is the only child, make it flex 1. Cells are wrapped
19
+ in a `data-cell-id`/`data-cell-name` div (see `cellDomProps`), so `.output`
20
+ is a grandchild rather than a direct child here. */
21
+ > *:only-child:has(> .output:only-child, > * > .output:only-child) {
20
22
  flex: 1;
21
23
  }
22
24