@marimo-team/islands 0.23.15-dev33 → 0.23.15-dev5

package/src/components/slides/reveal-component.tsx

@@ -1,7 +1,6 @@
 /* Copyright 2026 Marimo. All rights reserved. */
 
 import {
-  type CSSProperties,
   startTransition,
   useEffect,
   useMemo,
@@ -27,7 +26,6 @@ import { Logger } from "@/utils/Logger";
 import "./slides.css";
 import "./reveal-slides.css";
 import type {
-  DeckVerticalAlign,
   SlideConfig,
   SlidesLayout,
   SlideType,
@@ -41,7 +39,6 @@ import {
   type ComposedSubslide,
 } from "./compose-slides";
 import {
-  DEFAULT_DECK_VERTICAL_ALIGN,
   DEFAULT_DECK_TRANSITION,
   DEFAULT_SLIDE_TYPE,
   SlideSidebar,
@@ -295,38 +292,16 @@ export function useParkedPreview(options: {
   };
 }
 
-/**
- * Margin style that positions a slide's content vertically within the
- * full-height slide. The content is a flex item, so the vertical margins decide
- * where the free space lands: `auto` on both sides centers it, while pinning one
- * side to `0` pushes content to the top or bottom. The horizontal `20px` keeps
- * content off the slide edges regardless of alignment.
- */
-function resolveSlideContentStyle(
-  verticalAlign: DeckVerticalAlign | undefined,
-): CSSProperties {
-  switch (verticalAlign ?? DEFAULT_DECK_VERTICAL_ALIGN) {
-    case "top":
-      return { margin: "0 20px auto" };
-    case "bottom":
-      return { margin: "auto 20px 0" };
-    default:
-      return { margin: "auto 20px" };
-  }
-}
-
 const SubslideView = ({
   subslide,
   resolveShowCode,
   isEditable,
   slideConfigs,
-  contentStyle,
 }: {
   subslide: ComposedSubslide<RuntimeCell>;
   resolveShowCode: (cellId: CellId) => boolean;
   isEditable: boolean;
   slideConfigs: ReadonlyMap<CellId, SlideConfig>;
-  contentStyle: CSSProperties;
 }) => {
   const { slideLevel, cumulativeByBlock } = buildSubslideNotes(
     subslide,
@@ -346,7 +321,9 @@ const SubslideView = ({
               ? "mo-slide-content flex flex-col gap-3"
               : "mo-slide-content"
           }
-          style={contentStyle}
+          style={{
+            margin: "auto 20px",
+          }}
         >
           {subslide.blocks.map((block, i) => {
             const rendered = block.cells.map((cell) => {
@@ -537,10 +514,6 @@ const RevealSlidesComponent = ({
   );
 
   const deckTransition = layout.deck?.transition ?? DEFAULT_DECK_TRANSITION;
-  const slideContentStyle = resolveSlideContentStyle(
-    layout.deck?.verticalAlign,
-  );
-
   // Reveal's Notes plugin iframes the deck for the current/upcoming-slide
   // previews. We load the same URL but as a read-only kiosk client with the
   // app chrome hidden, which `<SlidesLayoutRenderer>` interprets the same as
@@ -563,10 +536,6 @@ const RevealSlidesComponent = ({
       transition: deckTransition,
       keyboardCondition: (event: KeyboardEvent) => !Events.fromInput(event),
       url: kioskUrl,
-      // reveal.js auto-switches to its scroll view for mobile.
-      // We disable this mode because it rewrites the slide DOM that
-      // `@revealjs/react` owns, which crashes on `reveal.sync()` re-renders.
-      scrollActivationWidth: 0,
     }),
     [width, height, deckTransition, kioskUrl],
   );
@@ -735,7 +704,6 @@ const RevealSlidesComponent = ({
                   resolveShowCode={resolveShowCode}
                   isEditable={isEditable}
                   slideConfigs={layout.cells}
-                  contentStyle={slideContentStyle}
                 />
               );
             }
@@ -749,7 +717,6 @@ const RevealSlidesComponent = ({
                       resolveShowCode={resolveShowCode}
                       isEditable={isEditable}
                       slideConfigs={layout.cells}
-                      contentStyle={slideContentStyle}
                     />
                   );
                 })}
@@ -776,7 +743,7 @@ const RevealSlidesComponent = ({
                     ? "mo-slide-content flex flex-col gap-3"
                     : "mo-slide-content"
                 }
-                style={slideContentStyle}
+                style={{ margin: "auto 20px" }}
               >
                 <ParkedPreviewContent
                   cell={parkedPreviewCell}

package/src/components/slides/slide-form.tsx

@@ -23,7 +23,6 @@ import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
 import type { CellId } from "@/core/cells/ids";
 import { cn } from "@/utils/cn";
 import type {
-  DeckVerticalAlign,
   DeckTransition,
   SlidesLayout,
   SlideType,
@@ -38,7 +37,6 @@ import { jotaiJsonStorage } from "@/utils/storage/jotai";
 
 export const DEFAULT_SLIDE_TYPE: SlideType = "slide";
 export const DEFAULT_DECK_TRANSITION: DeckTransition = "slide";
-export const DEFAULT_DECK_VERTICAL_ALIGN: DeckVerticalAlign = "center";
 const COLLAPSED_CONFIG_WIDTH = 36;
 const slideConfigOpenAtom = atomWithStorage<boolean>(
   "marimo:slides:config-open",
@@ -120,30 +118,6 @@ const DECK_TRANSITION_OPTIONS: DeckTransitionOption[] = [
   { value: "zoom", label: "Zoom", description: "Zoom into the next slide." },
 ];
 
-interface DeckVerticalAlignOption {
-  value: DeckVerticalAlign;
-  label: string;
-  description: string;
-}
-
-const DECK_VERTICAL_ALIGN_OPTIONS: DeckVerticalAlignOption[] = [
-  {
-    value: "center",
-    label: "Center",
-    description: "Vertically center each slide's content.",
-  },
-  {
-    value: "top",
-    label: "Top",
-    description: "Align content to the top, like the cell view.",
-  },
-  {
-    value: "bottom",
-    label: "Bottom",
-    description: "Align content to the bottom of each slide.",
-  },
-];
-
 const SlidesForm = ({
   layout,
   setLayout,
@@ -326,12 +300,6 @@ const DeckConfigForm = ({
     (opt) => opt.value === currentTransition,
   )?.description;
 
-  const currentVerticalAlign: DeckVerticalAlign =
-    layout.deck?.verticalAlign ?? DEFAULT_DECK_VERTICAL_ALIGN;
-  const activeVerticalAlignDescription = DECK_VERTICAL_ALIGN_OPTIONS.find(
-    (opt) => opt.value === currentVerticalAlign,
-  )?.description;
-
   const handleTransitionChange = (value: DeckTransition) => {
     setLayout({
       ...layout,
@@ -339,13 +307,6 @@ const DeckConfigForm = ({
     });
   };
 
-  const handleVerticalAlignChange = (value: DeckVerticalAlign) => {
-    setLayout({
-      ...layout,
-      deck: { ...layout.deck, verticalAlign: value },
-    });
-  };
-
   return (
     <div className="flex flex-col gap-3">
       <div className="flex flex-col gap-1.5">
@@ -376,39 +337,6 @@ const DeckConfigForm = ({
           <p className="text-xs text-foreground/70">{activeDescription}</p>
         )}
       </div>
-      <div className="flex flex-col gap-1.5">
-        <label
-          htmlFor="deck-vertical-align"
-          className="font-semibold text-sm text-foreground"
-        >
-          Vertical alignment
-        </label>
-        <Select
-          value={currentVerticalAlign}
-          onValueChange={(value) =>
-            handleVerticalAlignChange(value as DeckVerticalAlign)
-          }
-        >
-          <SelectTrigger
-            id="deck-vertical-align"
-            aria-label="Vertical alignment"
-          >
-            <SelectValue />
-          </SelectTrigger>
-          <SelectContent>
-            {DECK_VERTICAL_ALIGN_OPTIONS.map(({ value, label }) => (
-              <SelectItem key={value} value={value}>
-                {label}
-              </SelectItem>
-            ))}
-          </SelectContent>
-        </Select>
-        {activeVerticalAlignDescription && (
-          <p className="text-xs text-foreground/70">
-            {activeVerticalAlignDescription}
-          </p>
-        )}
-      </div>
     </div>
   );
 };

package/src/core/cells/__tests__/utils.test.ts

@@ -8,13 +8,11 @@ import {
 } from "@/core/cells/cells";
 import { CellId } from "@/core/cells/ids";
 import type { CellData, CellRuntimeState } from "@/core/cells/types";
-import type { OutputMessage } from "@/core/kernel/messages";
 import { MultiColumn } from "@/utils/id-tree";
 import {
   disabledCellIds,
   enabledCellIds,
   isUninstantiated,
-  shouldHidePublishedCell,
   staleCellIds,
 } from "../utils";
 
@@ -428,60 +426,3 @@ describe("enabledCellIds", () => {
     expect(result).toEqual([cellId2, cellId3]);
   });
 });
-
-describe("shouldHidePublishedCell", () => {
-  const base = {
-    errored: false,
-    interrupted: false,
-    stopped: false,
-    output: null,
-    showErrorTracebacks: false,
-  };
-  const errorOutput = (traceback?: string): OutputMessage => ({
-    channel: "marimo-error",
-    mimetype: "application/vnd.marimo+error",
-    data: [
-      { type: "exception", exception_type: "ValueError", msg: "!", traceback },
-    ],
-    timestamp: 0,
-  });
-
-  it("does not hide a healthy cell", () => {
-    expect(shouldHidePublishedCell(base)).toBe(false);
-  });
-
-  it.each(["errored", "interrupted", "stopped"] as const)(
-    "hides a %s cell",
-    (key) => {
-      expect(shouldHidePublishedCell({ ...base, [key]: true })).toBe(true);
-    },
-  );
-
-  it("hides error outputs", () => {
-    expect(shouldHidePublishedCell({ ...base, output: errorOutput() })).toBe(
-      true,
-    );
-  });
-
-  it("shows error outputs with a traceback when show_tracebacks is enabled", () => {
-    expect(
-      shouldHidePublishedCell({
-        ...base,
-        errored: true,
-        output: errorOutput("Traceback (most recent call last) ..."),
-        showErrorTracebacks: true,
-      }),
-    ).toBe(false);
-  });
-
-  it("hides error outputs without a traceback even when show_tracebacks is enabled", () => {
-    expect(
-      shouldHidePublishedCell({
-        ...base,
-        errored: true,
-        output: errorOutput(),
-        showErrorTracebacks: true,
-      }),
-    ).toBe(true);
-  });
-});

package/src/core/cells/utils.ts

@@ -2,8 +2,6 @@
 
 import type { EditorView } from "@codemirror/view";
 import { Objects } from "@/utils/objects";
-import type { MarimoError, OutputMessage } from "../kernel/messages";
-import { isErrorMime } from "../mime";
 import type { RuntimeState } from "../network/types";
 import type { NotebookState } from "./cells";
 import type { CellId } from "./ids";
@@ -198,52 +196,3 @@ export function cellStatusClasses({
     stale: status === "disabled-transitively",
   };
 }
-
-/**
- * Status classes for a published cell (read or present mode, output only).
- */
-export function publishedCellClasses({
-  errored,
-  stopped,
-}: {
-  errored: boolean;
-  stopped: boolean;
-}) {
-  return {
-    published: true,
-    "has-error": errored,
-    stopped: stopped,
-  };
-}
-
-/**
- * Whether a published cell (read or present mode) should be hidden.
- *
- * Errored, interrupted, and stopped cells (and error outputs) are hidden in
- * published views, unless `show_tracebacks` is enabled and the output carries
- * an exception traceback to display inline.
- */
-export function shouldHidePublishedCell({
-  errored,
-  interrupted,
-  stopped,
-  output,
-  showErrorTracebacks,
-}: {
-  errored: boolean;
-  interrupted: boolean;
-  stopped: boolean;
-  output: OutputMessage | null;
-  showErrorTracebacks: boolean;
-}): boolean {
-  const outputIsError = isErrorMime(output?.mimetype);
-  const hasTraceback =
-    showErrorTracebacks &&
-    outputIsError &&
-    Array.isArray(output?.data) &&
-    output.data.some(
-      (e: MarimoError) =>
-        e.type === "exception" && "traceback" in e && e.traceback,
-    );
-  return (errored || interrupted || stopped || outputIsError) && !hasTraceback;
-}

package/src/core/codemirror/completion/__tests__/signature-hint.test.ts

@@ -5,7 +5,6 @@ import { EditorView, type Tooltip } from "@codemirror/view";
 import { describe, expect, it } from "vitest";
 import {
   asSignatureHint,
-  closeSignatureHint,
   setSignatureHintEffect,
   signatureHintField,
 } from "../signature-hint";
@@ -52,79 +51,12 @@ describe("signatureHintField", () => {
     expect(state.field(signatureHintField)).toBeNull();
   });
 
-  it("keeps and re-anchors the tooltip across edits inside the call", () => {
+  it("keeps and re-anchors the tooltip across edits", () => {
     let state = stateWithHint("plt.plot(", 9);
-    // Insert before the tooltip position while the cursor stays inside the
-    // call; the anchor should shift but the hint should remain.
-    state = state.update({
-      changes: { from: 0, insert: "xy" },
-      selection: { anchor: 11 },
-    }).state;
+    // Insert before the tooltip position; it should shift to stay anchored.
+    state = state.update({ changes: { from: 0, insert: "xy" } }).state;
     expect(state.field(signatureHintField)?.pos).toBe(11);
   });
-
-  it("dismisses the tooltip when the closing paren is typed", () => {
-    let state = stateWithHint("plt.plot(", 9);
-    // Type the closing paren; the cursor is now outside the call.
-    state = state.update({
-      changes: { from: 9, insert: ")" },
-      selection: { anchor: 10 },
-    }).state;
-    expect(state.field(signatureHintField)).toBeNull();
-  });
-
-  it("dismisses the tooltip when the anchored call closes inside grouping parens", () => {
-    // Regression for the `(plt.plot())` case: the outer grouping paren must not
-    // keep the (now-closed) plt.plot hint alive.
-    let state = stateWithHint("(plt.plot(", 10);
-    // Close plt.plot's call; the outer `(` is still open but we've left the
-    // anchored call.
-    state = state.update({
-      changes: { from: 10, insert: ")" },
-      selection: { anchor: 11 },
-    }).state;
-    expect(state.field(signatureHintField)).toBeNull();
-  });
-
-  it("keeps the tooltip while typing a nested call inside the anchored call", () => {
-    // Cursor inside the anchored call of `f(g(<cursor>`; opening/typing a nested
-    // call stays inside the anchored call, so the hint should remain.
-    let state = stateWithHint("f(g(", 4);
-    state = state.update({
-      changes: { from: 4, insert: "x(" },
-      selection: { anchor: 6 },
-    }).state;
-    expect(state.field(signatureHintField)?.pos).toBe(4);
-  });
-
-  it("keeps the tooltip when a nested call closes inside the anchored call", () => {
-    const anchor = "f(".length;
-    let state = stateWithHint("f(g(x", anchor);
-    state = state.update({
-      changes: { from: 5, insert: ")" },
-      selection: { anchor: 6 },
-    }).state;
-    expect(state.field(signatureHintField)?.pos).toBe(anchor);
-  });
-
-  it("dismisses the tooltip when the closing paren is typed in a large multi-line call", () => {
-    const anchor = "f(".length;
-    const prefix = `f(\n${"  x,\n".repeat(25)}`;
-    let state = EditorState.create({
-      doc: prefix,
-      selection: { anchor: prefix.length },
-      extensions: [signatureHintField],
-    });
-    state = state.update({
-      effects: setSignatureHintEffect.of(fakeTooltip(anchor)),
-    }).state;
-    const head = prefix.length;
-    state = state.update({
-      changes: { from: head, insert: ")" },
-      selection: { anchor: head + 1 },
-    }).state;
-    expect(state.field(signatureHintField)).toBeNull();
-  });
 });
 
 describe("asSignatureHint", () => {
@@ -160,29 +92,3 @@ describe("asSignatureHint", () => {
     expect(wrapped.above).toBe(true);
   });
 });
-
-describe("closeSignatureHint", () => {
-  it("returns false when no hint is showing", () => {
-    const view = new EditorView({
-      state: EditorState.create({ extensions: [signatureHintField] }),
-    });
-    expect(closeSignatureHint(view)).toBe(false);
-    expect(view.state.field(signatureHintField)).toBeNull();
-    view.destroy();
-  });
-
-  it("dismisses the hint and returns true when one is showing", () => {
-    const view = new EditorView({
-      state: EditorState.create({
-        doc: "plt.plot(",
-        extensions: [signatureHintField],
-      }),
-    });
-    view.dispatch({ effects: setSignatureHintEffect.of(fakeTooltip(9)) });
-    expect(view.state.field(signatureHintField)?.pos).toBe(9);
-
-    expect(closeSignatureHint(view)).toBe(true);
-    expect(view.state.field(signatureHintField)).toBeNull();
-    view.destroy();
-  });
-});

package/src/core/codemirror/completion/signature-hint.ts

@@ -1,61 +1,12 @@
 /* Copyright 2026 Marimo. All rights reserved. */
-import type { EditorState } from "@codemirror/state";
 import { StateEffect, StateField } from "@codemirror/state";
-import { type EditorView, showTooltip, type Tooltip } from "@codemirror/view";
+import { showTooltip, type Tooltip } from "@codemirror/view";
 
 /**
  * Effect to set (or clear, with `null`) the floating signature hint.
  */
 export const setSignatureHintEffect = StateEffect.define<Tooltip | null>();
 
-// Bound the scan so large cells stay cheap on every keystroke.
-const MAX_LINES_BACK = 20;
-
-/**
- * Whether the cursor is still inside the anchored call (just inside its `(`).
- *
- * Anchor-relative paren scan, bounded to {@link MAX_LINES_BACK} lines.
- * Good enough for hint dismissal — not a full parse (ignores strings/comments).
- */
-function isCursorInsideAnchoredCall(options: {
-  state: EditorState;
-  anchor: number;
-  head: number;
-}): boolean {
-  const { state, anchor, head } = options;
-  if (head < anchor) {
-    return false;
-  }
-
-  const headLine = state.doc.lineAt(head).number;
-  const anchorLine = state.doc.lineAt(anchor).number;
-  const startLine = Math.max(anchorLine, headLine - MAX_LINES_BACK + 1);
-  const from = Math.max(anchor, state.doc.line(startLine).from);
-
-  // If the anchor is outside the bounded window, assume its `(` is still open.
-  const assumedOpen = from > anchor;
-  let balance = assumedOpen ? 1 : 0;
-  const iter = state.doc.iterRange(from, head);
-  for (;;) {
-    const { value, done } = iter.next();
-    if (done) {
-      break;
-    }
-    for (const char of value) {
-      if (char === "(") {
-        balance++;
-      } else if (char === ")") {
-        balance--;
-        const closed = assumedOpen ? balance <= 0 : balance < 0;
-        if (closed) {
-          return false;
-        }
-      }
-    }
-  }
-  return true;
-}
-
 /**
  * Wrap a tooltip so it renders like the completion popup's info box.
  *
@@ -83,7 +34,13 @@ export function asSignatureHint(tooltip: Tooltip): Tooltip {
  * Holds the floating "signature hint" shown after typing `(` or `,` inside a
  * call on the non-LSP (Jedi) completion path.
  *
- * The LSP path has its own signature help; this fills the gap for users without a language server.
+ * The LSP path has its own signature help; this fills the gap for users
+ * without a language server. The completion source (`pythonCompletionSource`)
+ * drives it: it dispatches `setSignatureHintEffect` with the tooltip when the
+ * backend returns a signature and with `null` otherwise. The hint is also
+ * cleared when the cursor moves via a selection-only change (e.g. clicking
+ * away or arrowing out of the call), and kept anchored across edits so it
+ * doesn't flicker while a fresh result is in flight.
  */
 export const signatureHintField = StateField.define<Tooltip | null>({
   create: () => null,
@@ -100,36 +57,12 @@ export const signatureHintField = StateField.define<Tooltip | null>({
     if (tr.selection && !tr.docChanged) {
       return null;
     }
-    // Dismiss once the cursor leaves the anchored call (e.g. the closing paren
-    // is typed). Otherwise keep the hint anchored across edits so it doesn't
-    // flicker while a fresh result is in flight; the completion source refreshes
-    // or clears it as results arrive.
+    // Keep the hint anchored across edits; the completion source refreshes or
+    // clears it as new results arrive.
     if (tr.docChanged) {
-      const anchor = tr.changes.mapPos(tooltip.pos);
-      if (
-        !isCursorInsideAnchoredCall({
-          state: tr.state,
-          anchor,
-          head: tr.state.selection.main.head,
-        })
-      ) {
-        return null;
-      }
-      return { ...tooltip, pos: anchor };
+      return { ...tooltip, pos: tr.changes.mapPos(tooltip.pos) };
     }
     return tooltip;
   },
   provide: (field) => showTooltip.from(field),
 });
-
-/**
- * Dismiss the floating signature hint if one is showing.
- * Returns `true` if a hint was dismissed.
- */
-export function closeSignatureHint(view: EditorView): boolean {
-  if (view.state.field(signatureHintField, false)) {
-    view.dispatch({ effects: setSignatureHintEffect.of(null) });
-    return true;
-  }
-  return false;
-}

package/src/core/constants.ts

@@ -50,12 +50,6 @@ export const KnownQueryParams = {
    * If false, the chrome will be hidden.
    */
   showChrome: "show-chrome",
-  /**
-   * Override the display theme: `light`, `dark`, or `system`.
-   * Takes precedence over the notebook's saved `display.theme`.
-   * Ignored for embedded islands, which infer the theme from their host page.
-   */
-  theme: "theme",
 };
 
 /**