@marimo-team/frontend 0.23.7-dev55 → 0.23.7-dev57

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (116) hide show
  1. package/dist/assets/{CellStatus-DXNmZJpi.js → CellStatus-DGBvmSvq.js} +1 -1
  2. package/dist/assets/JsonOutput-BEbyS3oG.js +53 -0
  3. package/dist/assets/{LazyAnyLanguageCodeMirror-B2pl_WA3.js → LazyAnyLanguageCodeMirror-GdhQ07zA.js} +2 -2
  4. package/dist/assets/{MarimoErrorOutput-YGhIA85d.js → MarimoErrorOutput-XWqnhvJ6.js} +1 -1
  5. package/dist/assets/{RenderHTML-Dz1OIbOh.js → RenderHTML-B5r25cP5.js} +1 -1
  6. package/dist/assets/{RunButton-D1IZ1Yr0.js → RunButton-Dbak5hfa.js} +1 -1
  7. package/dist/assets/{add-cell-with-ai-hIPYl46r.js → add-cell-with-ai-BbZkMqv2.js} +1 -1
  8. package/dist/assets/{add-connection-dialog-CMR-c9XE.js → add-connection-dialog-Cw6_iYno.js} +1 -1
  9. package/dist/assets/{agent-panel-DnBAoLsM.js → agent-panel-StLA6gDR.js} +1 -1
  10. package/dist/assets/{ai-model-dropdown-zvokTxf_.js → ai-model-dropdown-CjhUqXgj.js} +1 -1
  11. package/dist/assets/{any-language-editor-BgxVFHQ8.js → any-language-editor-Bdhmwznp.js} +1 -1
  12. package/dist/assets/{app-config-button-BjFAqaTN.js → app-config-button-CCs8Jepz.js} +1 -1
  13. package/dist/assets/{cell-editor-Dak_jwhB.js → cell-editor-Cgyoqdi5.js} +1 -1
  14. package/dist/assets/{cell-link-pRI-YfIp.js → cell-link-PQYiMZw1.js} +1 -1
  15. package/dist/assets/{cells-DbE28H1u.js → cells-Dnu4nDoy.js} +1 -1
  16. package/dist/assets/{chat-display-D_nDPZek.js → chat-display-DetTBnqK.js} +1 -1
  17. package/dist/assets/{chat-panel-BktSpl2P.js → chat-panel-CEgw_vg0.js} +1 -1
  18. package/dist/assets/{chat-ui-C0_KcXrv.js → chat-ui-D-Y7p_cT.js} +1 -1
  19. package/dist/assets/{chunk-5FQGJX7Z-DILIU9Rm.js → chunk-5FQGJX7Z-BSzccEgu.js} +3 -3
  20. package/dist/assets/{code-block-37QAKDTI-Bgm-HPiB.js → code-block-37QAKDTI-U2R1jyOo.js} +1 -1
  21. package/dist/assets/{column-preview-CNeXQtKn.js → column-preview-DA6nf5_Q.js} +1 -1
  22. package/dist/assets/{command-palette-CcjZs_TG.js → command-palette-n_e11WBA.js} +1 -1
  23. package/dist/assets/{common-CWRr25jC.js → common-BaBE_ygg.js} +1 -1
  24. package/dist/assets/{components-DUd0ki0p.js → components-CvGaLA5d.js} +1 -1
  25. package/dist/assets/{components-Cj3Al1Y6.js → components-zB5yT_R8.js} +1 -1
  26. package/dist/assets/config-C2lTvbuU.js +1 -0
  27. package/dist/assets/{datasource-Prn_GWOB.js → datasource-I-LOgxeP.js} +1 -1
  28. package/dist/assets/{dependency-graph-panel-DUUCij85.js → dependency-graph-panel-BjOeXp74.js} +1 -1
  29. package/dist/assets/{dist-DxnNQmQo.js → dist-CW3rweKM.js} +1 -1
  30. package/dist/assets/{documentation-panel-CB8xalFX.js → documentation-panel-DMdFXuBf.js} +1 -1
  31. package/dist/assets/{download-DEJbA1IY.js → download-BO6T2USS.js} +1 -1
  32. package/dist/assets/{edit-page-BkHYt2if.js → edit-page-Dos8zz_9.js} +6 -6
  33. package/dist/assets/{error-panel-DG6AtqLR.js → error-panel-iXznkJZ1.js} +1 -1
  34. package/dist/assets/{file-explorer-panel-Co6MlwYD.js → file-explorer-panel-_77UepGi.js} +3 -3
  35. package/dist/assets/{file-icons-BjTIuMQg.js → file-icons-B6DaZdP0.js} +1 -1
  36. package/dist/assets/{file-name-input-CQVbWhL8.js → file-name-input-g2H2sY2h.js} +1 -1
  37. package/dist/assets/{floating-outline-uy6dAsIe.js → floating-outline-DbOtUfo-.js} +1 -1
  38. package/dist/assets/{focus-0RBjdtZw.js → focus-BaOnnMs-.js} +1 -1
  39. package/dist/assets/{form-DNa2VnwU.js → form-CM8vYbSt.js} +1 -1
  40. package/dist/assets/{globals-DI5QlXvl.js → globals-CpVAcN9Z.js} +1 -1
  41. package/dist/assets/{home-page-BSuXANlw.js → home-page-De1W6q6f.js} +1 -1
  42. package/dist/assets/{hooks-B7pYZHjF.js → hooks-7OHHugrQ.js} +1 -1
  43. package/dist/assets/{html-to-image-CIu-0LbU.js → html-to-image-D6SgvARi.js} +1 -1
  44. package/dist/assets/index-1EIgCVR_.js +38 -0
  45. package/dist/assets/{kiosk-mode-Ch75k65P.js → kiosk-mode-Czvj3vmL.js} +1 -1
  46. package/dist/assets/{layout-DFhJt7oJ.js → layout-DQGNHEpb.js} +5 -5
  47. package/dist/assets/{logs-panel-DR-1BC0S.js → logs-panel-BMAfoMJg.js} +1 -1
  48. package/dist/assets/{markdown-renderer-DGqYztXR.js → markdown-renderer-BQ-BQLiJ.js} +3 -3
  49. package/dist/assets/mermaid-4DMBBIKO-C0OyyVdo.js +1 -0
  50. package/dist/assets/{name-cell-input-DwfyLq31.js → name-cell-input-bwfAyC0i.js} +1 -1
  51. package/dist/assets/{outline-panel-CWunrooQ.js → outline-panel-CkZUQcZ1.js} +1 -1
  52. package/dist/assets/{packages-panel-BdcXUFQJ.js → packages-panel-B3dRYuRM.js} +1 -1
  53. package/dist/assets/panels-DvIOAb34.js +1 -0
  54. package/dist/assets/{process-output-CS4QGJvL.js → process-output-9W-JyYdE.js} +1 -1
  55. package/dist/assets/{radio-group-BS2PIEzV.js → radio-group-rsi1ibXY.js} +1 -1
  56. package/dist/assets/{readonly-python-code-C5JNX2fu.js → readonly-python-code-BKYj8PNf.js} +1 -1
  57. package/dist/assets/{reveal-component-PiSHIrbA.js → reveal-component-ClM8W-TD.js} +1 -1
  58. package/dist/assets/{run-page-BovrPK0f.js → run-page-DJOwAe2z.js} +1 -1
  59. package/dist/assets/{scratchpad-panel-CAWFveBD.js → scratchpad-panel-CpM3jVv7.js} +1 -1
  60. package/dist/assets/{secrets-panel-CEh4Wjfn.js → secrets-panel-DqHGq3V8.js} +1 -1
  61. package/dist/assets/{session-panel-BR9h5w96.js → session-panel-jVcSUURP.js} +1 -1
  62. package/dist/assets/{snippets-panel-Y2etH9Qg.js → snippets-panel-DFJd1ui5.js} +1 -1
  63. package/dist/assets/{state-Fa6RzVTL.js → state-BXNNuw9g.js} +1 -1
  64. package/dist/assets/{state-1SbOXCLX.js → state-D9EoHCkz.js} +1 -1
  65. package/dist/assets/{switch-CTn-kJzM.js → switch-BtkQp293.js} +1 -1
  66. package/dist/assets/{terminal-DI2XRUUH.js → terminal-BSE1Vg5d.js} +1 -1
  67. package/dist/assets/{textarea-wgoQLrBS.js → textarea-BBTcSr-i.js} +1 -1
  68. package/dist/assets/{tracing-C9PZ0Pr1.js → tracing-BQU8fBDM.js} +1 -1
  69. package/dist/assets/{tracing-panel-C20Rk6hU.js → tracing-panel-DEVpyGX3.js} +2 -2
  70. package/dist/assets/useBoolean-B8LMGUHl.js +1 -0
  71. package/dist/assets/{useCellActionButton-D_-iAhme.js → useCellActionButton-CpNJthj4.js} +1 -1
  72. package/dist/assets/{useDeleteCell-41mvwiyA.js → useDeleteCell-DFahVcdW.js} +1 -1
  73. package/dist/assets/{useDependencyPanelTab-ELdrL73c.js → useDependencyPanelTab-BNbEyT1o.js} +1 -1
  74. package/dist/assets/{useNotebookActions-CgN-58GN.js → useNotebookActions-DqlAe4Ea.js} +1 -1
  75. package/dist/assets/{useRunCells-CfHlqXY6.js → useRunCells-C0BPo9m1.js} +1 -1
  76. package/dist/assets/{useSplitCell-gHtyz873.js → useSplitCell-BN53wD86.js} +1 -1
  77. package/dist/assets/{vega-component-BPU1T-x7.js → vega-component-C9fDGx86.js} +1 -1
  78. package/dist/assets/{write-secret-modal-DjVzKit_.js → write-secret-modal-Liv_9MXS.js} +1 -1
  79. package/dist/index.html +40 -40
  80. package/package.json +1 -1
  81. package/src/components/data-table/__tests__/column-header.test.tsx +106 -1
  82. package/src/components/data-table/__tests__/filter-pill-editor.test.tsx +88 -2
  83. package/src/components/data-table/__tests__/filters.test.ts +84 -13
  84. package/src/components/data-table/column-header.tsx +152 -26
  85. package/src/components/data-table/date-filter-inputs.tsx +325 -0
  86. package/src/components/data-table/filter-pill-editor.tsx +139 -30
  87. package/src/components/data-table/filter-pills.tsx +31 -57
  88. package/src/components/data-table/filters.ts +88 -66
  89. package/src/components/editor/chrome/wrapper/footer-items/backend-status.tsx +1 -1
  90. package/src/core/runtime/__tests__/runtime.test.ts +38 -17
  91. package/src/core/runtime/runtime.ts +57 -34
  92. package/src/core/websocket/__tests__/useMarimoKernelConnection.hook.test.tsx +5 -4
  93. package/src/core/websocket/__tests__/useMarimoKernelConnection.test.ts +18 -54
  94. package/src/core/websocket/transports/__tests__/ws.test.ts +125 -0
  95. package/src/core/websocket/transports/basic.ts +1 -3
  96. package/src/core/websocket/transports/transport.ts +0 -1
  97. package/src/core/websocket/transports/ws.ts +96 -0
  98. package/src/core/websocket/useMarimoKernelConnection.tsx +30 -26
  99. package/src/core/websocket/useWebSocket.tsx +3 -18
  100. package/dist/assets/JsonOutput-Dxol3ZtH.js +0 -49
  101. package/dist/assets/config-DGudsRYK.js +0 -1
  102. package/dist/assets/index-DySiGerD.js +0 -42
  103. package/dist/assets/mermaid-4DMBBIKO-B-uFGNnk.js +0 -1
  104. package/dist/assets/panels-CJ1t18_z.js +0 -1
  105. package/dist/assets/useBoolean-DP3412N2.js +0 -1
  106. /package/dist/assets/{bundle.esm-DjhGJy4I.js → bundle.esm-BXIlAZ6T.js} +0 -0
  107. /package/dist/assets/{esm-DLYpPRvw.js → esm-Cb2bnV6o.js} +0 -0
  108. /package/dist/assets/{field-CQGpbXj3.js → field-DNlzfMKW.js} +0 -0
  109. /package/dist/assets/{formats-CJQ67TPE.js → formats-BRq458WH.js} +0 -0
  110. /package/dist/assets/{icons-Ol38nIbL.js → icons-8tfAri2V.js} +0 -0
  111. /package/dist/assets/{micromark-factory-space-P--XWZhg.js → micromark-factory-space-BUQpMdx2.js} +0 -0
  112. /package/dist/assets/{react-resizable-panels.browser.esm-CgWOEYeG.js → react-resizable-panels.browser.esm-Ce2ksurd.js} +0 -0
  113. /package/dist/assets/{renderShortcut-D7FYCtYQ.js → renderShortcut-DK-VjfaX.js} +0 -0
  114. /package/dist/assets/{table-DUSsaCYD.js → table-DQE9hQzM.js} +0 -0
  115. /package/dist/assets/{tree-actions-D9i3o3Zk.js → tree-actions-DY8FUp3V.js} +0 -0
  116. /package/dist/assets/{useDeepCompareMemoize-zUHU--0D.js → useDeepCompareMemoize-CWcgQCbT.js} +0 -0
@@ -275,14 +275,14 @@ describe("RuntimeManager", () => {
275
275
  });
276
276
  });
277
277
 
278
- describe("isHealthy", () => {
278
+ describe("probeHealth", () => {
279
279
  it("should return true for successful health check", async () => {
280
280
  global.fetch = vi.fn().mockResolvedValue({
281
281
  ok: true,
282
282
  });
283
283
 
284
284
  const runtime = new RuntimeManager(mockConfig);
285
- const result = await runtime.isHealthy();
285
+ const result = await runtime.probeHealth();
286
286
 
287
287
  expect(result).toBe(true);
288
288
  expect(fetch).toHaveBeenCalledWith("https://example.com/health");
@@ -294,7 +294,7 @@ describe("RuntimeManager", () => {
294
294
  });
295
295
 
296
296
  const runtime = new RuntimeManager(mockConfig);
297
- const result = await runtime.isHealthy();
297
+ const result = await runtime.probeHealth();
298
298
 
299
299
  expect(result).toBe(false);
300
300
  });
@@ -304,11 +304,32 @@ describe("RuntimeManager", () => {
304
304
  global.fetch = vi.fn().mockRejectedValue(error);
305
305
 
306
306
  const runtime = new RuntimeManager(mockConfig);
307
- const result = await runtime.isHealthy();
307
+ const result = await runtime.probeHealth();
308
308
 
309
309
  expect(result).toBe(false);
310
310
  });
311
311
 
312
+ it("should not mutate config.url on redirect", async () => {
313
+ global.fetch = vi.fn().mockResolvedValue({
314
+ ok: true,
315
+ redirected: true,
316
+ url: "https://sandbox.example.com/health?some_value=abc123",
317
+ });
318
+
319
+ const runtime = new RuntimeManager(
320
+ {
321
+ ...mockConfig,
322
+ url: "https://backend.example.com/lazy?some_value=abc123",
323
+ },
324
+ true,
325
+ );
326
+ const result = await runtime.probeHealth();
327
+ expect(result).toBe(true);
328
+ expect(runtime.httpURL.hostname).toBe("backend.example.com");
329
+ });
330
+ });
331
+
332
+ describe("reconcileFromHealth", () => {
312
333
  it("should update config.url on redirect, stripping /health from pathname", async () => {
313
334
  global.fetch = vi.fn().mockResolvedValue({
314
335
  ok: true,
@@ -323,7 +344,7 @@ describe("RuntimeManager", () => {
323
344
  },
324
345
  true, // lazy — don't call init() in constructor
325
346
  );
326
- const result = await runtime.isHealthy();
347
+ const result = await runtime.reconcileFromHealth();
327
348
 
328
349
  expect(result).toBe(true);
329
350
  // Should strip /health from pathname but preserve query params
@@ -342,7 +363,7 @@ describe("RuntimeManager", () => {
342
363
  it("should resolve immediately if healthy", async () => {
343
364
  const runtime = new RuntimeManager(mockConfig, true);
344
365
 
345
- vi.spyOn(runtime, "isHealthy").mockResolvedValue(true);
366
+ vi.spyOn(runtime, "reconcileFromHealth").mockResolvedValue(true);
346
367
  runtime.init();
347
368
 
348
369
  await expect(runtime.waitForHealthy()).resolves.toBeUndefined();
@@ -351,7 +372,7 @@ describe("RuntimeManager", () => {
351
372
  it("should retry and eventually succeed", async () => {
352
373
  const runtime = new RuntimeManager(mockConfig, true);
353
374
  const healthySpy = vi
354
- .spyOn(runtime, "isHealthy")
375
+ .spyOn(runtime, "reconcileFromHealth")
355
376
  .mockResolvedValueOnce(false)
356
377
  .mockResolvedValueOnce(false)
357
378
  .mockResolvedValueOnce(true);
@@ -364,7 +385,7 @@ describe("RuntimeManager", () => {
364
385
 
365
386
  it("should throw after max retries", async () => {
366
387
  const runtime = new RuntimeManager(mockConfig, true);
367
- vi.spyOn(runtime, "isHealthy").mockResolvedValue(false);
388
+ vi.spyOn(runtime, "reconcileFromHealth").mockResolvedValue(false);
368
389
  runtime.init({ disableRetryDelay: true });
369
390
 
370
391
  await expect(runtime.waitForHealthy()).rejects.toThrow(
@@ -431,7 +452,7 @@ describe("RuntimeManager", () => {
431
452
  // Mock failed health check
432
453
  global.fetch = vi.fn().mockResolvedValue({ ok: false });
433
454
 
434
- await runtime.isHealthy();
455
+ await runtime.reconcileFromHealth();
435
456
 
436
457
  baseElement = document.querySelector("base");
437
458
  expect(baseElement).toBeNull();
@@ -443,7 +464,7 @@ describe("RuntimeManager", () => {
443
464
  // Mock successful health check
444
465
  global.fetch = vi.fn().mockResolvedValue({ ok: true });
445
466
 
446
- await runtime.isHealthy();
467
+ await runtime.reconcileFromHealth();
447
468
 
448
469
  const baseElement = document.querySelector("base");
449
470
  expect(baseElement).toBeTruthy();
@@ -461,7 +482,7 @@ describe("RuntimeManager", () => {
461
482
  // Mock successful health check
462
483
  global.fetch = vi.fn().mockResolvedValue({ ok: true });
463
484
 
464
- await runtime.isHealthy();
485
+ await runtime.reconcileFromHealth();
465
486
 
466
487
  const baseElement = document.querySelector("base");
467
488
  expect(baseElement).toBe(existingBase); // Should be the same element
@@ -483,7 +504,7 @@ describe("RuntimeManager", () => {
483
504
  // Mock successful health check
484
505
  global.fetch = vi.fn().mockResolvedValue({ ok: true });
485
506
 
486
- await runtime.isHealthy();
507
+ await runtime.reconcileFromHealth();
487
508
 
488
509
  const baseElement = document.querySelector("base");
489
510
  expect(baseElement).toBeTruthy();
@@ -524,11 +545,11 @@ describe("RuntimeManager", () => {
524
545
  });
525
546
 
526
547
  const wsUrl = runtime.getWsURL("test" as SessionId);
527
- const httpUrl = runtime.formatHttpURL(
528
- "api/test",
529
- new URLSearchParams(),
530
- false,
531
- );
548
+ const httpUrl = runtime.formatHttpURL({
549
+ path: "api/test",
550
+ searchParams: new URLSearchParams(),
551
+ restrictToKnownQueryParams: false,
552
+ });
532
553
 
533
554
  // Should preserve base URL query params
534
555
  expect(wsUrl.searchParams.get("base_param")).toBe("existing");
@@ -44,17 +44,22 @@ export class RuntimeManager {
44
44
  return this.httpURL.origin === window.location.origin;
45
45
  }
46
46
 
47
+ private get isServerless(): boolean {
48
+ return isWasm() || isIslands() || isStaticNotebook();
49
+ }
50
+
47
51
  /**
48
52
  * The base URL of the runtime.
49
53
  */
50
- formatHttpURL(
51
- path?: string,
52
- searchParams?: URLSearchParams,
54
+ formatHttpURL({
55
+ path = "",
56
+ searchParams,
53
57
  restrictToKnownQueryParams = true,
54
- ): URL {
55
- if (!path) {
56
- path = "";
57
- }
58
+ }: {
59
+ path?: string;
60
+ searchParams?: URLSearchParams;
61
+ restrictToKnownQueryParams?: boolean;
62
+ }): URL {
58
63
  // URL may be something like "http://localhost:8000?auth=123"
59
64
  const baseUrl = this.httpURL;
60
65
  const currentParams = new URLSearchParams(window.location.search);
@@ -84,11 +89,11 @@ export class RuntimeManager {
84
89
  formatWsURL(path: string, searchParams?: URLSearchParams): URL {
85
90
  // We don't restrict to known query parameters, since mo.query_params()
86
91
  // can accept arbitrary parameters.
87
- const url = this.formatHttpURL(
92
+ const url = this.formatHttpURL({
88
93
  path,
89
94
  searchParams,
90
- /* restrictToKnownQueryParams =*/ false,
91
- );
95
+ restrictToKnownQueryParams: false,
96
+ });
92
97
 
93
98
  // For cross-origin runtimes, pass the auth token as a query parameter.
94
99
  // WebSocket connections cannot send custom headers (no Authorization
@@ -168,45 +173,63 @@ export class RuntimeManager {
168
173
  }
169
174
 
170
175
  getAiURL(path: "completion" | "chat"): URL {
171
- return this.formatHttpURL(`/api/ai/${path}`);
176
+ return this.formatHttpURL({ path: `/api/ai/${path}` });
172
177
  }
173
178
 
174
179
  /**
175
180
  * The URL of the health check endpoint.
176
181
  */
177
182
  healthURL(): URL {
178
- return this.formatHttpURL("/health");
183
+ return this.formatHttpURL({ path: "/health" });
179
184
  }
180
185
 
181
- async isHealthy(): Promise<boolean> {
182
- // Always healthy if WASM, Islands, or a static notebook (no server)
183
- if (isWasm() || isIslands() || isStaticNotebook()) {
184
- return true;
185
- }
186
-
186
+ private async fetchHealth(): Promise<Response | null> {
187
187
  try {
188
- const response = await fetch(this.healthURL().toString());
189
- // If there is a redirect, update the URL in the config
190
- if (response.redirected) {
191
- Logger.debug(`Runtime redirected to ${response.url}`);
192
- // strip /health from the URL, using URL parsing to handle query params
193
- const redirected = new URL(response.url);
194
- redirected.pathname = redirected.pathname.replace(/\/health$/, "");
195
- this.config.url = redirected.toString();
196
- }
197
-
198
- const success = response.ok;
199
- if (success) {
200
- this.setDOMBaseUri(this.config.url);
201
- }
202
- return success;
188
+ return await fetch(this.healthURL().toString());
203
189
  } catch (error) {
204
190
  Logger.error(
205
191
  `Failed to check health: ${error instanceof Error ? error.message : "Unknown error"}`,
206
192
  { cause: error },
207
193
  );
194
+ return null;
195
+ }
196
+ }
197
+
198
+ async reconcileFromHealth(): Promise<boolean> {
199
+ // Always healthy if WASM, Islands, or a static notebook (no server)
200
+ if (this.isServerless) {
201
+ return true;
202
+ }
203
+
204
+ const response = await this.fetchHealth();
205
+
206
+ if (!response) {
208
207
  return false;
209
208
  }
209
+
210
+ if (response.redirected) {
211
+ Logger.debug(`Runtime redirected to ${response.url}`);
212
+ // strip /health from the URL, using URL parsing to handle query params
213
+ const redirected = new URL(response.url);
214
+ redirected.pathname = redirected.pathname.replace(/\/health$/, "");
215
+ this.config.url = redirected.toString();
216
+ }
217
+
218
+ if (response.ok) {
219
+ this.setDOMBaseUri(this.config.url);
220
+ }
221
+
222
+ return response.ok;
223
+ }
224
+
225
+ async probeHealth(): Promise<boolean> {
226
+ // Always healthy if WASM, Islands, or a static notebook (no server)
227
+ if (this.isServerless) {
228
+ return true;
229
+ }
230
+
231
+ const response = await this.fetchHealth();
232
+ return response?.ok ?? false;
210
233
  }
211
234
 
212
235
  /**
@@ -251,7 +274,7 @@ export class RuntimeManager {
251
274
  const growthFactor = 1.2;
252
275
  const maxDelay = 2000;
253
276
 
254
- while (!(await this.isHealthy())) {
277
+ while (!(await this.reconcileFromHealth())) {
255
278
  if (retries >= maxRetries) {
256
279
  Logger.error(`Failed to connect after ${maxRetries} retries`);
257
280
  this.initialHealthyCheck.reject(
@@ -35,7 +35,6 @@ import { useConnectionTransport } from "../useWebSocket";
35
35
 
36
36
  interface MockTransport {
37
37
  readyState: 0 | 1 | 2 | 3;
38
- retryCount: number;
39
38
  reconnect: ReturnType<typeof vi.fn>;
40
39
  close: ReturnType<typeof vi.fn>;
41
40
  send: ReturnType<typeof vi.fn>;
@@ -48,7 +47,6 @@ function makeTransport(
48
47
  ): MockTransport {
49
48
  return {
50
49
  readyState,
51
- retryCount: 0,
52
50
  reconnect: vi.fn(),
53
51
  close: vi.fn(),
54
52
  send: vi.fn(),
@@ -57,9 +55,12 @@ function makeTransport(
57
55
  };
58
56
  }
59
57
 
60
- function makeRuntimeManager(isHealthy = vi.fn().mockResolvedValue(true)) {
58
+ function makeRuntimeManager(
59
+ reconcileFromHealth = vi.fn().mockResolvedValue(true),
60
+ ) {
61
61
  return {
62
- isHealthy,
62
+ reconcileFromHealth,
63
+ probeHealth: vi.fn().mockResolvedValue(true),
63
64
  getWsURL: () => new URL("ws://localhost/ws"),
64
65
  waitForHealthy: vi.fn().mockResolvedValue(undefined),
65
66
  isSameOrigin: true,
@@ -4,50 +4,22 @@ import { afterEach, describe, expect, it, vi } from "vitest";
4
4
  import { Logger } from "@/utils/Logger";
5
5
  import { WebSocketClosedReason, WebSocketState } from "../types";
6
6
  import { classifyCloseEvent } from "../useMarimoKernelConnection";
7
- import { MAX_RETRIES } from "../useWebSocket";
8
7
 
9
- function classify(
10
- reason: string | undefined,
11
- retryCount = 0,
12
- maxRetries = MAX_RETRIES,
13
- ) {
14
- return classifyCloseEvent({ reason }, { retryCount, maxRetries });
8
+ function classify(reason: string | undefined) {
9
+ return classifyCloseEvent({ reason });
15
10
  }
16
11
 
17
12
  describe("classifyCloseEvent", () => {
18
13
  describe("transient closes (default branch)", () => {
19
- it("retries when retryCount < maxRetries", () => {
20
- const decision = classify(undefined, 0);
14
+ it("retries on empty/undefined reason", () => {
15
+ const decision = classify(undefined);
21
16
  expect(decision.kind).toBe("retry");
22
17
  expect(decision.status).toEqual({ state: WebSocketState.CONNECTING });
23
18
  });
24
19
 
25
- it("retries on each intermediate close event during a retry storm", () => {
26
- for (let n = 0; n < MAX_RETRIES; n++) {
27
- const decision = classify(undefined, n);
28
- expect(decision.kind).toBe("retry");
29
- expect(decision.status).toEqual({ state: WebSocketState.CONNECTING });
30
- }
31
- });
32
-
33
- it("transitions to CLOSED when retryCount reaches maxRetries", () => {
34
- const decision = classify(undefined, MAX_RETRIES);
35
- expect(decision.kind).toBe("gave-up");
36
- expect(decision.status).toEqual({
37
- state: WebSocketState.CLOSED,
38
- code: WebSocketClosedReason.KERNEL_DISCONNECTED,
39
- reason: "kernel not found",
40
- });
41
- });
42
-
43
- it("transitions to CLOSED when retryCount exceeds maxRetries", () => {
44
- const decision = classify(undefined, MAX_RETRIES + 5);
45
- expect(decision.kind).toBe("gave-up");
46
- });
47
-
48
20
  it("treats unknown reason strings as transient and logs a warning", () => {
49
21
  const logger = vi.spyOn(Logger, "warn").mockImplementation(() => {});
50
- const decision = classify("something-else", 3);
22
+ const decision = classify("something-else");
51
23
  expect(decision.kind).toBe("retry");
52
24
  expect(logger).toHaveBeenCalled();
53
25
  logger.mockRestore();
@@ -60,7 +32,7 @@ describe("classifyCloseEvent", () => {
60
32
 
61
33
  describe("terminal closes (server-initiated)", () => {
62
34
  it("MARIMO_ALREADY_CONNECTED → terminal + closeTransport, with takeover", () => {
63
- const decision = classify("MARIMO_ALREADY_CONNECTED", 0);
35
+ const decision = classify("MARIMO_ALREADY_CONNECTED");
64
36
  expect(decision.kind).toBe("terminal");
65
37
  expect(decision.status).toMatchObject({
66
38
  state: WebSocketState.CLOSED,
@@ -79,7 +51,7 @@ describe("classifyCloseEvent", () => {
79
51
  "MARIMO_NO_SESSION",
80
52
  "MARIMO_SHUTDOWN",
81
53
  ])("%s → terminal with KERNEL_DISCONNECTED, closes transport", (reason) => {
82
- const decision = classify(reason, 0);
54
+ const decision = classify(reason);
83
55
  expect(decision.kind).toBe("terminal");
84
56
  expect(decision.status).toMatchObject({
85
57
  state: WebSocketState.CLOSED,
@@ -91,7 +63,7 @@ describe("classifyCloseEvent", () => {
91
63
  });
92
64
 
93
65
  it("MARIMO_MALFORMED_QUERY → terminal but does NOT close transport", () => {
94
- const decision = classify("MARIMO_MALFORMED_QUERY", 0);
66
+ const decision = classify("MARIMO_MALFORMED_QUERY");
95
67
  expect(decision.kind).toBe("terminal");
96
68
  expect(decision.status).toMatchObject({
97
69
  state: WebSocketState.CLOSED,
@@ -103,7 +75,7 @@ describe("classifyCloseEvent", () => {
103
75
  });
104
76
 
105
77
  it("MARIMO_KERNEL_STARTUP_ERROR → terminal + closeTransport", () => {
106
- const decision = classify("MARIMO_KERNEL_STARTUP_ERROR", 0);
78
+ const decision = classify("MARIMO_KERNEL_STARTUP_ERROR");
107
79
  expect(decision.kind).toBe("terminal");
108
80
  expect(decision.status).toMatchObject({
109
81
  state: WebSocketState.CLOSED,
@@ -113,25 +85,17 @@ describe("classifyCloseEvent", () => {
113
85
  expect(decision.closeTransport).toBe(true);
114
86
  }
115
87
  });
116
-
117
- it("terminal closes ignore retryCount entirely", () => {
118
- const decision = classify("MARIMO_SHUTDOWN", 99);
119
- expect(decision.kind).toBe("terminal");
120
- });
121
88
  });
122
89
 
123
- describe("retry budget exhaustion", () => {
124
- it("yields retry on attempts 1..maxRetries-1 and gave-up on the final close", () => {
125
- const states: string[] = [];
126
- for (let attempt = 1; attempt <= MAX_RETRIES; attempt++) {
127
- states.push(classify(undefined, attempt - 1).kind);
128
- }
129
- states.push(classify(undefined, MAX_RETRIES).kind);
130
-
131
- expect(states).toEqual([
132
- ...Array.from({ length: MAX_RETRIES }, () => "retry"),
133
- "gave-up",
134
- ]);
90
+ describe("transport exhaustion", () => {
91
+ it("MARIMO_TRANSPORT_EXHAUSTED gave-up with KERNEL_DISCONNECTED", () => {
92
+ const decision = classify("MARIMO_TRANSPORT_EXHAUSTED");
93
+ expect(decision.kind).toBe("gave-up");
94
+ expect(decision.status).toEqual({
95
+ state: WebSocketState.CLOSED,
96
+ code: WebSocketClosedReason.KERNEL_DISCONNECTED,
97
+ reason: "kernel not found",
98
+ });
135
99
  });
136
100
  });
137
101
  });
@@ -0,0 +1,125 @@
1
+ /* Copyright 2026 Marimo. All rights reserved. */
2
+
3
+ import { beforeEach, describe, expect, it, vi } from "vitest";
4
+ import { MAX_RETRIES, WsTransport, TRANSPORT_EXHAUSTED_REASON } from "../ws";
5
+
6
+ let innerListeners: Record<string, ((e: unknown) => void)[]>;
7
+
8
+ vi.mock("partysocket/ws", () => {
9
+ class FakeReconnectingWebSocket {
10
+ retryCount = 0;
11
+ readyState = WebSocket.CONNECTING;
12
+ constructor() {
13
+ innerListeners = { open: [], close: [], message: [], error: [] };
14
+ }
15
+ addEventListener(event: string, cb: (e: unknown) => void) {
16
+ innerListeners[event].push(cb);
17
+ }
18
+ removeEventListener(event: string, cb: (e: unknown) => void) {
19
+ innerListeners[event] = innerListeners[event].filter((c) => c !== cb);
20
+ }
21
+ reconnect() {}
22
+ close() {}
23
+ send() {}
24
+ }
25
+ return { default: FakeReconnectingWebSocket };
26
+ });
27
+
28
+ interface FakeReconnectingWebSocket {
29
+ retryCount: number;
30
+ readyState: number;
31
+ }
32
+
33
+ function dispatchClose(reason = "") {
34
+ const evt = new CloseEvent("close", { reason, code: 1006 });
35
+ for (const cb of innerListeners.close) {
36
+ cb(evt);
37
+ }
38
+ }
39
+
40
+ describe("WsTransport", () => {
41
+ let transport: WsTransport;
42
+ let inner: FakeReconnectingWebSocket;
43
+
44
+ beforeEach(() => {
45
+ transport = new WsTransport(() => "ws://example.invalid/ws");
46
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
47
+ inner = (transport as any).inner;
48
+ });
49
+
50
+ describe("close event reason", () => {
51
+ it("forwards the original reason before retry budget is exhausted", () => {
52
+ const seen: CloseEvent[] = [];
53
+ transport.addEventListener("close", (e) => seen.push(e));
54
+
55
+ inner.retryCount = MAX_RETRIES - 1;
56
+ dispatchClose("");
57
+
58
+ expect(seen).toHaveLength(1);
59
+ expect(seen[0].reason).toBe("");
60
+ });
61
+
62
+ it("rewrites reason to MARIMO_TRANSPORT_EXHAUSTED on exhaustion", () => {
63
+ const seen: CloseEvent[] = [];
64
+ transport.addEventListener("close", (e) => seen.push(e));
65
+
66
+ inner.retryCount = MAX_RETRIES;
67
+ dispatchClose("");
68
+
69
+ expect(seen).toHaveLength(1);
70
+ expect(seen[0].reason).toBe(TRANSPORT_EXHAUSTED_REASON);
71
+ });
72
+
73
+ it("does not rewrite a server-sent reason on exhaustion", () => {
74
+ // If partysocket happens to deliver a real MARIMO_* reason at the same
75
+ // moment the retry budget exhausts, the exhausted-state rewrite still
76
+ // wins because the wrapper keys off retryCount, not the original reason.
77
+ // Document the behavior so a future change is deliberate.
78
+ const seen: CloseEvent[] = [];
79
+ transport.addEventListener("close", (e) => seen.push(e));
80
+
81
+ inner.retryCount = MAX_RETRIES;
82
+ dispatchClose("MARIMO_SHUTDOWN");
83
+
84
+ expect(seen[0].reason).toBe(TRANSPORT_EXHAUSTED_REASON);
85
+ });
86
+ });
87
+
88
+ describe("addEventListener dedupe", () => {
89
+ it("does not double-fire when the same close listener is added twice", () => {
90
+ const cb = vi.fn();
91
+ transport.addEventListener("close", cb);
92
+ transport.addEventListener("close", cb);
93
+
94
+ dispatchClose("");
95
+
96
+ expect(cb).toHaveBeenCalledTimes(1);
97
+ });
98
+
99
+ it("a single removeEventListener fully unregisters a duplicated add", () => {
100
+ const cb = vi.fn();
101
+ transport.addEventListener("close", cb);
102
+ transport.addEventListener("close", cb);
103
+ transport.removeEventListener("close", cb);
104
+
105
+ dispatchClose("");
106
+
107
+ expect(cb).not.toHaveBeenCalled();
108
+ // Inner socket has no orphaned wrappers left.
109
+ expect(innerListeners.close).toHaveLength(0);
110
+ });
111
+ });
112
+
113
+ describe("removeEventListener", () => {
114
+ it("unregisters the right wrapper for close listeners", () => {
115
+ const cb = vi.fn();
116
+ transport.addEventListener("close", cb);
117
+ transport.removeEventListener("close", cb);
118
+
119
+ inner.retryCount = MAX_RETRIES;
120
+ dispatchClose("");
121
+
122
+ expect(cb).not.toHaveBeenCalled();
123
+ });
124
+ });
125
+ });
@@ -43,9 +43,7 @@ export class BasicTransport implements IConnectionTransport {
43
43
  return WebSocket.OPEN;
44
44
  }
45
45
 
46
- readonly retryCount = 0;
47
-
48
- reconnect(code?: number | undefined, reason?: string | undefined): void {
46
+ reconnect(_code?: number | undefined, _reason?: string | undefined): void {
49
47
  this.close();
50
48
  this.connect();
51
49
  return;
@@ -25,7 +25,6 @@ export interface IConnectionTransport {
25
25
  callback: ConnectionTransportCallback<T>,
26
26
  ): void;
27
27
  readyState: WebSocket["readyState"];
28
- readonly retryCount: number;
29
28
  }
30
29
 
31
30
  export class ConnectionSubscriptions {
@@ -0,0 +1,96 @@
1
+ /* Copyright 2026 Marimo. All rights reserved. */
2
+
3
+ import ReconnectingWebSocket from "partysocket/ws";
4
+ import type {
5
+ ConnectionEvent,
6
+ ConnectionTransportCallback,
7
+ IConnectionTransport,
8
+ } from "./transport";
9
+
10
+ // Per-`reconnect()` retry budget. After exhaustion, partysocket stops silently;
11
+ // the wrapper rewrites the close-event reason to surface the give-up.
12
+ export const MAX_RETRIES = 10;
13
+
14
+ export const TRANSPORT_EXHAUSTED_REASON = "MARIMO_TRANSPORT_EXHAUSTED";
15
+
16
+ export class WsTransport implements IConnectionTransport {
17
+ private inner: ReconnectingWebSocket;
18
+ private closeWrappers = new WeakMap<
19
+ ConnectionTransportCallback<"close">,
20
+ ConnectionTransportCallback<"close">
21
+ >();
22
+
23
+ constructor(urlProvider: () => string) {
24
+ this.inner = new ReconnectingWebSocket(urlProvider, undefined, {
25
+ maxRetries: MAX_RETRIES,
26
+ debug: false,
27
+ startClosed: true,
28
+ // long timeout — the server can become slow when many notebooks are open.
29
+ connectionTimeout: 10_000,
30
+ });
31
+ }
32
+
33
+ get readyState(): WebSocket["readyState"] {
34
+ return this.inner.readyState as WebSocket["readyState"];
35
+ }
36
+
37
+ reconnect(code?: number, reason?: string): void {
38
+ this.inner.reconnect(code, reason);
39
+ }
40
+
41
+ close(): void {
42
+ this.inner.close();
43
+ }
44
+
45
+ send(data: string | ArrayBuffer | Blob | ArrayBufferView): void {
46
+ this.inner.send(data);
47
+ }
48
+
49
+ addEventListener<T extends ConnectionEvent>(
50
+ event: T,
51
+ callback: ConnectionTransportCallback<T>,
52
+ ): void {
53
+ if (event === "close") {
54
+ const userCb = callback as ConnectionTransportCallback<"close">;
55
+ // Match native EventTarget dedupe: a second addEventListener with the
56
+ // same listener is a no-op. Without this, repeated adds leak wrappers
57
+ // on the inner socket and double-fire on close.
58
+ if (this.closeWrappers.has(userCb)) {
59
+ return;
60
+ }
61
+ const wrapper: ConnectionTransportCallback<"close"> = (e) => {
62
+ if (this.inner.retryCount >= MAX_RETRIES) {
63
+ userCb(
64
+ new CloseEvent("close", {
65
+ code: e.code,
66
+ reason: TRANSPORT_EXHAUSTED_REASON,
67
+ wasClean: e.wasClean,
68
+ }),
69
+ );
70
+ } else {
71
+ userCb(e);
72
+ }
73
+ };
74
+ this.closeWrappers.set(userCb, wrapper);
75
+ this.inner.addEventListener("close", wrapper);
76
+ return;
77
+ }
78
+ this.inner.addEventListener(event, callback as never);
79
+ }
80
+
81
+ removeEventListener<T extends ConnectionEvent>(
82
+ event: T,
83
+ callback: ConnectionTransportCallback<T>,
84
+ ): void {
85
+ if (event === "close") {
86
+ const userCb = callback as ConnectionTransportCallback<"close">;
87
+ const wrapper = this.closeWrappers.get(userCb);
88
+ if (wrapper) {
89
+ this.closeWrappers.delete(userCb);
90
+ this.inner.removeEventListener("close", wrapper);
91
+ }
92
+ return;
93
+ }
94
+ this.inner.removeEventListener(event, callback as never);
95
+ }
96
+ }