@marimo-team/frontend 0.23.3-dev39 → 0.23.3-dev41

package/src/core/static/__tests__/export-context.test.ts

@@ -0,0 +1,122 @@
+/* Copyright 2026 Marimo. All rights reserved. */
+// @vitest-environment jsdom
+
+import type { ExtractAtomValue } from "jotai";
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
+import { hasRunAnyCellAtom } from "@/components/editor/cell/useRunCells";
+import { userConfigAtom } from "@/core/config/config";
+import { parseUserConfig } from "@/core/config/config-schema";
+import { initialModeAtom } from "@/core/mode";
+import { store } from "@/core/state/jotai";
+import {
+  getMarimoExportContext,
+  hasTrustedExportContext,
+  hasTrustedNotebookContext,
+} from "../export-context";
+
+type ExportContextWindow = Window & {
+  __MARIMO_EXPORT_CONTEXT__?: {
+    trusted: boolean;
+    notebookCode?: string;
+  };
+};
+
+function setAutoInstantiate(value: boolean) {
+  const cleared = parseUserConfig({});
+  store.set(userConfigAtom, {
+    ...cleared,
+    runtime: { ...cleared.runtime, auto_instantiate: value },
+  });
+}
+
+describe("hasTrustedNotebookContext", () => {
+  let previousHasRunAnyCell: ExtractAtomValue<typeof hasRunAnyCellAtom>;
+  let previousConfig: ExtractAtomValue<typeof userConfigAtom>;
+  let previousMode: ExtractAtomValue<typeof initialModeAtom>;
+  let w: ExportContextWindow;
+
+  beforeEach(() => {
+    w = window as ExportContextWindow;
+    previousHasRunAnyCell = store.get(hasRunAnyCellAtom);
+    previousConfig = store.get(userConfigAtom);
+    previousMode = store.get(initialModeAtom);
+    store.set(hasRunAnyCellAtom, false);
+    setAutoInstantiate(false);
+    store.set(initialModeAtom, "edit");
+    delete w.__MARIMO_EXPORT_CONTEXT__;
+  });
+
+  afterEach(() => {
+    store.set(hasRunAnyCellAtom, previousHasRunAnyCell);
+    store.set(userConfigAtom, previousConfig);
+    store.set(initialModeAtom, previousMode);
+    delete w.__MARIMO_EXPORT_CONTEXT__;
+  });
+
+  it("returns false in untrusted edit mode before interaction", () => {
+    expect(hasTrustedNotebookContext()).toBe(false);
+  });
+
+  it("returns true once the user has run a cell", () => {
+    store.set(hasRunAnyCellAtom, true);
+    expect(hasTrustedNotebookContext()).toBe(true);
+  });
+
+  it("returns true when a trusted export context is installed", () => {
+    w.__MARIMO_EXPORT_CONTEXT__ = { trusted: true };
+    expect(hasTrustedNotebookContext()).toBe(true);
+  });
+
+  it("returns true when auto_instantiate is enabled", () => {
+    setAutoInstantiate(true);
+    expect(hasTrustedNotebookContext()).toBe(true);
+  });
+
+  it("returns true in read mode", () => {
+    store.set(initialModeAtom, "read");
+    expect(hasTrustedNotebookContext()).toBe(true);
+  });
+
+  it("returns false if initialMode throws (config not yet applied)", () => {
+    store.set(initialModeAtom, undefined);
+    expect(hasTrustedNotebookContext()).toBe(false);
+  });
+});
+
+describe("hasTrustedExportContext / getMarimoExportContext shape validation", () => {
+  let w: ExportContextWindow;
+
+  beforeEach(() => {
+    w = window as ExportContextWindow;
+    delete w.__MARIMO_EXPORT_CONTEXT__;
+  });
+
+  afterEach(() => {
+    delete w.__MARIMO_EXPORT_CONTEXT__;
+  });
+
+  it("accepts a valid context", () => {
+    w.__MARIMO_EXPORT_CONTEXT__ = { trusted: true, notebookCode: "x = 1" };
+    expect(hasTrustedExportContext()).toBe(true);
+    expect(getMarimoExportContext()).toEqual({
+      trusted: true,
+      notebookCode: "x = 1",
+    });
+  });
+
+  it("rejects a context where `trusted` is not exactly true", () => {
+    w.__MARIMO_EXPORT_CONTEXT__ = {
+      trusted: "yes" as unknown as true,
+    };
+    expect(hasTrustedExportContext()).toBe(false);
+    expect(getMarimoExportContext()).toBeUndefined();
+  });
+
+  it("rejects a context with non-string notebookCode", () => {
+    w.__MARIMO_EXPORT_CONTEXT__ = {
+      trusted: true,
+      notebookCode: 42 as unknown as string,
+    };
+    expect(getMarimoExportContext()).toBeUndefined();
+  });
+});

package/src/core/static/__tests__/static-state.test.ts

@@ -0,0 +1,80 @@
+/* Copyright 2026 Marimo. All rights reserved. */
+// @vitest-environment jsdom
+
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
+import {
+  getStaticModelNotifications,
+  getStaticVirtualFiles,
+  isStaticNotebook,
+} from "../static-state";
+
+function setMarimoStatic(value: unknown): void {
+  (window as unknown as { __MARIMO_STATIC__?: unknown }).__MARIMO_STATIC__ =
+    value;
+}
+
+function clearMarimoStatic(): void {
+  delete (window as unknown as { __MARIMO_STATIC__?: unknown })
+    .__MARIMO_STATIC__;
+}
+
+describe("static-state shape validation", () => {
+  beforeEach(() => {
+    clearMarimoStatic();
+  });
+
+  afterEach(() => {
+    clearMarimoStatic();
+  });
+
+  it("treats an absent global as not-a-static-notebook", () => {
+    expect(isStaticNotebook()).toBe(false);
+    expect(getStaticModelNotifications()).toBeUndefined();
+  });
+
+  it("accepts a well-formed state", () => {
+    setMarimoStatic({
+      files: { "/@file/a.txt": "data:text/plain;base64,YQ==" },
+      modelNotifications: [],
+    });
+    expect(isStaticNotebook()).toBe(true);
+    expect(getStaticVirtualFiles()).toEqual({
+      "/@file/a.txt": "data:text/plain;base64,YQ==",
+    });
+    expect(getStaticModelNotifications()).toEqual([]);
+  });
+
+  it("rejects a malformed global (missing files)", () => {
+    setMarimoStatic({ modelNotifications: [] });
+    expect(isStaticNotebook()).toBe(false);
+    expect(getStaticModelNotifications()).toBeUndefined();
+  });
+
+  it("rejects a malformed global (non-array modelNotifications)", () => {
+    setMarimoStatic({ files: {}, modelNotifications: "oops" });
+    expect(isStaticNotebook()).toBe(false);
+  });
+
+  it("rejects a non-object global", () => {
+    setMarimoStatic("pwned");
+    expect(isStaticNotebook()).toBe(false);
+  });
+
+  it("rejects an array as the state", () => {
+    setMarimoStatic([]);
+    expect(isStaticNotebook()).toBe(false);
+  });
+
+  it("rejects files when it is an array", () => {
+    setMarimoStatic({ files: [], modelNotifications: [] });
+    expect(isStaticNotebook()).toBe(false);
+  });
+
+  it("rejects files that contain non-string values", () => {
+    setMarimoStatic({
+      files: { "/@file/a.txt": 42 },
+      modelNotifications: [],
+    });
+    expect(isStaticNotebook()).toBe(false);
+  });
+});

package/src/core/static/export-context.ts

@@ -1,5 +1,10 @@
 /* Copyright 2026 Marimo. All rights reserved. */
 
+import { hasRunAnyCellAtom } from "@/components/editor/cell/useRunCells";
+import { autoInstantiateAtom } from "@/core/config/config";
+import { getInitialAppMode } from "@/core/mode";
+import { store } from "@/core/state/jotai";
+
 export interface MarimoExportContext {
   trusted: true;
   notebookCode?: string;
@@ -41,3 +46,39 @@ export function getMarimoExportContext():
 export function hasTrustedExportContext(): boolean {
   return getMarimoExportContext()?.trusted === true;
 }
+
+/**
+ * True when the current page is a context where notebook-authored script
+ * execution is expected, and therefore the user has consented (explicitly or
+ * by the nature of the page) to running arbitrary notebook content:
+ *
+ * - the user has run at least one cell, OR
+ * - a first-party exported notebook page installed a trusted export context
+ *   (islands / static exports / Quarto islands), OR
+ * - `auto_instantiate` is enabled (the notebook runs on page load by user
+ *   configuration), OR
+ * - the page was loaded in `read` / app mode (served by marimo as an app).
+ *
+ * Edit mode before any user interaction is intentionally NOT trusted — that
+ * is the only surface where we must prevent notebook-authored content from
+ * loading scripts or bypassing HTML sanitization.
+ */
+export function hasTrustedNotebookContext(): boolean {
+  if (store.get(hasRunAnyCellAtom)) {
+    return true;
+  }
+  if (hasTrustedExportContext()) {
+    return true;
+  }
+  if (store.get(autoInstantiateAtom)) {
+    return true;
+  }
+  try {
+    if (getInitialAppMode() === "read") {
+      return true;
+    }
+  } catch {
+    // getInitialAppMode throws before mount config is applied; treat as untrusted.
+  }
+  return false;
+}

package/src/core/static/static-state.ts

@@ -5,20 +5,58 @@ import type { MarimoStaticState, StaticVirtualFiles } from "./types";
 
 declare global {
   interface Window {
-    __MARIMO_STATIC__?: MarimoStaticState;
+    __MARIMO_STATIC__?: Readonly<MarimoStaticState>;
   }
 }
 
+function isStringToStringRecord(
+  value: unknown,
+): value is Record<string, string> {
+  if (typeof value !== "object" || value === null || Array.isArray(value)) {
+    return false;
+  }
+  for (const entry of Object.values(value)) {
+    if (typeof entry !== "string") {
+      return false;
+    }
+  }
+  return true;
+}
+
+function isMarimoStaticState(
+  value: unknown,
+): value is Readonly<MarimoStaticState> {
+  if (typeof value !== "object" || value === null || Array.isArray(value)) {
+    return false;
+  }
+  const candidate = value as MarimoStaticState;
+  if (!isStringToStringRecord(candidate.files)) {
+    return false;
+  }
+  if (
+    candidate.modelNotifications !== undefined &&
+    !Array.isArray(candidate.modelNotifications)
+  ) {
+    return false;
+  }
+  return true;
+}
+
+function getMarimoStaticState(): Readonly<MarimoStaticState> | undefined {
+  const state = window?.__MARIMO_STATIC__;
+  return isMarimoStaticState(state) ? state : undefined;
+}
+
 export function isStaticNotebook(): boolean {
-  return window?.__MARIMO_STATIC__ !== undefined;
+  return getMarimoStaticState() !== undefined;
 }
 
 export function getStaticVirtualFiles(): StaticVirtualFiles {
-  invariant(window.__MARIMO_STATIC__ !== undefined, "Not a static notebook");
-
-  return window.__MARIMO_STATIC__.files;
+  const state = getMarimoStaticState();
+  invariant(state !== undefined, "Not a static notebook");
+  return state.files;
 }
 
 export function getStaticModelNotifications(): ModelLifecycle[] | undefined {
-  return window?.__MARIMO_STATIC__?.modelNotifications;
+  return getMarimoStaticState()?.modelNotifications;
 }

package/src/plugins/core/RenderHTML.tsx

@@ -16,6 +16,8 @@ import { CopyClipboardIcon } from "@/components/icons/copy-icon";
 import { QueryParamPreservingLink } from "@/components/ui/query-param-preserving-link";
 import { Tooltip } from "@/components/ui/tooltip";
 import { DocHoverTarget } from "@/core/documentation/DocHoverTarget";
+import { hasTrustedNotebookContext } from "@/core/static/export-context";
+import { Logger } from "@/utils/Logger";
 import { sanitizeHtml, useSanitizeHtml } from "./sanitize";
 
 type ReplacementFn = NonNullable<HTMLReactParserOptions["replace"]>;
@@ -98,8 +100,27 @@ const replaceSrcScripts = (domNode: DOMNode): JSX.Element | undefined => {
     if (!src) {
       return;
     }
-    // Check if script already exists
-    if (!document.querySelector(`script[src="${src}"]`)) {
+    // Only append notebook-authored scripts when the page is a trusted
+    // context (the user has run a cell, the page is a trusted export, or
+    // we're running in read/app mode). In untrusted edit mode before any
+    // user interaction, drop the script and log a warning. Outer
+    // sanitization will normally strip <script> tags already; this is
+    // defense-in-depth for flows that reparse children with
+    // alwaysSanitizeHtml: false (see registerReactComponent.getChildren).
+    if (!hasTrustedNotebookContext()) {
+      Logger.warn(
+        `[RenderHTML] refusing <script src> in untrusted context: ${src}`,
+      );
+      // oxlint-disable-next-line react/jsx-no-useless-fragment
+      return <></>;
+    }
+    // Check if script already exists. Avoid building a CSS selector from
+    // notebook-provided input, which can throw for valid URLs containing
+    // selector-significant characters (e.g. IPv6 hosts with `[`/`]`).
+    const scriptExists = [...document.querySelectorAll("script[src]")].some(
+      (existingScript) => existingScript.getAttribute("src") === src,
+    );
+    if (!scriptExists) {
       const script = document.createElement("script");
       script.src = src;
       document.head.append(script);

package/src/plugins/core/__test__/RenderHTML.test.ts

@@ -1,5 +1,11 @@
 /* Copyright 2026 Marimo. All rights reserved. */
-import { describe, expect, test } from "vitest";
+import type { ExtractAtomValue } from "jotai";
+import { afterEach, beforeEach, describe, expect, test } from "vitest";
+import { hasRunAnyCellAtom } from "@/components/editor/cell/useRunCells";
+import { userConfigAtom } from "@/core/config/config";
+import { parseUserConfig } from "@/core/config/config-schema";
+import { initialModeAtom } from "@/core/mode";
+import { store } from "@/core/state/jotai";
 import { visibleForTesting } from "../RenderHTML";
 
 const { parseHtml } = visibleForTesting;
@@ -197,6 +203,85 @@ describe("parseHtml", () => {
   });
 });
 
+describe("replaceSrcScripts trust gate", () => {
+  let previousHasRunAnyCell: ExtractAtomValue<typeof hasRunAnyCellAtom>;
+  let previousConfig: ExtractAtomValue<typeof userConfigAtom>;
+  let previousMode: ExtractAtomValue<typeof initialModeAtom>;
+  const windowWithExport = window as Window & {
+    __MARIMO_EXPORT_CONTEXT__?: unknown;
+  };
+
+  function clearTrustSignals() {
+    const cleared = parseUserConfig({});
+    store.set(hasRunAnyCellAtom, false);
+    store.set(userConfigAtom, {
+      ...cleared,
+      runtime: { ...cleared.runtime, auto_instantiate: false },
+    });
+    store.set(initialModeAtom, "edit");
+    delete windowWithExport.__MARIMO_EXPORT_CONTEXT__;
+  }
+
+  beforeEach(() => {
+    previousHasRunAnyCell = store.get(hasRunAnyCellAtom);
+    previousConfig = store.get(userConfigAtom);
+    previousMode = store.get(initialModeAtom);
+    clearTrustSignals();
+    for (const s of document.head.querySelectorAll(
+      'script[src^="https://cdn.example.com/"]',
+    )) {
+      s.remove();
+    }
+  });
+
+  afterEach(() => {
+    store.set(hasRunAnyCellAtom, previousHasRunAnyCell);
+    store.set(userConfigAtom, previousConfig);
+    store.set(initialModeAtom, previousMode);
+    delete windowWithExport.__MARIMO_EXPORT_CONTEXT__;
+    for (const s of document.head.querySelectorAll(
+      'script[src^="https://cdn.example.com/"]',
+    )) {
+      s.remove();
+    }
+  });
+
+  test("drops <script src> in untrusted edit mode", () => {
+    parseHtml({
+      html: '<script src="https://cdn.example.com/unrun.js"></script>',
+    });
+    expect(
+      document.head.querySelector(
+        'script[src="https://cdn.example.com/unrun.js"]',
+      ),
+    ).toBeNull();
+  });
+
+  test("loads <script src> once a cell has been run", () => {
+    store.set(hasRunAnyCellAtom, true);
+    parseHtml({
+      html: '<script src="https://cdn.example.com/ok.js"></script>',
+    });
+    expect(
+      document.head.querySelector(
+        'script[src="https://cdn.example.com/ok.js"]',
+      ),
+    ).not.toBeNull();
+  });
+
+  test("loads <script src> when a trusted export context is installed", () => {
+    windowWithExport.__MARIMO_EXPORT_CONTEXT__ = { trusted: true };
+    parseHtml({
+      html: '<script src="https://cdn.example.com/export.js"></script>',
+    });
+    expect(
+      document.head.querySelector(
+        'script[src="https://cdn.example.com/export.js"]',
+      ),
+    ).not.toBeNull();
+  });
+});
+
 describe("wrapTooltipTargets", () => {
   test("data-tooltip wraps element in Tooltip component", () => {
     const html = '<span data-tooltip="Hello world">Hover me</span>';

package/src/plugins/core/sanitize.ts

@@ -3,25 +3,31 @@ import { atom, useAtomValue } from "jotai";
 import { hasRunAnyCellAtom } from "@/components/editor/cell/useRunCells";
 import { autoInstantiateAtom } from "@/core/config/config";
 import { getInitialAppMode } from "@/core/mode";
+import { hasTrustedExportContext } from "@/core/static/export-context";
 
 // Re-export so existing consumers don't break.
 export { sanitizeHtml } from "./sanitize-html";
 
 /**
- * Whether to sanitize the html.
- * When running as an app or with auto_instantiate enabled
- * we ignore sanitization because they should be treated as a website.
+ * Whether to sanitize the html. Trust signals match
+ * `hasTrustedNotebookContext` in `@/core/static/export-context`.
+ * Kept as a jotai atom so consumers re-render when `hasRunAnyCellAtom`
+ * flips after the user runs a cell.
  */
 const sanitizeHtmlAtom = atom<boolean>((get) => {
   const hasRunAnyCell = get(hasRunAnyCellAtom);
   const autoInstantiate = get(autoInstantiateAtom);
 
-  // If a user has specifically run at least one cell or auto_instantiate is enabled, we don't need to sanitize.
-  // HTML needs to be rich to allow for interactive widgets and other dynamic content.
   if (hasRunAnyCell || autoInstantiate) {
     return false;
   }
 
+  // Trusted export context is installed once at page load by a first-party
+  // script (frozen + non-configurable), so a direct read is safe and stable.
+  if (hasTrustedExportContext()) {
+    return false;
+  }
+
   let isInAppMode = true;
   try {
     isInAppMode = getInitialAppMode() === "read";

package/src/plugins/core/trusted-url.ts

@@ -37,6 +37,15 @@ export function isTrustedVirtualFileUrl(url: unknown): url is string {
   return false;
 }
 
+/**
+ * Intentionally narrower than `hasTrustedNotebookContext` in
+ * `@/core/static/export-context`: `auto_instantiate` and `read` mode are
+ * deliberately excluded here. Both can be triggered by DOM-observable page
+ * shape, and accepting inline base64 `data:` JS/CSS payloads on their
+ * strength would let a hostile notebook page smuggle attacker-controlled
+ * script into the same origin. Keep this gate tied only to "user actively
+ * ran a cell" or "first-party exporter installed a trusted runtime marker".
+ */
 function hasNotebookTrustedDataUrlContext(): boolean {
   return store.get(hasRunAnyCellAtom) || hasTrustedExportContext();
 }