@marimo-team/frontend 0.23.10-dev64 → 0.23.10-dev65

package/dist/index.html

@@ -66,7 +66,7 @@
     <marimo-server-token data-token="{{ server_token }}" hidden></marimo-server-token>
     <!-- /TODO -->
     <title>{{ title }}</title>
-    <script type="module" crossorigin src="./assets/index-BvEFiwY5.js"></script>
+    <script type="module" crossorigin src="./assets/index-BZRM-y7i.js"></script>
     <link rel="modulepreload" crossorigin href="./assets/preload-helper-BPPi7vOr.js">
     <link rel="modulepreload" crossorigin href="./assets/chunk-LvLJmgfZ.js">
     <link rel="modulepreload" crossorigin href="./assets/react-Bj1aDYRI.js">
@@ -133,7 +133,7 @@
     <link rel="modulepreload" crossorigin href="./assets/debounce-DhnxH9Rh.js">
     <link rel="modulepreload" crossorigin href="./assets/database-zap-kIkTfzTX.js">
     <link rel="modulepreload" crossorigin href="./assets/main-B0OX4z33.js">
-    <link rel="modulepreload" crossorigin href="./assets/cells-CoFnpuSu.js">
+    <link rel="modulepreload" crossorigin href="./assets/cells-qr7uuILQ.js">
     <link rel="modulepreload" crossorigin href="./assets/ErrorBoundary-DyYDV0HI.js">
     <link rel="modulepreload" crossorigin href="./assets/kbd-CTUAEnEx.js">
     <link rel="modulepreload" crossorigin href="./assets/useInstallPackage-GI6gu7_S.js">
@@ -147,38 +147,38 @@
     <link rel="modulepreload" crossorigin href="./assets/usePress-DQ_tAz5W.js">
     <link rel="modulepreload" crossorigin href="./assets/input-DA8xlX70.js">
     <link rel="modulepreload" crossorigin href="./assets/ImperativeModal-BW1dmntO.js">
-    <link rel="modulepreload" crossorigin href="./assets/cell-link-iYZiKtn4.js">
+    <link rel="modulepreload" crossorigin href="./assets/cell-link-DUtPozci.js">
     <link rel="modulepreload" crossorigin href="./assets/multi-map-C4OANz8X.js">
     <link rel="modulepreload" crossorigin href="./assets/alert-yTS3WpF4.js">
     <link rel="modulepreload" crossorigin href="./assets/chevron-right-CG5QYXYk.js">
     <link rel="modulepreload" crossorigin href="./assets/dropdown-menu-CZ4XbE-c.js">
     <link rel="modulepreload" crossorigin href="./assets/links-D1JoyKTt.js">
-    <link rel="modulepreload" crossorigin href="./assets/useRunCells-Ck2FcYV8.js">
+    <link rel="modulepreload" crossorigin href="./assets/useRunCells-DnEGBP6V.js">
     <link rel="modulepreload" crossorigin href="./assets/copy-LK56fFow.js">
     <link rel="modulepreload" crossorigin href="./assets/copy-BwrPA9zQ.js">
     <link rel="modulepreload" crossorigin href="./assets/copy-icon-BuRdHNPA.js">
-    <link rel="modulepreload" crossorigin href="./assets/RenderHTML-CXsJP1V5.js">
-    <link rel="modulepreload" crossorigin href="./assets/datasource-CQiCeDJW.js">
-    <link rel="modulepreload" crossorigin href="./assets/state-CHxBK47b.js">
+    <link rel="modulepreload" crossorigin href="./assets/RenderHTML-DZGu-Xkt.js">
+    <link rel="modulepreload" crossorigin href="./assets/datasource-D1OwcZkP.js">
+    <link rel="modulepreload" crossorigin href="./assets/state-DtlxvXq2.js">
     <link rel="modulepreload" crossorigin href="./assets/package-Tv6ztuzw.js">
     <link rel="modulepreload" crossorigin href="./assets/sparkles-lWUAsPhp.js">
-    <link rel="modulepreload" crossorigin href="./assets/MarimoErrorOutput-Ca2QF99G.js">
+    <link rel="modulepreload" crossorigin href="./assets/MarimoErrorOutput-DsFM0Fth.js">
     <link rel="modulepreload" crossorigin href="./assets/eye-off-Cm6DdkeR.js">
     <link rel="modulepreload" crossorigin href="./assets/refresh-cw-DHwG4Mac.js">
-    <link rel="modulepreload" crossorigin href="./assets/tree-actions-wXUHKee-.js">
+    <link rel="modulepreload" crossorigin href="./assets/tree-actions-_uZ9RGnT.js">
     <link rel="modulepreload" crossorigin href="./assets/spinner-Bhir8k53.js">
-    <link rel="modulepreload" crossorigin href="./assets/html-to-image-DkJzNEld.js">
-    <link rel="modulepreload" crossorigin href="./assets/focus-DaSvgWUb.js">
+    <link rel="modulepreload" crossorigin href="./assets/html-to-image-CpPmDraL.js">
+    <link rel="modulepreload" crossorigin href="./assets/focus-Cz5G1JXC.js">
     <link rel="modulepreload" crossorigin href="./assets/useAsyncData-bgszE9F0.js">
     <link rel="modulepreload" crossorigin href="./assets/LazyAnyLanguageCodeMirror-C7ALwTI_.js">
     <link rel="modulepreload" crossorigin href="./assets/micromark-factory-space-bqhKsQDn.js">
     <link rel="modulepreload" crossorigin href="./assets/chunk-5FQGJX7Z-D91x7QHS.js">
-    <link rel="modulepreload" crossorigin href="./assets/markdown-renderer-CU4wZzDH.js">
+    <link rel="modulepreload" crossorigin href="./assets/markdown-renderer-C1zlNjLj.js">
     <link rel="modulepreload" crossorigin href="./assets/command-BmOGG6-2.js">
     <link rel="modulepreload" crossorigin href="./assets/field-DCdxnSKm.js">
     <link rel="modulepreload" crossorigin href="./assets/popover-CNCYAwbC.js">
     <link rel="modulepreload" crossorigin href="./assets/errors-D3F5g1xA.js">
-    <link rel="modulepreload" crossorigin href="./assets/download-B10yQcVE.js">
+    <link rel="modulepreload" crossorigin href="./assets/download-BA-gn26a.js">
     <link rel="modulepreload" crossorigin href="./assets/table-BGPSHfig.js">
     <link rel="modulepreload" crossorigin href="./assets/useIframeCapabilities-CcI1zSdn.js">
     <link rel="modulepreload" crossorigin href="./assets/error-banner-D0xvrLog.js">
@@ -198,21 +198,21 @@
     <link rel="modulepreload" crossorigin href="./assets/plus-BgB18UzY.js">
     <link rel="modulepreload" crossorigin href="./assets/trash-2-rVklqqFF.js">
     <link rel="modulepreload" crossorigin href="./assets/react-resizable-panels.browser.esm-CV8-hvjx.js">
-    <link rel="modulepreload" crossorigin href="./assets/JsonOutput-YJa3UdEx.js">
+    <link rel="modulepreload" crossorigin href="./assets/JsonOutput-DXMZQNHI.js">
     <link rel="modulepreload" crossorigin href="./assets/chart-no-axes-column-nqk474t8.js">
     <link rel="modulepreload" crossorigin href="./assets/square-function-uY_yJr5g.js">
     <link rel="modulepreload" crossorigin href="./assets/spec-CPQR_o92.js">
-    <link rel="modulepreload" crossorigin href="./assets/column-preview-jXbK52Zz.js">
+    <link rel="modulepreload" crossorigin href="./assets/column-preview-BJeN5VzA.js">
     <link rel="modulepreload" crossorigin href="./assets/icons-Ol38nIbL.js">
-    <link rel="modulepreload" crossorigin href="./assets/radio-group-BfL6mbSu.js">
-    <link rel="modulepreload" crossorigin href="./assets/floating-outline-CzBp8YHO.js">
+    <link rel="modulepreload" crossorigin href="./assets/radio-group-D9xk_k2Z.js">
+    <link rel="modulepreload" crossorigin href="./assets/floating-outline-Dbc8scuT.js">
     <link rel="modulepreload" crossorigin href="./assets/objectWithoutPropertiesLoose-DfWeGRFv.js">
     <link rel="modulepreload" crossorigin href="./assets/esm-xaw4Vy8N.js">
-    <link rel="modulepreload" crossorigin href="./assets/readonly-python-code-CBOwNI3y.js">
+    <link rel="modulepreload" crossorigin href="./assets/readonly-python-code-Cc9LVJJi.js">
     <link rel="modulepreload" crossorigin href="./assets/file-headphone-BrQspHac.js">
     <link rel="modulepreload" crossorigin href="./assets/file-BrdxGLRX.js">
     <link rel="modulepreload" crossorigin href="./assets/image-DQHXdEQn.js">
-    <link rel="modulepreload" crossorigin href="./assets/file-icons-CtmUbkxd.js">
+    <link rel="modulepreload" crossorigin href="./assets/file-icons-YDksmLtd.js">
     <link rel="modulepreload" crossorigin href="./assets/switch-Ac7CgLgh.js">
     <link rel="modulepreload" crossorigin href="./assets/events-CPoJAfgx.js">
     <link rel="modulepreload" crossorigin href="./assets/globals-BivClSmn.js">
@@ -221,11 +221,11 @@
     <link rel="modulepreload" crossorigin href="./assets/memoize-Tp7rARFe.js">
     <link rel="modulepreload" crossorigin href="./assets/get-C-qh_et5.js">
     <link rel="modulepreload" crossorigin href="./assets/_baseSet-CxV9N1bc.js">
-    <link rel="modulepreload" crossorigin href="./assets/state-CsYlSJPy.js">
+    <link rel="modulepreload" crossorigin href="./assets/state-BM6G_urd.js">
     <link rel="modulepreload" crossorigin href="./assets/label-C2_YQRio.js">
-    <link rel="modulepreload" crossorigin href="./assets/textarea-DoKXC-jv.js">
+    <link rel="modulepreload" crossorigin href="./assets/textarea-D40Zybvr.js">
     <link rel="modulepreload" crossorigin href="./assets/refresh-ccw-C-n2VFP5.js">
-    <link rel="modulepreload" crossorigin href="./assets/form-DZvHiFZw.js">
+    <link rel="modulepreload" crossorigin href="./assets/form-DCJhwIUY.js">
     <link rel="modulepreload" crossorigin href="./assets/renderShortcut--ku7VECI.js">
     <link rel="modulepreload" crossorigin href="./assets/useBoolean-CE6PfxGj.js">
     <link rel="modulepreload" crossorigin href="./assets/useDeepCompareMemoize-CVmg-GkP.js">

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@marimo-team/frontend",
-  "version": "0.23.10-dev64",
+  "version": "0.23.10-dev65",
   "main": "dist/main.js",
   "types": "dist/index.d.ts",
   "type": "module",

package/src/components/editor/cell/code/cell-editor.tsx

@@ -458,8 +458,11 @@ const CellEditorInternal = ({
   // Prioritize building this cell's editor when it scrolls into view, so the
   // visible region fills in first instead of waiting for the top-to-bottom
   // queue. The margin builds cells just before they reach the viewport.
+  // uidotdev sets threshold default to 1. Set it 0 so cells are prioritized
+  // at 300px.
   const [intersectionRef, intersection] = useIntersectionObserver({
     rootMargin: "300px 0px",
+    threshold: 0,
   });
   useEffect(() => {
     if (isEditorMounted) {

package/src/components/editor/notebook-cell.tsx

@@ -58,7 +58,6 @@ import type { UserConfig } from "../../core/config/config-schema";
 import { isAppInteractionDisabled } from "../../core/websocket/connection-utils";
 import { useCellRenderCount } from "../../hooks/useCellRenderCount";
 import type { Theme } from "../../theme/useTheme";
-import { derefNotNull } from "../../utils/dereference";
 import { Functions } from "../../utils/functions";
 import { Logger } from "../../utils/Logger";
 import { renderShortcut } from "../shortcuts/renderShortcut";
@@ -233,8 +232,9 @@ export type CellComponentActions = Pick<
 export interface CellHandle {
   /**
    * The CodeMirror editor view.
+   * TODO: merge this with editorViewOrNull
    */
-  editorView: EditorView;
+  editorView: EditorView | null;
   /**
    * The CodeMirror editor view, or null if it is not yet mounted.
    */
@@ -280,7 +280,7 @@ const CellComponent = (props: CellProps) => {
     ref,
     () => ({
       get editorView() {
-        return derefNotNull(editorView);
+        return editorView.current;
       },
       get editorViewOrNull() {
         return editorView.current;

package/src/core/cells/__tests__/document-changes.test.ts

@@ -430,7 +430,7 @@ describe("toDocumentChanges", () => {
       const [a] = state.cellIds.inOrderIds;
 
       // Position cursor at end of "line1" (position 5)
-      const view = state.cellHandles[a].current!.editorView;
+      const view = state.cellHandles[a].current!.editorView!;
       view.dispatch({ selection: { anchor: 5 } });
 
       const { changes } = resolve(state, {
@@ -466,7 +466,7 @@ describe("toDocumentChanges", () => {
       const [a] = state.cellIds.inOrderIds;
 
       // Split the cell first
-      const view = state.cellHandles[a].current!.editorView;
+      const view = state.cellHandles[a].current!.editorView!;
       view.dispatch({ selection: { anchor: 5 } });
       const snapshot = view.state.doc.toString();
       state = dispatch(state, {

package/src/core/cells/utils.ts

@@ -29,7 +29,7 @@ export function notebookCells(state: NotebookState) {
 export function notebookCellEditorViews({ cellHandles }: NotebookState) {
   const views: Record<CellId, EditorView> = {};
   for (const [cell, ref] of Objects.entries(cellHandles)) {
-    if (!ref.current) {
+    if (!ref.current?.editorView) {
       continue;
     }
     views[cell] = ref.current.editorView;

package/src/core/codemirror/copilot/getCodes.ts

@@ -47,7 +47,9 @@ const notebookCellCodes = atom((get) => {
       const handle = notebook.cellHandles[id];
       return [
         id,
-        handle?.current ? getEditorCodeAsPython(handle.current.editorView) : "",
+        handle?.current?.editorView
+          ? getEditorCodeAsPython(handle.current.editorView)
+          : "",
       ];
     }),
   );

package/src/core/errors/errors.ts

@@ -18,7 +18,7 @@ export interface AutoFix {
   fixType: "manual" | "ai";
   onFix: (ctx: {
     addCodeBelow: (code: string) => void;
-    editor: EditorView | undefined;
+    editor: EditorView | null | undefined;
     cellId: CellId;
     aiFix?: AIFix;
   }) => Promise<void>;