@marcusrbrown/infra 0.13.1 → 0.13.3

package/src/commands/cliproxy/setup/providers.test.ts

@@ -1,245 +0,0 @@
-/// <reference types="bun" />
-
-import type {MultiSelectOptions, TextOptions} from '@clack/prompts'
-import {describe, expect, it, spyOn} from 'bun:test'
-
-import {parseProviders, promptForModel, promptForProviders} from './providers'
-
-// Type helper: cast a concrete-typed clack implementation to the generic spy type.
-// clack's multiselect/text/select are generic functions; Bun's spyOn preserves the
-// generic signature, so mockImplementation requires the same generic. We provide a
-// concrete instantiation and widen through `unknown` — this is safe because the
-// concrete type is a structural subtype of the generic at the call site.
-function asMultiselectImpl<V>(fn: (opts: MultiSelectOptions<V>) => Promise<V[] | symbol>) {
-  return fn as unknown as <Value>(opts: MultiSelectOptions<Value>) => Promise<Value[] | symbol>
-}
-
-function asTextImpl(fn: (opts: TextOptions) => Promise<string | symbol>) {
-  return fn as unknown as (opts: TextOptions) => Promise<string | symbol>
-}
-
-describe('option parsing', () => {
-  describe('parseProviders', () => {
-    it("parses \"anthropic,openai\" to ['anthropic', 'openai']", () => {
-      expect(parseProviders('anthropic,openai')).toEqual(['anthropic', 'openai'])
-    })
-
-    it('parses "openai" to [\'openai\']', () => {
-      expect(parseProviders('openai')).toEqual(['openai'])
-    })
-
-    it('parses "anthropic" to [\'anthropic\']', () => {
-      expect(parseProviders('anthropic')).toEqual(['anthropic'])
-    })
-
-    it('rejects duplicate providers with a "duplicate" error', () => {
-      expect(() => parseProviders('anthropic,anthropic')).toThrow(/duplicate/i)
-    })
-
-    it('rejects an empty string with a clear message', () => {
-      expect(() => parseProviders('')).toThrow()
-    })
-
-    it('rejects an unknown provider "claude" with an enum error', () => {
-      expect(() => parseProviders('claude')).toThrow()
-    })
-
-    it('trims whitespace around provider names', () => {
-      expect(parseProviders(' anthropic , openai ')).toEqual(['anthropic', 'openai'])
-    })
-
-    it('rejects "__proto__" (prototype-chain safety)', () => {
-      expect(() => parseProviders('__proto__')).toThrow()
-    })
-  })
-})
-
-describe('interactive provider/model prompts', () => {
-  // We spy on @clack/prompts functions directly since Bun's mock.module
-  // requires static hoisting. Instead we use spyOn on the imported module.
-  // The helpers call the clack functions via the module binding, so we
-  // intercept them via spyOn after importing.
-
-  // Note: Because providers.ts imports clack at module load time and calls the
-  // functions directly (not via a re-exported object), we need to use
-  // mock.module to intercept. However, Bun's mock.module must be called
-  // before the module is imported. Since providers.ts is already imported above,
-  // we test the helpers by injecting controlled behavior through the clack
-  // module mock at the describe level using beforeEach/afterEach with spyOn
-  // on the actual clack module exports.
-  //
-  // The approach: import clack directly and spyOn its exports.
-
-  describe('promptForProviders', () => {
-    it('happy path: anthropic-only selection returns [anthropic]', async () => {
-      const clack = await import('@clack/prompts')
-      // multiselect<Value> returns Promise<Value[] | symbol>; resolved value is string[] | symbol
-      const multiselectSpy = spyOn(clack, 'multiselect').mockResolvedValue(['anthropic'])
-
-      const result = await promptForProviders()
-
-      expect(result).toEqual(['anthropic'])
-      expect(multiselectSpy).toHaveBeenCalledTimes(1)
-
-      multiselectSpy.mockRestore()
-    })
-
-    it('happy path: both providers selected returns [anthropic, openai]', async () => {
-      const clack = await import('@clack/prompts')
-      const multiselectSpy = spyOn(clack, 'multiselect').mockResolvedValue(['anthropic', 'openai'])
-
-      const result = await promptForProviders()
-
-      expect(result).toEqual(['anthropic', 'openai'])
-
-      multiselectSpy.mockRestore()
-    })
-
-    it('edge case: empty selection re-prompts; multiselect called exactly twice', async () => {
-      const clack = await import('@clack/prompts')
-      let callCount = 0
-      const multiselectSpy = spyOn(clack, 'multiselect').mockImplementation(
-        asMultiselectImpl<string>(async () => {
-          callCount++
-          if (callCount === 1) return []
-          return ['anthropic']
-        }),
-      )
-
-      const result = await promptForProviders()
-
-      expect(result).toEqual(['anthropic'])
-      expect(multiselectSpy).toHaveBeenCalledTimes(2)
-
-      multiselectSpy.mockRestore()
-    })
-
-    it('edge case: cancel mid-flow causes process.exit(0)', async () => {
-      const clack = await import('@clack/prompts')
-      const cancelSymbol = Symbol('cancel')
-      const multiselectSpy = spyOn(clack, 'multiselect').mockResolvedValue(cancelSymbol)
-      const isCancelSpy = spyOn(clack, 'isCancel').mockImplementation(v => v === cancelSymbol)
-      const cancelSpy = spyOn(clack, 'cancel').mockImplementation(() => {})
-      const exitSpy = spyOn(process, 'exit').mockImplementation((_code?: number): never => {
-        throw new Error('process.exit called')
-      })
-
-      await expect(promptForProviders()).rejects.toThrow('process.exit called')
-
-      multiselectSpy.mockRestore()
-      isCancelSpy.mockRestore()
-      cancelSpy.mockRestore()
-      exitSpy.mockRestore()
-    })
-  })
-
-  describe('promptForModel', () => {
-    it('happy path: single anthropic provider returns anthropic/claude-sonnet-4-6 without prompting', async () => {
-      const clack = await import('@clack/prompts')
-      const selectSpy = spyOn(clack, 'select')
-
-      const result = await promptForModel(['anthropic'])
-
-      expect(result).toBe('anthropic/claude-sonnet-4-6')
-      expect(selectSpy).not.toHaveBeenCalled()
-
-      selectSpy.mockRestore()
-    })
-
-    it('happy path: single openai provider returns openai/gpt-5.4-mini without prompting', async () => {
-      const clack = await import('@clack/prompts')
-      const selectSpy = spyOn(clack, 'select')
-
-      const result = await promptForModel(['openai'])
-
-      expect(result).toBe('openai/gpt-5.4-mini')
-      expect(selectSpy).not.toHaveBeenCalled()
-
-      selectSpy.mockRestore()
-    })
-
-    it('happy path: both providers, operator picks openai/gpt-5.4-mini from select', async () => {
-      const clack = await import('@clack/prompts')
-      const selectSpy = spyOn(clack, 'select').mockResolvedValue('openai/gpt-5.4-mini')
-
-      const result = await promptForModel(['anthropic', 'openai'])
-
-      expect(result).toBe('openai/gpt-5.4-mini')
-      expect(selectSpy).toHaveBeenCalledTimes(1)
-
-      selectSpy.mockRestore()
-    })
-
-    it('happy path: both providers, operator picks anthropic/claude-sonnet-4-6 from select', async () => {
-      const clack = await import('@clack/prompts')
-      const selectSpy = spyOn(clack, 'select').mockResolvedValue('anthropic/claude-sonnet-4-6')
-
-      const result = await promptForModel(['anthropic', 'openai'])
-
-      expect(result).toBe('anthropic/claude-sonnet-4-6')
-
-      selectSpy.mockRestore()
-    })
-
-    it('happy path: operator picks "enter custom..." then types openai/gpt-5.4-mini', async () => {
-      const clack = await import('@clack/prompts')
-      const selectSpy = spyOn(clack, 'select').mockResolvedValue('__custom__')
-      const textSpy = spyOn(clack, 'text').mockResolvedValue('openai/gpt-5.4-mini')
-
-      const result = await promptForModel(['anthropic', 'openai'])
-
-      expect(result).toBe('openai/gpt-5.4-mini')
-      expect(textSpy).toHaveBeenCalledTimes(1)
-
-      selectSpy.mockRestore()
-      textSpy.mockRestore()
-    })
-
-    it('edge case: custom model entry fails regex then succeeds on second attempt', async () => {
-      const clack = await import('@clack/prompts')
-      const selectSpy = spyOn(clack, 'select').mockResolvedValue('__custom__')
-      let textCallCount = 0
-      const textSpy = spyOn(clack, 'text').mockImplementation(
-        asTextImpl(async () => {
-          textCallCount++
-          // Simulate the validate function being called inline by the mock
-          // The real clack text prompt calls validate internally; here we just
-          // return the value and let the helper's validate logic re-prompt.
-          // Since we can't simulate clack's internal validate loop, we test
-          // that the helper's validate function rejects bad input.
-          if (textCallCount === 1) {
-            // Return a bad value — the helper should detect this and re-prompt
-            return 'bad-model'
-          }
-          return 'openai/gpt-5.4-mini'
-        }),
-      )
-
-      const result = await promptForModel(['anthropic', 'openai'])
-
-      expect(result).toBe('openai/gpt-5.4-mini')
-      expect(textSpy.mock.calls.length).toBeGreaterThanOrEqual(1)
-
-      selectSpy.mockRestore()
-      textSpy.mockRestore()
-    })
-
-    it('edge case: cancel during model select causes process.exit(0)', async () => {
-      const clack = await import('@clack/prompts')
-      const cancelSymbol = Symbol('cancel')
-      const selectSpy = spyOn(clack, 'select').mockResolvedValue(cancelSymbol)
-      const isCancelSpy = spyOn(clack, 'isCancel').mockImplementation(v => v === cancelSymbol)
-      const cancelSpy = spyOn(clack, 'cancel').mockImplementation(() => {})
-      const exitSpy = spyOn(process, 'exit').mockImplementation((_code?: number): never => {
-        throw new Error('process.exit called')
-      })
-
-      await expect(promptForModel(['anthropic', 'openai'])).rejects.toThrow('process.exit called')
-
-      selectSpy.mockRestore()
-      isCancelSpy.mockRestore()
-      cancelSpy.mockRestore()
-      exitSpy.mockRestore()
-    })
-  })
-})

package/src/commands/cliproxy/setup/providers.ts

@@ -1,136 +0,0 @@
-/// <reference types="bun" />
-
-import {isCancel, multiselect, select, text} from '@clack/prompts'
-import {z} from 'zod'
-
-import {cancelAndExit} from './prompts'
-
-const providerIdSchema = z.enum(['anthropic', 'openai'])
-export type ProviderId = z.infer<typeof providerIdSchema>
-
-const MODEL_ID_RE = /^(?:anthropic|openai)\/[a-z\d](?:[a-z\d.\-]*[a-z\d])?$/
-
-/**
- * Parse a comma-separated provider list string into a validated ProviderId array.
- * Rejects empty input, unknown providers, and duplicates.
- */
-export function parseProviders(input: string): ProviderId[] {
-  const parts = input
-    .split(',')
-    .map(p => p.trim())
-    .filter(Boolean)
-
-  if (parts.length === 0) {
-    throw new Error('--providers must not be empty. Supported values: anthropic, openai')
-  }
-
-  const parsed = parts.map(p => {
-    const result = providerIdSchema.safeParse(p)
-    if (!result.success) {
-      throw new Error(`Unknown provider "${p}". Supported values: anthropic, openai`)
-    }
-    return result.data
-  })
-
-  const deduped = new Set(parsed)
-  if (deduped.size < parsed.length) {
-    throw new Error(`--providers contains duplicate values: ${parsed.join(',')}`)
-  }
-
-  return parsed
-}
-
-export const PROVIDER_DEFAULTS: Record<ProviderId, string> = {
-  anthropic: 'anthropic/claude-sonnet-4-6',
-  openai: 'openai/gpt-5.4-mini',
-}
-
-const CUSTOM_MODEL_SENTINEL = '__custom__'
-
-/**
- * Interactively prompt the user to select one or more providers.
- * Anthropic is pre-checked. Empty selection re-prompts.
- */
-export async function promptForProviders(): Promise<ProviderId[]> {
-  let providers: ProviderId[] = []
-
-  do {
-    const result = await multiselect<ProviderId>({
-      message: 'Select providers to configure',
-      options: [
-        {value: 'anthropic', label: 'Anthropic'},
-        {value: 'openai', label: 'OpenAI'},
-      ],
-      initialValues: ['anthropic'],
-      required: false,
-    })
-
-    if (isCancel(result)) {
-      cancelAndExit('Setup cancelled before selecting providers.')
-    }
-
-    providers = result as ProviderId[]
-  } while (providers.length === 0)
-
-  return providers
-}
-
-/**
- * Interactively prompt the user to select a default model.
- * When only one provider is selected, returns that provider's default immediately.
- * When multiple providers are selected, shows a select with preset options and a custom entry.
- */
-export async function promptForModel(providers: ProviderId[]): Promise<string> {
-  if (providers.length === 1) {
-    return PROVIDER_DEFAULTS[providers[0] as ProviderId]
-  }
-
-  const chosen = await select<string>({
-    message: 'Choose a default model',
-    options: [
-      {value: 'openai/gpt-5.4-mini', label: 'openai/gpt-5.4-mini'},
-      {value: 'anthropic/claude-sonnet-4-6', label: 'anthropic/claude-sonnet-4-6'},
-      {value: CUSTOM_MODEL_SENTINEL, label: 'Enter custom model ID...'},
-    ],
-  })
-
-  if (isCancel(chosen)) {
-    cancelAndExit('Setup cancelled before selecting a model.')
-  }
-
-  if (chosen === CUSTOM_MODEL_SENTINEL) {
-    return promptForCustomModel()
-  }
-
-  return chosen as string
-}
-
-async function promptForCustomModel(): Promise<string> {
-  let modelId: string | undefined
-
-  do {
-    const result = await text({
-      message: 'Enter a custom model ID (e.g. openai/gpt-5.4-mini)',
-      placeholder: 'provider/model-name',
-      validate: value => {
-        if (!MODEL_ID_RE.test(value ?? '')) {
-          return 'Model ID must match provider/model-name (lowercase, digits, dots, hyphens only)'
-        }
-        return undefined
-      },
-    })
-
-    if (isCancel(result)) {
-      cancelAndExit('Setup cancelled before entering a custom model ID.')
-    }
-
-    const candidate = result as string
-    if (MODEL_ID_RE.test(candidate)) {
-      modelId = candidate
-    }
-    // If the mock bypasses clack's internal validate and returns a bad value,
-    // loop again to re-prompt.
-  } while (!modelId)
-
-  return modelId
-}