@marcomigozzi/trailhead 0.16.1 → 0.18.0

package/plugins/trailhead/templates/trailhead-report-status.js

@@ -3,20 +3,21 @@
 // trailhead report status check (self-contained, ships in templates/ so it reaches
 // every install channel). Checks the leading `status:` line of an engine-agent
 // report (Code review, Goal-backward verification #250; executor, fix, plan, debug,
-// research, codebase-map #249) before the engine branches on it, and returns the
+// research, codebase-map #249; grill #323) before the engine branches on it, and returns the
 // report's fields.
 //
 // CLI:
-//   node trailhead-report-status.js --technique <technique> [--file <path>]
+//   node trailhead-report-status.js --technique <technique> [--file <path> | --task-output <path>]
 // <technique> is verify | code-review | executor | fix | plan | debug | research |
-// codebase-map. Reads the report from --file, or from stdin when there is none.
+// codebase-map | grill. Reads the report from --file, from the last assistant message
+// of a background agent's task .output with --task-output, or from stdin when neither.
 // Prints exactly one JSON line {"action","verdict","problem","report","fields","body"}:
 //   action   accept | normalise | reask
 //   verdict  the canonical token, or null on reask
 //   problem  null | missing | unknown-token | conflicting | counts | fields (null iff not reask)
 //   report   the original text on accept and reask; the normalised text on normalise
 //   fields   label -> trimmed value for the report's fields (executor, fix, plan, debug,
-//            research, codebase-map); {} for verify and code-review; null on reask
+//            research, codebase-map, grill); {} for verify and code-review; null on reask
 //   body     plan with `ready` only: the normalised report without its status line, the
 //            PLAN to post verbatim; null otherwise
 // Exit 0 for all three actions; exit 2 on a usage error (missing or unknown
@@ -89,6 +90,19 @@ const CONTRACTS = Object.freeze({
       Object.freeze({ when: frozen(['needs_input']), field: 'questions', rule: 'non-empty' }),
     ]),
   }),
+  grilling: Object.freeze({
+    tokens: frozen(['question', 'review']),
+    required: frozen(['settled', 'frontier', 'amendments', 'conflicts']),
+    optional: frozen(['question', 'recommended', 'areas', 'facts']),
+    invariants: Object.freeze([
+      Object.freeze({ when: frozen(['question']), field: 'question', rule: 'non-empty' }),
+      Object.freeze({ when: frozen(['question']), field: 'recommended', rule: 'non-empty' }),
+      Object.freeze({ when: frozen(['question']), field: 'amendments', rule: 'none' }),
+      Object.freeze({ when: frozen(['question']), field: 'conflicts', rule: 'none' }),
+      Object.freeze({ when: frozen(['review']), field: 'frontier', rule: 'none' }),
+      Object.freeze({ when: frozen(['review']), field: 'question', rule: 'none' }),
+    ]),
+  }),
 });
 
 // Technique -> field family.
@@ -99,6 +113,7 @@ const FAMILY_OF = Object.freeze({
   research: 'investigating',
   'codebase-map': 'investigating',
   plan: 'plan',
+  grill: 'grilling',
 });
 
 // Technique -> its closed set of status tokens.
@@ -296,14 +311,38 @@ function checkReport(text, technique) {
   return { action: 'normalise', verdict, problem: null, report: [...head, ...rest].join('\n'), fields, body };
 }
 
+// The report of a background agent, read from the host's task .output (JSONL, often a
+// symlink to the subagent transcript): the text of the last assistant message that has
+// any, its blocks joined in order. One message can span several lines sharing
+// message.id; lines that are not JSON are skipped. null when there is no assistant text.
+function reportFromTaskOutput(raw) {
+  const entries = raw.split('\n').flatMap((l) => {
+    if (!l.trim()) return [];
+    try { return [JSON.parse(l)]; } catch (_) { return []; }
+  });
+  const texts = (e) => {
+    const c = e && e.message && e.message.content;
+    if (typeof c === 'string') return [c];
+    return Array.isArray(c) ? c.filter((b) => b && b.type === 'text' && typeof b.text === 'string').map((b) => b.text) : [];
+  };
+  const assistant = entries.filter((e) => e && e.type === 'assistant' && e.message);
+  const last = [...assistant].reverse().find((e) => texts(e).length > 0);
+  if (!last) return null;
+  const id = last.message.id;
+  const parts = id === undefined ? texts(last) : assistant.filter((e) => e.message.id === id).flatMap(texts);
+  return parts.join('');
+}
+
+const VALUE_FLAGS = { '--technique': 'technique', '--file': 'file', '--task-output': 'taskOutput' };
+
 function parseArgs(argv) {
-  const opts = { technique: null, file: null };
+  const opts = { technique: null, file: null, taskOutput: null };
   for (let i = 0; i < argv.length; i++) {
     const a = argv[i];
-    if (a === '--technique' || a === '--file') {
+    if (Object.prototype.hasOwnProperty.call(VALUE_FLAGS, a)) {
       const v = argv[i + 1];
       if (v === undefined || v === '' || v.startsWith('--')) throw new Error(`${a} needs a value`);
-      opts[a === '--technique' ? 'technique' : 'file'] = v;
+      opts[VALUE_FLAGS[a]] = v;
       i++;
     } else {
       throw new Error(`unknown argument: ${a}`);
@@ -311,9 +350,18 @@ function parseArgs(argv) {
   }
   if (!opts.technique) throw new Error(`--technique <${Object.keys(TOKENS).join('|')}> is required`);
   if (!Object.prototype.hasOwnProperty.call(TOKENS, opts.technique)) throw new Error(`unknown technique: ${opts.technique}`);
+  if (opts.file !== null && opts.taskOutput !== null) throw new Error('--file and --task-output are mutually exclusive');
   return opts;
 }
 
+function readReport(opts, readFile, readStdin) {
+  if (opts.file !== null) return readFile(opts.file);
+  if (opts.taskOutput === null) return readStdin();
+  const report = reportFromTaskOutput(readFile(opts.taskOutput));
+  if (report === null) throw new Error(`no assistant report in ${opts.taskOutput}`);
+  return report;
+}
+
 function main(argv, io = {}) {
   const stdout = io.stdout || process.stdout;
   const stderr = io.stderr || process.stderr;
@@ -322,7 +370,7 @@ function main(argv, io = {}) {
   let result;
   try {
     const opts = parseArgs(argv);
-    const text = opts.file !== null ? readFile(opts.file) : readStdin();
+    const text = readReport(opts, readFile, readStdin);
     result = checkReport(text, opts.technique);
   } catch (e) {
     stderr.write(`${JSON.stringify({ error: e.message })}\n`);
@@ -335,4 +383,4 @@ function main(argv, io = {}) {
 // exitCode, not process.exit(): exiting at once truncates piped stdout at 64 KB.
 if (require.main === module) process.exitCode = main(process.argv.slice(2));
 
-module.exports = { checkReport, parseArgs, main, TOKENS, CONTRACTS, FAMILY_OF, VERIFY_CLASSES };
+module.exports = { checkReport, reportFromTaskOutput, parseArgs, main, TOKENS, CONTRACTS, FAMILY_OF, VERIFY_CLASSES };