@marcomigozzi/trailhead 0.12.1 → 0.14.0

package/plugins/trailhead/hooks/trailhead-mockup-link-guard.test.js

@@ -10,6 +10,8 @@ const {
   isMockupApprovalAsk,
   hasLink,
   proseBeforeAsk,
+  pendingAskIndex,
+  askHasLink,
 } = require('./trailhead-mockup-link-guard.js');
 
 const HOOK = path.join(__dirname, 'trailhead-mockup-link-guard.js');
@@ -20,7 +22,7 @@ const ok = (name, cond) => { assert.ok(cond, name); passed++; };
 // Costruttori di righe transcript (stesso shape JSONL di Claude Code)
 const text = (t) => ({ type: 'assistant', isSidechain: false, message: { content: [{ type: 'text', text: t }] } });
 const thinking = () => ({ type: 'assistant', isSidechain: false, message: { content: [{ type: 'thinking', thinking: '' }] } });
-const toolUse = (name, input = {}) => ({ type: 'assistant', isSidechain: false, message: { content: [{ type: 'tool_use', id: 'x', name, input }] } });
+const toolUse = (name, input = {}, id = 'x') => ({ type: 'assistant', isSidechain: false, message: { content: [{ type: 'tool_use', id, name, input }] } });
 const toolResult = (c) => ({ type: 'user', isSidechain: false, message: { content: [{ type: 'tool_result', tool_use_id: 'x', content: c }] } });
 const userPrompt = (c) => ({ type: 'user', isSidechain: false, message: { content: c } });
 
@@ -52,7 +54,7 @@ ok('mockup offer whose option description mentions approval is NOT an approval a
     header: 'Scope',
     options: [
       { label: 'Va bene così', description: 'Procedo con lo scope descritto' },
-      { label: 'Prima un mockup', description: 'Disegno la pagina su claude.ai/design e attendo approvazione prima di scriverla' },
+      { label: 'Prima un mockup', description: 'Disegno la pagina su un canvas Artifacts e attendo approvazione prima di scriverla' },
     ],
   }],
 }));
@@ -68,7 +70,7 @@ ok('unrelated ask is not detected', !isMockupApprovalAsk({
 ok('malformed input is not detected', !isMockupApprovalAsk({}) && !isMockupApprovalAsk(null));
 
 // --- hasLink ---
-ok('https URL counts as a link', hasLink('Ecco: https://claude.ai/design/p/abc?file=faq.html'));
+ok('https URL counts as a link', hasLink('Ecco: https://claude.ai/artifact/AbC123xyz'));
 ok('absolute html path counts as a link', hasLink('Mockup in /home/u/app/mockups/faq.html'));
 ok('relative html path counts as a link', hasLink('apri `mockups/faq.html`'));
 ok('markdown link to a file counts', hasLink('[faq](mockups/faq.html)'));
@@ -88,7 +90,7 @@ ok('prose right before the ask is collected', /pronto su MyApp/.test(proseBefore
 
 const linkBeforeTools = [
   userPrompt('lavora #12'),
-  text('Mockup: https://claude.ai/design/p/abc'),
+  text('Mockup: https://claude.ai/artifact/AbC123xyz'),
   toolUse('Bash'),
   toolResult('ok'),
   text('Pronto.'),
@@ -103,8 +105,45 @@ const sidechain = [
 ];
 ok('sidechain text is ignored', !hasLink(proseBeforeAsk(sidechain)));
 
-const noAskYet = [userPrompt('x'), text('Ecco https://a.b/c')];
-ok('works when the pending tool_use is not yet in the transcript', hasLink(proseBeforeAsk(noAskYet)));
+// Senza ancora: comportamento storico, si parte dalla coda del transcript
+const noAnchor = [userPrompt('x'), text('Ecco https://a.b/c')];
+ok('without an anchor the prose is read from the transcript tail', hasLink(proseBeforeAsk(noAnchor)));
+
+// Con ancora: si parte dall'ask trovato, non dalla coda
+const anchored = [
+  userPrompt('x'),
+  text('Mockup: https://a.b/c'),
+  toolUse('AskUserQuestion', approvalInput, 'ask1'),
+  toolResult('Approvo'),
+  text('Altro testo senza link'),
+];
+ok('with an anchor the prose is read back from the anchored ask', hasLink(proseBeforeAsk(anchored, 2)));
+
+// --- askHasLink ---
+const askWith = (over) => ({ questions: [{ ...approvalInput.questions[0], ...over }] });
+ok('link in the approval question counts', askHasLink(askWith({ question: 'Approvi il mockup https://claude.ai/artifact/AbC123?' })));
+ok('link in the approval header counts', askHasLink(askWith({ header: 'https://claude.ai/artifact/AbC123' })));
+ok('link in an approval option label counts', askHasLink(askWith({ options: [{ label: 'Apri https://a.b/c' }, { label: 'No' }] })));
+ok('link in an approval option description counts', askHasLink(askWith({ options: [{ label: 'Approvo', description: 'vedi mockups/faq.html' }] })));
+ok('approval ask without any link has none', !askHasLink(approvalInput));
+ok('link only in a different non-approval question does not count', !askHasLink({
+  questions: [
+    { question: 'Dove sta il piano?', options: [{ label: 'https://a.b/piano' }] },
+    approvalInput.questions[0],
+  ],
+}));
+ok('malformed input has no ask link', !askHasLink({}) && !askHasLink(null));
+
+// --- pendingAskIndex ---
+const withIds = [userPrompt('x'), toolUse('Bash', {}, 'b1'), toolResult('ok'), text('Prosa'), toolUse('AskUserQuestion', approvalInput, 'ask1')];
+ok('pendingAskIndex finds the entry by tool_use id', pendingAskIndex(withIds, 'ask1', approvalInput) === 4);
+ok('pendingAskIndex by id ignores a missing id', pendingAskIndex(withIds, 'nope', approvalInput) === -1);
+ok('pendingAskIndex without id falls back to input equality on the tail', pendingAskIndex(withIds, undefined, approvalInput) === 4);
+ok('pendingAskIndex without id is -1 when the tail ask has a different input',
+  pendingAskIndex(withIds, undefined, askWith({ question: 'Approvi il mockup B?' })) === -1);
+ok('pendingAskIndex is -1 when the tail is the previous tool_result',
+  pendingAskIndex([userPrompt('x'), toolUse('Bash', {}, 'b1'), toolResult('ok')], undefined, approvalInput) === -1);
+ok('pendingAskIndex ignores sidechain entries', pendingAskIndex([{ ...toolUse('AskUserQuestion', approvalInput, 'ask1'), isSidechain: true }], 'ask1', approvalInput) === -1);
 
 // --- end-to-end ---
 function writeTranscript(entries) {
@@ -125,7 +164,7 @@ function runHook(payload) {
 const r1 = runHook({ tool_name: 'AskUserQuestion', tool_input: approvalInput, transcript_path: writeTranscript(failing) });
 ok('approval ask without a link in the prose is blocked (exit 2)', r1.code === 2 && /MOCKUP_LINK_MISSING/.test(r1.out));
 
-const withLink = [...failing.slice(0, 4), text('Mockup: https://claude.ai/design/p/abc?file=faq.html'), failing[5]];
+const withLink = [...failing.slice(0, 4), text('Mockup: https://claude.ai/artifact/AbC123xyz'), failing[5]];
 const r2 = runHook({ tool_name: 'AskUserQuestion', tool_input: approvalInput, transcript_path: writeTranscript(withLink) });
 ok('approval ask with a link in the prose is allowed', r2.code === 0 && r2.out.trim() === '');
 
@@ -138,6 +177,39 @@ ok('other tools are ignored', r4.code === 0);
 const r5 = runHook({ tool_name: 'AskUserQuestion', tool_input: { questions: [{ question: 'Approvi il piano?', options: [] }] }, transcript_path: writeTranscript(failing) });
 ok('non-mockup ask is allowed', r5.code === 0);
 
+// Shape reale di Claude Code 2.1.295: il messaggio corrente non e' ancora nel transcript
+const unflushed = [userPrompt('lavora #12'), toolUse('Bash', {}, 'b1'), toolResult('ok')];
+const ra = runHook({ tool_name: 'AskUserQuestion', tool_use_id: 'ask1', tool_input: approvalInput, transcript_path: writeTranscript(unflushed) });
+ok('(a) transcript ending at a previous tool_result fails open', ra.code === 0 && ra.out.trim() === '');
+
+const flushedNoLink = [...failing.slice(0, 5), toolUse('AskUserQuestion', approvalInput, 'ask1')];
+const rb = runHook({ tool_name: 'AskUserQuestion', tool_use_id: 'ask1', tool_input: approvalInput, transcript_path: writeTranscript(flushedNoLink) });
+ok('(b) tool_use_id with the ask entry present and no link in the prose is blocked', rb.code === 2 && /MOCKUP_LINK_MISSING/.test(rb.out));
+
+const linkedAsk = askWith({ question: 'Approvi il mockup https://claude.ai/artifact/AbC123?' });
+const rc = runHook({ tool_name: 'AskUserQuestion', tool_use_id: 'ask1', tool_input: linkedAsk, transcript_path: writeTranscript(failing) });
+ok('(c) link carried by the ask question is allowed', rc.code === 0 && rc.out.trim() === '');
+
+const otherPending = [userPrompt('x'), text('Niente link'), toolUse('AskUserQuestion', { questions: [{ question: 'Altro?', options: [] }] }, 'other')];
+const rd = runHook({ tool_name: 'AskUserQuestion', tool_use_id: 'ask1', tool_input: approvalInput, transcript_path: writeTranscript(otherPending) });
+ok('(d) transcript ending in a different pending ask fails open', rd.code === 0 && rd.out.trim() === '');
+
+// Testo e tool_use nella STESSA riga di transcript
+const sameEntry = (t) => ({ type: 'assistant', isSidechain: false, message: { content: [{ type: 'text', text: t }, { type: 'tool_use', id: 'ask1', name: 'AskUserQuestion', input: approvalInput }] } });
+ok('text before the tool_use in the same entry counts as prose', hasLink(proseBeforeAsk([userPrompt('x'), sameEntry('Vedi https://a.b/c')], 1)));
+ok('same-entry text is also read from the tail', hasLink(proseBeforeAsk([userPrompt('x'), sameEntry('Vedi https://a.b/c')])));
+const rs1 = runHook({ tool_name: 'AskUserQuestion', tool_use_id: 'ask1', tool_input: approvalInput, transcript_path: writeTranscript([userPrompt('x'), sameEntry('Vedi https://a.b/c')]) });
+ok('same-entry text with a link is allowed', rs1.code === 0 && rs1.out.trim() === '');
+const rs2 = runHook({ tool_name: 'AskUserQuestion', tool_use_id: 'ask1', tool_input: approvalInput, transcript_path: writeTranscript([userPrompt('x'), sameEntry('Mockup pronto su MyApp')]) });
+ok('same-entry text without a link is blocked', rs2.code === 2 && /MOCKUP_LINK_MISSING/.test(rs2.out));
+
+// Senza tool_use_id: ask in coda identico a tool_input (fallback per uguaglianza)
+const ri1 = runHook({ tool_name: 'AskUserQuestion', tool_input: approvalInput, transcript_path: writeTranscript(flushedNoLink) });
+ok('no id, identical tail ask, no link in the prose is blocked', ri1.code === 2 && /MOCKUP_LINK_MISSING/.test(ri1.out));
+const flushedLink = [...failing.slice(0, 4), text('Mockup: https://claude.ai/artifact/AbC123xyz'), toolUse('AskUserQuestion', approvalInput, 'ask1')];
+const ri2 = runHook({ tool_name: 'AskUserQuestion', tool_input: approvalInput, transcript_path: writeTranscript(flushedLink) });
+ok('no id, identical tail ask, link in the prose is allowed', ri2.code === 0 && ri2.out.trim() === '');
+
 let r6;
 try { execFileSync('node', [HOOK], { input: 'not json' }); r6 = 0; } catch (e) { r6 = e.status; }
 ok('unparseable input fails open', r6 === 0);

package/plugins/trailhead/hooks/trailhead-mockup-link-stop.test.js

@@ -19,7 +19,7 @@ const noLink = [
   '1. Approvo',
   '2. Chiedo modifiche',
 ].join('\n');
-const withLink = noLink.replace('pronto su MyApp', 'pronto: https://claude.ai/design/p/abc?file=faq.html');
+const withLink = noLink.replace('pronto su MyApp', 'pronto: https://claude.ai/artifact/AbC123xyz');
 
 // --- isMockupApprovalMessage ---
 ok('IT approval reply is detected', isMockupApprovalMessage(noLink));

package/plugins/trailhead/hooks/trailhead-search-guard.js

@@ -239,15 +239,26 @@ function detectSearchHygieneViolation(cmd) {
   return null;
 }
 
-function block(hit) {
+function blockVerdict(hit) {
   const reason =
     "trailhead search-hygiene: a 'cd <dir>' (or pushd/env -C) followed by a relative " +
     `${hit.verb} read (\`${hit.file}\`) makes the read target non-static, which trips the ` +
     'Read() deny rule under bypass permissions (prompting for manual approval instead of ' +
     'running headless). Pass explicit paths instead and never cd first: ' +
     'grep -niE "<patterns>" <abs>/<file>, git -C <abs> ..., or use the Grep/Read tools.';
-  process.stdout.write(JSON.stringify({ decision: 'block', code: 'SEARCH_HYGIENE_VIOLATION', reason }));
-  process.exit(2);
+  return { kind: 'block', payload: { decision: 'block', code: 'SEARCH_HYGIENE_VIOLATION', reason } };
+}
+
+// Pure verdict for one command: {kind:'allow'} or {kind:'block', payload}. Never
+// exits or writes; any internal error falls through to allow.
+function evaluate(cmd) {
+  try {
+    const hit = detectSearchHygieneViolation(cmd);
+    if (hit) return blockVerdict(hit);
+  } catch {
+    // fall through to allow: a guard must never wedge the workflow
+  }
+  return { kind: 'allow' };
 }
 
 function run(data) {
@@ -257,11 +268,10 @@ function run(data) {
   } catch {
     process.exit(0); // unparseable input: nothing to gate
   }
-  try {
-    const hit = detectSearchHygieneViolation(cmd);
-    if (hit) block(hit);
-  } catch {
-    // fall through to allow: a guard must never wedge the workflow
+  const v = evaluate(cmd);
+  if (v.kind === 'block') {
+    process.stdout.write(JSON.stringify(v.payload));
+    process.exit(2);
   }
   process.exit(0);
 }
@@ -276,4 +286,4 @@ if (require.main === module) {
   });
 }
 
-module.exports = { detectSearchHygieneViolation };
+module.exports = { detectSearchHygieneViolation, evaluate };

package/plugins/trailhead/hooks/trailhead-search-guard.test.js

@@ -5,7 +5,8 @@ const assert = require('assert');
 const { execFileSync } = require('child_process');
 const path = require('path');
 
-const HOOK = path.join(__dirname, 'trailhead-search-guard.js');
+// TRAILHEAD_GUARD_HOOK re-runs this suite through the merged trailhead-bash-guards.js.
+const HOOK = process.env.TRAILHEAD_GUARD_HOOK || path.join(__dirname, 'trailhead-search-guard.js');
 
 let passed = 0;
 const ok = (name, cond) => { assert.ok(cond, name); passed++; };