@maplibre/maplibre-react-native 10.0.0-alpha.20 → 10.0.0-alpha.22

package/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+  root: true,
+  extends: ["universe/native"],
+  ignorePatterns: ["build"],
+};

package/.git-blame-ignore-revs

@@ -0,0 +1,3 @@
+# style: apply formatting via lint:fix
+# https://github.com/maplibre/maplibre-react-native/pull/467
+017b3861ae8ac856a3b032ebea6497eff4420e1f

package/CHANGELOG.md

@@ -6,6 +6,23 @@ PR Title ([#123](link to my pr))
 
 ```
 
+## 10.0.0-alpha.22
+
+chore: configure jest to use with ts
+([#470](https://github.com/maplibre/maplibre-react-native/pull/470))
+
+refactor: switch many examples to TypeScript
+([#469](https://github.com/maplibre/maplibre-react-native/pull/469))
+
+chore: eslint formatting and improve scripts
+([#467](https://github.com/maplibre/maplibre-react-native/pull/467))
+
+fix: allow resetting contentInset with 0 ([#468](https://github.com/maplibre/maplibre-react-native/pull/468))
+
+## 10.0.0-alpha.21
+
+fix: Call requestProgress when getting pack status on IOS + example improvement [#445](https://github.com/maplibre/maplibre-react-native/pull/445)
+
 ## 10.0.0-alpha.20
 
 fix: fix style expressions, revert changes to scripts/autogenHelpers/globals.js ([#466](https://github.com/maplibre/maplibre-react-native/pull/466))

package/app.plugin.js

@@ -1 +1 @@
-module.exports = require('./plugin/build/withMapLibre');
+module.exports = require("./plugin/build/withMapLibre");

package/babel.config.js

@@ -1,9 +1,12 @@
 module.exports = {
-  presets: ['module:metro-react-native-babel-preset'],
-  plugins: [['@babel/plugin-proposal-class-properties', {loose: true}]],
+  presets: ["module:metro-react-native-babel-preset"],
+  plugins: [
+    ["@babel/plugin-proposal-class-properties", { loose: true }],
+    ["@babel/plugin-transform-private-methods", { loose: true }],
+  ],
   env: {
     production: {
-      plugins: ['transform-remove-console'],
+      plugins: ["transform-remove-console"],
     },
   },
 };

package/ios/RCTMLN/MLNOfflineModule.m

@@ -48,12 +48,12 @@ NSString *const RCT_MAPBOX_OFFLINE_CALLBACK_ERROR = @"MapboOfflineRegionError";
         packRequestQueue = [NSMutableArray new];
         eventThrottle = 300;
         lastPackState = -1;
-        
+
         NSNotificationCenter *defaultCenter = [NSNotificationCenter defaultCenter];
         [defaultCenter addObserver:self selector:@selector(offlinePackProgressDidChange:) name:MLNOfflinePackProgressChangedNotification object:nil];
         [defaultCenter addObserver:self selector:@selector(offlinePackDidReceiveError:) name:MLNOfflinePackErrorNotification object:nil];
         [defaultCenter addObserver:self selector:@selector(offlinePackDidReceiveMaxAllowedMapboxTiles:) name:MLNOfflinePackMaximumMapboxTilesReachedNotification object:nil];
-        
+
         [[MLNOfflineStorage sharedOfflineStorage] addObserver:self forKeyPath:@"packs" options:NSKeyValueObservingOptionInitial context:NULL];
     }
     return self;
@@ -72,15 +72,21 @@ NSString *const RCT_MAPBOX_OFFLINE_CALLBACK_ERROR = @"MapboOfflineRegionError";
 
 - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary<NSKeyValueChangeKey,id> *)change context:(void *)context
 {
+    if ([keyPath isEqualToString:@"state"] && [object isKindOfClass:[MLNOfflinePack class]]) {
+        MLNOfflinePack* pack = (MLNOfflinePack*)object;
+        [self observerStateForPack:pack context:context];
+        return;
+    }
+
     if (packRequestQueue.count == 0) {
         return;
     }
-    
+
     NSArray<MLNOfflinePack *> *packs = [[MLNOfflineStorage sharedOfflineStorage] packs];
     if (packs == nil) {
         return;
     }
-    
+
     while (packRequestQueue.count > 0) {
         RCTPromiseResolveBlock resolve = [packRequestQueue objectAtIndex:0];
         resolve([self _convertPacksToJson:packs]);
@@ -94,13 +100,13 @@ RCT_EXPORT_METHOD(createPack:(NSDictionary *)options
 {
     NSString *styleURL = options[@"styleURL"];
     MLNCoordinateBounds bounds = [RCTMLNUtils fromFeatureCollection:options[@"bounds"]];
-    
+
     id<MLNOfflineRegion> offlineRegion = [[MLNTilePyramidOfflineRegion alloc] initWithStyleURL:[NSURL URLWithString:styleURL]
                                                                               bounds:bounds
                                                                               fromZoomLevel:[options[@"minZoom"] doubleValue]
                                                                               toZoomLevel:[options[@"maxZoom"] doubleValue]];
     NSData *context = [self _archiveMetadata:options[@"metadata"]];
-    
+
     [[MLNOfflineStorage sharedOfflineStorage] addPackForRegion:offlineRegion
                                               withContext:context
                                               completionHandler:^(MLNOfflinePack *pack, NSError *error) {
@@ -129,7 +135,7 @@ RCT_EXPORT_METHOD(mergeOfflineRegions:(NSString *)path
             return reject(@"asset_does_not_exist", [NSString stringWithFormat:@"The given assetName, %@, can't be found in the app's bundle.", path], nil);
         }
     }
-    
+
     [[MLNOfflineStorage sharedOfflineStorage] addContentsOfFile:absolutePath withCompletionHandler:^(NSURL *fileURL, NSArray<MLNOfflinePack *> *packs, NSError *error) {
         if (error != nil) {
             reject(@"mergeOfflineRegions", error.description, error);
@@ -143,7 +149,7 @@ RCT_EXPORT_METHOD(getPacks:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseR
 {
     dispatch_async(dispatch_get_main_queue(), ^{
         NSArray<MLNOfflinePack *> *packs = [[MLNOfflineStorage sharedOfflineStorage] packs];
-        
+
         if (packs == nil) {
             // packs have not loaded yet
             [self->packRequestQueue addObject:resolve];
@@ -187,7 +193,7 @@ RCT_EXPORT_METHOD(setMaximumAmbientCacheSize:(NSUInteger)cacheSize
         }
         resolve(nil);
     }];
-    
+
 }
 
 RCT_EXPORT_METHOD(resetDatabase:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject)
@@ -199,7 +205,7 @@ RCT_EXPORT_METHOD(resetDatabase:(RCTPromiseResolveBlock)resolve rejecter:(RCTPro
         }
         resolve(nil);
     }];
-    
+
 }
 
 RCT_EXPORT_METHOD(getPackStatus:(NSString *)name
@@ -207,14 +213,29 @@ RCT_EXPORT_METHOD(getPackStatus:(NSString *)name
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
     MLNOfflinePack *pack = [self _getPackFromName:name];
-    
+
     if (pack == nil) {
         resolve(nil);
         NSLog(@"getPackStatus - Unknown offline region");
         return;
     }
-    
-    resolve([self _makeRegionStatusPayload:name pack:pack]);
+
+    if (pack.state == MLNOfflinePackStateUnknown) {
+        [pack addObserver:self forKeyPath:@"state" options:NSKeyValueObservingOptionNew context:(__bridge_retained void*)resolve];
+        [pack requestProgress];
+    } else {
+        resolve([self _makeRegionStatusPayload:name pack:pack]);
+    }
+}
+
+-(void)observerStateForPack:(MLNOfflinePack*)pack context:(nullable void*) context {
+    RCTPromiseResolveBlock resolve = (__bridge_transfer RCTPromiseResolveBlock)context;
+    dispatch_async(dispatch_get_main_queue(), ^{
+        NSDictionary* metadata = [self _unarchiveMetadata:pack];
+        NSString* name = metadata[@"name"];
+        resolve([self _makeRegionStatusPayload:name pack:pack]);
+    });
+    [pack removeObserver:self forKeyPath:@"state" context:context];
 }
 
 RCT_EXPORT_METHOD(invalidatePack:(NSString *)name
@@ -241,7 +262,7 @@ RCT_EXPORT_METHOD(deletePack:(NSString *)name
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
     MLNOfflinePack *pack = [self _getPackFromName:name];
-    
+
     if (pack == nil) {
         resolve(nil);
         return;
@@ -265,17 +286,17 @@ RCT_EXPORT_METHOD(pausePackDownload:(NSString *)name
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
     MLNOfflinePack *pack = [self _getPackFromName:name];
-    
+
     if (pack == nil) {
         reject(@"pausePackDownload", @"Unknown offline region", nil);
         return;
     }
-    
+
     if (pack.state == MLNOfflinePackStateInactive || pack.state == MLNOfflinePackStateComplete) {
         resolve(nil);
         return;
     }
-    
+
     [pack suspend];
     resolve(nil);
 }
@@ -285,17 +306,17 @@ RCT_EXPORT_METHOD(resumePackDownload:(NSString *)name
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
     MLNOfflinePack *pack = [self _getPackFromName:name];
-    
+
     if (pack == nil) {
         reject(@"resumePack", @"Unknown offline region", nil);
         return;
     }
-    
+
     if (pack.state == MLNOfflinePackStateActive || pack.state == MLNOfflinePackStateComplete) {
         resolve(nil);
         return;
     }
-    
+
     [pack resume];
     resolve(nil);
 }
@@ -313,18 +334,18 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
 - (void)offlinePackProgressDidChange:(NSNotification *)notification
 {
     MLNOfflinePack *pack = notification.object;
-  
+
     if (pack.state == MLNOfflinePackStateInvalid) {
         return; // Avoid invalid offline pack exception
     }
-  
+
     if ([self _shouldSendProgressEvent:[self _getCurrentTimestamp] pack:pack]) {
         NSDictionary *metadata = [self _unarchiveMetadata:pack];
         RCTMLNEvent *event = [self _makeProgressEvent:metadata[@"name"] pack:pack];
         [self _sendEvent:RCT_MAPBOX_OFFLINE_CALLBACK_PROGRESS event:event];
         lastPackTimestamp = [self _getCurrentTimestamp];
     }
-    
+
     lastPackState = pack.state;
 }
 
@@ -335,7 +356,7 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
         return; // Avoid invalid offline pack exception
     }
     NSDictionary *metadata = [self _unarchiveMetadata:pack];
-    
+
     NSString *name = metadata[@"name"];
     if (name != nil) {
         NSError *error = notification.userInfo[MLNOfflinePackUserInfoKeyError];
@@ -350,7 +371,7 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
 {
     MLNOfflinePack *pack = notification.object;
     NSDictionary *metadata = [self _unarchiveMetadata:pack];
-    
+
     NSString *name = metadata[@"name"];
     if (name != nil) {
         RCTMLNEvent *event = [self _makeErrorEvent:name
@@ -386,11 +407,11 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
     if ([data isKindOfClass:[NSDictionary class]]) {
         return data;
     }
-    
+
     if (data == nil) {
         return @{};
     }
-    
+
     return [NSJSONSerialization JSONObjectWithData:[data dataUsingEncoding:NSUTF8StringEncoding]
                                 options:NSJSONReadingMutableContainers
                                 error:nil];
@@ -406,7 +427,7 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
     if(expectedResources == 0) {
         progressPercentage = 0;
     }
-    
+
     return @{
       @"state": @(pack.state),
       @"name": name,
@@ -433,15 +454,15 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
 - (NSArray<NSDictionary *> *)_convertPacksToJson:(NSArray<MLNOfflinePack *> *)packs
 {
     NSMutableArray<NSDictionary *> *jsonPacks = [NSMutableArray new];
-    
+
     if (packs == nil) {
         return jsonPacks;
     }
-    
+
     for (MLNOfflinePack *pack in packs) {
         [jsonPacks addObject:[self _convertPackToDict:pack]];
     }
-    
+
     return jsonPacks;
 }
 
@@ -452,12 +473,12 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
     if (region == nil) {
         return nil;
     }
-    
+
     NSArray *jsonBounds = @[
       @[@(region.bounds.ne.longitude), @(region.bounds.ne.latitude)],
       @[@(region.bounds.sw.longitude), @(region.bounds.sw.latitude)]
     ];
-    
+
     // format metadata
     NSDictionary *metadata = [self _unarchiveMetadata:pack];
     NSData *jsonMetadata = [NSJSONSerialization dataWithJSONObject:metadata
@@ -472,19 +493,19 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
 - (MLNOfflinePack *)_getPackFromName:(NSString *)name
 {
     NSArray<MLNOfflinePack *> *packs = [[MLNOfflineStorage sharedOfflineStorage] packs];
-    
+
     if (packs == nil) {
         return nil;
     }
-    
+
     for (MLNOfflinePack *pack in packs) {
         NSDictionary *metadata = [self _unarchiveMetadata:pack];
-        
+
         if ([name isEqualToString:metadata[@"name"]]) {
             return pack;
         }
     }
-    
+
     return nil;
 }
 
@@ -501,15 +522,15 @@ RCT_EXPORT_METHOD(setProgressEventThrottle:(nonnull NSNumber *)throttleValue)
     if (lastPackState == -1) {
         return YES;
     }
-    
+
     if (lastPackState != currentPack.state) {
         return YES;
     }
-    
+
     if (currentTimestamp - lastPackTimestamp > eventThrottle) {
         return YES;
     }
-    
+
     return NO;
 }
 

package/javascript/Maplibre.ts

@@ -40,6 +40,12 @@ export {
   type Location,
 } from "./modules/location/locationManager";
 export { default as offlineManager } from "./modules/offline/offlineManager";
+export type {
+  OfflineProgressStatus,
+  OfflinePackError,
+} from "./modules/offline/offlineManager";
+export type { OfflinePackStatus } from "./modules/offline/OfflinePack";
+export { default as OfflinePack } from "./modules/offline/OfflinePack";
 export { default as OfflineCreatePackOptions } from "./modules/offline/OfflineCreatePackOptions";
 export { default as snapshotManager } from "./modules/snapshot/snapshotManager";
 export type { SnapshotInputOptions } from "./modules/snapshot/SnapshotOptions";

package/javascript/components/HeadingIndicator.tsx

@@ -1,7 +1,6 @@
 import React, { ReactElement } from "react";
 
 import SymbolLayer from "./SymbolLayer";
-// @ts-ignore
 import headingIcon from "../../assets/heading.png";
 import BaseProps from "../types/BaseProps";
 

package/javascript/components/MapView.tsx

@@ -760,7 +760,7 @@ const MapView = memo(
       };
 
       const contentInsetValue = useMemo(() => {
-        if (!props.contentInset) {
+        if (props.contentInset === undefined) {
           return;
         }
 
@@ -812,7 +812,7 @@ const MapView = memo(
           surfaceView,
           regionWillChangeDebounceTime,
           regionDidChangeDebounceTime,
-          contentInsetValue,
+          contentInset: contentInsetValue,
           style: styles.matchParent,
         };
       }, [
@@ -825,7 +825,6 @@ const MapView = memo(
         surfaceView,
         regionWillChangeDebounceTime,
         regionDidChangeDebounceTime,
-        contentInsetValue,
         props,
         contentInsetValue,
       ]);

package/javascript/modules/offline/OfflinePack.ts

@@ -4,7 +4,7 @@ import OfflineCreatePackOptions from "./OfflineCreatePackOptions";
 
 const MapLibreGLOfflineManager = NativeModules.MLNOfflineModule;
 
-type OfflinePackStatus = {
+export type OfflinePackStatus = {
   name: string;
   state: number;
   percentage: number;

package/javascript/types/png.d.ts

@@ -0,0 +1 @@
+declare module "*.png";

package/jest-setup.ts

@@ -0,0 +1,113 @@
+/* eslint-disable no-undef, import/no-extraneous-dependencies */
+import "@testing-library/react-native/extend-expect";
+import { NativeModules } from "react-native";
+
+// Silence the warning: Animated: `useNativeDriver` is not supported because the native animated module is missing
+jest.mock("react-native/Libraries/Animated/NativeAnimatedHelper");
+
+function keyMirror(keys: string[]) {
+  const obj: Record<string, string> = {};
+  keys.forEach((key) => (obj[key] = key));
+  return obj;
+}
+
+// Mock of what the native code puts on the JS object
+NativeModules.MLNModule = {
+  // constants
+  UserTrackingModes: keyMirror([
+    "None",
+    "Follow",
+    "FollowWithCourse",
+    "FollowWithHeading",
+  ]),
+  StyleURL: keyMirror(["Default"]),
+  EventTypes: keyMirror([
+    "MapClick",
+    "MapLongClick",
+    "RegionWillChange",
+    "RegionIsChanging",
+    "RegionDidChange",
+    "WillStartLoadingMap",
+    "DidFinishLoadingMap",
+    "DidFailLoadingMap",
+    "WillStartRenderingFrame",
+    "DidFinishRenderingFrame",
+    "DidFinishRenderingFrameFully",
+    "DidFinishLoadingStyle",
+    "SetCameraComplete",
+  ]),
+  CameraModes: keyMirror(["Flight", "Ease", "None"]),
+  StyleSource: keyMirror(["DefaultSourceID"]),
+  InterpolationMode: keyMirror([
+    "Exponential",
+    "Categorical",
+    "Interval",
+    "Identity",
+  ]),
+  LineJoin: keyMirror(["Bevel", "Round", "Miter"]),
+  LineCap: keyMirror(["Butt", "Round", "Square"]),
+  LineTranslateAnchor: keyMirror(["Map", "Viewport"]),
+  CirclePitchScale: keyMirror(["Map", "Viewport"]),
+  CircleTranslateAnchor: keyMirror(["Map", "Viewport"]),
+  FillExtrusionTranslateAnchor: keyMirror(["Map", "Viewport"]),
+  FillTranslateAnchor: keyMirror(["Map", "Viewport"]),
+  IconRotationAlignment: keyMirror(["Auto", "Map", "Viewport"]),
+  IconTextFit: keyMirror(["None", "Width", "Height", "Both"]),
+  IconTranslateAnchor: keyMirror(["Map", "Viewport"]),
+  SymbolPlacement: keyMirror(["Line", "Point"]),
+  TextAnchor: keyMirror([
+    "Center",
+    "Left",
+    "Right",
+    "Top",
+    "Bottom",
+    "TopLeft",
+    "TopRight",
+    "BottomLeft",
+    "BottomRight",
+  ]),
+  TextJustify: keyMirror(["Center", "Left", "Right"]),
+  TextPitchAlignment: keyMirror(["Auto", "Map", "Viewport"]),
+  TextRotationAlignment: keyMirror(["Auto", "Map", "Viewport"]),
+  TextTransform: keyMirror(["None", "Lowercase", "Uppercase"]),
+  TextTranslateAnchor: keyMirror(["Map", "Viewport"]),
+  LightAnchor: keyMirror(["Map", "Viewport"]),
+  OfflinePackDownloadState: keyMirror(["Inactive", "Active", "Complete"]),
+  OfflineCallbackName: keyMirror(["Progress", "Error"]),
+
+  // methods
+  setAccessToken: jest.fn(),
+  getAccessToken: () => Promise.resolve("test-token"),
+  setConnected: jest.fn(),
+};
+
+NativeModules.MLNOfflineModule = {
+  createPack: (packOptions: any) => {
+    return Promise.resolve({
+      bounds: packOptions.bounds,
+      metadata: JSON.stringify({ name: packOptions.name }),
+    });
+  },
+  getPacks: () => Promise.resolve([]),
+  deletePack: () => Promise.resolve(),
+  getPackStatus: () => Promise.resolve({}),
+  pausePackDownload: () => Promise.resolve(),
+  resumePackDownload: () => Promise.resolve(),
+  setPackObserver: () => Promise.resolve(),
+  setTileCountLimit: jest.fn(),
+  setProgressEventThrottle: jest.fn(),
+};
+
+NativeModules.MLNSnapshotModule = {
+  takeSnap: () => {
+    return Promise.resolve("file://test.png");
+  },
+};
+
+NativeModules.MLNLocationModule = {
+  getLastKnownLocation: jest.fn(),
+  setMinDisplacement: jest.fn(),
+  start: jest.fn(),
+  stop: jest.fn(),
+  pause: jest.fn(),
+};

package/jest.config.js

@@ -0,0 +1,8 @@
+module.exports = {
+  preset: "@testing-library/react-native",
+  moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json"],
+  setupFilesAfterEnv: ["./jest-setup.ts"],
+  setupFiles: ["./__tests__/__mocks__/react-native.mock.js"],
+  modulePathIgnorePatterns: ["__tests__/__mocks__", "fixtures"],
+  collectCoverageFrom: ["javascript/**/*.{ts,tsx,js,jsx}"],
+};