@mapbox/mapbox-gl-style-spec 14.0.0-beta.4 → 14.0.0-rc.2

package/error/validation_error.js

@@ -16,3 +16,5 @@ export default class ValidationError {
         }
     }
 }
+
+export class ValidationWarning extends ValidationError {}

package/flow-typed/webgl2.js

@@ -10,6 +10,11 @@ declare interface WebGLVertexArrayObject {
     new(): WebGLVertexArrayObject;
 }
 
+declare interface WebGLQuery {
+    prototype: WebGLQuery;
+    new(): WebGLQuery;
+}
+
 export type WebGL2RenderingContext = WebGLRenderingContext & {
     createVertexArray: () => WebGLVertexArrayObject | null;
     deleteVertexArray: (vertexArray: WebGLVertexArrayObject | null) => void;
@@ -17,4 +22,9 @@ export type WebGL2RenderingContext = WebGLRenderingContext & {
     getBufferSubData: (target: GLenum, srcByteOffset: GLintptr, dstBuffer: $ArrayBufferView, dstOffset?: GLuint, length?: GLuint) => void;
     drawElementsInstanced: (mode: GLenum, count: GLsizei, type: GLenum, offset: GLintptr, instanceCount: GLsizei) => void;
     vertexAttribDivisor: (index: GLuint, divisor: GLuint) => void;
+    createQuery: () => WebGLQuery;
+    beginQuery: (target: GLenum, query: WebGLQuery) => void;
+    endQuery: (target: GLenum) => void;
+    deleteQuery: (query: WebGLQuery) => void;
+    getQueryParameter: (query: WebGLQuery, pname: GLenum) => GLuint;
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@mapbox/mapbox-gl-style-spec",
   "description": "a specification for mapbox gl styles",
-  "version": "14.0.0-beta.4",
+  "version": "14.0.0-rc.2",
   "author": "Mapbox",
   "keywords": [
     "mapbox",

package/reference/v8.json

@@ -354,7 +354,14 @@
         ]
       },
       "doc": "Direction of the light source specified as [a azimuthal angle, p polar angle] where a indicates the azimuthal angle of the light relative to north (in degrees and proceeding clockwise), and p indicates polar angle of the light (from 0°, directly above, to 180°, directly below).",
-      "example": [90, 40]
+      "example": [90, 40],
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     },
     "color": {
       "type": "color",
@@ -367,7 +374,14 @@
         ]
       },
       "transition": true,
-      "doc": "Color of the directional light."
+      "doc": "Color of the directional light.",
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     },
     "intensity": {
       "type": "number",
@@ -382,7 +396,14 @@
         ]
       },
       "transition": true,
-      "doc": "A multiplier for the color of the directional light."
+      "doc": "A multiplier for the color of the directional light.",
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     },
     "cast-shadows": {
       "type": "boolean",
@@ -392,7 +413,14 @@
       "expression": {
         "interpolated": false
       },
-      "property-type": "data-constant"
+      "property-type": "data-constant",
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     },
     "shadow-intensity": {
       "type": "number",
@@ -407,7 +435,14 @@
         ]
       },
       "doc": "Determines the shadow strength, affecting the shadow receiver surfaces final color. Values near 0.0 reduce the shadow contribution to the final color. Values near to 1.0 make occluded surfaces receive almost no directional light. Designed to be used mostly for transitioning between values 0 and 1.",
-      "transition": true
+      "transition": true,
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     }
   },
   "properties_light_ambient": {
@@ -422,7 +457,14 @@
         ]
       },
       "transition": true,
-      "doc": "Color of the ambient light."
+      "doc": "Color of the ambient light.",
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     },
     "intensity": {
       "type": "number",
@@ -437,7 +479,14 @@
         ]
       },
       "transition": true,
-      "doc": "A multiplier for the color of the ambient light."
+      "doc": "A multiplier for the color of the ambient light.",
+      "sdk-support": {
+        "basic functionality": {
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
+        }
+      }
     }
   },
   "properties_light_flat": {
@@ -464,10 +513,9 @@
       "example": "map",
       "sdk-support": {
         "basic functionality": {
-          "js": "0.27.0",
-          "android": "5.1.0",
-          "ios": "3.6.0",
-          "macos": "0.5.0"
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
         }
       }
     },
@@ -496,10 +544,9 @@
       ],
       "sdk-support": {
         "basic functionality": {
-          "js": "0.27.0",
-          "android": "5.1.0",
-          "ios": "3.6.0",
-          "macos": "0.5.0"
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
         }
       }
     },
@@ -517,10 +564,9 @@
       "doc": "Color tint for lighting extruded geometries.",
       "sdk-support": {
         "basic functionality": {
-          "js": "0.27.0",
-          "android": "5.1.0",
-          "ios": "3.6.0",
-          "macos": "0.5.0"
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
         }
       }
     },
@@ -540,10 +586,9 @@
       "doc": "Intensity of lighting (on a scale from 0 to 1). Higher numbers will present as more extreme contrast.",
       "sdk-support": {
         "basic functionality": {
-          "js": "0.27.0",
-          "android": "5.1.0",
-          "ios": "3.6.0",
-          "macos": "0.5.0"
+          "js": "3.0.0",
+          "android": "11.0.0",
+          "ios": "11.0.0"
         }
       }
     }
@@ -1269,6 +1314,7 @@
     },
     "model-id": {
       "type": "string",
+      "default": "",
       "doc": "Model to render.",
       "property-type": "data-driven",
       "expression": {
@@ -5293,7 +5339,10 @@
       "minimum": 0,
       "transition": true,
       "units": "intensity",
-      "doc": "Controls the intensity of light emitted on the source features. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Controls the intensity of light emitted on the source features.",
+      "requires": [
+        "lights"
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -5556,6 +5605,12 @@
       },
       "transition": true,
       "doc": "Controls the intensity of shading near ground and concave angles between walls. Default value 0.0 disables ambient occlusion and values around 0.3 provide the most plausible results for buildings.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-flood-light-intensity"
+        }
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -5579,7 +5634,10 @@
       "transition": true,
       "doc": "Shades area near ground and concave angles between walls where the radius defines only vertical impact. Default value 3.0 corresponds to height of one floor and brings the most plausible results for buildings. This property works only with legacy light. When 3D light is enabled `fill-extrusion-ambient-occlusion-wall-radius` and `fill-extrusion-ambient-occlusion-ground-radius` are used instead.",
       "requires": [
-        "fill-extrusion-edge-radius"
+        "fill-extrusion-edge-radius",
+        {
+          "!": "fill-extrusion-flood-light-intensity"
+        }
       ],
       "sdk-support": {
         "basic functionality": {
@@ -5601,9 +5659,13 @@
         ]
       },
       "transition": true,
-      "doc": "Shades area near ground and concave angles between walls where the radius defines only vertical impact. Default value 3.0 corresponds to height of one floor and brings the most plausible results for buildings. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Shades area near ground and concave angles between walls where the radius defines only vertical impact. Default value 3.0 corresponds to height of one floor and brings the most plausible results for buildings.",
       "requires": [
-        "fill-extrusion-edge-radius"
+        "lights",
+        "fill-extrusion-edge-radius",
+        {
+          "!": "fill-extrusion-flood-light-intensity"
+        }
       ],
       "sdk-support": {
         "basic functionality": {
@@ -5625,7 +5687,13 @@
         ]
       },
       "transition": true,
-      "doc": "The extent of the ambient occlusion effect on the ground beneath the extruded buildings in meters. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "The extent of the ambient occlusion effect on the ground beneath the extruded buildings in meters.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-flood-light-intensity"
+        }
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -5640,7 +5708,13 @@
       "default": 0.69,
       "minimum": 0.0,
       "maximum": 1.0,
-      "doc": "Provides a control to futher fine-tune the look of the ambient occlusion on the ground beneath the extruded buildings. Lower values give the effect a more solid look while higher values make it smoother. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Provides a control to futher fine-tune the look of the ambient occlusion on the ground beneath the extruded buildings. Lower values give the effect a more solid look while higher values make it smoother.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-flood-light-intensity"
+        }
+      ],
       "transition": true,
       "expression": {
         "interpolated": true,
@@ -5660,7 +5734,13 @@
       "property-type": "data-constant",
       "type": "color",
       "default": "#ffffff",
-      "doc": "The color of the flood light effect on the walls of the extruded buildings. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "The color of the flood light effect on the walls of the extruded buildings.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-ambient-occlusion-intensity"
+        }
+      ],
       "transition": true,
       "expression": {
         "interpolated": true,
@@ -5683,7 +5763,13 @@
       "default": 0.0,
       "minimum": 0.0,
       "maximum": 1.0,
-      "doc": "The intensity of the flood light color. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "The intensity of the flood light color.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-ambient-occlusion-intensity"
+        }
+      ],
       "transition": true,
       "expression": {
         "interpolated": true,
@@ -5706,7 +5792,13 @@
       "units": "meters",
       "default": 0,
       "minimum": 0,
-      "doc": "The extent of the flood light effect on the walls of the extruded buildings in meters. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "The extent of the flood light effect on the walls of the extruded buildings in meters.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-ambient-occlusion-intensity"
+        }
+      ],
       "transition": true,
       "expression": {
         "interpolated": true,
@@ -5734,7 +5826,13 @@
       "units": "meters",
       "default": 0,
       "minimum": 0,
-      "doc": "The extent of the flood light effect on the ground beneath the extruded buildings in meters. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "The extent of the flood light effect on the ground beneath the extruded buildings in meters.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-ambient-occlusion-intensity"
+        }
+      ],
       "transition": true,
       "expression": {
         "interpolated": true,
@@ -5762,7 +5860,13 @@
       "default": 0.69,
       "minimum": 0.0,
       "maximum": 1.0,
-      "doc": "Provides a control to futher fine-tune the look of the flood light on the ground beneath the extruded buildings. Lower values give the effect a more solid look while higher values make it smoother. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Provides a control to futher fine-tune the look of the flood light on the ground beneath the extruded buildings. Lower values give the effect a more solid look while higher values make it smoother.",
+      "requires": [
+        "lights",
+        {
+          "!": "fill-extrusion-ambient-occlusion-intensity"
+        }
+      ],
       "transition": true,
       "expression": {
         "interpolated": true,
@@ -6236,7 +6340,10 @@
       "minimum": 0,
       "transition": true,
       "units": "intensity",
-      "doc": "Controls the intensity of light emitted on the source features. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Controls the intensity of light emitted on the source features.",
+      "requires": [
+        "lights"
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -6650,7 +6757,10 @@
       "minimum": 0,
       "transition": true,
       "units": "intensity",
-      "doc": "Controls the intensity of light emitted on the source features. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Controls the intensity of light emitted on the source features.",
+      "requires": [
+        "lights"
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -6862,7 +6972,10 @@
       "minimum": 0,
       "transition": true,
       "units": "intensity",
-      "doc": "Controls the intensity of light emitted on the source features. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Controls the intensity of light emitted on the source features.",
+      "requires": [
+        "lights"
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -6890,7 +7003,10 @@
       "minimum": 0,
       "transition": true,
       "units": "intensity",
-      "doc": "Controls the intensity of light emitted on the source features. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Controls the intensity of light emitted on the source features.",
+      "requires": [
+        "lights"
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -7660,7 +7776,7 @@
       "default": 335,
       "minimum": 0,
       "maximum": 359,
-      "doc": "The direction of the light source used to generate the hillshading with 0 as the top of the viewport if `hillshade-illumination-anchor` is set to `viewport` and due north if `hillshade-illumination-anchor` is set to `map`.",
+      "doc": "The direction of the light source used to generate the hillshading with 0 as the top of the viewport if `hillshade-illumination-anchor` is set to `viewport` and due north if `hillshade-illumination-anchor` is set to `map` and no 3d lights enabled. If `hillshade-illumination-anchor` is set to `map` and 3d lights enabled, the direction from 3d lights is used instead.",
       "transition": false,
       "sdk-support": {
         "basic functionality": {
@@ -7895,7 +8011,10 @@
       "minimum": 0,
       "transition": true,
       "units": "intensity",
-      "doc": "Controls the intensity of light emitted on the source features. This property works only with 3D light, i.e. when `lights` root property is defined.",
+      "doc": "Controls the intensity of light emitted on the source features.",
+      "requires": [
+        "lights"
+      ],
       "sdk-support": {
         "basic functionality": {
           "js": "3.0.0",
@@ -8181,7 +8300,7 @@
       "property-type": "data-driven",
       "expression": {
         "interpolated": true,
-        "parameters": ["feature", "feature-state"]
+        "parameters": ["feature", "feature-state", "zoom"]
       },
       "sdk-support": {
          "basic functionality": {
@@ -8231,7 +8350,7 @@
       "property-type": "data-driven",
       "expression": {
         "interpolated": true,
-        "parameters": ["feature", "feature-state"]
+        "parameters": ["feature", "feature-state", "zoom"]
       },
       "sdk-support": {
           "basic functionality": {
@@ -8255,7 +8374,7 @@
       "property-type": "data-driven",
       "expression": {
         "interpolated": true,
-        "parameters": ["feature", "feature-state", "measure-light"]
+        "parameters": ["feature", "feature-state", "measure-light", "zoom"]
       },
       "sdk-support": {
           "basic functionality": {
@@ -8377,7 +8496,7 @@
       "default": 0.0,
       "minimum": 0,
       "maximum": 5,
-      "units": "number",
+      "units": "intensity",
       "doc": "Strength of the emission. There is no emission for value 0. For value 1.0, only emissive component (no shading) is displayed and values above 1.0 produce light contribution to surrounding area, for some of the parts (e.g. doors). Expressions that depend on measure-light are not supported when using GeoJSON or vector tile as the model layer source.",
       "expression": {
         "interpolated": true,

package/validate/validate_fog.js

@@ -1,6 +1,6 @@
 // @flow
 
-import ValidationError from '../error/validation_error.js';
+import {default as ValidationError, ValidationWarning} from '../error/validation_error.js';
 import validate from './validate.js';
 import getType from '../util/get_type.js';
 
@@ -41,7 +41,7 @@ export default function validateFog(options: ValidationOptions): Array<Validatio
                 styleSpec
             }));
         } else {
-            errors = errors.concat([new ValidationError(key, fog[key], `unknown property "${key}"`)]);
+            errors = errors.concat([new ValidationWarning(key, fog[key], `unknown property "${key}"`)]);
         }
     }
 

package/validate/validate_import.js

@@ -4,6 +4,7 @@ import extend from '../util/extend.js';
 import validateStyle from './validate_style.js';
 import validateObject from './validate_object.js';
 import ValidationError from '../error/validation_error.js';
+import {unbundle} from '../util/unbundle_jsonlint.js';
 
 import type {ValidationOptions} from './validate.js';
 
@@ -22,6 +23,12 @@ export default function validateImport(options: ValidationOptions): ValidationEr
         valueSpec: styleSpec.import
     }));
 
+    // Empty string is reserved for the root style id
+    if (unbundle(importSpec.id) === '') {
+        const key = `${options.key}.id`;
+        errors.push(new ValidationError(key, importSpec, `import id can't be an empty string`));
+    }
+
     if (data) {
         const key = `${options.key}.data`;
         errors = errors.concat(validateStyle(data, styleSpec, {key}));

package/validate/validate_lights.js

@@ -1,12 +1,17 @@
 // @flow
 
-import ValidationError from '../error/validation_error.js';
+import {default as ValidationError, ValidationWarning} from '../error/validation_error.js';
 import getType from '../util/get_type.js';
 import validate from './validate.js';
+import {unbundle} from '../util/unbundle_jsonlint.js';
 
 import type {ValidationOptions} from './validate.js';
 
-export default function validateLights(options: ValidationOptions): Array<ValidationError> {
+type Options = ValidationOptions & {
+    arrayIndex: number;
+}
+
+export default function validateLights(options: Options): Array<ValidationError> {
     const light = options.value;
     let errors = [];
 
@@ -22,7 +27,9 @@ export default function validateLights(options: ValidationOptions): Array<Valida
 
     const styleSpec = options.styleSpec;
     const lightSpec = styleSpec['light-3d'];
+    const key = options.key;
     const style = options.style;
+    const lights = options.style.lights;
 
     for (const key of ['type', 'id']) {
         if (!(key in light)) {
@@ -31,6 +38,17 @@ export default function validateLights(options: ValidationOptions): Array<Valida
         }
     }
 
+    if (light.type && lights) {
+        for (let i = 0; i < options.arrayIndex; i++) {
+            const lightType = unbundle(light.type);
+            const otherLight = lights[i];
+            if (unbundle(otherLight.type) === lightType) {
+                // $FlowFixMe[prop-missing] - id.__line__ is added dynamically during the readStyle step
+                errors.push(new ValidationError(key, light.id, `duplicate light type "${light.type}", previously defined at line ${otherLight.id.__line__}`));
+            }
+        }
+    }
+
     const lightType = `properties_light_${light['type']}`;
     if (!(lightType in styleSpec)) {
         errors = errors.concat([new ValidationError('light-3d', light, `Invalid light type ${light['type']}`)]);
@@ -48,13 +66,17 @@ export default function validateLights(options: ValidationOptions): Array<Valida
                 return errors;
             }
             for (const propertyKey in properties) {
-                errors = errors.concat(validate({
-                    key: propertyKey,
-                    value: properties[propertyKey],
-                    valueSpec: lightPropertySpec[propertyKey],
-                    style,
-                    styleSpec
-                }));
+                if (!lightPropertySpec[propertyKey]) {
+                    errors = errors.concat([new ValidationWarning(options.key, properties[propertyKey], `unknown property "${propertyKey}"`)]);
+                } else {
+                    errors = errors.concat(validate({
+                        key: propertyKey,
+                        value: properties[propertyKey],
+                        valueSpec: lightPropertySpec[propertyKey],
+                        style,
+                        styleSpec
+                    }));
+                }
             }
         } else {
             const transitionMatch = key.match(/^(.*)-transition$/);
@@ -75,7 +97,7 @@ export default function validateLights(options: ValidationOptions): Array<Valida
                     styleSpec
                 }));
             } else {
-                errors = errors.concat([new ValidationError(key, light[key], `unknown property "${key}"`)]);
+                errors = errors.concat([new ValidationWarning(key, light[key], `unknown property "${key}"`)]);
             }
         }
     }

package/validate/validate_object.js

@@ -1,6 +1,6 @@
 // @flow
 
-import ValidationError from '../error/validation_error.js';
+import {default as ValidationError, ValidationWarning} from '../error/validation_error.js';
 import getType from '../util/get_type.js';
 import validateSpec from './validate.js';
 
@@ -40,7 +40,7 @@ export default function validateObject(options: Options): Array<ValidationError>
         }
 
         if (!validateElement) {
-            errors.push(new ValidationError(key, object[objectKey], `unknown property "${objectKey}"`));
+            errors.push(new ValidationWarning(key, object[objectKey], `unknown property "${objectKey}"`));
             continue;
         }
 

package/validate/validate_property.js

@@ -1,7 +1,7 @@
 // @flow
 
 import validate from './validate.js';
-import ValidationError from '../error/validation_error.js';
+import {default as ValidationError, ValidationWarning} from '../error/validation_error.js';
 import getType from '../util/get_type.js';
 import {isFunction} from '../function/index.js';
 import {unbundle, deepUnbundle} from '../util/unbundle_jsonlint.js';
@@ -41,7 +41,7 @@ export default function validateProperty(options: PropertyValidationOptions, pro
 
     const valueSpec = options.valueSpec || layerSpec[propertyKey];
     if (!valueSpec) {
-        return [new ValidationError(key, value, `unknown property "${propertyKey}"`)];
+        return [new ValidationWarning(key, value, `unknown property "${propertyKey}"`)];
     }
 
     let tokenMatch: ?RegExp$matchResult;
@@ -67,8 +67,8 @@ export default function validateProperty(options: PropertyValidationOptions, pro
             // Performance related style spec limitation: zoom and light expressions are not allowed for e.g. trees.
             const expression = createPropertyExpression(deepUnbundle(value), valueSpec);
             const expressionObj = (expression.value: any).expression || (expression.value: any)._styleExpression.expression;
-            if (expressionObj && (!isGlobalPropertyConstant(expressionObj, ['zoom']) || !isGlobalPropertyConstant(expressionObj, ['measure-light']))) {
-                errors.push(new ValidationError(key, value, `${propertyKey} does not support zoom or measure-light expressions when the model layer source is vector tile or GeoJSON.`));
+            if (expressionObj && !isGlobalPropertyConstant(expressionObj, ['measure-light'])) {
+                errors.push(new ValidationError(key, value, `${propertyKey} does not support measure-light expressions when the model layer source is vector tile or GeoJSON.`));
             }
         }
     }

package/validate/validate_terrain.js

@@ -1,6 +1,6 @@
 // @flow
 
-import ValidationError from '../error/validation_error.js';
+import {default as ValidationError, ValidationWarning} from '../error/validation_error.js';
 import validate from './validate.js';
 import getType from '../util/get_type.js';
 import {unbundle} from '../util/unbundle_jsonlint.js';
@@ -43,7 +43,7 @@ export default function validateTerrain(options: ValidationOptions): Array<Valid
                 styleSpec
             }));
         } else {
-            errors = errors.concat([new ValidationError(key, terrain[key], `unknown property "${key}"`)]);
+            errors = errors.concat([new ValidationWarning(key, terrain[key], `unknown property "${key}"`)]);
         }
     }
 

package/validate_mapbox_api_supported.js

@@ -118,6 +118,9 @@ function getImportErrors(imports: Array<Object> = []): {errors: Array<Validation
     };
 
     validateImports(imports);
+    if (imports.length !== (new Set(imports.map(i => i.id))).size) {
+        errors.push(new ValidationError(null, null, 'Duplicate ids of imports'));
+    }
 
     return {errors, sourcesCount};
 }