@maoleijin/dsh-mattpocock-skills 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +21 -0
- package/README.md +79 -0
- package/cordis.patch.yml +12 -0
- package/docs/installation.md +51 -0
- package/overlay/patches.json +462 -0
- package/overlay/skills/dsh-workflow/dsh-workflow/DSH-MAPPING.md +40 -0
- package/overlay/skills/dsh-workflow/dsh-workflow/SKILL.md +47 -0
- package/overlay/skills/dsh-workflow/dsh-workflow/SKILLS.md +50 -0
- package/overlay/skills/dsh-workflow/dsh-workflow/agents/openai.yaml +3 -0
- package/package.json +78 -0
- package/scripts/install-web.bat +32 -0
- package/skills/engineering/ask-matt/PHASE-BOUNDARIES.md +55 -0
- package/skills/engineering/ask-matt/SKILL.md +90 -0
- package/skills/engineering/ask-matt/agents/openai.yaml +5 -0
- package/skills/engineering/code-review/SKILL.md +87 -0
- package/skills/engineering/code-review/agents/openai.yaml +3 -0
- package/skills/engineering/codebase-design/DEEPENING.md +37 -0
- package/skills/engineering/codebase-design/DESIGN-IT-TWICE.md +44 -0
- package/skills/engineering/codebase-design/SKILL.md +114 -0
- package/skills/engineering/codebase-design/agents/openai.yaml +3 -0
- package/skills/engineering/diagnosing-bugs/SKILL.md +138 -0
- package/skills/engineering/diagnosing-bugs/agents/openai.yaml +3 -0
- package/skills/engineering/diagnosing-bugs/scripts/hitl-loop.template.sh +44 -0
- package/skills/engineering/domain-modeling/ADR-FORMAT.md +47 -0
- package/skills/engineering/domain-modeling/CONTEXT-FORMAT.md +60 -0
- package/skills/engineering/domain-modeling/SKILL.md +74 -0
- package/skills/engineering/domain-modeling/agents/openai.yaml +3 -0
- package/skills/engineering/grill-with-docs/SKILL.md +7 -0
- package/skills/engineering/grill-with-docs/agents/openai.yaml +5 -0
- package/skills/engineering/implement/SKILL.md +15 -0
- package/skills/engineering/implement/agents/openai.yaml +5 -0
- package/skills/engineering/improve-codebase-architecture/HTML-REPORT.md +123 -0
- package/skills/engineering/improve-codebase-architecture/SKILL.md +71 -0
- package/skills/engineering/improve-codebase-architecture/agents/openai.yaml +5 -0
- package/skills/engineering/prototype/LOGIC.md +67 -0
- package/skills/engineering/prototype/SKILL.md +26 -0
- package/skills/engineering/prototype/UI.md +112 -0
- package/skills/engineering/prototype/agents/openai.yaml +3 -0
- package/skills/engineering/research/SKILL.md +12 -0
- package/skills/engineering/research/agents/openai.yaml +3 -0
- package/skills/engineering/resolving-merge-conflicts/SKILL.md +14 -0
- package/skills/engineering/resolving-merge-conflicts/agents/openai.yaml +3 -0
- package/skills/engineering/setup-matt-pocock-skills/SKILL.md +116 -0
- package/skills/engineering/setup-matt-pocock-skills/agents/openai.yaml +5 -0
- package/skills/engineering/setup-matt-pocock-skills/domain.md +51 -0
- package/skills/engineering/setup-matt-pocock-skills/issue-tracker-github.md +45 -0
- package/skills/engineering/setup-matt-pocock-skills/issue-tracker-gitlab.md +46 -0
- package/skills/engineering/setup-matt-pocock-skills/issue-tracker-local.md +30 -0
- package/skills/engineering/setup-matt-pocock-skills/triage-labels.md +15 -0
- package/skills/engineering/tdd/SKILL.md +38 -0
- package/skills/engineering/tdd/agents/openai.yaml +3 -0
- package/skills/engineering/tdd/mocking.md +59 -0
- package/skills/engineering/tdd/tests.md +77 -0
- package/skills/engineering/to-spec/SKILL.md +75 -0
- package/skills/engineering/to-spec/agents/openai.yaml +5 -0
- package/skills/engineering/to-tickets/SKILL.md +105 -0
- package/skills/engineering/to-tickets/agents/openai.yaml +5 -0
- package/skills/engineering/triage/AGENT-BRIEF.md +207 -0
- package/skills/engineering/triage/OUT-OF-SCOPE.md +105 -0
- package/skills/engineering/triage/SKILL.md +112 -0
- package/skills/engineering/triage/agents/openai.yaml +5 -0
- package/skills/engineering/wayfinder/SKILL.md +128 -0
- package/skills/engineering/wayfinder/agents/openai.yaml +5 -0
- package/skills/engineering/wizard/SKILL.md +44 -0
- package/skills/engineering/wizard/agents/openai.yaml +3 -0
- package/skills/engineering/wizard/template.sh +204 -0
- package/skills/in-progress/claude-handoff/SKILL.md +18 -0
- package/skills/in-progress/claude-handoff/agents/openai.yaml +5 -0
- package/skills/in-progress/implement-spec/SKILL.md +35 -0
- package/skills/in-progress/implement-spec/agents/openai.yaml +5 -0
- package/skills/in-progress/loop-me/SKILL.md +32 -0
- package/skills/in-progress/loop-me/agents/openai.yaml +5 -0
- package/skills/in-progress/retro/SKILL.md +44 -0
- package/skills/in-progress/retro/agents/openai.yaml +5 -0
- package/skills/in-progress/setup-ts-deep-modules/SKILL.md +102 -0
- package/skills/in-progress/setup-ts-deep-modules/agents/openai.yaml +5 -0
- package/skills/in-progress/setup-ts-deep-modules/dependency-cruiser.config.cjs +95 -0
- package/skills/in-progress/writing-beats/SKILL.md +67 -0
- package/skills/in-progress/writing-beats/agents/openai.yaml +5 -0
- package/skills/in-progress/writing-fragments/SKILL.md +79 -0
- package/skills/in-progress/writing-fragments/agents/openai.yaml +5 -0
- package/skills/in-progress/writing-shape/SKILL.md +79 -0
- package/skills/in-progress/writing-shape/agents/openai.yaml +5 -0
- package/skills/misc/git-guardrails-claude-code/SKILL.md +95 -0
- package/skills/misc/git-guardrails-claude-code/agents/openai.yaml +3 -0
- package/skills/misc/git-guardrails-claude-code/scripts/block-dangerous-git.sh +25 -0
- package/skills/misc/migrate-to-shoehorn/SKILL.md +118 -0
- package/skills/misc/migrate-to-shoehorn/agents/openai.yaml +3 -0
- package/skills/misc/scaffold-exercises/SKILL.md +106 -0
- package/skills/misc/scaffold-exercises/agents/openai.yaml +3 -0
- package/skills/misc/setup-pre-commit/SKILL.md +91 -0
- package/skills/misc/setup-pre-commit/agents/openai.yaml +3 -0
- package/skills/productivity/grill-me/SKILL.md +7 -0
- package/skills/productivity/grill-me/agents/openai.yaml +5 -0
- package/skills/productivity/grilling/SKILL.md +28 -0
- package/skills/productivity/grilling/agents/openai.yaml +3 -0
- package/skills/productivity/handoff/SKILL.md +16 -0
- package/skills/productivity/handoff/agents/openai.yaml +5 -0
- package/skills/productivity/teach/GLOSSARY-FORMAT.md +35 -0
- package/skills/productivity/teach/LEARNING-RECORD-FORMAT.md +46 -0
- package/skills/productivity/teach/MISSION-FORMAT.md +31 -0
- package/skills/productivity/teach/RESOURCES-FORMAT.md +32 -0
- package/skills/productivity/teach/SKILL.md +140 -0
- package/skills/productivity/teach/agents/openai.yaml +5 -0
- package/skills/productivity/to-questionnaire/SKILL.md +54 -0
- package/skills/productivity/to-questionnaire/agents/openai.yaml +5 -0
- package/skills/productivity/wait-what/SKILL.md +7 -0
- package/skills/productivity/wait-what/agents/openai.yaml +5 -0
- package/skills/productivity/writing-for-agents/SKILL-MECHANICS.md +22 -0
- package/skills/productivity/writing-for-agents/SKILL.md +81 -0
- package/skills/productivity/writing-for-agents/agents/openai.yaml +3 -0
- package/src/frontmatter.js +153 -0
- package/src/index.js +99 -0
- package/src/overlay.js +322 -0
- package/src/paths.js +21 -0
- package/src/provider.js +294 -0
- package/src/skills.js +325 -0
- package/src/yaml.js +57 -0
- package/test/bundle.test.js +317 -0
- package/test/verify-profile.cjs +48 -0
- package/tools/archive-duplicates.mjs +139 -0
- package/vendor/VENDOR.md +67 -0
- package/vendor/gen-slash-rules.mjs +119 -0
- package/vendor/overlay-report.mjs +107 -0
- package/vendor/skills.manifest.json +493 -0
- package/vendor/sync-upstream.mjs +33 -0
- package/vendor/vendor-skills.mjs +419 -0
|
@@ -0,0 +1,47 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: dsh-workflow
|
|
3
|
+
description: Map for using Matt Pocock's engineering skills inside DeepSeek Harness — which of the 36 skills the model may load itself, which are user-only, how the flows connect, and how they hand off to DSH's subagents, plan mode, goals and session commands. Load this before routing work through the mattpocock set, or when a Matt Pocock skill tells you to run something you cannot run.
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Matt Pocock's skills in DSH
|
|
7
|
+
|
|
8
|
+
This bundle ships Matt Pocock's engineering skills (`mattpocock/skills` 1.2.3, 35 skills) plus this map. The skills themselves are unchanged in substance; what this file adds is the part that differs between harnesses: **who is allowed to start a skill, and what a reference to another skill means here.**
|
|
9
|
+
|
|
10
|
+
## The one rule that changes behaviour
|
|
11
|
+
|
|
12
|
+
Upstream is written for a harness where the model can run `/name` as a command. In DSH that is false in two ways:
|
|
13
|
+
|
|
14
|
+
1. **`/name` is a user-facing slash command.** You cannot type it or execute it. A skill name in backticks is just a name: to act on it, call the `skill` tool with that exact name.
|
|
15
|
+
2. **User-only skills are hard-blocked for you.** DSH refuses to load any skill marked `disable-model-invocation: true`: `skill` returns `skill "<name>" is not available for model invocation`. That is not a policy you can talk your way around — the 20 user-only skills in this bundle cannot be loaded by you at all.
|
|
16
|
+
|
|
17
|
+
So when a flow needs a user-only skill, **name it and let the user invoke it** (or suggest they ask for it). Do not claim you ran it, and do not try to reproduce its 400 lines from memory: those skills are deliberately user-started because they open a fresh context window and keep the human driving.
|
|
18
|
+
|
|
19
|
+
If the user wants you to be able to load one of them, that is a configuration change, not a workaround: the plugin's `promote` list turns a user-only skill into a model-invocable one.
|
|
20
|
+
|
|
21
|
+
## Start here
|
|
22
|
+
|
|
23
|
+
- **`ask-matt`** — the router and flow map (user-only). It answers "which skill fits this?". Load `dsh-workflow` instead when the question is "how does this work *in DSH*".
|
|
24
|
+
- **`setup-matt-pocock-skills`** — the one prerequisite for the engineering flows (user-only): configures the issue tracker, triage labels and `CONTEXT.md`/ADR layout a repo needs. Three skills (`code-review`, `to-spec`, `to-tickets`, `wayfinder`, `triage`) depend on its output and now say so explicitly instead of telling you to run it.
|
|
25
|
+
- **[SKILLS.md](SKILLS.md)** — every skill with its invocation policy and what each one is for.
|
|
26
|
+
- **[DSH-MAPPING.md](DSH-MAPPING.md)** — upstream term → DSH equivalent, and the DSH features worth reaching for in each flow.
|
|
27
|
+
|
|
28
|
+
## How the flows land in DSH
|
|
29
|
+
|
|
30
|
+
The main flow (`grill-with-docs` → `to-spec` → `to-tickets` → `implement` → `code-review`) is intact, with these hand-offs rewritten:
|
|
31
|
+
|
|
32
|
+
| Flow step | Who runs it | What you do |
|
|
33
|
+
| --- | --- | --- |
|
|
34
|
+
| `grill-with-docs`, `grill-me`, `triage`, `wayfinder`, `implement`, `to-spec`, `to-tickets`, `handoff` | user-only | Name the skill when the moment arrives and let the user start it. Continue when they come back. |
|
|
35
|
+
| `grilling`, `domain-modeling`, `codebase-design`, `tdd`, `code-review`, `diagnosing-bugs`, `research`, `prototype`, `wizard`, `resolving-merge-conflicts`, `writing-for-agents`, `migrate-to-shoehorn`, `scaffold-exercises`, `setup-pre-commit` | you | Load with the `skill` tool and work the skill in this session. |
|
|
36
|
+
| Parallel review, research fan-out, design-it-twice | you | DSH's `subagent` tool (background, durable id, report back) or `workflow` for a real fan-out. See [DSH-MAPPING.md](DSH-MAPPING.md). |
|
|
37
|
+
| A fresh context window between tickets | user | Only the user starts a new session. Ask for it at the phase boundary the flow names. |
|
|
38
|
+
| `/compact` | user | The command exists in DSH; ask the user to run it, optionally with their instruction. |
|
|
39
|
+
|
|
40
|
+
Subagents keep the flow's "no context pollution" promise, and they are how several skills actually work (`code-review` runs Standards and Spec in parallel; `codebase-design`'s design-it-twice runs three or more). Give each subagent the brief the skill specifies, run them concurrently, and aggregate their reports yourself — the skill's own process stays the source of truth.
|
|
41
|
+
|
|
42
|
+
## Two things not to trust as written
|
|
43
|
+
|
|
44
|
+
- **`git-guardrails-claude-code`** installs a Claude Code hook that DSH never reads. Its body now says so at the top. For git safety in DSH, use a repo-level `pre-commit`/`pre-push` hook (`setup-pre-commit`) or DSH's permission settings — not a `.claude/settings.json` hook.
|
|
45
|
+
- **`claude-handoff`** described launching Claude Code's background CLI; its body now delegates with `subagent`/`subagent_fork` instead. The handoff *document* skill (`handoff`) is unaffected except that it now writes into the workspace rather than the OS temp directory, so a fresh session of yours can actually find the file.
|
|
46
|
+
|
|
47
|
+
Everything else is upstream text, with only its cross-skill references rewritten. `vendor/overlay/patches.json` in the plugin package lists every rewrite.
|
|
@@ -0,0 +1,50 @@
|
|
|
1
|
+
# The skill catalog
|
|
2
|
+
|
|
3
|
+
Generated from `vendor/skills.manifest.json` by `node vendor/vendor-skills.mjs`. Do not edit by hand.
|
|
4
|
+
|
|
5
|
+
| Skill | Who can start it | Category | What it is for |
|
|
6
|
+
| --- | --- | --- | --- |
|
|
7
|
+
| `dsh-workflow` | model + user | overlay | DSH invocation rules, workflow map, and platform equivalents. |
|
|
8
|
+
| `ask-matt` | **user only** | engineering | Ask which skill or flow fits your situation. A router over the skills in this repo. |
|
|
9
|
+
| `claude-handoff` | **user only** | in-progress | Hand the current conversation off to a fresh background agent that picks up the work immediately. |
|
|
10
|
+
| `code-review` | model + user | engineering | Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/spec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to "review since X". |
|
|
11
|
+
| `codebase-design` | model + user | engineering | Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary. |
|
|
12
|
+
| `diagnosing-bugs` | model + user | engineering | Diagnosis loop for hard bugs and performance regressions. Use when the user says "diagnose"/"debug this", or reports something broken/throwing/failing/slow. |
|
|
13
|
+
| `domain-modeling` | model + user | engineering | Build and sharpen a project's domain model. Use when discussing codebase terminology, writing or editing a CONTEXT.md, or recording or editing an ADR. |
|
|
14
|
+
| `git-guardrails-claude-code` | model + user | misc | Set up Claude Code hooks to block dangerous git commands (push, reset --hard, clean, branch -D, etc.) before they execute. Use when user wants to prevent destructive git operations, add git safety hooks, or block git push/reset in Claude Code. |
|
|
15
|
+
| `grill-me` | **user only** | productivity | A relentless interview to sharpen a plan or design. |
|
|
16
|
+
| `grill-with-docs` | **user only** | engineering | A relentless interview to sharpen a plan or design, which also creates docs (ADR's and glossary) as we go. |
|
|
17
|
+
| `grilling` | model + user | productivity | Grill the user relentlessly about a plan, decision, or idea. Use when the user wants to stress-test their thinking, or uses any 'grill' trigger phrases. |
|
|
18
|
+
| `handoff` | **user only** | productivity | Compact the current conversation into a handoff document for another agent to pick up. |
|
|
19
|
+
| `implement` | **user only** | engineering | Implement a piece of work based on a spec or set of tickets. |
|
|
20
|
+
| `implement-spec` | **user only** | in-progress | Implement a specification in code. |
|
|
21
|
+
| `improve-codebase-architecture` | **user only** | engineering | Scan a codebase for deepening opportunities, present them as a visual HTML report, then grill through whichever one you pick. |
|
|
22
|
+
| `loop-me` | **user only** | in-progress | Grill me about specs for the workflows I want to build, within this workspace. |
|
|
23
|
+
| `migrate-to-shoehorn` | model + user | misc | Migrate test files from `as` type assertions to @total-typescript/shoehorn. Use when user mentions shoehorn, wants to replace `as` in tests, or needs partial test data. |
|
|
24
|
+
| `prototype` | model + user | engineering | Build a throwaway prototype to answer a design question. Use when the user wants to sanity-check whether a state model or logic feels right, or explore what a UI should look like. |
|
|
25
|
+
| `research` | model + user | engineering | Investigate a question against high-trust primary sources and capture the findings as a Markdown file in the repo. Use when the user wants a topic researched, docs or API facts gathered, or reading legwork delegated to a background agent. |
|
|
26
|
+
| `resolving-merge-conflicts` | model + user | engineering | Use when you need to resolve an in-progress git merge/rebase conflict. |
|
|
27
|
+
| `retro` | **user only** | in-progress | Conduct a retrospective on a coding session. |
|
|
28
|
+
| `scaffold-exercises` | model + user | misc | Create exercise directory structures with sections, problems, solutions, and explainers that pass linting. Use when user wants to scaffold exercises, create exercise stubs, or set up a new course section. |
|
|
29
|
+
| `setup-matt-pocock-skills` | **user only** | engineering | Configure this repo for the engineering skills: set up its issue tracker, triage label vocabulary, and domain doc layout. Run once before first use of the other engineering skills. |
|
|
30
|
+
| `setup-pre-commit` | model + user | misc | Set up Husky pre-commit hooks with lint-staged (Prettier), type checking, and tests in the current repo. Use when user wants to add pre-commit hooks, set up Husky, configure lint-staged, or add commit-time formatting/typechecking/testing. |
|
|
31
|
+
| `setup-ts-deep-modules` | **user only** | in-progress | Wire dependency-cruiser into a TypeScript repo so each package is a deep module, with implementation hidden in subfolders and reachable only through its entry-point files. User-invoked. |
|
|
32
|
+
| `tdd` | model + user | engineering | Test-driven development. Use when the user wants to build features or fix bugs test-first, mentions "red-green-refactor", or wants integration tests. |
|
|
33
|
+
| `teach` | **user only** | productivity | Teach the user a new skill or concept, within this workspace. |
|
|
34
|
+
| `to-questionnaire` | **user only** | productivity | Turn a decision you can't fully answer into a questionnaire for someone else to fill in. |
|
|
35
|
+
| `to-spec` | **user only** | engineering | Turn the current conversation into a spec and publish it to the project issue tracker: no interview, just synthesis of what you've already discussed. |
|
|
36
|
+
| `to-tickets` | **user only** | engineering | Break a plan, spec, or the current conversation into a set of tracer-bullet tickets, each declaring its blocking edges, published to the configured tracker (edges as text in one file per ticket locally, or native blocking links on a real tracker). |
|
|
37
|
+
| `triage` | **user only** | engineering | Move issues and external PRs through a state machine of triage roles, categorise, verify, grill if needed, and write agent-ready briefs. |
|
|
38
|
+
| `wait-what` | **user only** | productivity | Stop. That last message did not land: re-pitch it. |
|
|
39
|
+
| `wayfinder` | **user only** | engineering | Plan a huge chunk of work (more than one agent session can hold) as a shared map of decision tickets on your issue tracker, and resolve them one at a time until the way to the destination is clear. |
|
|
40
|
+
| `wizard` | model + user | engineering | Generate an interactive bash wizard that walks a human through steps only they can perform. Use when provisioning infrastructure, setting up credentials or CI secrets, walking an unfamiliar third-party dashboard, or running a one-off migration or cutover. Don't invoke this for steps the agent can perform itself. |
|
|
41
|
+
| `writing-beats` | **user only** | in-progress | Writing, exploit; assemble raw material into a journey of beats, grounding each term before a beat leans on it. |
|
|
42
|
+
| `writing-for-agents` | model + user | productivity | Writing documents for agents. Use when creating or editing skills, or modifying AGENTS.md or CLAUDE.md. |
|
|
43
|
+
| `writing-fragments` | **user only** | in-progress | Writing, explore: mine raw fragments, no structure yet. |
|
|
44
|
+
| `writing-shape` | **user only** | in-progress | Writing, exploit: shape raw material into an article, paragraph by paragraph. |
|
|
45
|
+
|
|
46
|
+
## Notes
|
|
47
|
+
|
|
48
|
+
- `user only` preserves upstream `disable-model-invocation: true`; the user starts those flows.
|
|
49
|
+
- `in-progress` skills are experimental upstream and may change without compatibility guarantees.
|
|
50
|
+
- DSH applies the adaptations in `overlay/patches.json` in memory; vendored files remain byte-identical to upstream.
|
package/package.json
ADDED
|
@@ -0,0 +1,78 @@
|
|
|
1
|
+
{
|
|
2
|
+
"name": "@maoleijin/dsh-mattpocock-skills",
|
|
3
|
+
"version": "0.1.0",
|
|
4
|
+
"private": false,
|
|
5
|
+
"publishConfig": {
|
|
6
|
+
"access": "public"
|
|
7
|
+
},
|
|
8
|
+
"description": "Continuously synchronized Matt Pocock skills for DeepSeek Harness, with a verified DSH adaptation overlay.",
|
|
9
|
+
"license": "MIT",
|
|
10
|
+
"author": {
|
|
11
|
+
"name": "Matt Pocock",
|
|
12
|
+
"url": "https://www.aihero.dev"
|
|
13
|
+
},
|
|
14
|
+
"contributors": [
|
|
15
|
+
"DSH adaptation by NmouZh",
|
|
16
|
+
"Upstream synchronization design by auggie246",
|
|
17
|
+
"Maintained by MAOLEIJIN"
|
|
18
|
+
],
|
|
19
|
+
"homepage": "https://github.com/MAOLEIJIN/dsh-mattpocock-skills",
|
|
20
|
+
"repository": {
|
|
21
|
+
"type": "git",
|
|
22
|
+
"url": "git+https://github.com/MAOLEIJIN/dsh-mattpocock-skills.git"
|
|
23
|
+
},
|
|
24
|
+
"keywords": [
|
|
25
|
+
"dsh-plugin",
|
|
26
|
+
"dsh",
|
|
27
|
+
"deepseek-harness",
|
|
28
|
+
"skill",
|
|
29
|
+
"skills",
|
|
30
|
+
"agent-skills",
|
|
31
|
+
"mattpocock"
|
|
32
|
+
],
|
|
33
|
+
"engines": {
|
|
34
|
+
"node": "^22.19.0 || >=24.0.0"
|
|
35
|
+
},
|
|
36
|
+
"main": "src/index.js",
|
|
37
|
+
"exports": {
|
|
38
|
+
".": "./src/index.js",
|
|
39
|
+
"./package.json": "./package.json"
|
|
40
|
+
},
|
|
41
|
+
"files": [
|
|
42
|
+
"src",
|
|
43
|
+
"skills",
|
|
44
|
+
"overlay",
|
|
45
|
+
"vendor",
|
|
46
|
+
"tools",
|
|
47
|
+
"test",
|
|
48
|
+
"cordis.patch.yml",
|
|
49
|
+
"README.md",
|
|
50
|
+
"docs",
|
|
51
|
+
"scripts",
|
|
52
|
+
"LICENSE"
|
|
53
|
+
],
|
|
54
|
+
"dsh": {
|
|
55
|
+
"bundle": {
|
|
56
|
+
"patch": "./cordis.patch.yml"
|
|
57
|
+
}
|
|
58
|
+
},
|
|
59
|
+
"dependencies": {
|
|
60
|
+
"yaml": "^2.4.2"
|
|
61
|
+
},
|
|
62
|
+
"peerDependencies": {
|
|
63
|
+
"@deepseek-ai/cordis": "^4.0.1 || ^4.0.2",
|
|
64
|
+
"@deepseek-ai/dsh-skill": ">=0.1.0-rc.7 <0.2.0-0 || >=0.1.5-rc.1 <0.2.0-0"
|
|
65
|
+
},
|
|
66
|
+
"scripts": {
|
|
67
|
+
"vendor": "node vendor/vendor-skills.mjs",
|
|
68
|
+
"sync": "node vendor/sync-upstream.mjs",
|
|
69
|
+
"sync:local": "node vendor/sync-upstream.mjs --from ../mattpocock-skills",
|
|
70
|
+
"sync:check": "node vendor/sync-upstream.mjs --check",
|
|
71
|
+
"check": "node vendor/sync-upstream.mjs --check",
|
|
72
|
+
"test": "node test/bundle.test.js",
|
|
73
|
+
"verify:profile": "node test/verify-profile.cjs",
|
|
74
|
+
"archive:duplicates": "node tools/archive-duplicates.mjs",
|
|
75
|
+
"overlay:report": "node vendor/overlay-report.mjs",
|
|
76
|
+
"overlay:gen": "node vendor/gen-slash-rules.mjs"
|
|
77
|
+
}
|
|
78
|
+
}
|
|
@@ -0,0 +1,32 @@
|
|
|
1
|
+
@echo off
|
|
2
|
+
setlocal EnableExtensions
|
|
3
|
+
|
|
4
|
+
set "PACKAGE_SPEC=@maoleijin/dsh-mattpocock-skills"
|
|
5
|
+
if not "%~1"=="" set "PACKAGE_SPEC=%~1"
|
|
6
|
+
|
|
7
|
+
where node >nul 2>&1 || (
|
|
8
|
+
echo ERROR: Node.js is not available in PATH. 1>&2
|
|
9
|
+
exit /b 1
|
|
10
|
+
)
|
|
11
|
+
|
|
12
|
+
where pnpm >nul 2>&1 || (
|
|
13
|
+
echo ERROR: pnpm is not available in PATH. 1>&2
|
|
14
|
+
exit /b 1
|
|
15
|
+
)
|
|
16
|
+
|
|
17
|
+
echo Installing %PACKAGE_SPEC% into the DSH web profile...
|
|
18
|
+
call npx --yes @deepseek-ai/dsh plugin --profile web add "%PACKAGE_SPEC%"
|
|
19
|
+
if errorlevel 1 exit /b 1
|
|
20
|
+
|
|
21
|
+
echo.
|
|
22
|
+
echo Verifying provider registration...
|
|
23
|
+
call npx --yes @deepseek-ai/dsh --profile web --dump-config | findstr /i "mattpocock"
|
|
24
|
+
if errorlevel 1 (
|
|
25
|
+
echo ERROR: The web profile did not expose the mattpocock provider. 1>&2
|
|
26
|
+
exit /b 1
|
|
27
|
+
)
|
|
28
|
+
|
|
29
|
+
echo.
|
|
30
|
+
echo Installation complete. Restart dsh web and create a new session.
|
|
31
|
+
echo For Desktop, install %PACKAGE_SPEC% from the Desktop plugin window.
|
|
32
|
+
exit /b 0
|
|
@@ -0,0 +1,55 @@
|
|
|
1
|
+
# Phase boundaries
|
|
2
|
+
|
|
3
|
+
A **phase** is a chunk of work inside a session: the grilling, the implementation, the QA. The definition is fuzzy on purpose: a phase ends when you think *"ok, we're done with that"*.
|
|
4
|
+
|
|
5
|
+
The **phase boundary** is the gap between two phases, and it is the only place this decision belongs. Mid-phase there is no decision to make: continue, or split the work that's left into subagents. Compacting mid-phase makes the agent lose the thread.
|
|
6
|
+
|
|
7
|
+
## The five options
|
|
8
|
+
|
|
9
|
+
| Option | What it does |
|
|
10
|
+
| ------------ | --------------------------------------------------------------- |
|
|
11
|
+
| **Continue** | Stay in the session. No context switch at all. |
|
|
12
|
+
| **`/clear`** | Empty the context window and start from nothing. |
|
|
13
|
+
| **`/handoff`** | Write a portable markdown file and seed a session anywhere with it. |
|
|
14
|
+
| **Subagent** | Send the task to its own context window and get a report back. |
|
|
15
|
+
| **`/compact`** | Compress this context and seed a fresh session with the summary. |
|
|
16
|
+
|
|
17
|
+
## The tree
|
|
18
|
+
|
|
19
|
+
Work top to bottom at the boundary. The first **yes** wins.
|
|
20
|
+
|
|
21
|
+
**1. Can you continue in this session?** Two things make the answer yes: the next phase needs this phase as a **primary source**, or you have enough [smart zone](https://www.aihero.dev/ai-coding-dictionary/smart-zone) left (~150k tokens) for the next phase to fit. Grilling → implementation is the standard yes: the implementation wants the reasoning verbatim, not a summary of it. Continue costs nothing and loses nothing, so rule it out before anything else.
|
|
22
|
+
|
|
23
|
+
**2. Is the context irrelevant to what comes next?** Is everything in this session (the exploration, the decisions, the dead ends) disposable? If so, **`/clear`**. It is the cheapest move on the board: it takes no time and hands back the whole window. `/clear` also isn't terminal: the old session stays resumable.
|
|
24
|
+
|
|
25
|
+
The cost of getting this wrong is one-way. Clear a *relevant* context and you lose the **why** behind what you built, and no amount of reading the diff back gets it returned.
|
|
26
|
+
|
|
27
|
+
**3. Do you need to hand off?** `/handoff` is narrow. You need it only when you are:
|
|
28
|
+
|
|
29
|
+
- swapping to a **new harness** (Claude → Codex),
|
|
30
|
+
- moving to a **new directory** or repo,
|
|
31
|
+
- sending the work to a **colleague**,
|
|
32
|
+
- or forking a side task you found **mid-phase** without derailing what you're doing.
|
|
33
|
+
|
|
34
|
+
That list is the whole clause. What `/handoff` buys is **portability**: a file that travels. If nothing is travelling, you don't need it.
|
|
35
|
+
|
|
36
|
+
**4. Can the task be done AFK?** Is it scoped tightly enough to run with you away from the keyboard, no steering? Then send it to a **subagent** and leave this session untouched. Automated review is the standard case: the agent reads the diff and reports, and you aren't needed while it does.
|
|
37
|
+
|
|
38
|
+
**5. Otherwise, `/compact`.** Relevant context, same harness, same directory, and you need to stay in the loop: this is where the tree lands, and it lands here often. Pass it an instruction (`/compact we're going to QA this area`) so the summary keeps what the next phase needs.
|
|
39
|
+
|
|
40
|
+
`/compact` is the **default, not the first reach**. It sits at the bottom because the four questions above it are all cheaper or more precise. The failure mode when people start here is a fresh session that is confidently wrong about a decision the summary flattened.
|
|
41
|
+
|
|
42
|
+
## Primary and secondary sources
|
|
43
|
+
|
|
44
|
+
Every move except **Continue** turns a **primary source** into a **secondary source**: the session as it happened, replaced by a summary of it. The trade is always the same shape:
|
|
45
|
+
|
|
46
|
+
| Source | Information | Noise | Room to move |
|
|
47
|
+
| --------------------------------- | ----------- | ----- | ------------ |
|
|
48
|
+
| Primary (Continue) | Full | Lots | Little |
|
|
49
|
+
| Secondary (`/compact`, `/handoff`) | Lossy | Less | Lots |
|
|
50
|
+
|
|
51
|
+
This is why question 1 comes first. You only pay the lossiness when staying costs more than it saves.
|
|
52
|
+
|
|
53
|
+
## These are judgement calls
|
|
54
|
+
|
|
55
|
+
The questions are not objective: each has taste in it, and the same boundary can go two ways on two days. The value is in asking them **in order**, at the boundary rather than in the middle of the work.
|
|
@@ -0,0 +1,90 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: ask-matt
|
|
3
|
+
description: Ask which skill or flow fits your situation. A router over the skills in this repo.
|
|
4
|
+
disable-model-invocation: true
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
# Ask Matt
|
|
8
|
+
|
|
9
|
+
You don't remember every skill, so ask.
|
|
10
|
+
|
|
11
|
+
A **flow** is a path through the skills. Most paths run along one **main flow**, and two **on-ramps** merge onto it. Everything else is standalone, or a vocabulary layer that runs underneath.
|
|
12
|
+
|
|
13
|
+
## The main flow: idea → ship
|
|
14
|
+
|
|
15
|
+
The route most work travels. You have an idea and want it built.
|
|
16
|
+
|
|
17
|
+
1. **`/grill-with-docs`** sharpens the idea by interview. Start here whenever you are **working in a working directory**: it's stateful, retaining what it learns in `CONTEXT.md` and ADRs. (No working directory? Use `/grill-me` instead, covered under Standalone. Both run the same `/grilling` primitive; `grill-with-docs` is the one that leaves a paper trail, which makes it the better of the two whenever a repo is there to leave it in.)
|
|
18
|
+
2. **Branch: can you settle every question in conversation?** If a question needs a runnable answer (state, business logic, a UI you have to see), detour through a prototype, bridged by **`/handoff`** in both directions (a prototype lives in its own directory, which is exactly what `/handoff` is for; see Phase boundaries):
|
|
19
|
+
- **`/handoff`** out, then open a fresh session against that file,
|
|
20
|
+
- **`/prototype`** to answer the question with throwaway code,
|
|
21
|
+
- **`/handoff`** back what you learned, and reference it from the original idea thread.
|
|
22
|
+
3. **Branch: is this a multi-session build?**
|
|
23
|
+
- **Yes** → **`/to-spec`** (turn the thread into a spec), then **`/to-tickets`** to split it into tracer-bullet tickets, each declaring its **blocking edges**. On a local tracker that's one file per ticket under `.scratch/<feature>/issues/`, worked blockers-first by hand; on a real tracker the edges become native blocking links, so any ticket whose blockers are done can be grabbed: kick off **`/implement`** per ticket, **`/clear`ing context between each one**. Each ticket is self-contained, so the last one's context is disposable.
|
|
24
|
+
- **No** → **`/implement`** right here, in the same context window.
|
|
25
|
+
|
|
26
|
+
Either way, **`/implement`** builds each issue by driving **`/tdd`** internally (one red-green slice at a time), then closes out by running **`/code-review`**, a two-axis review (Standards + Spec) of the diff, before committing. Reach for **`/tdd`** on its own when you just want to build a concrete behaviour test-first without a full spec, and **`/code-review`** on its own whenever you want to review a branch or PR against a fixed point.
|
|
27
|
+
|
|
28
|
+
### Context hygiene
|
|
29
|
+
|
|
30
|
+
Keep steps 1–3 in **one unbroken context window** (don't compact or clear until after `/to-tickets`) so the grilling, spec, and tickets all build on the same thinking. Each `/implement` then starts fresh, working from the ticket.
|
|
31
|
+
|
|
32
|
+
The limit on this is the **[smart zone](https://www.aihero.dev/ai-coding-dictionary/smart-zone)**: the window (~150k tokens on state-of-the-art models) within which the model still reasons sharply. If a session approaches it before `/to-tickets`, don't push on degraded; `/compact` at the nearest phase boundary and carry on (see Phase boundaries).
|
|
33
|
+
|
|
34
|
+
## On-ramps
|
|
35
|
+
|
|
36
|
+
A starting situation that generates work, then merges onto the main flow.
|
|
37
|
+
|
|
38
|
+
- **Bugs and requests piling up** → **`/triage`**. It moves issues through triage roles and produces agent-ready issues, which **`/implement`** later picks up.
|
|
39
|
+
|
|
40
|
+
Triage is only for issues **you didn't create**: bug reports, incoming feature requests, anything that arrives raw. Tickets that `/to-tickets` produced are already agent-ready, so **don't triage them**.
|
|
41
|
+
|
|
42
|
+
- **Something's broken** → **`/diagnosing-bugs`**. For the hard ones: the bug that resists a first glance, the intermittent flake, the regression that crept in between two known-good states. It refuses to theorise until it has a **tight feedback loop** (one command that already goes red on *this* bug), then fixes with a regression test. Its post-mortem hands off to **`/improve-codebase-architecture`** when the real finding is that there's no good seam to lock the bug down.
|
|
43
|
+
|
|
44
|
+
- **A huge, foggy effort: a greenfield project or a huge feature build, too big for one session** → **`/wayfinder`**, the most cognitively demanding flow here. When the way from here to the destination isn't visible yet, it charts a **shared map** of **decision tickets** on the issue tracker and resolves them one at a time, producing **decisions, not deliverables**, until the fog is pushed back and the way is clear. Where **`/grill-with-docs`** sharpens an idea you can hold in one session, wayfinder is for the idea you can't, and it's slower and denser, so save it for exactly that, never a well-scoped feature.
|
|
45
|
+
|
|
46
|
+
When the map clears, **it hands off, it doesn't build**: merge onto the main flow at **`/to-spec`**, which collapses the map's linked decisions into a buildable plan, then `/to-tickets` and `/implement` as usual. Looping the map straight into `/implement` skips that collapse and throws the linked detail away, so go straight to `/implement` only when the effort turned out genuinely small.
|
|
47
|
+
|
|
48
|
+
## Codebase health
|
|
49
|
+
|
|
50
|
+
Not feature work, just upkeep.
|
|
51
|
+
|
|
52
|
+
- **`/improve-codebase-architecture`** runs whenever you have a spare moment to keep the codebase good for agents to operate in. It surfaces **deepening opportunities**; picking one _generates an idea_ you can take into the main flow at `/grill-with-docs`. It's the survey that finds the candidates; **`/codebase-design`** (below) is the bench you design the chosen one on.
|
|
53
|
+
|
|
54
|
+
## Vocabulary underneath
|
|
55
|
+
|
|
56
|
+
Two model-invoked references that run *beneath* the other skills, each the single source of truth for its vocabulary. Reach for them directly when the **words**, not the process, are the problem; or let the skills above pull them in.
|
|
57
|
+
|
|
58
|
+
- **`/domain-modeling`**: sharpen the project's *domain* language: challenge a fuzzy term, resolve an overloaded word ("account" doing three jobs), record a hard-to-reverse decision as an ADR. It's the active discipline `/grill-with-docs` drives to keep `CONTEXT.md` a clean glossary.
|
|
59
|
+
- **`/codebase-design`** is the deep-module vocabulary (module, interface, depth, seam, adapter, leverage, locality) for designing a module's *shape*: a lot of behaviour behind a small interface at a clean seam. `/tdd` and `/improve-codebase-architecture` both speak it.
|
|
60
|
+
|
|
61
|
+
## Phase boundaries
|
|
62
|
+
|
|
63
|
+
A **phase** is a chunk of work inside a session: the grilling, the implementation, the QA. At the **boundary** between two of them you have five options, and picking between them is the fuzziest decision in this whole map:
|
|
64
|
+
|
|
65
|
+
- **Continue**: stay put. Costs nothing, loses nothing.
|
|
66
|
+
- **`/clear`**: empty the window, when nothing here matters to what's next.
|
|
67
|
+
- **`/handoff`** writes a portable markdown file. Narrow: only for a **new harness**, a **new directory**, a **colleague**, or forking a side task **mid-phase**. What it buys is portability.
|
|
68
|
+
- **Subagent**: send a tightly-scoped task to its own window and get a report back.
|
|
69
|
+
- **`/compact`** compresses this context and seeds a fresh session with it. The **default**, at the bottom of the tree rather than the first reach.
|
|
70
|
+
|
|
71
|
+
Read [PHASE-BOUNDARIES.md](PHASE-BOUNDARIES.md) for the ordered tree: the five questions, the reasoning behind each branch, and why the primary-source cost makes **Continue** the one to rule out first. Make the decision **at** a boundary; mid-phase, continue or split the rest into subagents.
|
|
72
|
+
|
|
73
|
+
## Standalone
|
|
74
|
+
|
|
75
|
+
Off the main flow entirely.
|
|
76
|
+
|
|
77
|
+
- **`/grill-me`**: the same relentless interview as `/grill-with-docs`, but **stateless**: it saves nothing locally and builds no `CONTEXT.md`. Reach for it when you are **not working in a working directory** (sharpening a plan, a design, a piece of writing, anything with no repo under it). If you are in a working directory, use `/grill-with-docs` instead: it runs the same interview and leaves a paper trail, so it is strictly the better one.
|
|
78
|
+
- **`/grilling`** is the interview primitive itself: rounds, the frontier, facts are the agent's job and decisions are yours. `/grill-me` and `/grill-with-docs` are the two named ways in, and `/triage`, `/wayfinder` and `/improve-codebase-architecture` all run it internally. Reach for it directly only when you want the interview with no wrapper around it.
|
|
79
|
+
- **`/resolving-merge-conflicts`** works an in-progress merge or rebase conflict hunk by hunk, resolving by **intent** traced to each side's primary source rather than by picking lines, then finishes the operation. It never runs `--abort`. Standalone and off every flow: reach for it when you are already mid-conflict.
|
|
80
|
+
- **`/prototype`** is a small, throwaway program that answers one design question: does this state model feel right, or what should this UI look like. Throwaway is a constraint on how the code is written, not a promise to destroy it: the answer folds into the real code, and the prototype itself is kept as a **primary source** on a `prototype/<name>` branch out of main, pointed at from the implementation issue. It's the detour in step 2 of the main flow, but reach for it any time a design question is hard to settle on paper.
|
|
81
|
+
- **`/research`**: delegate reading legwork to a **background agent**: it investigates a question against **primary sources**, then leaves a cited Markdown file in the repo. Keep working while it reads. The file it produces is something to take *into* the main flow at `/grill-with-docs`, since research feeds the thinking rather than replacing it.
|
|
82
|
+
- **`/to-questionnaire`** comes in when the thing blocking you isn't in your head or the codebase but in **someone else's**, and it writes them a questionnaire to fill in. It's the inverse of `/grill-me`: instead of interviewing you about the subject, it interviews you about the **send** (who it's going to, what you need back) and aims the questions at the gap. What comes back is material for `/grill-with-docs` or `/to-spec`.
|
|
83
|
+
- **`/wizard`** is for the steps only a **human** can take: provisioning infrastructure, setting up credentials or CI secrets, clicking through an unfamiliar third-party dashboard, running a one-off migration or cutover. It generates an interactive bash script that opens each URL, captures each value, and writes it into `.env` and GitHub secrets, so the procedure stops being something you re-explain to an agent every time. Model-invoked, so the agent reaches for it the moment it hits a wall only you can pass. If the agent could just do it itself, it should; this is for where a human is genuinely in the loop.
|
|
84
|
+
- **`/wait-what`** is the corrective for a message that didn't land. Use it mid-conversation, inside any other skill, and the agent re-pitches what it just said with the context you were missing, in plain English, using the `CONTEXT.md` vocabulary. It works after the fact; `/grill-with-docs` is the upfront cure, because a shared language agreed early is what stops the jargon arriving at all.
|
|
85
|
+
- **`/teach`**: learn a concept over multiple sessions, using the current directory as a stateful workspace.
|
|
86
|
+
- **`/writing-for-agents`** is the reference for writing documents agents consume: skills, AGENTS.md, pointed-at docs.
|
|
87
|
+
|
|
88
|
+
## Precondition
|
|
89
|
+
|
|
90
|
+
**`/setup-matt-pocock-skills`**: run before your first engineering flow to configure the issue tracker, triage labels, and doc layout the other skills assume. Custom issue trackers also work.
|
|
@@ -0,0 +1,87 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: code-review
|
|
3
|
+
description: "Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/spec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\"."
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
Two-axis review of the diff between `HEAD` and a fixed point the user supplies:
|
|
7
|
+
|
|
8
|
+
- **Standards**: does the code conform to this repo's documented coding standards?
|
|
9
|
+
- **Spec**: does the code faithfully implement the originating issue / spec?
|
|
10
|
+
|
|
11
|
+
Both axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings.
|
|
12
|
+
|
|
13
|
+
The issue tracker should have been provided to you. If `docs/agents/issue-tracker.md` is missing, tell the user to run `/setup-matt-pocock-skills`.
|
|
14
|
+
|
|
15
|
+
## Process
|
|
16
|
+
|
|
17
|
+
### 1. Pin the fixed point
|
|
18
|
+
|
|
19
|
+
Whatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.
|
|
20
|
+
|
|
21
|
+
Capture the diff command once: `git diff <fixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log <fixed-point>..HEAD --oneline`.
|
|
22
|
+
|
|
23
|
+
Before going further, confirm the fixed point resolves (`git rev-parse <fixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents.
|
|
24
|
+
|
|
25
|
+
### 2. Identify the spec source
|
|
26
|
+
|
|
27
|
+
Look for the originating spec, in this order:
|
|
28
|
+
|
|
29
|
+
1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs/agents/issue-tracker.md`.
|
|
30
|
+
2. A path the user passed as an argument.
|
|
31
|
+
3. A spec file under `docs/`, `specs/`, or `.scratch/` matching the branch name or feature.
|
|
32
|
+
4. If nothing is found, ask the user where the spec is. If they say there isn't one, the **Spec** sub-agent will skip and report "no spec available".
|
|
33
|
+
|
|
34
|
+
### 3. Identify the standards sources
|
|
35
|
+
|
|
36
|
+
Anything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.
|
|
37
|
+
|
|
38
|
+
On top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:
|
|
39
|
+
|
|
40
|
+
- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.
|
|
41
|
+
- **Always a judgement call.** Each smell is a labelled heuristic ("possible Feature Envy"), never a hard violation. Like any standard here, skip anything tooling already enforces.
|
|
42
|
+
|
|
43
|
+
Each smell reads *what it is* → *how to fix*; match it against the diff:
|
|
44
|
+
|
|
45
|
+
- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.
|
|
46
|
+
- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.
|
|
47
|
+
- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.
|
|
48
|
+
- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.
|
|
49
|
+
- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.
|
|
50
|
+
- **Repeated Switches**: the same `switch`/`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.
|
|
51
|
+
- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.
|
|
52
|
+
- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.
|
|
53
|
+
- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.
|
|
54
|
+
- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.
|
|
55
|
+
- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.
|
|
56
|
+
- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.
|
|
57
|
+
|
|
58
|
+
### 4. Spawn both sub-agents in parallel
|
|
59
|
+
|
|
60
|
+
**Standards sub-agent prompt** should include:
|
|
61
|
+
|
|
62
|
+
- The full diff command and commit list.
|
|
63
|
+
- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it).
|
|
64
|
+
- The brief: "Report, per file/hunk where relevant, (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell you spot: name it and quote the hunk. Distinguish hard violations from judgement calls: documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented repo standard overrides the baseline. Skip anything tooling enforces. Under 400 words."
|
|
65
|
+
|
|
66
|
+
**Spec sub-agent prompt** should include:
|
|
67
|
+
|
|
68
|
+
- The diff command and commit list.
|
|
69
|
+
- The path or fetched contents of the spec.
|
|
70
|
+
- The brief: "Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words."
|
|
71
|
+
|
|
72
|
+
If the spec is missing, skip the Spec sub-agent and note this in the final report.
|
|
73
|
+
|
|
74
|
+
### 5. Aggregate
|
|
75
|
+
|
|
76
|
+
Present the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).
|
|
77
|
+
|
|
78
|
+
End with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.
|
|
79
|
+
|
|
80
|
+
## Why two axes
|
|
81
|
+
|
|
82
|
+
A change can pass one axis and fail the other:
|
|
83
|
+
|
|
84
|
+
- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**
|
|
85
|
+
- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**
|
|
86
|
+
|
|
87
|
+
Reporting them separately stops one axis from masking the other.
|
|
@@ -0,0 +1,37 @@
|
|
|
1
|
+
# Deepening
|
|
2
|
+
|
|
3
|
+
How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**.
|
|
4
|
+
|
|
5
|
+
## Dependency categories
|
|
6
|
+
|
|
7
|
+
When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam.
|
|
8
|
+
|
|
9
|
+
### 1. In-process
|
|
10
|
+
|
|
11
|
+
Pure computation, in-memory state, no I/O. Always deepenable: merge the modules and test through the new interface directly. No adapter needed.
|
|
12
|
+
|
|
13
|
+
### 2. Local-substitutable
|
|
14
|
+
|
|
15
|
+
Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface.
|
|
16
|
+
|
|
17
|
+
### 3. Remote but owned (Ports & Adapters)
|
|
18
|
+
|
|
19
|
+
Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter.
|
|
20
|
+
|
|
21
|
+
Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."*
|
|
22
|
+
|
|
23
|
+
### 4. True external (Mock)
|
|
24
|
+
|
|
25
|
+
Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter.
|
|
26
|
+
|
|
27
|
+
## Seam discipline
|
|
28
|
+
|
|
29
|
+
- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection.
|
|
30
|
+
- **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them.
|
|
31
|
+
|
|
32
|
+
## Testing strategy: replace, don't layer
|
|
33
|
+
|
|
34
|
+
- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist; delete them.
|
|
35
|
+
- Write new tests at the deepened module's interface. The **interface is the test surface**.
|
|
36
|
+
- Tests assert on observable outcomes through the interface, not internal state.
|
|
37
|
+
- Tests should survive internal refactors, since they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface.
|
|
@@ -0,0 +1,44 @@
|
|
|
1
|
+
# Design It Twice
|
|
2
|
+
|
|
3
|
+
When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout): your first idea is unlikely to be the best.
|
|
4
|
+
|
|
5
|
+
Uses the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**, **leverage**.
|
|
6
|
+
|
|
7
|
+
## Process
|
|
8
|
+
|
|
9
|
+
### 1. Frame the problem space
|
|
10
|
+
|
|
11
|
+
Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate:
|
|
12
|
+
|
|
13
|
+
- The constraints any new interface would need to satisfy
|
|
14
|
+
- The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md))
|
|
15
|
+
- A rough illustrative code sketch to ground the constraints, not a proposal, just a way to make the constraints concrete
|
|
16
|
+
|
|
17
|
+
Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel.
|
|
18
|
+
|
|
19
|
+
### 2. Spawn sub-agents
|
|
20
|
+
|
|
21
|
+
Spawn 3+ sub-agents in parallel. Each must produce a **radically different** interface for the deepened module.
|
|
22
|
+
|
|
23
|
+
Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint:
|
|
24
|
+
|
|
25
|
+
- Agent 1: "Minimize the interface: aim for 1–3 entry points max. Maximise leverage per entry point."
|
|
26
|
+
- Agent 2: "Maximise flexibility: support many use cases and extension."
|
|
27
|
+
- Agent 3: "Optimise for the most common caller: make the default case trivial."
|
|
28
|
+
- Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies."
|
|
29
|
+
|
|
30
|
+
Include both [SKILL.md](SKILL.md) vocabulary and CONTEXT.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language.
|
|
31
|
+
|
|
32
|
+
Each sub-agent outputs:
|
|
33
|
+
|
|
34
|
+
1. Interface (types, methods, params, plus invariants, ordering, error modes)
|
|
35
|
+
2. Usage example showing how callers use it
|
|
36
|
+
3. What the implementation hides behind the seam
|
|
37
|
+
4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md))
|
|
38
|
+
5. Trade-offs: where leverage is high, where it's thin
|
|
39
|
+
|
|
40
|
+
### 3. Present and compare
|
|
41
|
+
|
|
42
|
+
Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**.
|
|
43
|
+
|
|
44
|
+
After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated: the user wants a strong read, not a menu.
|