@manyos/smileconnect-api 1.74.2 → 1.74.3

package/.claude/settings.local.json

@@ -9,7 +9,8 @@
       "WebFetch(domain:unpkg.com)",
       "WebFetch(domain:www.npmjs.com)",
       "Bash(node *)",
-      "Bash(grep -E '^\\(p-queue|proper-lockfile|async-mutex|p-limit\\)$')"
+      "Bash(grep -E '^\\(p-queue|proper-lockfile|async-mutex|p-limit\\)$')",
+      "Bash(awk NR>=160 && NR<=165 {printf \"%d: \", NR; for \\(i=1;i<=length\\($0\\);i++\\) {c=substr\\($0,i,1\\); printf \"%s\", c} printf \"\\\\n\"} *)"
     ]
   }
 }

package/docs/releases.md

@@ -1,7 +1,7 @@
 # Release Notes
 
 ## API
-### 1.74.2 - 20.05.26
+### 1.74.3 - 20.05.26
 Improve client config validation to avoid duplicate client configs.
 
 ### 1.74.1 - 12.05.26

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.74.2",
+  "version": "1.74.3",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/appConfigRoutes.js

@@ -295,7 +295,7 @@ module.exports = (function() {
         });
 
     routes.delete('/clients/:id', isAuthorizedAdmin,
-        function (req, res, next) {
+        async function (req, res, next) {
             const id = req.params.id;
             setEventData(
                 req,
@@ -305,7 +305,11 @@ module.exports = (function() {
                 id
             );
             try {
-                config.deleteClient(id);
+                const removed = await config.deleteClient(id);
+                if (!removed) {
+                    req.errorStatus = 404;
+                    return next(new Error(`client '${id}' not found`));
+                }
                 req.result = {
                     "status": "success"
                 };

package/util/config.js

@@ -132,6 +132,8 @@ async function setClient(clientName, clientConfig) {
     if (!clientConfig || typeof clientConfig !== 'object' || !clientConfig.name) {
         throw new Error('setClient: clientConfig.name is required');
     }
+    const normalizedParam = typeof clientName === 'string' ? clientName.trim() : clientName;
+    clientConfig.name = clientConfig.name.trim();
     return clientConfigWriteLimit(async () => {
         let config;
         try {
@@ -142,8 +144,8 @@ async function setClient(clientName, clientConfig) {
             config = [];
         }
         if (!Array.isArray(config)) config = [];
-        const namesToRemove = new Set([clientName, clientConfig.name].filter(Boolean));
-        config = config.filter(obj => obj && !namesToRemove.has(obj.name));
+        const namesToRemove = new Set([normalizedParam, clientConfig.name].filter(Boolean));
+        config = config.filter(obj => obj && !namesToRemove.has(obj.name && obj.name.trim ? obj.name.trim() : obj.name));
         config.push(clientConfig);
         log.debug('new config size', config.length);
         const tmp = `${clientConfigFile}.tmp.${process.pid}.${crypto.randomBytes(4).toString('hex')}`;
@@ -153,16 +155,37 @@ async function setClient(clientName, clientConfig) {
     });
 }
 
-function deleteClient(clientName) {
+async function deleteClient(clientName) {
     log.debug('start to update config in file', clientConfigFile);
     log.debug('delete client data', clientName);
-    let config = JSON.parse(fs.readFileSync(clientConfigFile)) || {};
-    config = config.filter(function( obj ) {
-        return obj.name !== clientName;
+    const normalizedName = typeof clientName === 'string' ? clientName.trim() : clientName;
+    return clientConfigWriteLimit(async () => {
+        let config;
+        try {
+            const raw = await fsPromises.readFile(clientConfigFile, 'utf8');
+            config = JSON.parse(raw);
+        } catch (e) {
+            log.warn('deleteClient: cannot parse existing clients.json, nothing to delete', e.message);
+            return false;
+        }
+        if (!Array.isArray(config)) return false;
+        const before = config.length;
+        config = config.filter(obj => {
+            if (!obj || !obj.name) return true;
+            const objName = typeof obj.name === 'string' ? obj.name.trim() : obj.name;
+            return objName !== normalizedName;
+        });
+        const removed = before - config.length;
+        if (removed === 0) {
+            log.warn('deleteClient: no entry matched', clientName);
+            return false;
+        }
+        const tmp = `${clientConfigFile}.tmp.${process.pid}.${crypto.randomBytes(4).toString('hex')}`;
+        await fsPromises.writeFile(tmp, JSON.stringify(config, null, 2));
+        await fsPromises.rename(tmp, clientConfigFile);
+        log.debug('deleteClient: removed', removed, 'entries for', normalizedName);
+        return true;
     });
-    log.debug('new config', config);
-    fs.writeFileSync(clientConfigFile, JSON.stringify(config, null, 2));
-    return true
 }
 
 function getConstants(objectType) {