@manyos/smileconnect-api 1.74.0 → 1.74.3

package/.claude/settings.local.json

@@ -7,7 +7,10 @@
       "Bash(npm view *)",
       "Bash(npm pack *)",
       "WebFetch(domain:unpkg.com)",
-      "WebFetch(domain:www.npmjs.com)"
+      "WebFetch(domain:www.npmjs.com)",
+      "Bash(node *)",
+      "Bash(grep -E '^\\(p-queue|proper-lockfile|async-mutex|p-limit\\)$')",
+      "Bash(awk NR>=160 && NR<=165 {printf \"%d: \", NR; for \\(i=1;i<=length\\($0\\);i++\\) {c=substr\\($0,i,1\\); printf \"%s\", c} printf \"\\\\n\"} *)"
     ]
   }
 }

package/controller/scriptController.js

@@ -153,7 +153,7 @@ async function renameScript(scriptIdOld, scriptIdNew) {
             })
             scriptDefOps[usage.scriptType] = scriptDefNew
         }
-        setClient(usage.client, clientConfig)
+        await setClient(usage.client, clientConfig)
     }
     return true;
 }

package/docs/releases.md

@@ -1,7 +1,13 @@
 # Release Notes
 
 ## API
-### 1.73.1 - 29.04.26
+### 1.74.3 - 20.05.26
+Improve client config validation to avoid duplicate client configs.
+
+### 1.74.1 - 12.05.26
+Fix issue with dynamic openapi spec for worklogs.
+
+### 1.74.0 - 29.04.26
 Update node.js to v22 and replace request-native with native fetch in adapter.
 
 ### 1.73.0 - 28.04.26

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.74.0",
+  "version": "1.74.3",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/appConfigRoutes.js

@@ -295,7 +295,7 @@ module.exports = (function() {
         });
 
     routes.delete('/clients/:id', isAuthorizedAdmin,
-        function (req, res, next) {
+        async function (req, res, next) {
             const id = req.params.id;
             setEventData(
                 req,
@@ -305,7 +305,11 @@ module.exports = (function() {
                 id
             );
             try {
-                config.deleteClient(id);
+                const removed = await config.deleteClient(id);
+                if (!removed) {
+                    req.errorStatus = 404;
+                    return next(new Error(`client '${id}' not found`));
+                }
                 req.result = {
                     "status": "success"
                 };
@@ -317,7 +321,7 @@ module.exports = (function() {
 
     routes.post('/clients', isAuthorizedAdmin,
         checkSchema(clientConfigSchema),
-        function (req, res, next) {
+        async function (req, res, next) {
             const origData = JSON.parse(JSON.stringify(req.body));
             setEventData(
                 req,
@@ -336,7 +340,7 @@ module.exports = (function() {
                 try {
                     const clientConfig = req.body.data;
                     const clientName = clientConfig.name;
-                    config.setClient(clientName, clientConfig)
+                    await config.setClient(clientName, clientConfig)
                     const savedClientConfig = config.getClient(clientName);
                     req.result = {
                         "data": savedClientConfig
@@ -351,7 +355,7 @@ module.exports = (function() {
 
     routes.put('/clients/:id', isAuthorizedAdmin,
         checkSchema(clientConfigSchema),
-        function (req, res, next) {
+        async function (req, res, next) {
             const id = req.params.id;
             const origData = JSON.parse(JSON.stringify(req.body));
             setEventData(
@@ -370,7 +374,7 @@ module.exports = (function() {
                 try {
                     const clientConfig = req.body.data;
                     const clientName = clientConfig.name;
-                    config.setClient(id, clientConfig);
+                    await config.setClient(id, clientConfig);
                     const savedClientConfig = config.getClient(clientName);
                     req.result = {
                         "data": savedClientConfig

package/util/config.js

@@ -1,11 +1,14 @@
 const fs = require('fs');
 const fsPromises = require('fs').promises;
+const crypto = require('crypto');
+const pLimit = require('p-limit');
 require('dotenv').config();
 
 const path = require('path');
 const log = require('@manyos/logger').setupLog('SMILEconnect', path.basename(__filename));
 
 const clientConfigFile = 'conf/clients.json';
+const clientConfigWriteLimit = pLimit(1);
 const arquery = require('../util/arquery');
 const mappingUtil = require('../util/mappingUtil');
 const CacheService = require ('../util/cache.service');
@@ -123,29 +126,66 @@ function setMappings(mapping) {
     return true
 }
 
-function setClient(clientName, clientConfig) {
+async function setClient(clientName, clientConfig) {
     log.debug('start to update config in file', clientConfigFile);
     log.debug('set client data', clientName, clientConfig);
-    let config = JSON.parse(fs.readFileSync(clientConfigFile)) || {};
-    config = config.filter(function( obj ) {
-        return obj.name !== clientName;
+    if (!clientConfig || typeof clientConfig !== 'object' || !clientConfig.name) {
+        throw new Error('setClient: clientConfig.name is required');
+    }
+    const normalizedParam = typeof clientName === 'string' ? clientName.trim() : clientName;
+    clientConfig.name = clientConfig.name.trim();
+    return clientConfigWriteLimit(async () => {
+        let config;
+        try {
+            const raw = await fsPromises.readFile(clientConfigFile, 'utf8');
+            config = JSON.parse(raw);
+        } catch (e) {
+            log.warn('setClient: cannot parse existing clients.json, starting empty', e.message);
+            config = [];
+        }
+        if (!Array.isArray(config)) config = [];
+        const namesToRemove = new Set([normalizedParam, clientConfig.name].filter(Boolean));
+        config = config.filter(obj => obj && !namesToRemove.has(obj.name && obj.name.trim ? obj.name.trim() : obj.name));
+        config.push(clientConfig);
+        log.debug('new config size', config.length);
+        const tmp = `${clientConfigFile}.tmp.${process.pid}.${crypto.randomBytes(4).toString('hex')}`;
+        await fsPromises.writeFile(tmp, JSON.stringify(config, null, 2));
+        await fsPromises.rename(tmp, clientConfigFile);
+        return true;
     });
-    config.push(clientConfig)
-    log.debug('new config', config);
-    fs.writeFileSync(clientConfigFile, JSON.stringify(config, null, 2));
-    return true
 }
 
-function deleteClient(clientName) {
+async function deleteClient(clientName) {
     log.debug('start to update config in file', clientConfigFile);
     log.debug('delete client data', clientName);
-    let config = JSON.parse(fs.readFileSync(clientConfigFile)) || {};
-    config = config.filter(function( obj ) {
-        return obj.name !== clientName;
+    const normalizedName = typeof clientName === 'string' ? clientName.trim() : clientName;
+    return clientConfigWriteLimit(async () => {
+        let config;
+        try {
+            const raw = await fsPromises.readFile(clientConfigFile, 'utf8');
+            config = JSON.parse(raw);
+        } catch (e) {
+            log.warn('deleteClient: cannot parse existing clients.json, nothing to delete', e.message);
+            return false;
+        }
+        if (!Array.isArray(config)) return false;
+        const before = config.length;
+        config = config.filter(obj => {
+            if (!obj || !obj.name) return true;
+            const objName = typeof obj.name === 'string' ? obj.name.trim() : obj.name;
+            return objName !== normalizedName;
+        });
+        const removed = before - config.length;
+        if (removed === 0) {
+            log.warn('deleteClient: no entry matched', clientName);
+            return false;
+        }
+        const tmp = `${clientConfigFile}.tmp.${process.pid}.${crypto.randomBytes(4).toString('hex')}`;
+        await fsPromises.writeFile(tmp, JSON.stringify(config, null, 2));
+        await fsPromises.rename(tmp, clientConfigFile);
+        log.debug('deleteClient: removed', removed, 'entries for', normalizedName);
+        return true;
     });
-    log.debug('new config', config);
-    fs.writeFileSync(clientConfigFile, JSON.stringify(config, null, 2));
-    return true
 }
 
 function getConstants(objectType) {
@@ -243,7 +283,7 @@ async function checkCustomFormMapping() {
     }
 }
 
-function checkClientConfig(client) {
+async function checkClientConfig(client) {
     let updateRequired = false;
     const clientKeys = [
         'cmdbobject',
@@ -361,25 +401,25 @@ function checkClientConfig(client) {
         log.warn(`check config for client ${client.name} done. Update required.`);
         client.config = clientConfig;
         //save
-        setClient(client.name, client);
+        await setClient(client.name, client);
         log.warn(`check config for client ${client.name} done. Update done.`);
     }
     log.info(`check config for client ${client.name} done. No update required.`);
 }
 
-function checkClientConfigs() {
+async function checkClientConfigs() {
     log.info('check client configs');
     const clientConfigs = getClients();
-    clientConfigs.forEach(clientConfig => {
-        checkClientConfig(clientConfig);
-    });
+    for (const clientConfig of clientConfigs) {
+        await checkClientConfig(clientConfig);
+    }
     log.info('check client configs done');
 }
 
 async function checkConfig() {
     log.info('check config');
     checkMapping();
-    checkClientConfigs();
+    await checkClientConfigs();
     await checkCustomFormMapping();
     log.info('check config done');
 }
@@ -434,7 +474,7 @@ async function getDesignPackage(clientId) {
                 const mapping = getDeprecatedMappingAsCustom(config.requestTypeWorkLog)
                 schemas[config.requestTypeWorkLog] = await getObjectSchema(clientConfig[config.requestTypeWorkLog].fields, mapping, config.forms.workLog)
                 schemas[config.requestTypeWorkLog + '_create_update'] = await getObjectSchema(clientConfig[config.requestTypeWorkLog].fields, mapping, config.forms.workLog, true)
-                paths = {...paths, ... await getPathDef(config.assocTicketType, config.baseURI + '/{ticketId}/worklogs', config.requestTypeWorkLog, true, true)}
+                paths = {...paths, ... await getPathDef(`${config.assocTicketType} Worklog`, config.baseURI + '/{ticketId}/worklogs', config.requestTypeWorkLog, true, true)}
                 paths = {...paths, ... await getAttachmentPathDef(config.assocTicketType, config.baseURI + '/{ticketId}/worklogs')}
             }
             if (config.requestTemplate && clientConfig[config.requestTemplate].fields  && clientConfig[config.requestTemplate].fields.length > 0) {