@manyos/smileconnect-api 1.71.6 → 1.71.7

package/docs/releases.md

@@ -1,6 +1,10 @@
 # Release Notes
 
 ## API
+### 1.71.7 - 10.07.25
+Return 404 if ticketWorklog is not found
+Return 404 if task is not found
+
 ### 1.71.6 - 01.07.25
 Enhance stability of oauth2 Adapter
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.71.6",
+  "version": "1.71.7",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/taskRoutes.js

@@ -112,8 +112,12 @@ module.exports = (function () {
         );
 
         const result = await task.getTaskByRootRequest(req.user.config, parentId, taskId, req.globalScriptParams, includeString);
-        req.includeObjectsList = result.included;
-        req.result = {data:result.data || {}};
+        if (result.data) {
+            req.includeObjectsList = result.included;
+            req.result = {data:result.data || {}};
+        } else {
+            req.responseStatus = 404;
+        }
         next();
     });
 
@@ -260,9 +264,13 @@ module.exports = (function () {
             "self" : `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}`
         };
         log.debug('res', urls);
-        req.includeObjectsList = result.included;
-        req.result = {data:result.data || {}};
-        req.result.urls = urls;
+        if (result.data) {
+            req.includeObjectsList = result.included;
+            req.result = {data: result.data || {}};
+            req.result.urls = urls;
+        } else {
+            req.responseStatus = 404;
+        }
         next();
         });
 
@@ -346,4 +354,4 @@ module.exports = (function () {
     });
 
     return taskRoutes;
-})();
+})();

package/routes/ticketWorkLogRoutes.js

@@ -68,7 +68,11 @@ module.exports = (function() {
                 worklogId
             );
             ticketWorkLogController.getWorklog(req.ticketConfig, req.user.config, ticketId, worklogId, undefined, req.globalScriptParams).then(function (result) {
-                req.result = result;
+                if (!result.data) {
+                    req.responseStatus = 404;
+                } else {
+                    req.result = result;
+                }
                 next();
             }).catch(function (reason) {
                 next(reason);
@@ -210,4 +214,4 @@ module.exports = (function() {
         });
 
     return ticketWorkLogRoutes;
-})();
+})();