@manyos/smileconnect-api 1.62.0 → 1.63.0

package/app.js

@@ -152,6 +152,8 @@ passport.use(
         const clientConfig = config.getClientConfig(clientId)
         clientConfig.clientId = clientId
 
+        req.clientId = clientId;
+
         const user = {
             'id': jwt_payload.sub,
             'azp': jwt_payload.azp,
@@ -196,7 +198,8 @@ const maxFilesize = process.env.MAX_FILESIZE || 5;
 
 app.use(fileUpload({
     limits: { fileSize: maxFilesize * 1024 * 1024 },
-    abortOnLimit: true
+    abortOnLimit: true,
+    debug: true
 }));
 
 //global check for compatibility
@@ -265,7 +268,8 @@ app.use(function (req, res, next) {
 app.use(function (req, res, next) {
     req.globalScriptParams = {
         query: req.query,
-        user: req.user
+        user: req.user,
+        log: log.child({req_id: req.id, clientId:req.clientId}, true)
     }
     // Für Scripte einen globalen parameter bereitstellen, der den org. Body enthält. Damit hat man auch noch in Post Scripten Zugriff auf customAttributes die beim Mapping entfernt werden.
     if (req.body) {

package/controller/scriptController.js

@@ -80,7 +80,7 @@ async function executeCode(code, requestData, params, logStream, executedByScrip
         requestData,
         params,
         adapter,
-        log,
+        log: globalScriptParams.log.child({script: scriptId}, true),
         clientId,
         xmlParser,
         script:executeScriptByScript,

package/docs/adapter.md

@@ -584,6 +584,7 @@ The SMILEconnect adapter is an open source project.
 **secure**: Is secure communication use? True/False
 
 **auth.user**: User for SMTP Authentication
+
 **auth.pass**: Pass for SMTP Authentication
 
 ## Functions
@@ -626,6 +627,8 @@ const mailData = {
     text: "Hello world?", // plain text body
     html: "<b>Hello world?</b>", // html body
 }
+
+const result = adapter.mail.sendMail(mailData);
 ```
 
 # DeepL

package/docs/configuration/config.md

@@ -156,6 +156,10 @@ Sample:
 
 Loglevel of the api. Defaults to *error*
 
+### LOG_REQUEST
+
+If set to true, the incoming request & headers will be written to the JsonValue field in the QueueForm. 
+
 ## Rate Limits
 
 ### RATE_LIMIT

package/docs/releases.md

@@ -1,6 +1,9 @@
 # Release Notes
 
 ## API
+### 1.63.0 - 10.01.23
+Security fix for jsonwebtoken https://github.com/advisories/GHSA-27h2-hvpr-p74q
+
 ### 1.62.0 - 18.11.22
 Add Deepl Translation Adapter
 
@@ -182,6 +185,9 @@ e.g.
 */v1/incidents?impersonateUser=abc123
 
 ## Event Manager
+### 1.29.1 - 10.01.23
+Security fix for jsonwebtoken https://github.com/advisories/GHSA-27h2-hvpr-p74q
+
 ### 1.29.0 - 18.11.22
 Add Deepl Translation Adapter
 

package/docs/scripts.md

@@ -311,23 +311,25 @@ This script looks up the previous assignment group if an incident is set to "ass
 //lookup Previous Assigned Support Group for Incident
 // and assign this group if status is changed to "assigned", and assignedGroup is not set.
 
+if ( globalScriptParams && globalScriptParams.id && requestData['status']=="Assigned"  && !requestData.hasOwnProperty("assignedGroup") ) {
 
-if ( requestData['id'] && requestData['status']=="Assigned"  && !requestData.hasOwnProperty("assignedGroup") ) {
-    const remedyResult = await adapter.remedy.search("HPD:Help Desk Assignment Log", `'Incident Number' = "${requestData.id}"`, "Submit Date,Assigned Support Company,Assigned Support Organization,Assigned Group,Assigned Group ID")
-
-    if (remedyResult && remedyResult.data && Array.isArray(remedyResult.data)) {
-        const data = remedyResult.data;
-        let entry = 0;
-        if (data.length > 1) {
-            entry = data.length - 2;
-        }
-
-        if (data[entry] && data[entry].hasOwnProperty("Assigned Group ID")) {
-            requestData['assignedGroup'] = data[entry]['Assigned Group ID'];
-        } else {
-            reject("could not find previous group. automatic re-ssignement failed. set assigendGroup manually")
+    const remedyOptions = {
+        limit: 1,
+        sort: {
+            "Last Date Duration Calculated": -1
         }
-
+    }
+    
+    const remedyResult = await adapter.remedy.search("HPD:Help Desk Assignment Log", `'Incident Number' = "${globalScriptParams.id}"`, "Submit Date, Assigned Support Company, Assigned Support Organization, Assigned Group, Assigned Group ID", remedyOptions);
+
+    if (remedyResult && remedyResult.data && Array.isArray(remedyResult.data) && remedyResult.data.length > 0) {
+        const prevGroupData = remedyResult.data[0];
+        requestData.assignedGroup = prevGroupData['Assigned Group ID'];
+        requestData.assignedCompany = prevGroupData['Assigned Support Company'];
+        requestData.assignedSupportOrg = prevGroupData['Assigned Support Organization'];
+        requestData.assignedGroupName = prevGroupData['Assigned Group'];
+    } else {
+        reject("could not find previous group. automatic re-ssignement failed. set assigendGroup manually")
     }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.62.0",
+  "version": "1.63.0",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {
@@ -19,7 +19,7 @@
     "cors": "^2.8.4",
     "dotenv": "^4.0.0",
     "express": "^4.17.1",
-    "express-fileupload": "^1.2.1",
+    "express-fileupload": "^1.3.1",
     "express-rate-limit": "^5.2.6",
     "express-request-id": "^1.4.1",
     "express-validator": "^6.10.1",

package/util/responsehandler.js

@@ -72,6 +72,19 @@ function eventQueueHandler(req, res, next) {
     //write to eventQueue if provided
     if (req.eventData) {
         const eventData = req.eventData;
+        if (process.env.LOG_REQUEST && (process.env.LOG_REQUEST === true || process.env.LOG_REQUEST.toLowerCase() === 'true')) {
+            if (!eventData.jsonData) {
+                eventData.jsonData = {};
+            }
+            eventData.jsonData['req'] = {
+                headers: req.headers,
+                body: req.body
+            }
+            // remove auth header
+            if (eventData.jsonData.req && eventData.jsonData.req.headers && eventData.jsonData.req.headers.authorization) {
+                eventData.jsonData.req.headers.authorization = '*** REMOVED ***';
+            }
+        }
         eventLog.createSuccessLog(
             req.id,
             req.user.config.clientId,