@manyos/smileconnect-api 1.59.4 → 1.61.0

package/conf/clients.json

@@ -2091,9 +2091,11 @@
             "preMapping": [],
             "postMapping": []
           },
-          "POST": {
+          "PUT": {
             "preMapping": [],
-            "postMapping": []
+            "postMapping": [
+              "notfetchresult"
+            ]
           }
         }
       },
@@ -2614,7 +2616,22 @@
           }
         ],
         "basequery": "1=1",
-        "scripts": {},
+        "scripts": {
+          "POST": {
+            "preMapping": [],
+            "postMapping": [
+              "notFetchResult"
+            ],
+            "afterExecution": []
+          },
+          "PUT": {
+            "preMapping": [],
+            "postMapping": [
+              "notFetchResult"
+            ],
+            "afterExecution": []
+          }
+        },
         "attachmentScripts": {
           "POST": {
             "preMapping": [

package/controller/scriptController.js

@@ -6,6 +6,7 @@ const { v4 } = require('uuid');
 
 const basePath = 'conf';
 const basePathGlobalScripts = basePath + '/scripts';
+const HttpsProxyAgent = require('https-proxy-agent');
 
 const fetch = require('node-fetch');
 const xmlParser = require('fast-xml-parser')
@@ -83,6 +84,7 @@ async function executeCode(code, requestData, params, logStream, executedByScrip
         clientId,
         xmlParser,
         script:executeScriptByScript,
+        HttpsProxyAgent,
         globalScriptParams,
         env: process.env,
         fetch:fetch,

package/docs/releases.md

@@ -1,6 +1,12 @@
 # Release Notes
 
 ## API
+### 1.61.0 - 17.11.22
+Add HttpsProxyAgent to Scripts
+
+### 1.60.0 - 27.09.22
+Add optional parameter "notFetchResult" to globalScriptParams. If set to yes, no object will be returned after POST/PUT requests. This can help to reduce database / server load as request are reduced.
+
 ### 1.59.3 - 10.06.22
 Collect all ciTicketRelationErrors and return them at the end
 
@@ -173,6 +179,8 @@ e.g.
 */v1/incidents?impersonateUser=abc123
 
 ## Event Manager
+### 1.26.0 - 17.11.22
+Add HttpsProxyAgent to Scripts
 
 ### 1.25.0 - 13.09.22
 Improve error logging
@@ -211,6 +219,10 @@ Update Record added to [Remedy Adapter](adapter#remedy).
 The eventmanager will check all outbound webhooks for an event. If one fails, the whole Event will be set to error and the details will be added to the error message.
 
 ## GUI
+
+### 1.10.2 - 30.09.22
+Fixed: openApi page is not loading.
+
 ### 1.9.2 - 08.03.22
 Fixed: Sync mapping not working correctly in some situations
 Feat: Mapping: Added warning to "new" Form mapping, if a mapping is missing (you can disble this with parameter REACT_APP_MAPPING_SYNC_CHECK=DISABLE

package/docs/scripts.md

@@ -189,6 +189,8 @@ Full example:
 }
 ```
 
+**notFetchResult**: If set to yes, no object will be returned after POST/PUT requests. This can help to reduce database / server load as request are reduced.
+
 globalScriptParams is not available in Event Manager scripts. Ids are part of requestData there.
 
 ## requestData
@@ -245,6 +247,12 @@ Allows access to external webservices via the package *node-fetch*
 
 See https://www.npmjs.com/package/node-fetch for details.
 
+## HttpsProxyAgent
+
+Provides Proxy Access for fetch.
+
+See https://www.npmjs.com/package/https-proxy-agent for details.
+
 ## adapter
 
 Allows to make adapter calls. [See details](../configuration/adapter.md)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.59.4",
+  "version": "1.61.0",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/cmdbObjectRoutes.js

@@ -187,9 +187,14 @@ module.exports = (function () {
                 const hasAccess = await cmdbobjects.hasAccess(req.user.config, id);
                 if (hasAccess) {
                     const result = await cmdbobjects.updateCmdbObject(req.ticketConfig, req.user.config, id, req.body.data, classId, req.globalScriptParams);
-                    const ci = await cmdbobjects.getCmdbObject(req.user.config, id, includeString, undefined, req.globalScriptParams);
-                    req.result = ci;
-                    next();
+                    if (req.globalScriptParams && req.globalScriptParams.notFetchResult && req.globalScriptParams.notFetchResult === true) {
+                        req.result = {};
+                        next()
+                    } else {
+                        const ci = await cmdbobjects.getCmdbObject(req.user.config, id, includeString, undefined, req.globalScriptParams);
+                        req.result = ci;
+                        next();
+                    }
                 } else {
                     req.errorStatus = 403;
                     next('Access forbidden.')
@@ -219,10 +224,15 @@ module.exports = (function () {
             const result = [];
             try {
                 const ciInstanceId = await cmdbobjects.createCmdbObject(req.ticketConfig, req.user.config, classId, req.body.data, req.globalScriptParams);
-                req.globalScriptParams.id = ciInstanceId
-                const ci = await cmdbobjects.getCmdbObject(req.user.config, ciInstanceId, includeString, undefined, req.globalScriptParams);
-                req.result = ci;
-                next();
+                req.globalScriptParams.id = ciInstanceId;
+                if (req.globalScriptParams && req.globalScriptParams.notFetchResult && req.globalScriptParams.notFetchResult === true) {
+                    req.result = {};
+                    next()
+                } else {
+                    const ci = await cmdbobjects.getCmdbObject(req.user.config, ciInstanceId, includeString, undefined, req.globalScriptParams);
+                    req.result = ci;
+                    next();
+                }
             } catch (e) {
                 next(e);
             }

package/routes/taskRoutes.js

@@ -210,18 +210,23 @@ module.exports = (function () {
             task.createWorklog(req.user.config, taskId, req.body.data, req.globalScriptParams)
                 .then(createResult => {
                     const worklogId = createResult['0'];
-                    task.getTaskWorklog(req.user.config, taskId, worklogId, req.globalScriptParams).then(result => {
-                        const urls = {
-                            "attachmentUrl" : `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}/attachments/1`,
-                            "attachmentUrl2" : `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}/attachments/2`,
-                            "attachmentUrl3" : `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}/attachments/3`,
-                            "self" : `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}`
-                        };
-                        req.includeObjectsList = result.included;
-                        req.result = {data:result.data || {}};
-                        req.result.urls = urls;
-                        next();
-                    });
+                    if (req.globalScriptParams && req.globalScriptParams.notFetchResult && req.globalScriptParams.notFetchResult === true) {
+                        req.result = {};
+                        next()
+                    } else {
+                        task.getTaskWorklog(req.user.config, taskId, worklogId, req.globalScriptParams).then(result => {
+                            const urls = {
+                                "attachmentUrl": `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}/attachments/1`,
+                                "attachmentUrl2": `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}/attachments/2`,
+                                "attachmentUrl3": `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}/attachments/3`,
+                                "self": `/v1/${req.parentType}/${req.parentId}/tasks/${taskId}/worklogs/${worklogId}`
+                            };
+                            req.includeObjectsList = result.included;
+                            req.result = {data: result.data || {}};
+                            req.result.urls = urls;
+                            next();
+                        });
+                    }
                     log.debug('WorkLog created');
                 })
                 .catch(error => {