@manyos/smileconnect-api 1.57.0 → 1.57.2

package/conf/clients.json

@@ -1994,7 +1994,8 @@
           "Class Location",
           "Class Cost",
           "Department",
-          "Class Start Date & Time"
+          "Class Start Date & Time",
+          "Name"
         ]
       },
       "custom_CTM:People": {
@@ -2009,9 +2010,7 @@
             "postMapping": []
           },
           "PUT": {
-            "preMapping": [
-              "slash"
-            ],
+            "preMapping": [],
             "postMapping": [],
             "afterExecution": []
           },
@@ -2179,6 +2178,18 @@
         "constants": [],
         "scripts": {}
       },
+      "custom_MYS:CustomFormTest": {
+        "basequery": "1=1",
+        "fields": [
+          "Request ID",
+          "Short Description",
+          "Submitter",
+          "Status",
+          "Submitter"
+        ],
+        "constants": [],
+        "scripts": {}
+      },
       "changeWorklog": {
         "fields": [
           "Description",
@@ -2256,6 +2267,38 @@
         "basequery": "",
         "scripts": {}
       },
+      "custom_AST:ComputerSystem": {
+        "basequery": "1=1",
+        "fields": [
+          "Instance Id",
+          "Reconciliation Identity",
+          "Name",
+          "Short Description",
+          "Asset ID+"
+        ],
+        "constants": [
+          {
+            "name": "Data Set Id",
+            "value": "BMC.ASSET"
+          }
+        ],
+        "scripts": {
+          "GET": {
+            "preMapping": [],
+            "postMapping": []
+          },
+          "PUT": {
+            "preMapping": [],
+            "postMapping": [],
+            "afterExecution": []
+          },
+          "POST": {
+            "preMapping": [],
+            "postMapping": [],
+            "afterExecution": []
+          }
+        }
+      },
       "incident": {
         "fields": [
           "Incident Number",
@@ -2318,10 +2361,10 @@
         "basequery": "1=1",
         "scripts": {
           "GET": {
-            "preMapping": [
+            "preMapping": [],
+            "postMapping": [
               "createRecord"
             ],
-            "postMapping": [],
             "afterExecution": []
           },
           "POST": {

package/conf/customFormMapping.json

@@ -19,6 +19,14 @@
       "Department": "Department"
     }
   },
+  "customFormTest": {
+    "formName": "MYS:CustomFormTest",
+    "mapping": {
+      "Short Description": "shortDescription",
+      "Submitter": "submitter",
+      "Status": "status"
+    }
+  },
   "Tasks": {
     "formName": "TMS:Task",
     "mapping": {
@@ -71,5 +79,16 @@
       "Class Id": "class",
       "Class Id2": "class4"
     }
+  },
+  "computerSystem": {
+    "formName": "AST:ComputerSystem",
+    "mapping": {
+      "Name": "name",
+      "DatasetId": "dataSetId",
+      "Asset ID+": "id",
+      "Reconciliation Identity": "reconId",
+      "Instance Id": "instanceId",
+      "Short Description": "shortDescription"
+    }
   }
 }

package/controller/customFormController.js

@@ -27,6 +27,7 @@ function getRecords(formConfig, clientConfig, includeString, customOptions, glob
 }
 
 async function createRecord(formConfig, clientConfig, data, globalScriptParams) {
+    const idField = getIdField(formConfig)
     const allScripts = clientConfig[formConfig.configName].scripts;
     let scripts
     if (allScripts) {
@@ -55,15 +56,27 @@ async function createRecord(formConfig, clientConfig, data, globalScriptParams)
     const result = await arquery.createEntry(formConfig.formName, data, clientConfig.options)
 
     log.debug('RecordCreateResult', result.data);
-    const recordCreateId = Object.values(result)[0];
+    let recordCreateId = Object.values(result)[0];
     //Find change id
-    const resultInterfaceCreate = await arquery.executeARQuery(formConfig.formName, null, "'1'=\"" + recordCreateId + "\"", formConfig.ticketIdField, clientConfig.options)
+    if (!recordCreateId) {
+        recordCreateId = data[idField]
+    }
+    if (!recordCreateId) {
+        throw ({message: `Id of new record could not be determined. Please provide ${idField} for join forms.`})
+    }
+
+    log.error(idField)
+    log.error(recordCreateId)
+
+    //const query = `'${idField}'=\"${recordCreateId}\"`;
+
+    /*const resultInterfaceCreate = await arquery.executeARQuery(formConfig.formName, null, query, formConfig.ticketIdField, clientConfig.options)
     if (resultInterfaceCreate.data && Array.isArray(resultInterfaceCreate.data) && resultInterfaceCreate.data.length > 0) {
         const recordCreateId = resultInterfaceCreate.data[0][formConfig.ticketIdField];
     } else {
         log.error('Cannot create Record', resultInterfaceCreate);
         throw({message: 'Cannot create Record', details : resultInterfaceCreate});
-    }
+    }*/
     globalScriptParams.id = recordCreateId
     //run afterExecution
     if (scripts && scripts.afterExecution) {

package/controller/ticketController.js

@@ -44,7 +44,7 @@ async function createTicket(ticketConfig, clientConfig, data, globalScriptParams
 
     const result = await arquery.createEntry(ticketConfig.forms.new, data, clientConfig.options)
 
-    log.debug('TicketCreateResult', result.data);
+    log.debug('TicketCreateResult', result);
     const ticketCreateId = Object.values(result)[0];
     //Find change id
     const resultInterfaceCreate = await arquery.executeARQuery(ticketConfig.forms.new, null, "'1'=\"" + ticketCreateId + "\"", ticketConfig.ticketIdField, clientConfig.options)

package/docs/releases.md

@@ -2,6 +2,12 @@
 
 ## API 
 
+### 1.57.2 - 28.03.22
+Fix problem with custom ids on custom forms
+
+### 1.57.1 - 25.03.22
+Remove misleading error from CustomFormMappings
+
 ### 1.57.0 - 25.03.22
 
 Add impersonate to update requests.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.57.0",
+  "version": "1.57.2",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/util/mappingUtil.js

@@ -153,7 +153,7 @@ function applyCustomFormMapping2Remedy(entryData, mapping, constants, fields) {
                 delete entryData[mappedName];
             }
         } catch (e) {
-            log.error('mappingError', e)
+            //log.error('mappingError', e)
         }
     })