@manyos/smileconnect-api 1.55.2 → 1.55.4

package/conf/adapterConfig.js

@@ -6,7 +6,7 @@ const adapterParams = {
         arPassword: env.AR_PASSWORD,
         arPort: env.AR_PORT,
         rapiUri: env.BASEURL,
-        cacheTime: env.AR_CACHE_TTL || 300,
+        cacheTime: 300,
         limitDefault: env.LIMIT_DEFAULT || 100,
         limitMax: env.LIMIT_MAX
     },

package/conf/clients.json

@@ -159,7 +159,25 @@
         "fields": [
           "Remedy Login ID",
           "Full Name"
-        ]
+        ],
+        "scripts": {
+          "GET": {
+            "preMapping": [],
+            "postMapping": []
+          },
+          "PUT": {
+            "preMapping": [
+              "slash"
+            ],
+            "postMapping": [],
+            "afterExecution": []
+          },
+          "POST": {
+            "preMapping": [],
+            "postMapping": [],
+            "afterExecution": []
+          }
+        }
       },
       "custom_TMS:Task": {
         "basequery": "1=1",
@@ -463,36 +481,21 @@
         "basequery": "1=1",
         "scripts": {
           "GET": {
-            "preMapping": [
-              "checkGlobalParams"
-            ],
-            "postMapping": [
-              "p4",
-              "update"
-            ],
-            "afterExecution": [
-              "script3"
-            ]
+            "preMapping": [],
+            "postMapping": [],
+            "afterExecution": []
           },
           "POST": {
-            "preMapping": [
-              "p1"
-            ],
-            "postMapping": [
-              "p3"
-            ],
+            "preMapping": [],
+            "postMapping": [],
             "afterExecution": [
-              "p4"
+              "INC_CreateWorklog_OnCreate"
             ]
           },
           "PUT": {
             "preMapping": [],
-            "postMapping": [
-              "p3"
-            ],
-            "afterExecution": [
-              "p4"
-            ]
+            "postMapping": [],
+            "afterExecution": []
           }
         }
       },

package/conf/scripts/INC_CreateWorklog_OnCreate.js

@@ -0,0 +1,10 @@
+log.debug('ID of my new Ticket:', globalScriptParams, clientId)
+
+const worklogData = {
+    summary: 'New SMILEconnect Ticket',
+    text: `Dieses Ticket wurde ueber SMILEconnect (${clientId}) angelegt.`
+}
+const result = await adapter.smileconnect.createTicketWorklog('incidents', globalScriptParams.id, {data: worklogData})
+log.debug(result);
+
+resolve()

package/conf/scripts/count.js

@@ -0,0 +1,2 @@
+const result = await adapter.remedy.search("MYS:SMILEconnect_QueueData", '1=1', "", {countOnly:true, bypassCache:true});
+reject(result)

package/conf/scripts/slash.js

@@ -0,0 +1,2 @@
+const value = await adapter.remedy.search('CTM:People',requestData.query,'Last Name, Corporate ID',{})
+log.error('valSlash', value)

package/controller/customFormController.js

@@ -10,7 +10,7 @@ const {getIncludeArray, applyCustomFormMapping} = require('../util/paramHelper')
 const scriptController = require('./scriptController');
 const mappingUtil = require('../util/mappingUtil');
 
-const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 1); // Create a new cache service instance
+const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 0); // Create a new cache service instance
 
 function getIdField(formConfig) {
     const mapping = formConfig.mapping

package/controller/ticketController.js

@@ -12,7 +12,7 @@ const ticketCIRelationController = require('./ticketCIRelationController');
 const scriptController = require('./scriptController');
 const mappingUtil = require('../util/mappingUtil');
 
-const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 1); // Create a new cache service instance
+const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 0); // Create a new cache service instance
 
 function getTickets(ticketConfig, config, includeString, customOptions, globalScriptParams) {
     let query = '1=1';

package/docs/releases.md

@@ -2,6 +2,12 @@
 
 ## API 
 
+### 1.55.4 - 02.03.22
+Fix error when scripts with space in name are deleted  
+
+### 1.55.3 - 01.03.22
+Ensure TTL of 0 disables cache for Remedy Adapter
+
 ### 1.55.2 - 14.02.22
 Use custom login Id instead of azp also for eventlog
 
@@ -138,6 +144,9 @@ e.g.
 
 ## Event Manager
 
+### 1.21.0 - 14.02.22
+Add Auto Resolve to Scripts
+
 ### 1.20.0 - 14.02.22
 Improve logging
 
@@ -164,6 +173,10 @@ The eventmanager will check all outbound webhooks for an event. If one fails, th
 
 ## GUI
 
+### 1.8.2 - 3.3.22
+Fixed: delete webhooks for client if client is deleted
+Fixed: delete button / menu is hidden if client or scriptname is to long 
+
 ### 1.8.0 - 3.2.22
 Fixed wrong Script Config for Custom Form Scripts (attribute clients instead of scripts)
 Fixed Scrolling

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.55.2",
+  "version": "1.55.4",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/scriptRoutes.js

@@ -13,6 +13,10 @@ const {throwSchemaError} = require('../util/responsehandler');
 module.exports = (function() {
     const scriptRoutes = require('express').Router();
 
+    function decodeScriptName(path) {
+        return decodeURI(path).replace(`/`,"")
+    }
+
     scriptRoutes.get('/',
         isAuthorizedAdmin,
         function (req, res, next) {
@@ -35,7 +39,7 @@ module.exports = (function() {
     });
 
     scriptRoutes.get('/:scriptId*', isAuthorizedAdmin, async function (req, res, next) {
-        const scriptId = req.path.replace(`/`,"");
+        const scriptId = decodeScriptName(req.path);
         eventLog.setEventData(
             req,
             CONSTANTS.EVENT_BASE_SCRIPT,
@@ -75,7 +79,7 @@ module.exports = (function() {
             const errors = validationResult(req);
             throwSchemaError(errors);
 
-            const scriptId = req.path.replace(`/`,"");
+            const scriptId = decodeScriptName(req.path);
 
             eventLog.setEventData(
                 req,
@@ -94,7 +98,7 @@ module.exports = (function() {
         });
 
     scriptRoutes.delete('/:scriptId*', isAuthorizedAdmin, function (req, res, next) {
-        const scriptId = req.path.replace(`/`,"");
+        const scriptId = decodeScriptName(req.path);
         eventLog.setEventData(
             req,
             CONSTANTS.EVENT_BASE_SCRIPT,

package/util/cache.service.js

@@ -7,14 +7,18 @@ class Cache {
     constructor(ttlSeconds) {
         log.debug('cache created. ttl seconds:', ttlSeconds);
         this.cache = new NodeCache({ stdTTL: ttlSeconds, checkperiod: ttlSeconds * 0.2, useClones: false });
+        if (ttlSeconds == 0) {
+            this.disabled = true;
+        }
     }
 
-    get(key, storeFunction) {
+    get(key, storeFunction, bypassCache) {
         const value = this.cache.get(key);
-        if (value) {
+        if (value && (!(bypassCache === true) || bypassCache === undefined) && (!(this.disabled === true) || this.disabled === undefined)) {
+            log.debug('Use cache value')
             return Promise.resolve(value);
         }
-
+        log.debug('Use live query')
         return storeFunction().then((result) => {
             this.cache.set(key, result);
             return result;

package/conf/scripts/p1.js

@@ -1,11 +0,0 @@
-const allowedCats = [
-    "Request",
-    "Failure"
-];
-
-//Validate opsCat1
-if (requestData.opsCat1 && !allowedCats.find(element => element === requestData.opsCat1)) {
-    reject(`opsCat1 ${requestData.opsCat1} not in allowed values ${allowedCats}`);
-}
-requestData.summary = `Da kam an: ${requestData.summary}`
-resolve();