@manyos/smileconnect-api 1.53.0 → 1.53.2

package/conf/clients.json

@@ -161,6 +161,37 @@
           "Full Name"
         ]
       },
+      "custom_TMS:Task": {
+        "basequery": "1=1",
+        "fields": [
+          "Task ID",
+          "Summary",
+          "z1D_WorkInfoNotes",
+          "Notes",
+          "Assignee Group",
+          "Assignee Group ID",
+          "Assignee Organization",
+          "Support Company",
+          "Status"
+        ],
+        "constants": [],
+        "scripts": {
+          "GET": {
+            "preMapping": [],
+            "postMapping": []
+          },
+          "PUT": {
+            "preMapping": [],
+            "postMapping": [],
+            "afterExecution": []
+          },
+          "POST": {
+            "preMapping": [],
+            "postMapping": [],
+            "afterExecution": []
+          }
+        }
+      },
       "cmdbobject": {
         "basequery": "'Data Set Id' = \"BMC.ASSET\" AND ('Mark As Deleted' = \"No\" OR 'Mark As Deleted' = $NULL$)",
         "fields": [

package/conf/customFormMapping.json

@@ -19,6 +19,51 @@
       "Department": "Department"
     }
   },
+  "Tasks": {
+    "formName": "TMS:Task",
+    "mapping": {
+      "Summary": "summary",
+      "Task ID": "id",
+      "Notes": "notes",
+      "Status": "status",
+      "StatusReasonSelection": "statusReason",
+      "Actual Start Date": "actualStartDate",
+      "Actual End Date": "actualEndDate",
+      "Scheduled Start Date": "scheduledStartDate",
+      "Scheduled End Date": "scheduledEndDate",
+      "InstanceId": "instanceId",
+      "RootRequestFormName": "rootRequestForm",
+      "RootRequestID": "rootRequest",
+      "Sequence": "sequence",
+      "Service Cat Tier 1": "opsCat1",
+      "Service Cat Tier 2": "opsCat2",
+      "Service Cat Tier 3": "opsCat3",
+      "Product Cat Tier 1": "prodCat1",
+      "Product Cat Tier 2": "prodCat2",
+      "Product Cat Tier 3": "prodCat3",
+      "Product Name": "productName",
+      "Assignee Group ID": "assignedGroup",
+      "Customer Person ID": "customerid",
+      "Requested By Person ID": "requestorid",
+      "Support Company": "supportCompany",
+      "Assignee Organization": "supportOrganization",
+      "Assignee Group": "supportGroup",
+      "TemplateID": "templateid",
+      "TaskName": "taskName",
+      "z1D_WorkInfoNotes": "workInfoNotes",
+      "z1D_WorkInfoSummary": "workInfoSummary",
+      "z1D_WorkInfoType": "workInfoType",
+      "z1D_WorkInfoViewAccess": "workInfoViewAccess",
+      "z1D_WorkInfoSecureLog": "workInfoSecureLog",
+      "Incident Resolution": "incidentResolution",
+      "Incident Resolution2": "incidentResolution2",
+      "z1D Action": "action",
+      "Assignee": "assignee",
+      "Assignee Login": "assigneeLogin",
+      "Assigned To": "assignedTo",
+      "Assignee Id": "assigneeID"
+    }
+  },
   "baseElement": {
     "formName": "AST:BaseElement",
     "mapping": {

package/controller/taskController.js

@@ -129,6 +129,20 @@ async function updateTaskFlow(clientConfig, rootForm, rootRequestId, rootRequest
         "RootRequestInstanceID" : rootRequestInstanceId
     };
 
+    /*let flowReq2 = {
+        "10000000" : "AGGarserver000RD23DCRC3JB8TC9E",
+        "10000001" : "PBI000000001807",
+        "10000005" : "PBM:Problem Investigation",
+        "10001735" : "CREATE_TASK_FLOW",
+        "10001751" : "TMGarserver000RD2334RC3J1UTD55",
+        "10001753" : "0",
+        "10001756" : "AGGarserver000RD23DCRC3JB8TC9E",
+        "10002025" : "1",
+        "10007302" : "TMGarserver000RD233CRC3J18TD4L",
+        "10010305" : "PBI000000001807",
+        "1000000001" : "Calbro Services"
+    }*/
+
     const mappingflow = config.getMapping('flowBuilder');
 
     flowBuilderRequest = mappingUtil.applyMapping2Remedy(flowBuilderRequest, mappingflow, clientConfig.flowBuilder.constants);
@@ -171,10 +185,17 @@ async function checkFlowActivation(clientConfig, rootRequestInstanceId, rootRequ
 
         const phaseRecords = await arquery.executeARQuery(form, undefined,
             configQuery, 'InstanceId')
+
+        //Todo: Handle records without phases
         if (phaseRecords && phaseRecords.data && phaseRecords.data.length > 0) {
             const phaseRecord = phaseRecords.data[0]
             const phaseGuid = phaseRecord['InstanceId']
             await activateTaskFlow(clientConfig, rootRequestInstanceId, phaseGuid)
+        } else {
+            // nur bei Problem sofort aktivieren
+            if (rootForm === CONSTANTS.FORM_PROBLEM) {
+                activateTaskFlow(clientConfig, rootRequestInstanceId)
+            }
         }
     }
 
@@ -191,8 +212,12 @@ async function activateTaskFlow(clientConfig, rootRequestInstanceId, phaseGuid)
         "zTmpInternal" : "True"
     };
 
-    const records = await arquery.executeARQuery(form, undefined,
-        `'RootRequestInstanceID'="${rootRequestInstanceId}" AND 'ParentID' = "${rootRequestInstanceId}" AND 'Predecessor Link' = "Start" AND 'Status' = "Pending" AND 'Sequence Mode' = "Yes" AND 'Phase GUID' = "${phaseGuid}"`, idField)
+    let query = `'RootRequestInstanceID'="${rootRequestInstanceId}" AND 'ParentID' = "${rootRequestInstanceId}" AND 'Predecessor Link' = "Start" AND 'Status' = "Pending" AND 'Sequence Mode' = "Yes"`
+    if (phaseGuid) {
+        query += ` AND 'Phase GUID' = "${phaseGuid}"`
+    }
+
+    const records = await arquery.executeARQuery(form, undefined, query, idField)
     if (records && records.data) {
         for (let x=0; x<records.data.length; x++) {
             const record = records.data[x]

package/docs/releases.md

@@ -2,19 +2,25 @@
 
 ## API 
 
-### 1.53.0 - 17.11.11
+### 1.53.2 - 03.02.22
+Fix issue: Remove error message on custom form mapping
+
+### 1.53.1 - 01.02.22
+Fix issue: Task Flow Activation for Problems
+
+### 1.53.0 - 17.11.21
 Update NodeJs to v16
 
-### 1.52.4 - 17.11.11
+### 1.52.4 - 17.11.21
 Fix issue: Keep invisible ServiceCi Relation in Tickets during CI Relation Update
 
-### 1.52.3 - 16.11.11
+### 1.52.3 - 16.11.21
 Fix issue: Add globalParams to update ticket
 
-### 1.52.2 - 16.11.11
+### 1.52.2 - 16.11.21
 Fix issue: Inbound Events Names missed 'Worklog' for Task Worklogs
 
-### 1.52.1 - 12.11.11
+### 1.52.1 - 12.11.21
 Fix issue: Task CI relations might be removed on duplicate updates
 
 ### 1.52.0 - 09.11.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.53.0",
+  "version": "1.53.2",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/util/mappingUtil.js

@@ -106,11 +106,14 @@ function getFieldsForCreate(mapping, mappingNew, clientFields) {
 }*/
 
 function applyCustomFormMapping(object, mapping, requestIdField) {
+    //log.debug('apply mapping', object, mapping)
     //Apply mapping
     Object.keys(mapping).forEach(remedyName => {
         try {
             const mappedName = mapping[remedyName]
-            Object.defineProperty(object, mappedName, Object.getOwnPropertyDescriptor(object, remedyName));
+            if (object[remedyName] !== undefined) {
+                Object.defineProperty(object, mappedName, Object.getOwnPropertyDescriptor(object, remedyName));
+            }
             //delete only if names are different
             if (mappedName !== remedyName) {
                 delete object[remedyName];