@manyos/smileconnect-api 1.49.0 → 1.49.2

package/conf/clients.json

@@ -154,6 +154,13 @@
           "Class Start Date & Time"
         ]
       },
+      "custom_CTM:People": {
+        "basequery": "1=1",
+        "fields": [
+          "Remedy Login ID",
+          "Full Name"
+        ]
+      },
       "cmdbobject": {
         "basequery": "'Data Set Id' = \"BMC.ASSET\" AND ('Mark As Deleted' = \"No\" OR 'Mark As Deleted' = $NULL$)",
         "fields": [

package/conf/customFormMapping.json

@@ -16,7 +16,7 @@
       "Class Location": "location",
       "Class Start Date & Time": "startDate",
       "Class Cost": "cost",
-      "Department": "department"
+      "Department": "Department"
     }
   },
   "baseElement": {

package/controller/cmdbobjectController.js

@@ -332,9 +332,10 @@ async function updateCmdbObject(ticketConfig, clientConfig, id, ciData, classId,
     }
 
     const mapping = getClassMapping(classId);
+    const classFields = getClassFields(clientConfig, classId)
 
     //Constants work only on new.
-    ciData = mappingUtil.applyMapping2Remedy(ciData, mapping, undefined, clientConfig.cmdbobject.fields);
+    ciData = mappingUtil.applyMapping2Remedy(ciData, mapping, undefined, classFields);
 
     //run postMapping
     if (scripts && scripts.postMapping) {
@@ -351,11 +352,26 @@ async function updateCmdbObject(ticketConfig, clientConfig, id, ciData, classId,
     return update;
 }
 
+function getClassFields(clientConfig, classId) {
+    //Add globalFields
+    const globalFields = clientConfig.cmdbobject.fields;
+    log.debug('Global class fields', globalFields)
+    if (classId) {
+        const classFields = clientConfig.cmdbobject[`fields_${classId}`]
+        log.debug('Local class fields', classFields)
+        return [...new Set([...globalFields,...classFields])]
+    }
+    return globalFields
+}
+
 function getClassMapping(classId) {
     const mappings = [];
     const globalMappings = config.getMapping(CMDBOBJECT);
     const classMappings = config.getMapping(`${CMDBOBJECT}_${classId}`);
 
+    log.debug('Found global Mapping', globalMappings)
+    log.debug('Found class Mapping', classMappings)
+
     //Add all global Mappings that are not in ClassMapping
     globalMappings.forEach(globalMapping => {
         const foundInClassMappings = classMappings.find(element => element.newName === globalMapping.newName);
@@ -368,6 +384,8 @@ function getClassMapping(classId) {
     classMappings.forEach(classMapping => {
         mappings.push(classMapping);
     });
+
+    log.debug('Created joined Mapping', mappings)
     return mappings;
 }
 
@@ -385,10 +403,10 @@ async function createCmdbObject(assetConfig, clientConfig, classId, ciData, glob
 
     const mapping = getClassMapping(classId);
 
-    log.debug('Combined Mapping', mapping);
+    const classFields = getClassFields(clientConfig, classId)
 
     //Constants work only on new.
-    ciData = mappingUtil.applyMapping2Remedy(ciData, mapping, undefined, clientConfig.cmdbobject.fields);
+    ciData = mappingUtil.applyMapping2Remedy(ciData, mapping, undefined, classFields);
 
     //run postMapping
     if (scripts && scripts.postMapping) {

package/docs/releases.md

@@ -2,6 +2,12 @@
 
 ## API 
 
+### 1.49.2 - 05.11.21
+Fix issue: Class specific Attributes not working in CMDBObject create & update
+
+### 1.49.1 - 04.11.21
+Fix issue: Self Mapping in custom Forms removed attribute
+
 ### 1.49.0 - 04.11.21
 Add attachmentScripts to Worklogs
 
@@ -109,6 +115,9 @@ Update Record added to [Remedy Adapter](adapter#remedy).
 The eventmanager will check all outbound webhooks for an event. If one fails, the whole Event will be set to error and the details will be added to the error message.
 
 ## GUI
+### 1.6.0 - 05.11.21
+Added attachmentScripts to GUI
+
 ### 1.5.5 - 03.11.21
 Add Parameter REACT_APP_OIDC_SCOPE to choose the oicd scope
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.49.0",
+  "version": "1.49.2",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/util/arquery.js

@@ -92,10 +92,10 @@ async function executeARQuery(form, baseQuery, query, fields, options) {
     if (limit) {
         uri = uri + "&maxEntries=" + limit;
     }
-    log.debug('start request on:', uri);
+    log.debug('start GET request on:', uri);
 
     const value = await request(uri).auth(process.env.AR_USER, process.env.AR_PASSWORD, true);
-    log.debug('request done', uri, value);
+    log.debug('GET request done', uri, value);
 
     if (value && value.status && value.status === 'error') {
         throw new Error(value);
@@ -216,8 +216,8 @@ function createEntry(form, entryData, clientOptions) {
             json: true // Automatically stringifies the body to JSON
         };
 
-        log.debug('start request with:', options.body);
-        log.debug('start request on:', uri);
+        log.debug('start POST request with:', options.body);
+        log.debug('start POST request on:', uri);
         const singleRecord = Object.keys(finalEntries).length == 1;
         request(options).auth(process.env.AR_USER, process.env.AR_PASSWORD, true)
             .then(function (response) {
@@ -390,8 +390,8 @@ function updateEntry(form, id, entryData) {
             json: true // Automatically stringifies the body to JSON
         };
 
-        log.debug('start request with:', options.body);
-        log.debug('start request on:', uri);
+        log.debug('start PUT request with:', options.body);
+        log.debug('start PUT request on:', uri);
         request(options).auth(process.env.AR_USER, process.env.AR_PASSWORD, true)
             .then(function (response) {
                 log.debug('RAPI update return', response);

package/util/mappingUtil.js

@@ -97,7 +97,10 @@ function applyCustomFormMapping(object, mapping, requestIdField) {
         try {
             const mappedName = mapping[remedyName]
             Object.defineProperty(object, mappedName, Object.getOwnPropertyDescriptor(object, remedyName));
-            delete object[remedyName];
+            //delete only if names are different
+            if (mappedName !== remedyName) {
+                delete object[remedyName];
+            }
         } catch (e) {
             log.error('mappingError', e)
         }
@@ -129,7 +132,9 @@ function applyCustomFormMapping2Remedy(entryData, mapping, constants, fields) {
         try {
             const mappedName = mapping[remedyName]
             Object.defineProperty(entryData, remedyName, Object.getOwnPropertyDescriptor(entryData, mappedName));
-            delete entryData[mappedName];
+            if (mappedName !== remedyName) {
+                delete entryData[mappedName];
+            }
         } catch (e) {
             log.error('mappingError', e)
         }