@manyos/smileconnect-api 1.45.7 → 1.46.0

package/conf/mapping.json

@@ -827,6 +827,10 @@
     {
       "oldName": "Assignee Group",
       "newName": "supportGroup"
+    },
+    {
+      "oldName": "Phase GUID",
+      "newName": "phase"
     }
   ],
   "taskWorklog": [
@@ -877,8 +881,8 @@
       "newName": "RootRequestName"
     },
     {
-      "oldName": "RootRequestInstanceId",
-      "newName": "RootRequestInstanceId"
+      "oldName": "RootRequestInstanceID",
+      "newName": "RootRequestInstanceID"
     },
     {
       "oldName": "zTmpInternalCommand",
@@ -895,6 +899,10 @@
     {
       "oldName": "Parent Name",
       "newName": "Parent Name"
+    },
+    {
+      "oldName": "Location Company",
+      "newName": "Location Company"
     }
   ],
   "changeTemplate": [

package/controller/taskController.js

@@ -78,7 +78,6 @@ async function createTask(clientConfig, rootForm, rootRequestId, taskData, creat
             thisTask.RootRequestMode = "1";
             thisTask.RootRequestName = rootRequestId;
             thisTask.RootRequestInstanceId = rootRequest.data[0]['InstanceId'];
-            thisTask.sequence = thisTask.Sequence || "1";
         });
 
         for (let x=0; x< allTaskFinal.length; x++) {
@@ -113,21 +112,21 @@ async function createTask(clientConfig, rootForm, rootRequestId, taskData, creat
     }
 }
 
-async function deleteTaskFlow(rootRequestId) {
-    log.debug('Delete Task Flow', rootRequestId)
-    const taskFlowResult = await arquery.deleteEntries('TMS:Flow', undefined, `'RootRequestName' = "${rootRequestId}"`)
+async function deleteTaskFlow(rootRequestInstanceId) {
+    log.debug('Delete Task Flow', rootRequestInstanceId)
+    const taskFlowResult = await arquery.deleteEntries('TMS:Flow', undefined, `'RootRequestInstanceID' = "${rootRequestInstanceId}"`)
 }
 
 async function updateTaskFlow(clientConfig, rootForm, rootRequestId, rootRequestInstanceId) {
-    await deleteTaskFlow(rootRequestId)
+    await deleteTaskFlow(rootRequestInstanceId)
     let flowBuilderRequest = {
-        "RootRequestFormName" : rootForm,
-        "RootRequestName" : rootRequestId,
-        "RootRequestInstanceId" : rootRequestInstanceId,
-        "zTmpInternalCommand" : "CREATE",
-        "Parent Type" : "0",
+        "Parent Name": rootForm,
         "ParentID" : rootRequestInstanceId,
-        "Parent Name" : rootRequestId
+        "Parent Type": "Root Request",
+        "zTmpInternalCommand" : "CREATE",
+        "RootRequestFormName" : rootForm,
+        "RootRequestName" : rootForm,
+        "RootRequestInstanceID" : rootRequestInstanceId
     };
 
     const mappingflow = config.getMapping('flowBuilder');

package/controller/ticketCIRelationController.js

@@ -420,7 +420,12 @@ function doesTicketRelationExists(ticketRelations, newRelation) {
 
 async function updateRelations(ticketConfig, userConfig, ticketId, relations) {
     log.debug('Checker', {ticketConfig, userConfig, ticketId, relations});
-    //Cehck CI Relations
+    // Remove Ticket Relations if task
+    if (ticketConfig.assocTicketType === 'Task') {
+        relations.ticketRelations = undefined
+    }
+
+    //Check CI Relations
     if (relations && relations.ciRelations && Array.isArray(relations.ciRelations)) {
         const existingRelations = await getTicketCIRelations(ticketId);
         log.debug('foundRelations', existingRelations);

package/docs/releases.md

@@ -2,6 +2,12 @@
 
 ## API 
 
+### 1.46.0 - 14.10.21
+Add validateUpdateRequest to cmdbobjects
+
+### 1.45.8 - 11.10.21
+Fix issue: Ignore Ticketrelations for Task Update & Create
+
 ### 1.45.7 - 05.10.21
 Fix issue: Use normal Task mapping for new tasks and existing tasks as no Interface Create Form is used. 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.45.7",
+  "version": "1.46.0",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/cmdbObjectRoutes.js

@@ -129,8 +129,8 @@ module.exports = (function () {
             })
         });
 
-    cmdbObjectRoutes.post('/validateUpdateRequest/:clientId', isAuthorizedAdmin, checkSchema(fieldMappingSchemas.validateCMDBDataSchema), async function (req, res, next) {
-        const clientId = req.params.clientId;
+    cmdbObjectRoutes.post('/validateUpdateRequest', passport.authenticate('jwt', {session: false}), checkSchema(fieldMappingSchemas.validateCMDBDataSchema), async function (req, res, next) {
+        const clientId = req.user.config.clientId;
         eventLog.setEventData(
             req,
             CONSTANTS.EVENT_BASE_AST,