@manyos/smileconnect-api 1.42.1 → 1.43.1

package/conf/clients.json

@@ -293,10 +293,6 @@
           {
             "name": "Communication Source",
             "value": "Other"
-          },
-          {
-            "name": "View Access",
-            "value": "Internal"
           }
         ],
         "basequery": "",
@@ -590,7 +586,8 @@
           "Character 01",
           "Support Company",
           "Assignee Organization",
-          "Assignee Group"
+          "Assignee Group",
+          "Phase GUID"
         ],
         "constants": [
           {

package/conf/mapping.json

@@ -868,7 +868,7 @@
     },
     {
       "oldName": "Sequence",
-      "newName": "Sequence"
+      "newName": "sequence"
     },
     {
       "oldName": "TaskName",
@@ -881,6 +881,10 @@
     {
       "oldName": "Character 06",
       "newName": "character06"
+    },
+    {
+      "oldName": "Phase GUID",
+      "newName": "phaseGuid"
     }
   ],
   "taskWorklog": [

package/controller/taskController.js

@@ -90,23 +90,9 @@ async function createTask(clientConfig, rootForm, rootRequestId, taskData, creat
         }
 
         log.debug('Create Task Result', taskResult);
-        let flowBuilderRequest = {
-            "RootRequestFormName" : rootForm,
-            "RootRequestName" : rootRequestId,
-            "RootRequestInstanceId" : rootRequest.data[0]['InstanceId'],
-            "zTmpInternalCommand" : "CREATE",
-            "Parent Type" : "0",
-            "ParentID" : rootRequest.data[0]['InstanceId'],
-            "Parent Name" : rootRequestId
-        };
         log.debug('createFlow', createTaskFlow === true);
         if (createTaskFlow != null && createTaskFlow === true ) {
-            const mappingflow = config.getMapping('flowBuilder');
-
-            flowBuilderRequest = mappingUtil.applyMapping2Remedy(flowBuilderRequest, mappingflow, clientConfig.flowBuilder.constants);
-
-            const taskFlowResult = await arquery.createEntry('TMS:FlowBuilder', flowBuilderRequest, clientConfig.options)
-            log.debug('TaskFlowBuilder Result', taskFlowResult);
+            await updateTaskFlow(clientConfig, rootForm, rootRequestId, rootRequest.data[0]['InstanceId'])
             return taskResult;
         } else {
             log.debug('Task flow update not requested');
@@ -114,7 +100,31 @@ async function createTask(clientConfig, rootForm, rootRequestId, taskData, creat
         }
     }
 }
-//Todo make dynamic
+
+async function deleteTaskFlow(rootRequestId) {
+    log.debug('Delete Task Flow', rootRequestId)
+    const taskFlowResult = await arquery.deleteEntries('TMS:Flow', undefined, `'RootRequestName' = "${rootRequestId}"`)
+}
+
+async function updateTaskFlow(clientConfig, rootForm, rootRequestId, rootRequestInstanceId) {
+    await deleteTaskFlow(rootRequestId)
+    let flowBuilderRequest = {
+        "RootRequestFormName" : rootForm,
+        "RootRequestName" : rootRequestId,
+        "RootRequestInstanceId" : rootRequestInstanceId,
+        "zTmpInternalCommand" : "CREATE",
+        "Parent Type" : "0",
+        "ParentID" : rootRequestInstanceId,
+        "Parent Name" : rootRequestId
+    };
+
+    const mappingflow = config.getMapping('flowBuilder');
+
+    flowBuilderRequest = mappingUtil.applyMapping2Remedy(flowBuilderRequest, mappingflow, clientConfig.flowBuilder.constants);
+    const taskFlowResult = await arquery.createEntry('TMS:FlowBuilder', flowBuilderRequest, clientConfig.options)
+}
+
+
 async function createWorklog(clientConfig, taskId, data, globalScriptParams) {
     const task = await getTask(clientConfig,taskId)
     const fields = clientConfig.taskWorklog.fields;
@@ -327,6 +337,22 @@ async function updateTask(clientConfig, id, taskData, globalScriptParams) {
 
     const result = await arquery.updateEntry('TMS:Task', id, taskData);
 
+    //flow update
+    const taskQuery = `'1' = "${id}"`
+    const rootRequestFields = [
+        "RootRequestInstanceId",
+        "RootRequestFormName",
+        "RootRequestName"
+    ]
+    const rootRequestDetails = await arquery.executeARQuery('TMS:Task', null, taskQuery, rootRequestFields.toString(), clientConfig.options)
+    log.debug('rootDetails', rootRequestDetails)
+    if (rootRequestDetails && rootRequestDetails.data && Array.isArray(rootRequestDetails.data)) {
+        const detailData = rootRequestDetails.data[0]
+        await updateTaskFlow(clientConfig, detailData['RootRequestFormName'], detailData['RootRequestName'], detailData['RootRequestInstanceID'])
+    } else {
+        log.error('Root Request Details not found for', id)
+    }
+
     //run afterExecution
     if (scripts && scripts.afterExecution) {
         await scriptController.runScripts(scripts.afterExecution, taskData, clientConfig.clientId, globalScriptParams);

package/controller/ticketWorkLogController.js

@@ -12,7 +12,7 @@ const scriptController = require('./scriptController');
 const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 1); // Create a new cache service instance
 
 async function createWorklog(ticketConfig, clientConfig, ticketId, data, globalScriptParams) {
-    const scripts = clientConfig[ticketConfig.requestTypeWorkLog].scripts.POST;
+    const scripts = clientConfig[ticketConfig.requestTypeWorkLog].scripts;
     const mapping = config.getMapping(ticketConfig.requestTypeWorkLog);
     const fields = clientConfig[ticketConfig.requestTypeWorkLog].fields;
 
@@ -53,7 +53,7 @@ async function createWorklog(ticketConfig, clientConfig, ticketId, data, globalS
     const viewAccessConstant = clientConstants.find(element => element.name === "View Access")
     //run only if isPublic is set and no Constant is defined
     if (data.isPublic && !viewAccessConstant) {
-        if (data.isPublic === true) {
+        if (data.isPublic === true || data.isPublic === "true") {
             clientConstants.push({"name": "View Access", "value" : "Public"});
         } else {
             clientConstants.push({"name": "View Access", "value" : "Internal"});

package/docs/adapter.md

@@ -267,6 +267,25 @@ const options = {
 }
 ```
 
+* bypassCache (only search)
+
+Can be used to execute a query without utilizing the cache.
+
+Full example:
+
+```javascript
+const options = {
+    limit: 100,
+    offset: 100,
+    dafeFormat: "yyyy-MM-dd HH:mm:ss.SSSZ",
+    bypassCache: true,
+    sort: {
+        "Name": 1,
+        "Status": -1
+    }
+}
+```
+
 # LDAP
 
 

package/docs/releases.md

@@ -2,11 +2,18 @@
 
 ## API 
 
+### 1.43.1 - 23.09.21
+Allow also "isPublic": "true" instead of "isPublic": true for Ticket Worklogs
+
+### 1.43.0 - 20.09.21
+Allow bypassCache option in Remedy Adapter
+Add support for Task Phasing
+Regenrate Task Flow on Task Update
+
 ### 1.42.1 - 09.09.21
 Fix authentication issue with health check
 
 ### 1.42.0 - 08.09.21
-
 Add IDs to POST Actions for After Execution Scripts
 
 ### 1.41.4 - 10.08.21
@@ -31,6 +38,10 @@ e.g.
 
 ## Event Manager
 
+### 1.17.0 - 17.09.21
+
+Add eventdata to Queue for outbound
+
 ### 1.16.0 - 03.08.21
 
 Update Record added to [Remedy Adapter](adapter#remedy).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.42.1",
+  "version": "1.43.1",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/test/changeTest.js

@@ -153,24 +153,6 @@ describe('Integration Tests - Change', function () {
         })
     })
 
-    describe ('Change Update', function () {
-        it ('it should update a spezific change by id', function (done) {
-            this.timeout(5000);
-            chai.request(server)
-                .put(`/v1/changes/${change.id}`)
-                .set('Authorization', 'Bearer ' + authUser.access_token)
-                .send({"data":{"summary":"Updated", "status":"Request For Authorization", "scheduledStartDate":new Date(), "scheduledEndDate":new Date(new Date().getTime()+3600000)}})
-                .end(function(err, res) {
-                    res.should.have.status(200);
-                    res.body.data.should.be.an('object');
-                    res.body.data.should.have.property('summary');
-                    res.body.data.should.have.property('id');
-                    res.body.data.should.have.property('status');
-                    res.body.data.summary.should.equal("Updated");
-                    done();
-                })
-        })
-    })
 
 
     describe ('Change Relations', function() {
@@ -382,13 +364,14 @@ describe('Integration Tests - Change', function () {
     })
 
     describe('Tasks', function () {
+        //Task in Implementation Phase
         let task;
         it ('it should create a spezific task', function (done) {
             this.timeout(5000);
             chai.request(server)
                 .post(`/v1/changes/${change.id}/tasks`)
                 .set('Authorization', 'Bearer ' + authUser.access_token)
-                .send({"data":{"summary":"task1"}})
+                .send({"data":{"summary":"task1", "phaseGuid":"TM0019B9B1CBCBTatrSQH6HRAAuj8C"}})
                 .end(function(err, res) {
                     res.should.have.status(200);
                     res.body.data.should.be.an('object');
@@ -407,8 +390,8 @@ describe('Integration Tests - Change', function () {
                 .set('Authorization', 'Bearer ' + authUser.access_token)
                 .send({
                     "data": [
-                        {"summary":"task2"},
-                        {"summary":"task3"}
+                        {"summary":"task2", "phaseGuid":"TMGarserver000QWYOIDQVZTE5HMPE"},
+                        {"summary":"task3", "phaseGuid":"TMGarserver000QWYOIDQVZTE5HMPE"}
                     ]
                 })
                 .end(function(err, res) {
@@ -426,7 +409,7 @@ describe('Integration Tests - Change', function () {
                 .set('Authorization', 'Bearer ' + authUser.access_token)
                 .send({
                     "data": [
-                        {"summary":"task2"}
+                        {"summary":"task2", "phaseGuid":"TMGarserver000QWYOIDQVZTE5HMPE"}
                     ]
                 })
                 .end(function(err, res) {
@@ -538,4 +521,23 @@ describe('Integration Tests - Change', function () {
             })
         })
     })
+
+    describe ('Change Update', function () {
+        it ('it should update a spezific change by id', function (done) {
+            this.timeout(5000);
+            chai.request(server)
+                .put(`/v1/changes/${change.id}`)
+                .set('Authorization', 'Bearer ' + authUser.access_token)
+                .send({"data":{"summary":"Updated", "status":"Request For Authorization", "scheduledStartDate":new Date(), "scheduledEndDate":new Date(new Date().getTime()+3600000)}})
+                .end(function(err, res) {
+                    res.should.have.status(200);
+                    res.body.data.should.be.an('object');
+                    res.body.data.should.have.property('summary');
+                    res.body.data.should.have.property('id');
+                    res.body.data.should.have.property('status');
+                    res.body.data.summary.should.equal("Updated");
+                    done();
+                })
+        })
+    })
 })