@manyos/smileconnect-api 1.33.0 → 1.35.0

package/app.js

@@ -11,6 +11,7 @@ const JwtStrategy = require('passport-jwt').Strategy,
 const bodyParser = require('body-parser');
 
 const config = require('./util/config');
+const authUtil = require('./util/auth');
 
 const cors = require('cors');
 
@@ -83,6 +84,8 @@ if (audienceArray.length > 0) {
     opts.audience = audienceArray;
 }
 
+opts.passReqToCallback = true
+
 // Do any necessary shutdown logic for our application here
 const shutdown = (signal, value) => {
     console.log("shutdown!");
@@ -130,18 +133,29 @@ app.use(compression()); //Compress all routes
 
 log.debug('Passport Opts', opts);
 passport.use(
-    new JwtStrategy(opts, function (jwt_payload, done) {
+    new JwtStrategy(opts, function (req, jwt_payload, done) {
         //log.info(jwt_payload);
         //log.info('token', jwt_payload.sub);
         //TODO: Config error abfangen
         //TODO: Add AdminScope and Impersonate
-        const clientId = jwt_payload[SSO_CLIENTNAME_ATTRIBUTE];
+        let clientId = jwt_payload[SSO_CLIENTNAME_ATTRIBUTE];
+
+        //check for master client
+        const requestedClientId = req.query.clientId
+        if (requestedClientId && authUtil.isMasterClient(clientId)) {
+            log.debug(`client ${clientId} acts as ${requestedClientId}`)
+            clientId = requestedClientId
+        }
+
+        const clientConfig = config.getClientConfig(clientId)
+        clientConfig.clientId = clientId
+
         const user = {
             'id': jwt_payload.sub,
             'azp': jwt_payload.azp,
             'scope': jwt_payload.scope,
             'exp': jwt_payload.exp,
-            'config': config.getClientConfig(clientId),
+            'config': clientConfig,
             'username': jwt_payload.preferred_username
         }
         log.debug('Passport User', jwt_payload);
@@ -159,6 +173,7 @@ passport.use(
 
 app.use(bodyParser.json({limit: '200mb'}));
 app.use(bodyParser.urlencoded({limit: '200mb', extended: true}));
+
 //health check
 app.use('/v1/health', function (req, res, next) {
     res.json({status:"ok"})

package/conf/adapterConfig.js

@@ -9,6 +9,13 @@ const adapterParams = {
         cacheTime: env.AR_CACHE_TTL || 300,
         limitDefault: env.LIMIT_DEFAULT || 100,
         limitMax: env.LIMIT_MAX
+    },
+    smileconnect: {
+        type: "SMILEconnect",
+        clientId: env.SC_CLIENT,
+        secret: env.SC_SECRET,
+        ssoUrl: env.SC_SSO_URL,
+        smileConnectUrl: env.SC_SMILECONNECT_URL
     }
 };
 

package/conf/clients.json

@@ -21,8 +21,10 @@
         "scripts": {}
       },
       "incident": {
-        "basequery": "1=2",
-        "fields": [],
+        "basequery": "1=1",
+        "fields": [
+          "Description"
+        ],
         "constants": [],
         "scripts": {}
       },

package/controller/cmdbobjectController.js

@@ -299,7 +299,7 @@ async function updateCmdbObject(ticketConfig, clientConfig, id, ciData, classId)
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, ciData);
+        await scriptController.runScripts(scripts.preMapping, ciData, clientConfig.clientId);
     }
 
     const myClientConfig = {};
@@ -323,14 +323,14 @@ async function updateCmdbObject(ticketConfig, clientConfig, id, ciData, classId)
 
     //run postMapping
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, ciData);
+        await scriptController.runScripts(scripts.postMapping, ciData, clientConfig.clientId);
     }
 
     const update = await arquery.updateEntry(formName, ci['Request ID'], ciData);
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, ciData);
+        await scriptController.runScripts(scripts.afterExecution, ciData, clientConfig.clientId);
     }
 
     return update;
@@ -365,7 +365,7 @@ async function createCmdbObject(assetConfig, clientConfig, classId, ciData) {
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, ciData);
+        await scriptController.runScripts(scripts.preMapping, ciData, clientConfig.clientId);
     }
 
     const mapping = getClassMapping(classId);
@@ -377,7 +377,7 @@ async function createCmdbObject(assetConfig, clientConfig, classId, ciData) {
 
     //run postMapping
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, ciData);
+        await scriptController.runScripts(scripts.postMapping, ciData, clientConfig.clientId);
     }
 
     ciData['Data Set Id'] = "BMC.ASSET"
@@ -388,7 +388,7 @@ async function createCmdbObject(assetConfig, clientConfig, classId, ciData) {
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, ciData);
+        await scriptController.runScripts(scripts.afterExecution, ciData, clientConfig.clientId);
     }
 
     return instanceId;

package/controller/scriptController.js

@@ -45,7 +45,7 @@ function recFindByExt(base,ext,files,result) {
     return result
 }
 
-async function executeScriptInternal(scriptId, requestData, params, executedByScript) {
+async function executeScriptInternal(scriptId, requestData, params, executedByScript, clientId) {
 
     const code = await getGlobalScript(scriptId);
 
@@ -53,14 +53,14 @@ async function executeScriptInternal(scriptId, requestData, params, executedBySc
         throw (`Script ${scriptId} does not exist!`);
     }
 
-    return executeCode(code, requestData, params, null, executedByScript);
+    return executeCode(code, requestData, params, null, executedByScript, clientId);
 }
 
-async function executeScript(scriptId, requestData, params) {
-    return executeScriptInternal(scriptId, requestData, params, false)
+async function executeScript(scriptId, requestData, params, clientId) {
+    return executeScriptInternal(scriptId, requestData, params, false, clientId)
 }
 
-async function executeCode(code, requestData, params, logStream, executedByScript) {
+async function executeCode(code, requestData, params, logStream, executedByScript, clientId) {
     //todo should only be added once
     /*if (logStream) {
         log.addStream(logStream);
@@ -69,7 +69,7 @@ async function executeCode(code, requestData, params, logStream, executedByScrip
     //try to set user data for sandbox
 
     async function executeScriptByScript(scriptId, requestData, params) {
-        return executeScriptInternal(scriptId, requestData, params, true)
+        return executeScriptInternal(scriptId, requestData, params, true, clientId)
     }
 
     const sandbox = {
@@ -77,6 +77,7 @@ async function executeCode(code, requestData, params, logStream, executedByScrip
         params,
         adapter,
         log,
+        clientId,
         script:executeScriptByScript,
         env: process.env,
         fetch:fetch
@@ -243,10 +244,10 @@ async function getGlobalScripts() {
     return getScripts(path);
 }
 
-async function runScripts(scripts, data) {
+async function runScripts(scripts, data, clientId) {
     try {
         for (let x = 0; x < scripts.length; x++) {
-            await executeScript(scripts[x], data);
+            await executeScript(scripts[x], data, undefined, clientId);
         }
     } catch (error) {
         throw error;

package/controller/taskController.js

@@ -70,21 +70,21 @@ async function createTask(clientConfig, rootForm, rootRequestId, taskData, creat
 
         //run preScripts
         if (scripts && scripts.preMapping) {
-            await scriptController.runScripts(scripts.preMapping, taskData);
+            await scriptController.runScripts(scripts.preMapping, taskData, clientConfig.clientId);
         }
 
         taskData = mappingUtil.applyMapping2Remedy(taskData, mapping, clientConfig.task.constants, fields);
 
         //run postScripts
         if (scripts && scripts.postMapping) {
-            await scriptController.runScripts(scripts.postMapping, taskData);
+            await scriptController.runScripts(scripts.postMapping, taskData, clientConfig.clientId);
         }
 
         const taskResult = await arquery.createEntry('TMS:Task', taskData, clientConfig.options)
 
         //run afterExecution
         if (scripts && scripts.afterExecution) {
-            await scriptController.runScripts(scripts.afterExecution, data);
+            await scriptController.runScripts(scripts.afterExecution, data, clientConfig.clientId);
         }
 
         log.debug('Create Task Result', taskResult);
@@ -140,21 +140,21 @@ async function createWorklog(clientConfig, taskId, summary, text, attachment) {
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, data);
+        await scriptController.runScripts(scripts.preMapping, data, clientConfig.clientId);
     }
 
     data = mappingUtil.applyMapping2Remedy(data, mapping, clientConfig.taskWorklog.constants, fields);
 
     //run postScripts
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, data);
+        await scriptController.runScripts(scripts.postMapping, data, clientConfig.clientId);
     }
 
     const result = await arquery.createEntry('TMS:WorkInfo', data, clientConfig.options)
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, data);
+        await scriptController.runScripts(scripts.afterExecution, data, clientConfig.clientId);
     }
 
     return(result);
@@ -196,7 +196,7 @@ function queryTasks(clientConfig, query) {
 
                 //run preScripts
                 if (scripts && scripts.preMapping) {
-                    await scriptController.runScripts(scripts.preMapping, element);
+                    await scriptController.runScripts(scripts.preMapping, element, clientConfig.clientId);
                 }
 
                 //Apply mapping
@@ -212,7 +212,7 @@ function queryTasks(clientConfig, query) {
 
                 //run preScripts
                 if (scripts && scripts.postMapping) {
-                    await scriptController.runScripts(scripts.postMapping, element);
+                    await scriptController.runScripts(scripts.postMapping, element, clientConfig.clientId);
                 }
             }
             return ({
@@ -252,7 +252,7 @@ async function queryWorklogs(clientConfig, query, mapping) {
 
                 //run preScripts
                 if (scripts && scripts.preMapping) {
-                    await scriptController.runScripts(scripts.preMapping, element);
+                    await scriptController.runScripts(scripts.preMapping, element, clientConfig.clientId);
                 }
 
                 //Apply mapping
@@ -268,7 +268,7 @@ async function queryWorklogs(clientConfig, query, mapping) {
 
                 //run postScripts
                 if (scripts && scripts.postMapping) {
-                    await scriptController.runScripts(scripts.postMapping, element);
+                    await scriptController.runScripts(scripts.postMapping, element, clientConfig.clientId);
                 }
             }
             return {
@@ -314,21 +314,21 @@ async function updateTask(clientConfig, id, taskData) {
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, taskData);
+        await scriptController.runScripts(scripts.preMapping, taskData, clientConfig.clientId);
     }
 
     taskData = mappingUtil.applyMapping2Remedy(taskData, mapping, taskConstants, fields);
 
     //run postScripts
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, taskData);
+        await scriptController.runScripts(scripts.postMapping, taskData, clientConfig.clientId);
     }
 
     const result = await arquery.updateEntry('TMS:Task', id, taskData);
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, taskData);
+        await scriptController.runScripts(scripts.afterExecution, taskData, clientConfig.clientId);
     }
     return result;
 }

package/controller/ticketController.js

@@ -24,7 +24,7 @@ async function createTicket(ticketConfig, clientConfig, data) {
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, data);
+        await scriptController.runScripts(scripts.preMapping, data, clientConfig.clientId);
     }
 
     const requestType = ticketConfig.requestType;
@@ -39,7 +39,7 @@ async function createTicket(ticketConfig, clientConfig, data) {
 
     //run postScripts
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, data);
+        await scriptController.runScripts(scripts.postMapping, data, clientConfig.clientId);
     }
 
     const result = await arquery.createEntry(ticketConfig.forms.new, data, clientConfig.options)
@@ -63,7 +63,7 @@ async function createTicket(ticketConfig, clientConfig, data) {
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, data);
+        await scriptController.runScripts(scripts.afterExecution, data, clientConfig.clientId);
     }
     return resultInterfaceCreate;
 }
@@ -136,7 +136,7 @@ async function handleTicket(ticketConfig, ticket, mapping, clientConfig, include
         const preScripts = scripts.preMapping;
         try {
             for (let x = 0; x < preScripts.length; x++) {
-                const result = await scriptController.executeScript(preScripts[x], ticket);
+                const result = await scriptController.executeScript(preScripts[x], ticket, null, clientConfig.clientId);
             }
         } catch (error) {
             throw error;
@@ -160,7 +160,7 @@ async function handleTicket(ticketConfig, ticket, mapping, clientConfig, include
         const postScripts = scripts.postMapping;
         try {
             for (let x = 0; x < postScripts.length; x++) {
-                const result = await scriptController.executeScript(postScripts[x], ticket);
+                const result = await scriptController.executeScript(postScripts[x], ticket, null, clientConfig.clientId);
             }
         } catch (error) {
             throw error;
@@ -283,7 +283,7 @@ async function updateTicket(ticketConfig, clientConfig, id, ticketData) {
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, ticketData);
+        await scriptController.runScripts(scripts.preMapping, ticketData, clientConfig.clientId);
     }
 
     log.debug(clientConfig[ticketConfig.requestType]);
@@ -300,14 +300,14 @@ async function updateTicket(ticketConfig, clientConfig, id, ticketData) {
 
     //run postMapping
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, ticketData);
+        await scriptController.runScripts(scripts.postMapping, ticketData, clientConfig.clientId);
     }
 
     const update = await arquery.updateEntry(ticketConfig.forms.regular, ticket.data.internalId, ticketData);
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, ticketData);
+        await scriptController.runScripts(scripts.afterExecution, ticketData, clientConfig.clientId);
     }
 
     return update;

package/controller/ticketWorkLogController.js

@@ -61,21 +61,21 @@ async function createWorklog(ticketConfig, clientConfig, ticketId, summary, text
 
     //run preScripts
     if (scripts && scripts.preMapping) {
-        await scriptController.runScripts(scripts.preMapping, data);
+        await scriptController.runScripts(scripts.preMapping, data, clientConfig.clientId);
     }
 
     data = mappingUtil.applyMapping2Remedy(data, mapping, clientConstants, fields);
 
     //run postScripts
     if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, data);
+        await scriptController.runScripts(scripts.postMapping, data, clientConfig.clientId);
     }
 
     const result = arquery.createEntry(ticketConfig.forms.workLog, data, clientConfig.options)
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
-        await scriptController.runScripts(scripts.afterExecution, data);
+        await scriptController.runScripts(scripts.afterExecution, data, clientConfig.clientId);
     }
 
     return result;
@@ -169,12 +169,12 @@ async function queryWorklogs(ticketConfig, clientConfig, query, mapping) {
                 const element = result.data[x];
                 //run preScripts
                 if (scripts && scripts.preMapping) {
-                    await scriptController.runScripts(scripts.preMapping, result.data);
+                    await scriptController.runScripts(scripts.preMapping, result.data, clientConfig.clientId);
                 }
                 applyMapping(element, mapping, 'Entry ID');
                 //run postScripts
                 if (scripts && scripts.postMapping) {
-                    await scriptController.runScripts(scripts.postMapping, result.data);
+                    await scriptController.runScripts(scripts.postMapping, result.data, clientConfig.clientId);
                 }
             }
             return {

package/docs/general/config.md

@@ -82,6 +82,15 @@ List of users who are allowed to access /v1/appconfig endpoints.
 Sample:
 ADMIN_USERS=username1, username2
 
+### MASTER_CLIENTS
+
+List of clients that can act on behalf of other clients. 
+
+The URL Parameter *clientId* is used for this.
+
+Sample:
+MASTER_CLIENTS=idm,adminTool
+
 ## Cache
 
 ### CACHETTL_CMDB

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.33.0",
+  "version": "1.35.0",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/test/incidentTest.js

@@ -46,9 +46,9 @@ describe('Integration Tests - Incidents', function () {
         })
 
         it ('it should get all incidents', function (done) {
-            this.timeout(5000);
+            this.timeout(25000);
             chai.request(server)
-                .get('/v1/incidents')
+                .get('/v1/incidents?limit=10')
                 .set('Authorization', 'Bearer ' + authUser.access_token)
                 .end(function(err, res) {
                     res.should.have.status(200);

package/util/auth.js

@@ -19,6 +19,20 @@ function isAuthorizedAdmin(req, res, next) {
     }
 }
 
+function isMasterClient(clientId) {
+    const masterClients = process.env.MASTER_CLIENTS;
+    if (masterClients !== null
+        && masterClients !== undefined
+        && clientId !== null
+        && clientId !== undefined
+        && isUserInList(masterClients, clientId)) {
+        log.debug('master client authorized', clientId);
+        return true
+    } else {
+        return false
+    }
+}
+
 function isUserInList(userList, userName) {
     log.debug('Check if user is in List', userName, userList)
     if (userList !== null && userList !== undefined && userName !== null && userName !== undefined) {
@@ -33,5 +47,5 @@ function isUserInList(userList, userName) {
 }
 
 module.exports = {
-    isAuthorizedAdmin
+    isAuthorizedAdmin, isMasterClient
 }