@manny-est/node-red-flowpilot 0.6.0-beta.1 → 0.6.1

package/lib/core/main.js

@@ -35,7 +35,8 @@
     // Every code path that appends DOM to #fp-messages also appends a record
     // here. refreshView() clears the message container and re-renders from
     // records, restoring interactive elements without losing conversation.
-    // Records are in-memory only — no sessionStorage, no persistence.
+    // Records are in-memory only — no full sessionStorage persistence.
+    // Only the minimal interrupted-run marker is persisted separately.
     // ---------------------------------------------------------------------
     var messageRecords = [];
     var _nextRecordId = 0;
@@ -722,6 +723,11 @@
     // Clears the visible chat AND resets the conversation history the model
     // sees — "start a fresh conversation".
     function clearChat() {
+        flowpilotStorageLog("log", "clearChat-enter", {
+            conversationId: conversationId,
+            messageCount: messageRecords.length,
+            href: location.href
+        });
         el("#fp-messages").empty();
         messageRecords = [];
         relayClearMessagesToPopout();
@@ -731,6 +737,7 @@
         disarmExecuteAction(); // also clears pinnedSelectionIds
         delete appliedOpsByConversation[conversationId];
         conversationId = newConversationId();
+        clearRunMarker("clearChat");
         fpChatSnappedToBottom = true;
         updateSelectionStatus();
         updateDebugStatus();
@@ -846,11 +853,18 @@
     // onError: optional — CLAUDE-029's page-load rehydration passes one to
     // stay quiet (no chat error bubble) and clear a stale sessionStorage
     // entry on 404, instead of the ajaxJson default of addMessage("error", …).
-    function loadConversation(id, onError) {
+    function loadConversation(id, onError, onLoaded, options) {
+        options = options || {};
+        flowpilotStorageLog("log", "loadConversation-start", {
+            requestedConversationId: id,
+            currentConversationId: conversationId,
+            href: location.href
+        });
         ajaxJson("GET", "flowpilot/conversations/" + encodeURIComponent(id), null, function (data) {
             delete appliedOpsByConversation[conversationId];
             conversationId = id;
-            try { sessionStorage.setItem("fp-conversation-id", id); } catch (e) { /* storage unavailable */ }
+            persistConversationId(id, "loadConversation success");
+            if (!options.preserveRunMarker) { clearRunMarker("loadConversation"); }
 
             conversationHistory = [];
             relayClearMessagesToPopout();
@@ -865,6 +879,7 @@
             pinnedSelectionIds = null;
             updateSelectionStatus();
             showChat();
+            if (onLoaded) { onLoaded(data); }
         }, onError);
     }
 
@@ -1032,7 +1047,9 @@
         if (!$box.length) { return; }
 
         var label = role === "user" ? "YOU" : role === "error" ? "ERROR" : "FLOWPILOT";
-        var cls = "fp-message" + (role === "user" ? " fp-user" : role === "error" ? " fp-error" : "");
+        var cls = "fp-message" + (role === "user" ? " fp-user" :
+            role === "error" ? " fp-error" :
+            role === "fp-notice" ? " fp-secondary" : "");
 
         var $msg = $("<div>").addClass(cls);
         $("<div>").addClass("fp-label").text(label).appendTo($msg);
@@ -1270,6 +1287,7 @@
         el("#fp-api-key").val(p.apiKey || "");
         el("#fp-api-key").attr("placeholder", p.hasApiKey ? "Saved — leave to keep, retype to change" : "Optional");
         el("#fp-model").val(p.model || "");
+        el("#fp-num-ctx").val(p.numCtx !== undefined ? p.numCtx : 0);
         el("#fp-temperature").val(p.temperature !== undefined ? p.temperature : 0.2);
         // Test provider is disabled until this provider has a model.
         el("#fp-test-provider").prop("disabled", !(p.model && String(p.model).trim()));
@@ -1294,13 +1312,60 @@
         el("#fp-persona-label").text(personaLabelFor(n));
     }
 
-    function fillSettings(settings) {
+    function hideUpdateBanner() {
+        el("#fp-update-banner").addClass("fp-hidden").empty();
+    }
+
+    function showUpdateBanner(data) {
+        var $banner = el("#fp-update-banner");
+        if (!$banner.length) { return; }
+        $banner.empty().removeClass("fp-hidden");
+        $banner.append(document.createTextNode("Update available (v" + data.latestVersion + ") — see Palette Manager to install. "));
+        $("<a>").attr("href", "#").text("Dismiss").on("click", function (ev) {
+            ev.preventDefault();
+            try {
+                sessionStorage.setItem("fp-update-dismissed-" + data.latestVersion, "1");
+            } catch (e) { /* storage unavailable */ }
+            hideUpdateBanner();
+        }).appendTo($banner);
+    }
+
+    function checkForFlowPilotUpdates() {
+        if (isPopoutContext) { return; }
+        ajaxJson("GET", "flowpilot/update-check", null, function (data) {
+            if (!data || data.enabled === false || data.updateAvailable === false) {
+                hideUpdateBanner();
+                return;
+            }
+            try {
+                if (sessionStorage.getItem("fp-update-dismissed-" + data.latestVersion)) {
+                    hideUpdateBanner();
+                    return;
+                }
+            } catch (e) { /* storage unavailable */ }
+            showUpdateBanner(data);
+        }, function () {
+            hideUpdateBanner();
+        });
+    }
+
+    function fillSettings(settings, reason) {
         settings = settings || {};
         currentSettings = settings;
 
         renderProviderDropdown();
         fillProviderFields(activeProvider());
 
+        el("#fp-flowpilot-version").text("FlowPilot v" + (settings.flowpilotVersion || "unknown"));
+        var systemPromptCurrent = el("#fp-system-prompt").val();
+        var systemPromptIncoming = settings.systemPrompt || "";
+        console.log("[FlowPilot][G3] fillSettings systemPrompt", {
+            reason: reason || "unspecified",
+            current: systemPromptCurrent,
+            incoming: settings.systemPrompt,
+            writing: systemPromptIncoming,
+            differs: systemPromptCurrent !== systemPromptIncoming
+        });
         el("#fp-system-prompt").val(settings.systemPrompt || "");
         el("#fp-persona-intensity").val(settings.personaIntensity !== undefined ? settings.personaIntensity : 2);
         updatePersonaLabel();
@@ -1309,19 +1374,24 @@
         el("#fp-history-max").val(settings.historyMaxExchanges !== undefined ? settings.historyMaxExchanges : 10);
         el("#fp-streaming-enabled").prop("checked", !!settings.streamingEnabled);
         el("#fp-request-timeout").val(settings.requestTimeoutMs !== undefined ? (settings.requestTimeoutMs / 1000) : 180);
+        el("#fp-check-for-updates").prop("checked", settings.checkForUpdates !== false);
         el("#fp-agent-turn-max-tokens").val(settings.agentTurnMaxTokens !== undefined ? settings.agentTurnMaxTokens : 4096);
+        el("#fp-agent-loop-token-ceiling").val(settings.agentLoopTokenCeiling !== undefined ? settings.agentLoopTokenCeiling : 50000);
         el("#fp-agent-loop-max-iterations").val(settings.agentLoopMaxIterations !== undefined ? settings.agentLoopMaxIterations : 5);
         el("#fp-loop-hold-step").prop("checked", !!settings.loopHoldStep);
         el("#fp-suppress-warnings").prop("checked", !!settings.suppressContextWarnings);
         el("#fp-redaction-disabled").prop("checked", settings.redactionEnabled === false);
         el("#fp-debug-logging").prop("checked", !!settings.debugLogging);
 
-        // The dev/test banner is part of the warning set the user can silence
-        // via the type-to-confirm acknowledgement.
+        // Plain checkbox-driven dev/test warning icon visibility; this warning
+        // no longer uses a type-to-confirm acknowledgement.
         if (settings.suppressContextWarnings) {
-            el("#fp-dev-banner").addClass("fp-hidden");
+            el("#fp-dev-warning-status").addClass("fp-hidden");
         } else {
-            el("#fp-dev-banner").removeClass("fp-hidden");
+            el("#fp-dev-warning-status").removeClass("fp-hidden");
+        }
+        if (settings.checkForUpdates === false) {
+            hideUpdateBanner();
         }
 
         // Custom intents may have changed; rebuild buttons and the editor list.
@@ -1363,21 +1433,21 @@
         ap.baseUrl = el("#fp-base-url").val() || "";
         ap.apiKey = el("#fp-api-key").val() || "";
         ap.model = el("#fp-model").val() || "";
+        ap.numCtx = Math.max(0, Number(el("#fp-num-ctx").val() || 0));
         ap.temperature = Number(el("#fp-temperature").val() || 0.2);
         currentSettings.providers = list;
     }
 
     function collectSettings() {
-        // Only honour the suppression toggle if the confirmation phrase was
-        // typed exactly. Otherwise warnings stay on regardless of the checkbox.
-        var wantSuppress = el("#fp-suppress-warnings").prop("checked");
-        var typed = (el("#fp-suppress-confirm").val() || "").trim();
-        var suppress = wantSuppress && typed === "I understand the risk";
-
-        // Same type-to-confirm gate as suppressContextWarnings above, and for
-        // the same reason: the confirm box is never pre-filled from settings,
-        // so disabling redaction stays off unless re-confirmed on every save —
-        // "off-able, not off-by-accident".
+        // Plain checkbox — no confirmation phrase required (Manny's explicit
+        // call: excessive friction for this particular warning, unlike the
+        // redaction opt-out below which stays gated).
+        var suppress = el("#fp-suppress-warnings").prop("checked");
+
+        // Same type-to-confirm gate as suppressContextWarnings used to have,
+        // and for the same reason: the confirm box is never pre-filled from
+        // settings, so disabling redaction stays off unless re-confirmed on
+        // every save — "off-able, not off-by-accident".
         var wantRedactionOff = el("#fp-redaction-disabled").prop("checked");
         var redactionTyped = (el("#fp-redaction-confirm").val() || "").trim();
         var redactionEnabled = !(wantRedactionOff && redactionTyped === "disable redaction");
@@ -1397,18 +1467,25 @@
         if (!isFinite(agentLoopMaxIterations) || agentLoopMaxIterations < 1) { agentLoopMaxIterations = 5; }
 
         var agentTurnMaxTokens = Number(el("#fp-agent-turn-max-tokens").val());
+        var agentLoopTokenCeiling = Number(el("#fp-agent-loop-token-ceiling").val());
+        var systemPrompt = el("#fp-system-prompt").val();
+        console.log("[FlowPilot][G3] saveSettings reading systemPrompt", {
+            value: systemPrompt
+        });
 
         return {
             providers: providersList(),
             activeProviderId: currentSettings.activeProviderId,
-            systemPrompt: el("#fp-system-prompt").val(),
+            systemPrompt: systemPrompt,
             personaIntensity: personaIntensity,
             contextWarnTokens: Number(el("#fp-warn-tokens").val() || 4000),
             contextHighTokens: Number(el("#fp-high-tokens").val() || 8000),
             historyMaxExchanges: historyMax,
             streamingEnabled: el("#fp-streaming-enabled").prop("checked"),
             requestTimeoutMs: Math.round(requestTimeoutSec * 1000),
+            checkForUpdates: el("#fp-check-for-updates").prop("checked"),
             agentTurnMaxTokens: agentTurnMaxTokens,
+            agentLoopTokenCeiling: agentLoopTokenCeiling,
             agentLoopMaxIterations: agentLoopMaxIterations,
             loopHoldStep: el("#fp-loop-hold-step").prop("checked"),
             suppressContextWarnings: suppress,
@@ -1449,6 +1526,7 @@
             baseUrl: "http://localhost:8080",
             apiKey: "",
             model: "",
+            numCtx: 0,
             temperature: 0.2
         });
         currentSettings.providers = list;
@@ -1542,7 +1620,7 @@
             return;
         }
         ajaxJson("GET", "flowpilot/settings", null, function (data) {
-            fillSettings(data);
+            fillSettings(data, "loadSettings GET response");
             maybeShowFirstRun(data);
             updateSelectionStatus();
         }, function (msg) {
@@ -1567,12 +1645,19 @@
             return;
         }
         if (!isFinite(payload.agentTurnMaxTokens) || payload.agentTurnMaxTokens <= 0 || Math.floor(payload.agentTurnMaxTokens) !== payload.agentTurnMaxTokens) {
-            var tokenMsg = "Cannot save: max tokens per agent turn must be a positive whole number.";
+            var tokenMsg = "Cannot save: max tokens per model response (agent step) must be a positive whole number.";
             addMessage("error", tokenMsg);
             if (announce) { showSaveStatus(tokenMsg, true); }
             showSettings();
             return;
         }
+        if (!isFinite(payload.agentLoopTokenCeiling) || payload.agentLoopTokenCeiling <= 0 || Math.floor(payload.agentLoopTokenCeiling) !== payload.agentLoopTokenCeiling) {
+            var ceilingMsg = "Cannot save: max total tokens per agent turn must be a positive whole number.";
+            addMessage("error", ceilingMsg);
+            if (announce) { showSaveStatus(ceilingMsg, true); }
+            showSettings();
+            return;
+        }
 
         // Validation 1: every non-Anthropic provider needs a base URL.
         // Anthropic providers default to api.anthropic.com when baseUrl is blank.
@@ -1627,7 +1712,7 @@
         }
 
         ajaxJson("POST", "flowpilot/settings", payload, function (data) {
-            fillSettings(data);
+            fillSettings(data, "saveSettings POST response");
             addMessage("assistant", "Settings saved.");
             if (announce) { showSaveStatus("Settings saved."); }
             updateSelectionStatus();
@@ -2116,8 +2201,8 @@
         if (typeof args.selectionHint === "string" && args.selectionHint.trim()) {
             result.suggestedAction.selectionHint = args.selectionHint.trim();
         }
-        if (args.targetNodeIds === "all") {
-            result.suggestedAction.targetNodeIds = "all";
+        if (args.targetNodeIds === "all" || args.targetNodeIds === "instance") {
+            result.suggestedAction.targetNodeIds = args.targetNodeIds;
         } else if (Array.isArray(args.targetNodeIds)) {
             var ids = args.targetNodeIds
                 .filter(function (id) { return typeof id === "string" && id.trim(); })
@@ -2422,6 +2507,9 @@
         } else {
             var warnAt = Number(currentSettings.contextWarnTokens) || 4000;
             var highAt = Number(currentSettings.contextHighTokens) || 8000;
+            var ap = activeProvider();
+            var numCtx = ap ? Number(ap.numCtx) : 0;
+            var hasNumCtx = isFinite(numCtx) && numCtx > 0;
 
             var parts = [];
             if (contextTokens) { parts.push("context ~" + contextTokens.toLocaleString()); }
@@ -2432,9 +2520,15 @@
             }
             var sizeText = "~" + tokens.toLocaleString() + " tokens" +
                 (parts.length ? " (" + parts.join(", ") + ")" : "");
+            if (hasNumCtx) {
+                sizeText += " — " + Math.round((tokens / numCtx) * 100) + "% of " +
+                    (ap.providerName || "this provider") + "'s " + numCtx.toLocaleString() +
+                    " context window";
+            }
+            var nearProviderLimit = hasNumCtx && tokens >= numCtx * 0.8;
 
             $size.removeClass("fp-hidden fp-size-warn fp-size-high");
-            if (tokens >= highAt) {
+            if (tokens >= highAt || nearProviderLimit) {
                 $size.text(sizeText + " — large; may exceed smaller local models. " +
                            "Consider selecting fewer nodes, clearing chat history, or splitting your request.")
                      .addClass("fp-size-high");