@manny-est/node-red-flowpilot 0.5.1 → 0.6.0-beta.1

package/lib/core/init.js

@@ -24,7 +24,8 @@
         "- `/build` — describe a goal; I'll plan, propose, and walk an iterative build → deploy → debug → review → fix loop with you\n" +
         "- `/compact` — hide labels on the selected node(s) (icon-only); `/expand` restores them. Instant, no AI involved — one Ctrl+Z undoes it.\n" +
         "- `/disable` — disable the selected node(s) (skipped on Deploy); `/enable` re-enables them. Instant, no AI involved — one Ctrl+Z undoes it.\n" +
-        "- `/refresh` — re-render all messages from the in-memory record store (restores interactive Apply buttons if they were lost).\n\n" +
+        "- `/refresh` — re-render all messages from the in-memory record store (restores interactive Apply buttons if they were lost).\n" +
+        "- `/debug` — toggle debug logging (full prompts/replies/decisions to `flowpilot/debug.log`) on/off. Instant, no AI involved.\n\n" +
         "### Also worth knowing\n\n" +
         "- Action chips (paper-plane buttons) offer a one-click follow-up — review and send, nothing fires automatically.\n" +
         "- When I ask a clarifying question, I'll often offer quick-reply buttons (plus \"Other\" for your own answer) — clicking one sends it right away.\n" +
@@ -64,6 +65,7 @@
         { cmd: "/disable",  desc: "Disable selected nodes" },
         { cmd: "/enable",   desc: "Enable selected nodes" },
         { cmd: "/refresh",  desc: "Re-render all messages from shadow record store" },
+        { cmd: "/debug",    desc: "Toggle debug logging on/off" },
         { cmd: "/demo",     desc: "Type in a demo prompt" },
         { cmd: "/help",     desc: "Show all available commands" },
         { cmd: "/feedback", desc: "Show feedback info" }
@@ -237,6 +239,17 @@
                 refreshView();
                 if ($promptBox.length) { $promptBox.val(""); }
                 break;
+            // Deterministic, no AI round-trip: flips the same
+            // settings.debugLogging field the Hangar checkbox binds to, via
+            // the normal saveSettings() round trip, so the two never drift.
+            case "/debug":
+                var newDebugState = !el("#fp-debug-logging").prop("checked");
+                el("#fp-debug-logging").prop("checked", newDebugState);
+                saveSettings(function () {
+                    addMessage("assistant", "Debug logging is now " + (newDebugState ? "ON" : "OFF") + ".");
+                });
+                if ($promptBox.length) { $promptBox.val(""); }
+                break;
             // Deterministic, no LLM round-trip: just invokes Node-RED's own
             // native "show/hide selected node labels" action (RED.actions
             // "core:show-selected-node-labels" / "core:hide-selected-node-
@@ -567,7 +580,7 @@
             $panel.data("fp-review-apply-bound", true);
             var recordId = parseInt($panel.attr("data-fp-record-id"), 10);
             if (isNaN(recordId)) { return; }
-            $panel.find(".fp-review-actions button.red-ui-button-primary").on("click", function () {
+            $panel.find(".fp-review-actions button.fp-chip.fp-chip-card:not(:disabled)").on("click", function () {
                 var $btn = $(this);
                 if ($btn.prop("disabled")) { return; }
                 $btn.prop("disabled", true).text("Applying…");
@@ -579,6 +592,50 @@
         });
     }
 
+    // Interactive question/consent buttons are cloned into the pop-out as
+    // HTML, so their main-window click closures do not survive. Relay the
+    // record id plus the selected action back to the parent, where the live
+    // record still owns the continuation callback/state.
+    function bindRecordActionButtons($scope) {
+        $scope.filter("[data-fp-record-id]").add($scope.find("[data-fp-record-id]"))
+            .filter("button").each(function () {
+                var $btn = $(this);
+                if ($btn.data("fp-record-action-bound") || $btn.prop("disabled")) { return; }
+                var recordId = parseInt($btn.attr("data-fp-record-id"), 10);
+                var action = $btn.attr("data-fp-record-action");
+                if (isNaN(recordId) || !action) { return; }
+                $btn.data("fp-record-action-bound", true).on("click", function () {
+                    if (action === "show-other") {
+                        $btn.closest(".fp-question-row").next(".fp-question-other-row")
+                            .removeClass("fp-hidden").find("input").focus();
+                        return;
+                    }
+                    var relayAction = action;
+                    var value = $btn.attr("data-fp-record-value") || "";
+                    if (action === "answer-other") {
+                        value = $btn.siblings("input").val().trim();
+                        if (!value) { return; }
+                        relayAction = "answer";
+                    }
+                    var $questionRow = $btn.closest(".fp-question-row");
+                    var $otherRow = $btn.closest(".fp-question-other-row");
+                    $questionRow.find("button, input").prop("disabled", true);
+                    $questionRow.next(".fp-question-other-row").find("button, input").prop("disabled", true);
+                    $otherRow.find("button, input").prop("disabled", true);
+                    $otherRow.prev(".fp-question-row").find("button, input").prop("disabled", true);
+                    if (!window.opener || window.opener.closed) { return; }
+                    try {
+                        window.opener.postMessage({
+                            event: "resolveRecordAction",
+                            recordId: recordId,
+                            action: relayAction,
+                            value: value
+                        }, location.origin);
+                    } catch (e) { /* ignore */ }
+                });
+            });
+    }
+
     // The loop stepper's "Stop build loop" button is relayed the same
     // generic way as any other chat message (renderLoopStepper appends/
     // replaces a #fp-loop-stepper element, which the MutationObserver
@@ -830,6 +887,7 @@
             if (data.event === "initialSync") {
                 el("#fp-messages").html(data.html);
                 bindReviewApplyButtons(el("#fp-messages"));
+                bindRecordActionButtons(el("#fp-messages"));
                 bindStopLoopButton(el("#fp-messages"));
                 bindTabSwitching(el("#fp-messages"));
                 bindDebugAttachButtons(el("#fp-messages"));
@@ -837,6 +895,7 @@
             } else if (data.event === "appendMessage") {
                 el("#fp-messages").append(data.html);
                 bindReviewApplyButtons(el("#fp-messages").children().last());
+                bindRecordActionButtons(el("#fp-messages").children().last());
                 bindStopLoopButton(el("#fp-messages").children().last());
                 bindTabSwitching(el("#fp-messages").children().last());
                 bindDebugAttachButtons(el("#fp-messages").children().last());
@@ -1000,8 +1059,14 @@
                 '      </div>' +
                 '      <label>Provider Name</label>' +
                 '      <input id="fp-provider-name" type="text" placeholder="LocalAI">' +
+                '      <label>Provider type</label>' +
+                '      <select id="fp-provider-type">' +
+                '        <option value="openai-compatible">OpenAI-compatible (LocalAI, Ollama, SGLang, OpenAI, etc.)</option>' +
+                '        <option value="anthropic">Anthropic</option>' +
+                '      </select>' +
                 '      <label>Base URL</label>' +
                 '      <input id="fp-base-url" type="text" placeholder="http://localhost:8080">' +
+                '      <div id="fp-base-url-hint" class="fp-consent-hint fp-hidden">Leave blank to use api.anthropic.com.</div>' +
                 '      <label>API Key</label>' +
                 '      <input id="fp-api-key" type="password" placeholder="Optional">' +
                 '      <label>Model</label>' +
@@ -1028,8 +1093,8 @@
                 '      </div>' +
 
                 '      <div class="fp-settings-section">Personality</div>' +
-                '      <label>Persona intensity: <span id="fp-persona-value">3</span>/10</label>' +
-                '      <input id="fp-persona-intensity" type="range" min="1" max="10" step="1">' +
+                '      <label>Persona intensity: <span id="fp-persona-value">2</span>/5</label>' +
+                '      <input id="fp-persona-intensity" type="range" min="1" max="5" step="1">' +
                 '      <div id="fp-persona-label" class="fp-consent-hint"></div>' +
                 '      <div class="fp-consent-hint">Chat only. Scales the AI\'s voice at greetings, ' +
                 '        capability questions, and brief transitions — 1 is a plain Node-RED engineer, ' +
@@ -1056,10 +1121,14 @@
 
                 '      <div class="fp-settings-section">Request timeout</div>' +
                 '      <label>Give up after (seconds)</label>' +
-                '      <input id="fp-request-timeout" type="number" min="5" step="5" placeholder="180">' +
+                '      <input id="fp-request-timeout" type="number" step="any" placeholder="180">' +
                 '      <div class="fp-consent-hint">How long to wait for a provider response before ' +
                 '        giving up. Raise this if you\'re running a large local model on slow hardware ' +
                 '        (e.g. Ollama without a GPU) and seeing timeout errors.</div>' +
+                '      <label>Max tokens per agent turn</label>' +
+                '      <input id="fp-agent-turn-max-tokens" type="number" min="1" max="65536" step="1" placeholder="4096">' +
+                '      <div class="fp-consent-hint">Hard output limit for each tool-calling agent step. ' +
+                '        Classic (no-tools) requests are not capped.</div>' +
 
                 '      <div class="fp-settings-section">Agentic build loop</div>' +
                 '      <label>Max build/fix attempts</label>' +
@@ -1119,6 +1188,15 @@
                 '        sent either way. To disable, check the box and type ' +
                 '        <strong>disable redaction</strong> below.</div>' +
                 '      <input id="fp-redaction-confirm" type="text" placeholder="Type: disable redaction">' +
+
+                '      <div class="fp-settings-section">Debug mode</div>' +
+                '      <label class="fp-checkbox-row">' +
+                '        <input id="fp-debug-logging" type="checkbox"> ' +
+                '        Debug mode' +
+                '      </label>' +
+                '      <div class="fp-consent-hint">Logs full prompts, replies, and decisions to ' +
+                '        <code>flowpilot/debug.log</code> for troubleshooting. Off by default — ' +
+                '        this file can get large.</div>' +
                 '      </details>' +
 
                 '      <div class="fp-settings-actions">' +
@@ -1173,6 +1251,7 @@
             // Nothing is sent to the backend until the user explicitly
             // attaches a message and sends a request.
             try { RED.comms.subscribe("debug", onDebugMessage); } catch (e) { /* comms unavailable */ }
+            try { RED.comms.subscribe("status/#", onNodeStatus); } catch (e) { /* comms unavailable */ }
 
             // Track whether the user is scrolled to the bottom of the chat,
             // so "Cruising…"/streaming updates only auto-follow when they
@@ -1216,6 +1295,9 @@
             content.find("#fp-provider-select").on("change", function () {
                 switchProvider($(this).val());
             });
+            content.find("#fp-provider-type").on("change", function () {
+                toggleAnthropicHint($(this).val());
+            });
             content.find("#fp-add-provider").on("click", function () { addProvider(); });
             content.find("#fp-remove-provider").on("click", function () { removeProvider(); });
             content.find("#fp-test-provider").on("click", function () { testProvider(); });
@@ -1277,6 +1359,13 @@
             RED.events.on("deploy", function () {
                 if (activeBuildLoop && activeBuildLoop.waypoint === "apply") {
                     activeBuildLoop.waypoint = "attach";
+                    // CLAUDE-025: marks the start of THIS attempt's own
+                    // evidence window — see freshBuildLoopEvidence. Anything
+                    // that arrived before this (a prior attempt's debug
+                    // output, a manual attach, an unrelated still-running
+                    // flow) is stale and must not count toward this
+                    // attempt's own goal.
+                    activeBuildLoop.deployedAt = Date.now();
                     renderLoopStepper(activeBuildLoop);
                     // Start a timer so flows with no debug nodes (e.g. HTTP
                     // endpoints) don't leave the loop stuck silently waiting.
@@ -1358,6 +1447,36 @@
                         }
                         rec.state = "applied";
                     }
+                } else if (data.event === "resolveRecordAction" && typeof data.recordId === "number") {
+                    var actionRec = null;
+                    for (var ai = 0; ai < messageRecords.length; ai++) {
+                        if (messageRecords[ai].id === data.recordId) { actionRec = messageRecords[ai]; break; }
+                    }
+                    if (actionRec && actionRec.kind === "question" && !actionRec.decision) {
+                        if (actionRec.buildConsentGate && (data.action === "proceed" || data.action === "skip")) {
+                            actionRec.decision = data.action;
+                            runBuildConsentDecision(actionRec, data.action === "proceed");
+                        } else if (actionRec.agentToolConsent && (data.action === "proceed" || data.action === "skip")) {
+                            actionRec.decision = data.action;
+                            if (typeof actionRec.onResume === "function") { actionRec.onResume(data.action === "proceed"); }
+                        } else if (actionRec.askUserTool && data.action === "answer") {
+                            actionRec.decision = "answered";
+                            actionRec.answerText = String(data.value || "");
+                            if (typeof actionRec.onAnswer === "function") { actionRec.onAnswer(actionRec.answerText); }
+                        } else if (actionRec.loopCheckpoint && (data.action === "continue" || data.action === "stop")) {
+                            actionRec.decision = data.action;
+                            if (typeof actionRec.onResume === "function") { actionRec.onResume(data.action); }
+                        }
+                    } else if (actionRec && actionRec.kind === "chip" && actionRec.chipType === "suggestedAction"
+                            && data.action === "apply-suggested-action") {
+                        // CLAUDE-028: the redirect chip's own click handler (bound
+                        // directly on the button at render time) doesn't survive the
+                        // pop-out's innerHTML clone. Rides the same rebind-by-record-id
+                        // relay renderAskUserQuestion's quick-reply buttons already use
+                        // (bindRecordActionButtons in this file) — no chip-specific wiring
+                        // needed on the pop-out side.
+                        applySuggestedAction(actionRec.suggestedAction);
+                    }
                 } else if (data.event === "stopBuildLoop") {
                     stopBuildLoop("Build loop stopped — applied nodes remain as-is.");
                 } else if (data.event === "clearChat") {
@@ -1430,6 +1549,30 @@
             loadSettings();
             updateSelectionStatus();
             showChat();
+            rehydrateConversationOnLoad();
+    }
+
+    // CLAUDE-029: on a page reload, sessionStorage already retains the
+    // conversation-id (see history.js) and the backend already has the full
+    // transcript (History panel proves it's retrievable) — but nothing ever
+    // fetched and rendered it into the Chat panel on init, so a reload left
+    // Chat looking empty even though the conversation was never lost.
+    // Reuses loadConversation() verbatim (same fetch + same addMessage()
+    // render path the History panel's click handler uses) so there is no
+    // second copy of the message-rendering logic to drift out of sync.
+    function rehydrateConversationOnLoad() {
+        if (!conversationIdWasRestored) { return; }
+        loadConversation(conversationId, function (msg, xhr) {
+            // Conversation no longer exists server-side (404) — the
+            // sessionStorage entry is stale, so drop it rather than retry
+            // this same failed fetch on every future reload. Any other
+            // failure (network hiccup, etc.) leaves it in place in case it
+            // was transient. Either way: stay quiet, Chat simply stays
+            // empty exactly as it does today — no error bubble on load.
+            if (xhr && xhr.status === 404) {
+                try { sessionStorage.removeItem("fp-conversation-id"); } catch (e) { /* storage unavailable */ }
+            }
+        });
     }
 
     window.FlowPilotCore = { initMainWindow: initMainWindow, initPopout: initPopout };