@mandujs/core 0.54.32 → 0.55.0-beta.1

package/src/resource/ddl/emit.ts

@@ -15,11 +15,11 @@
  *   4. Value literals in `DEFAULT` clauses flow through `resolveDefault`
  *      which handles quote escaping. `kind: "sql"` is the explicit
  *      escape hatch — caller's responsibility.
- *   5. Unsupported changes (v1 scope — `alter-column-type`, and some
- *      dialect-specific ALTER gaps) emit a `-- TODO:` comment block plus
- *      a deliberate failing sentinel statement. The generated migration
- *      is reviewable/editable, but `mandu db apply` will not record it
- *      until the operator replaces the TODO with real SQL.
+ *   5. Unsupported changes (v1 scope — `alter-column-type`, and some
+ *      dialect-specific ALTER gaps) emit a `-- TODO:` comment block plus
+ *      a deliberate failing sentinel statement. The generated migration
+ *      is reviewable/editable, but `mandu db apply` will not record it
+ *      until the operator replaces the TODO with real SQL.
  *
  * Determinism:
  *   - `emitCreateTable` emits columns in `DdlFieldDef` array order — the
@@ -339,16 +339,16 @@ export function emitChange(change: Change, provider: SqlProvider): string {
 // Change emitters (internal — called only via emitChange dispatch).
 // =====================================================================
 
-function emitAddColumn(
-  resourceName: string,
-  field: DdlFieldDef,
-  provider: SqlProvider,
-): string {
-  validateAddColumn(resourceName, field, provider);
-  const table = quoteIdent(resourceName, provider);
-  const columnDef = emitColumnDef(field, provider);
-  const addColumn = `ALTER TABLE ${table} ADD COLUMN ${columnDef};`;
-  if (!field.indexed || field.unique || field.primary) return addColumn;
+function emitAddColumn(
+  resourceName: string,
+  field: DdlFieldDef,
+  provider: SqlProvider,
+): string {
+  validateAddColumn(resourceName, field, provider);
+  const table = quoteIdent(resourceName, provider);
+  const columnDef = emitColumnDef(field, provider);
+  const addColumn = `ALTER TABLE ${table} ADD COLUMN ${columnDef};`;
+  if (!field.indexed || field.unique || field.primary) return addColumn;
   return [
     addColumn,
     emitCreateIndex(
@@ -358,85 +358,85 @@ function emitAddColumn(
       false,
       provider,
     ),
-  ].join("\n");
-}
-
-function validateAddColumn(
-  resourceName: string,
-  field: DdlFieldDef,
-  provider: SqlProvider,
-): void {
-  if (provider !== "sqlite") return;
-
-  if (field.primary) {
-    throw new Error(
-      `SQLite cannot add PRIMARY KEY column "${field.name}" to existing table "${resourceName}" via ALTER TABLE. ` +
-        `Create a manual table-rebuild migration instead.`,
-    );
-  }
-
-  if (field.unique) {
-    throw new Error(
-      `SQLite cannot add UNIQUE column "${field.name}" to existing table "${resourceName}" via ALTER TABLE. ` +
-        `Add a nullable/non-unique column first, backfill it, then create a unique index manually.`,
-    );
-  }
-
-  const defaultIssue = sqliteAddColumnDefaultIssue(field);
-  if (defaultIssue) {
-    throw new Error(
-      `SQLite cannot add column "${field.name}" to existing table "${resourceName}" with this DEFAULT: ` +
-        `${defaultIssue} Use a scalar literal default or write a manual backfill migration.`,
-    );
-  }
-
-  if (field.nullable) return;
-  if (field.default !== undefined && !isSqliteNullDefault(field.default)) return;
-
-  throw new Error(
-    `SQLite cannot add required column "${field.name}" to existing table "${resourceName}" without a non-NULL constant DEFAULT. ` +
-      `Add a scalar default, set required:false, or write a manual backfill migration.`,
-  );
-}
-
-function sqliteAddColumnDefaultIssue(field: DdlFieldDef): string | null {
-  const def = field.default;
-  if (!def) return null;
-  if (def.kind === "now") {
-    return `default "now" maps to CURRENT_TIMESTAMP, which SQLite rejects in ADD COLUMN.`;
-  }
-  if (def.kind !== "sql") return null;
-
-  const expr = def.expr.trim();
-  if (/^CURRENT_(?:TIME|DATE|TIMESTAMP)\b/i.test(expr)) {
-    return `SQLite rejects CURRENT_TIME/CURRENT_DATE/CURRENT_TIMESTAMP in ADD COLUMN.`;
-  }
-  if (/\b[A-Za-z_][A-Za-z0-9_]*\s*\(/.test(expr)) {
-    return `SQLite rejects non-constant function defaults in ADD COLUMN.`;
-  }
-  if (!isSqliteAddColumnConstantSqlDefault(expr)) {
-    return `SQLite ADD COLUMN only accepts literal constant defaults; raw SQL expression ${JSON.stringify(expr)} is not safe to emit automatically.`;
-  }
-  return null;
-}
-
-function isSqliteNullDefault(def: NonNullable<DdlFieldDef["default"]>): boolean {
-  return def.kind === "null" || (def.kind === "sql" && /^NULL$/i.test(def.expr.trim()));
-}
-
-function isSqliteAddColumnConstantSqlDefault(expr: string): boolean {
-  let value = expr.trim();
-  while (value.startsWith("(") && value.endsWith(")")) {
-    value = value.slice(1, -1).trim();
-  }
-  return (
-    /^NULL$/i.test(value) ||
-    /^(?:TRUE|FALSE)$/i.test(value) ||
-    /^[+-]?(?:\d+|\d+\.\d+|\.\d+)(?:e[+-]?\d+)?$/i.test(value) ||
-    /^'(?:''|[^'])*'$/.test(value) ||
-    /^X'(?:[0-9a-f]{2})*'$/i.test(value)
-  );
-}
+  ].join("\n");
+}
+
+function validateAddColumn(
+  resourceName: string,
+  field: DdlFieldDef,
+  provider: SqlProvider,
+): void {
+  if (provider !== "sqlite") return;
+
+  if (field.primary) {
+    throw new Error(
+      `SQLite cannot add PRIMARY KEY column "${field.name}" to existing table "${resourceName}" via ALTER TABLE. ` +
+        `Create a manual table-rebuild migration instead.`,
+    );
+  }
+
+  if (field.unique) {
+    throw new Error(
+      `SQLite cannot add UNIQUE column "${field.name}" to existing table "${resourceName}" via ALTER TABLE. ` +
+        `Add a nullable/non-unique column first, backfill it, then create a unique index manually.`,
+    );
+  }
+
+  const defaultIssue = sqliteAddColumnDefaultIssue(field);
+  if (defaultIssue) {
+    throw new Error(
+      `SQLite cannot add column "${field.name}" to existing table "${resourceName}" with this DEFAULT: ` +
+        `${defaultIssue} Use a scalar literal default or write a manual backfill migration.`,
+    );
+  }
+
+  if (field.nullable) return;
+  if (field.default !== undefined && !isSqliteNullDefault(field.default)) return;
+
+  throw new Error(
+    `SQLite cannot add required column "${field.name}" to existing table "${resourceName}" without a non-NULL constant DEFAULT. ` +
+      `Add a scalar default, set required:false, or write a manual backfill migration.`,
+  );
+}
+
+function sqliteAddColumnDefaultIssue(field: DdlFieldDef): string | null {
+  const def = field.default;
+  if (!def) return null;
+  if (def.kind === "now") {
+    return `default "now" maps to CURRENT_TIMESTAMP, which SQLite rejects in ADD COLUMN.`;
+  }
+  if (def.kind !== "sql") return null;
+
+  const expr = def.expr.trim();
+  if (/^CURRENT_(?:TIME|DATE|TIMESTAMP)\b/i.test(expr)) {
+    return `SQLite rejects CURRENT_TIME/CURRENT_DATE/CURRENT_TIMESTAMP in ADD COLUMN.`;
+  }
+  if (/\b[A-Za-z_][A-Za-z0-9_]*\s*\(/.test(expr)) {
+    return `SQLite rejects non-constant function defaults in ADD COLUMN.`;
+  }
+  if (!isSqliteAddColumnConstantSqlDefault(expr)) {
+    return `SQLite ADD COLUMN only accepts literal constant defaults; raw SQL expression ${JSON.stringify(expr)} is not safe to emit automatically.`;
+  }
+  return null;
+}
+
+function isSqliteNullDefault(def: NonNullable<DdlFieldDef["default"]>): boolean {
+  return def.kind === "null" || (def.kind === "sql" && /^NULL$/i.test(def.expr.trim()));
+}
+
+function isSqliteAddColumnConstantSqlDefault(expr: string): boolean {
+  let value = expr.trim();
+  while (value.startsWith("(") && value.endsWith(")")) {
+    value = value.slice(1, -1).trim();
+  }
+  return (
+    /^NULL$/i.test(value) ||
+    /^(?:TRUE|FALSE)$/i.test(value) ||
+    /^[+-]?(?:\d+|\d+\.\d+|\.\d+)(?:e[+-]?\d+)?$/i.test(value) ||
+    /^'(?:''|[^'])*'$/.test(value) ||
+    /^X'(?:[0-9a-f]{2})*'$/i.test(value)
+  );
+}
 
 /**
  * DROP COLUMN.
@@ -462,8 +462,8 @@ function emitDropColumn(
  *
  * Output: a multi-line SQL comment block naming the resource + field +
  * fromType → toType, followed by the literal TODO message and a no-op
- * a deliberate failing sentinel so the migration runner refuses to mark
- * this TODO as applied until the operator edits the migration manually.
+ * a deliberate failing sentinel so the migration runner refuses to mark
+ * this TODO as applied until the operator edits the migration manually.
  */
 function emitAlterColumnTypeStub(
   resourceName: string,
@@ -477,13 +477,13 @@ function emitAlterColumnTypeStub(
     `--   from: ${fromType}`,
     `--   to:   ${toType}`,
     `-- TODO: Mandu does not auto-generate ALTER COLUMN TYPE in v1.`,
-    `-- Please write the migration manually, then re-run \`mandu db apply\`.`,
-    `-- ================================================================`,
-    manualMigrationRequiredStatement(
-      `Mandu cannot auto-generate ALTER COLUMN TYPE for ${resourceName}.${fieldName}`,
-    ),
-  ].join("\n");
-}
+    `-- Please write the migration manually, then re-run \`mandu db apply\`.`,
+    `-- ================================================================`,
+    manualMigrationRequiredStatement(
+      `Mandu cannot auto-generate ALTER COLUMN TYPE for ${resourceName}.${fieldName}`,
+    ),
+  ].join("\n");
+}
 
 function emitAlterColumnNullable(
   resourceName: string,
@@ -500,34 +500,34 @@ function emitAlterColumnNullable(
       : `ALTER TABLE ${table} ALTER COLUMN ${col} SET NOT NULL;`;
   }
   if (provider === "sqlite") {
-    // SQLite cannot toggle NOT NULL on an existing column without a full
-    // table recreate. Emit a failing stub so the user handles it manually.
-    return [
-      `-- ================================================================`,
-      `-- Nullability change: ${resourceName}.${fieldName} → ${nullable ? "NULL" : "NOT NULL"}`,
-      `-- TODO: SQLite cannot toggle NOT NULL in place. Recreate the table`,
-      `-- manually (CREATE new, INSERT SELECT, DROP old, RENAME) and re-run.`,
-      `-- ================================================================`,
-      manualMigrationRequiredStatement(
-        `SQLite nullability change requires manual table rebuild for ${resourceName}.${fieldName}`,
-      ),
-    ].join("\n");
-  }
+    // SQLite cannot toggle NOT NULL on an existing column without a full
+    // table recreate. Emit a failing stub so the user handles it manually.
+    return [
+      `-- ================================================================`,
+      `-- Nullability change: ${resourceName}.${fieldName} → ${nullable ? "NULL" : "NOT NULL"}`,
+      `-- TODO: SQLite cannot toggle NOT NULL in place. Recreate the table`,
+      `-- manually (CREATE new, INSERT SELECT, DROP old, RENAME) and re-run.`,
+      `-- ================================================================`,
+      manualMigrationRequiredStatement(
+        `SQLite nullability change requires manual table rebuild for ${resourceName}.${fieldName}`,
+      ),
+    ].join("\n");
+  }
   // MySQL requires the full column spec; we cannot reconstruct it here.
   // Emit a stub — Agent B's diff emits `alter-column-nullable` only when
   // everything else matches, so this is narrow-scope.
   return [
     `-- ================================================================`,
     `-- Nullability change: ${resourceName}.${fieldName} → ${nullable ? "NULL" : "NOT NULL"}`,
-    `-- TODO: MySQL MODIFY COLUMN requires the full column type; Mandu v1`,
-    `-- cannot emit this automatically. Please edit this migration to use`,
-    `-- \`ALTER TABLE ${resourceName} MODIFY COLUMN ${fieldName} <TYPE> ${nullable ? "NULL" : "NOT NULL"}\``,
-    `-- ================================================================`,
-    manualMigrationRequiredStatement(
-      `MySQL nullability change requires manual MODIFY COLUMN for ${resourceName}.${fieldName}`,
-    ),
-  ].join("\n");
-}
+    `-- TODO: MySQL MODIFY COLUMN requires the full column type; Mandu v1`,
+    `-- cannot emit this automatically. Please edit this migration to use`,
+    `-- \`ALTER TABLE ${resourceName} MODIFY COLUMN ${fieldName} <TYPE> ${nullable ? "NULL" : "NOT NULL"}\``,
+    `-- ================================================================`,
+    manualMigrationRequiredStatement(
+      `MySQL nullability change requires manual MODIFY COLUMN for ${resourceName}.${fieldName}`,
+    ),
+  ].join("\n");
+}
 
 function emitAlterColumnDefault(
   resourceName: string,
@@ -543,17 +543,17 @@ function emitAlterColumnDefault(
       : `ALTER TABLE ${table} ALTER COLUMN ${col} DROP DEFAULT;`;
   }
   if (provider === "sqlite") {
-    // Same constraint as nullability — SQLite needs a table recreate.
-    return [
-      `-- ================================================================`,
-      `-- Default change: ${resourceName}.${fieldName}`,
-      `-- TODO: SQLite cannot ALTER DEFAULT in place. Recreate the table.`,
-      `-- ================================================================`,
-      manualMigrationRequiredStatement(
-        `SQLite default change requires manual table rebuild for ${resourceName}.${fieldName}`,
-      ),
-    ].join("\n");
-  }
+    // Same constraint as nullability — SQLite needs a table recreate.
+    return [
+      `-- ================================================================`,
+      `-- Default change: ${resourceName}.${fieldName}`,
+      `-- TODO: SQLite cannot ALTER DEFAULT in place. Recreate the table.`,
+      `-- ================================================================`,
+      manualMigrationRequiredStatement(
+        `SQLite default change requires manual table rebuild for ${resourceName}.${fieldName}`,
+      ),
+    ].join("\n");
+  }
   // MySQL — ALTER COLUMN ... SET DEFAULT / DROP DEFAULT is actually supported.
   return def
     ? `ALTER TABLE ${table} ALTER COLUMN ${col} SET DEFAULT ${resolveDefault(def, provider)};`
@@ -597,7 +597,7 @@ function emitRenameTable(
   return `ALTER TABLE ${from} RENAME TO ${to};`;
 }
 
-function emitRenameColumn(
+function emitRenameColumn(
   resourceName: string,
   oldName: string,
   newName: string,
@@ -609,15 +609,15 @@ function emitRenameColumn(
   // All three dialects use `ALTER TABLE ... RENAME COLUMN ... TO ...` in
   // their modern versions (PG >=9.2, MySQL >=8.0.3, SQLite >=3.25).
   return `ALTER TABLE ${table} RENAME COLUMN ${from} TO ${to};`;
-}
-
-function manualMigrationRequiredStatement(message: string): string {
-  return `SELECT mandu_manual_migration_required(${sqlStringLiteral(message)});`;
-}
-
-function sqlStringLiteral(value: string): string {
-  return `'${value.replace(/'/g, "''")}'`;
-}
+}
+
+function manualMigrationRequiredStatement(message: string): string {
+  return `SELECT mandu_manual_migration_required(${sqlStringLiteral(message)});`;
+}
+
+function sqlStringLiteral(value: string): string {
+  return `'${value.replace(/'/g, "''")}'`;
+}
 
 // =====================================================================
 // Validation helpers.