@mandujs/core 0.54.17 → 0.54.19

package/src/router/client-entry.test.ts

@@ -1,12 +1,14 @@
 import { describe, expect, it } from "bun:test";
 import { mkdir, mkdtemp, rm, writeFile } from "fs/promises";
 import path from "path";
-import {
-  findClientComponentImports,
-  findRouteLevelClientComponentImport,
-  findRouteLevelClientComponentImports,
-  resolveRouteLevelClientEntryPath,
+import {
+  findClientComponentImports,
+  findRouteLevelClientComponentImport,
+  findRouteLevelClientComponentImports,
+  resolveRouteLevelClientEntryPath,
+  validateClientModuleForBrowserBundle,
 } from "./client-entry";
+import { analyzeRouteSource } from "./route-source-analyzer";
 
 const repoTempRoot = path.resolve(import.meta.dir, "../../../..", ".tmp-test-artifacts");
 
@@ -16,10 +18,10 @@ async function mkRepoTempDir(prefix: string): Promise<string> {
 }
 
 describe("findClientComponentImports", () => {
-  it("detects named .client imports for diagnostics", () => {
-    const imports = findClientComponentImports(`
-      import { LoginForm, SubmitButton as Button } from "@/client/widgets/login-form/LoginForm.client";
-      import Header from "./Header.client.tsx";
+  it("detects named .client imports for diagnostics", () => {
+    const imports = findClientComponentImports(`
+      import { LoginForm, SubmitButton as Button } from "@/client/widgets/login-form/LoginForm.client";
+      import Header from "./Header.client.tsx";
     `);
 
     expect(imports).toEqual([
@@ -32,9 +34,34 @@ describe("findClientComponentImports", () => {
         module: "./Header.client.tsx",
         kind: "default",
         names: ["Header"],
-      },
-    ]);
-  });
+      },
+    ]);
+  });
+
+  it("ignores import syntax inside string literals", () => {
+    const imports = findClientComponentImports(`
+      const example = "import Fake from './Fake.client'";
+
+      export default function Page() {
+        return <main>{example}</main>;
+      }
+    `);
+
+    expect(imports).toEqual([]);
+  });
+
+  it("ignores type-only client imports", () => {
+    const imports = findClientComponentImports(`
+      import type { LoginForm } from "@/client/widgets/login-form/LoginForm.client";
+      import { type SubmitButton } from "@/client/widgets/login-form/LoginForm.client";
+
+      export default function Page() {
+        return <main />;
+      }
+    `);
+
+    expect(imports).toEqual([]);
+  });
 
   it("detects a default-imported client component when the page returns only that component", () => {
     const routeClient = findRouteLevelClientComponentImport(`
@@ -124,11 +151,11 @@ describe("findClientComponentImports", () => {
     });
   });
 
-  it("promotes client imports when the page wrapper passes props", () => {
-    const routeClient = findRouteLevelClientComponentImport(`
-      import PledgePage from "@/client/pages/pledges/PledgePage.client";
-
-      export default function Page({ params }) {
+  it("promotes client imports when the page wrapper passes props", () => {
+    const routeClient = findRouteLevelClientComponentImport(`
+      import PledgePage from "@/client/pages/pledges/PledgePage.client";
+
+      export default function Page({ params }) {
         return <PledgePage id={params.id} />;
       }
     `);
@@ -138,7 +165,23 @@ describe("findClientComponentImports", () => {
       localName: "PledgePage",
       exportName: "default",
     });
-  });
+  });
+
+  it("detects client entries rendered by an identifier default export", () => {
+    const routeClient = findRouteLevelClientComponentImport(`
+      import PledgePage from "@/client/pages/pledges/PledgePage.client";
+
+      const Page = ({ params }) => <PledgePage id={params.id} />;
+
+      export default Page;
+    `);
+
+    expect(routeClient).toEqual({
+      module: "@/client/pages/pledges/PledgePage.client",
+      localName: "PledgePage",
+      exportName: "default",
+    });
+  });
 
   it("detects multiple rendered client imports in a server shell", () => {
     const routeClients = findRouteLevelClientComponentImports(`
@@ -187,17 +230,63 @@ describe("findClientComponentImports", () => {
     });
   });
 
-  it("does not promote shared UI primitives to route-level client entries", () => {
-    const routeClient = findRouteLevelClientComponentImport(`
-      import { Button } from "@/client/shared/ui/button";
-
-      export default function Page() {
+  it("does not promote shared UI primitives to route-level client entries", () => {
+    const routeClient = findRouteLevelClientComponentImport(`
+      import { Button } from "@/client/shared/ui/button";
+
+      export default function Page() {
         return <main><Button>Open</Button></main>;
       }
     `);
-
-    expect(routeClient).toBeNull();
-  });
+
+    expect(routeClient).toBeNull();
+  });
+
+  it("classifies default re-exports without treating them as rendered JSX", () => {
+    const analysis = analyzeRouteSource(`
+      export { default } from "./Page";
+    `);
+
+    expect(analysis.defaultExport).toMatchObject({
+      kind: "identifier",
+      localName: "default",
+      source: "./Page",
+      referencesJsx: false,
+      renderedJsxNames: [],
+    });
+  });
+
+  it("diagnoses default export wrapper calls conservatively", () => {
+    const analysis = analyzeRouteSource(`
+      import { memo } from "react";
+
+      const Page = () => <main />;
+
+      export default memo(Page);
+    `);
+
+    expect(analysis.defaultExport.kind).toBe("call");
+    expect(analysis.diagnostics.some((diagnostic) =>
+      diagnostic.code === "MANDU_ROUTE_DEFAULT_EXPORT_WRAPPER"
+    )).toBe(true);
+  });
+
+  it("records namespace imports without promoting member JSX as a route-level client entry", () => {
+    const source = `
+      import * as Widgets from "@/client/widgets/Widget.client";
+
+      export default function Page() {
+        return <Widgets.Panel />;
+      }
+    `;
+    const analysis = analyzeRouteSource(source);
+
+    expect(analysis.imports[0]).toMatchObject({
+      source: "@/client/widgets/Widget.client",
+      namespaceName: "Widgets",
+    });
+    expect(findRouteLevelClientComponentImport(source)).toBeNull();
+  });
 
   it("resolves a route-level client entry by reading a use client target without .client in the path", async () => {
     const rootDir = await mkRepoTempDir("client-entry-");
@@ -230,6 +319,42 @@ describe("findClientComponentImports", () => {
       expect(resolved).toBe("src/client/widgets/pledge-form/PledgeForm.tsx");
     } finally {
       await rm(rootDir, { recursive: true, force: true });
-    }
-  });
-});
+    }
+  });
+
+  it("validates explicit route-level client modules against server-only imports", async () => {
+    const rootDir = await mkRepoTempDir("client-entry-server-only-");
+    try {
+      await mkdir(path.join(rootDir, "app"), { recursive: true });
+      await writeFile(
+        path.join(rootDir, "app", "dashboard.island.tsx"),
+        `"use client";
+         import { Database } from "bun:sqlite";
+         export default function Dashboard() {
+           return String(Database);
+         }`,
+      );
+
+      const error = await validateClientModuleForBrowserBundle(
+        {
+          id: "dashboard",
+          kind: "page",
+          pattern: "/dashboard",
+          module: "app/dashboard.tsx",
+          componentModule: "app/dashboard.tsx",
+          clientModule: "app/dashboard.island.tsx",
+          clientExportName: "default",
+          hydration: { strategy: "island", priority: "visible", preload: false },
+        },
+        rootDir,
+      );
+
+      expect(error).toContain("MANDU_BOUNDARY_SERVER_ONLY_IMPORT");
+      expect(error).toContain("bun:sqlite");
+      expect(error).toContain("route=dashboard");
+      expect(error).toContain("Suggestion:");
+    } finally {
+      await rm(rootDir, { recursive: true, force: true });
+    }
+  });
+});