@mandujs/core 0.53.3 → 0.54.0

package/src/bundler/build.test.ts

@@ -1,179 +1,179 @@
-import { afterAll, beforeAll, describe, expect, test } from "bun:test";
-import { mkdtemp, mkdir, readFile, rm, writeFile } from "fs/promises";
-import path from "path";
-import { pathToFileURL } from "url";
-
-// 모든 테스트가 하나의 빌드 결과를 공유 — 병렬 Bun.build 충돌 방지
-let rootDir: string;
-let result: { success: boolean; errors: string[] };
-
-async function importBuiltModule(relativePath: string): Promise<Record<string, unknown>> {
-  const fileUrl = pathToFileURL(path.join(rootDir, relativePath)).href;
-  return import(`${fileUrl}?t=${Date.now()}`);
-}
-
-/**
- * Run `buildClientBundles` in an isolated `bun` subprocess.
- *
- * Bun 1.3.x exhibits a deterministic `AggregateError: Bundle failed` when
- * `buildClientBundles` is called from a test file AND the same `bun test`
- * process has previously imported `react` / `react-dom` through any sibling
- * test file (happens transitively through almost every `src/testing/*` or
- * `src/runtime/*` consumer). Retrying in-process does not recover — the
- * resolver state is sticky. A fresh subprocess has a clean module graph.
- * See `__tests__/build-runner.ts` for the subprocess entrypoint and more
- * background.
- */
-async function runBuildInSubprocess(root: string): Promise<{
-  success: boolean;
-  errors: string[];
-}> {
-  const runner = path.join(
-    import.meta.dir,
-    "__tests__",
-    "build-runner.ts",
-  );
-  try {
-    const proc = Bun.spawn([process.execPath, "run", runner, root], {
-      cwd: path.resolve(import.meta.dir, "..", ".."),
-      stdin: "ignore",
-      stdout: "pipe",
-      stderr: "inherit",
-    });
-    const out = await new Response(proc.stdout).text();
-    await proc.exited;
-
-    // Find the final JSON line — the runner may log Mandu dev banners
-    // (e.g. "[Mandu] DevTools …") before emitting the payload. The
-    // contract is: last non-empty line is the JSON blob.
-    const lines = out.split(/\r?\n/).filter((l) => l.trim().length > 0);
-    const last = lines[lines.length - 1] ?? "";
-    try {
-      const parsed = JSON.parse(last);
-      return {
-        success: parsed.success === true,
-        errors: Array.isArray(parsed.errors) ? parsed.errors : [],
-      };
-    } catch (e) {
-      return {
-        success: false,
-        errors: [
-          `build-runner output could not be parsed as JSON: ${String(e)}\nLast stdout line: ${last}`,
-        ],
-      };
-    }
-  } catch (err) {
-    return { success: false, errors: [`spawn failed: ${String(err)}`] };
-  }
-}
-
-beforeAll(async () => {
-  rootDir = await mkdtemp(path.join(import.meta.dir, ".tmp-bundler-"));
-
-  await mkdir(path.join(rootDir, "app"), { recursive: true });
-  await writeFile(
-    path.join(rootDir, "package.json"),
-    JSON.stringify({ name: "mandu-build-test", type: "module" }, null, 2),
-    "utf-8",
-  );
-  await writeFile(
-    path.join(rootDir, "app", "demo.client.tsx"),
-    "export default function DemoIsland() { return null; }\n",
-    "utf-8",
-  );
-
-  result = await runBuildInSubprocess(rootDir);
-});
-
-afterAll(async () => {
-  if (rootDir) {
-    await rm(rootDir, { recursive: true, force: true });
-  }
-});
-
-// Historical note — `MANDU_SKIP_BUNDLER_TESTS` gate REMOVED.
-//
-// A previous revision gated this describe block behind
-// `describe.skipIf(MANDU_SKIP_BUNDLER_TESTS === "1")` because running
-// `bun test src/bundler/` without the gate hung indefinitely on Windows
-// (see Phase 0.6 and `docs/qa/wave-R2-integration-report.md`). Root cause
-// was NOT actually in THIS file — it was a deadlock in `safe-build.test.ts`'s
-// "slot handoff" regression test, which drove Bun's microtask queue with a
-// `while (!stop) { await Promise.resolve() }` sampler. That starved libuv
-// I/O callbacks, so the 7 parallel `safeBuild()` calls never completed, the
-// whole test process hung, and downstream test files (including this one
-// when run in the same invocation) looked flaky when they were simply
-// never reached. The handoff sampler now yields via `setImmediate`, which
-// unblocks Bun.build completion and makes `bun test src/bundler/` finish
-// deterministically in ~35s on Windows. Confirmed green 3/3 runs without
-// the gate on 2026-04-20. If you are tempted to re-introduce the skip here,
-// first check whether a sibling test is starving the event loop.
-//
-// A second, independent flake — Bun.build `AggregateError: Bundle failed`
-// when another test file in the same invocation has imported `react` —
-// is now sidestepped by running `buildClientBundles` in a spawned `bun`
-// subprocess via `__tests__/build-runner.ts`. In-process retry does not
-// recover from that one; a fresh module graph does.
-describe("buildClientBundles vendor shims", () => {
-  test("build succeeds", () => {
-    if (!result.success) {
-      console.error("[build.test] errors:", result.errors);
-    }
-    expect(result.success).toBe(true);
-  });
-
-  test("re-exports modern React 19 APIs used by islands", async () => {
-    const reactShim = await importBuiltModule(".mandu/client/_react.js");
-    const requiredExports = [
-      "Activity",
-      "__COMPILER_RUNTIME",
-      "cache",
-      "cacheSignal",
-      "startTransition",
-      "use",
-      "useActionState",
-      "useEffectEvent",
-      "useOptimistic",
-      "unstable_useCacheRefresh",
-    ];
-
-    for (const exportName of requiredExports) {
-      expect(exportName in reactShim).toBe(true);
-    }
-  });
-
-  test("re-exports modern react-dom and react-dom/client APIs", async () => {
-    const reactDomShim = await importBuiltModule(".mandu/client/_react-dom.js");
-    for (const exportName of [
-      "preconnect",
-      "prefetchDNS",
-      "preinit",
-      "preinitModule",
-      "preload",
-      "preloadModule",
-      "requestFormReset",
-      "unstable_batchedUpdates",
-      "useFormState",
-      "useFormStatus",
-    ]) {
-      expect(exportName in reactDomShim).toBe(true);
-    }
-
-    const reactDomClientShim = await importBuiltModule(".mandu/client/_react-dom-client.js");
-    for (const exportName of ["createRoot", "hydrateRoot", "version"]) {
-      expect(exportName in reactDomClientShim).toBe(true);
-    }
-  });
-
-  test("embeds hydration guards for deferred trigger strategies", async () => {
-    const runtimeSource = await readFile(path.join(rootDir, ".mandu", "client", "_runtime.js"), "utf-8");
-    expect(runtimeSource).toContain("function resolveHydrationTarget");
-    expect(runtimeSource).toContain("function hasHydratableMarkup");
-    expect(runtimeSource).toContain("function shouldHydrateCompiledIsland");
-    expect(runtimeSource).toContain("onRecoverableError");
-    expect(runtimeSource).toContain("data-mandu-hydrating");
-    expect(runtimeSource).toContain("data-mandu-render-mode");
-    expect(runtimeSource).toContain("data-mandu-recoverable-error");
-    expect(runtimeSource).toContain("pointerdown");
-  });
-});
+import { afterAll, beforeAll, describe, expect, test } from "bun:test";
+import { mkdtemp, mkdir, readFile, rm, writeFile } from "fs/promises";
+import path from "path";
+import { pathToFileURL } from "url";
+
+// 모든 테스트가 하나의 빌드 결과를 공유 — 병렬 Bun.build 충돌 방지
+let rootDir: string;
+let result: { success: boolean; errors: string[] };
+
+async function importBuiltModule(relativePath: string): Promise<Record<string, unknown>> {
+  const fileUrl = pathToFileURL(path.join(rootDir, relativePath)).href;
+  return import(`${fileUrl}?t=${Date.now()}`);
+}
+
+/**
+ * Run `buildClientBundles` in an isolated `bun` subprocess.
+ *
+ * Bun 1.3.x exhibits a deterministic `AggregateError: Bundle failed` when
+ * `buildClientBundles` is called from a test file AND the same `bun test`
+ * process has previously imported `react` / `react-dom` through any sibling
+ * test file (happens transitively through almost every `src/testing/*` or
+ * `src/runtime/*` consumer). Retrying in-process does not recover — the
+ * resolver state is sticky. A fresh subprocess has a clean module graph.
+ * See `__tests__/build-runner.ts` for the subprocess entrypoint and more
+ * background.
+ */
+async function runBuildInSubprocess(root: string): Promise<{
+  success: boolean;
+  errors: string[];
+}> {
+  const runner = path.join(
+    import.meta.dir,
+    "__tests__",
+    "build-runner.ts",
+  );
+  try {
+    const proc = Bun.spawn([process.execPath, "run", runner, root], {
+      cwd: path.resolve(import.meta.dir, "..", ".."),
+      stdin: "ignore",
+      stdout: "pipe",
+      stderr: "inherit",
+    });
+    const out = await new Response(proc.stdout).text();
+    await proc.exited;
+
+    // Find the final JSON line — the runner may log Mandu dev banners
+    // (e.g. "[Mandu] DevTools …") before emitting the payload. The
+    // contract is: last non-empty line is the JSON blob.
+    const lines = out.split(/\r?\n/).filter((l) => l.trim().length > 0);
+    const last = lines[lines.length - 1] ?? "";
+    try {
+      const parsed = JSON.parse(last);
+      return {
+        success: parsed.success === true,
+        errors: Array.isArray(parsed.errors) ? parsed.errors : [],
+      };
+    } catch (e) {
+      return {
+        success: false,
+        errors: [
+          `build-runner output could not be parsed as JSON: ${String(e)}\nLast stdout line: ${last}`,
+        ],
+      };
+    }
+  } catch (err) {
+    return { success: false, errors: [`spawn failed: ${String(err)}`] };
+  }
+}
+
+beforeAll(async () => {
+  rootDir = await mkdtemp(path.join(import.meta.dir, ".tmp-bundler-"));
+
+  await mkdir(path.join(rootDir, "app"), { recursive: true });
+  await writeFile(
+    path.join(rootDir, "package.json"),
+    JSON.stringify({ name: "mandu-build-test", type: "module" }, null, 2),
+    "utf-8",
+  );
+  await writeFile(
+    path.join(rootDir, "app", "demo.client.tsx"),
+    "export default function DemoIsland() { return null; }\n",
+    "utf-8",
+  );
+
+  result = await runBuildInSubprocess(rootDir);
+});
+
+afterAll(async () => {
+  if (rootDir) {
+    await rm(rootDir, { recursive: true, force: true });
+  }
+});
+
+// Historical note — `MANDU_SKIP_BUNDLER_TESTS` gate REMOVED.
+//
+// A previous revision gated this describe block behind
+// `describe.skipIf(MANDU_SKIP_BUNDLER_TESTS === "1")` because running
+// `bun test src/bundler/` without the gate hung indefinitely on Windows
+// (see Phase 0.6 and `docs/qa/wave-R2-integration-report.md`). Root cause
+// was NOT actually in THIS file — it was a deadlock in `safe-build.test.ts`'s
+// "slot handoff" regression test, which drove Bun's microtask queue with a
+// `while (!stop) { await Promise.resolve() }` sampler. That starved libuv
+// I/O callbacks, so the 7 parallel `safeBuild()` calls never completed, the
+// whole test process hung, and downstream test files (including this one
+// when run in the same invocation) looked flaky when they were simply
+// never reached. The handoff sampler now yields via `setImmediate`, which
+// unblocks Bun.build completion and makes `bun test src/bundler/` finish
+// deterministically in ~35s on Windows. Confirmed green 3/3 runs without
+// the gate on 2026-04-20. If you are tempted to re-introduce the skip here,
+// first check whether a sibling test is starving the event loop.
+//
+// A second, independent flake — Bun.build `AggregateError: Bundle failed`
+// when another test file in the same invocation has imported `react` —
+// is now sidestepped by running `buildClientBundles` in a spawned `bun`
+// subprocess via `__tests__/build-runner.ts`. In-process retry does not
+// recover from that one; a fresh module graph does.
+describe("buildClientBundles vendor shims", () => {
+  test("build succeeds", () => {
+    if (!result.success) {
+      console.error("[build.test] errors:", result.errors);
+    }
+    expect(result.success).toBe(true);
+  });
+
+  test("re-exports modern React 19 APIs used by islands", async () => {
+    const reactShim = await importBuiltModule(".mandu/client/_react.js");
+    const requiredExports = [
+      "Activity",
+      "__COMPILER_RUNTIME",
+      "cache",
+      "cacheSignal",
+      "startTransition",
+      "use",
+      "useActionState",
+      "useEffectEvent",
+      "useOptimistic",
+      "unstable_useCacheRefresh",
+    ];
+
+    for (const exportName of requiredExports) {
+      expect(exportName in reactShim).toBe(true);
+    }
+  });
+
+  test("re-exports modern react-dom and react-dom/client APIs", async () => {
+    const reactDomShim = await importBuiltModule(".mandu/client/_react-dom.js");
+    for (const exportName of [
+      "preconnect",
+      "prefetchDNS",
+      "preinit",
+      "preinitModule",
+      "preload",
+      "preloadModule",
+      "requestFormReset",
+      "unstable_batchedUpdates",
+      "useFormState",
+      "useFormStatus",
+    ]) {
+      expect(exportName in reactDomShim).toBe(true);
+    }
+
+    const reactDomClientShim = await importBuiltModule(".mandu/client/_react-dom-client.js");
+    for (const exportName of ["createRoot", "hydrateRoot", "version"]) {
+      expect(exportName in reactDomClientShim).toBe(true);
+    }
+  });
+
+  test("embeds hydration guards for deferred trigger strategies", async () => {
+    const runtimeSource = await readFile(path.join(rootDir, ".mandu", "client", "_runtime.js"), "utf-8");
+    expect(runtimeSource).toContain("function resolveHydrationTarget");
+    expect(runtimeSource).toContain("function hasHydratableMarkup");
+    expect(runtimeSource).toContain("function shouldHydrateCompiledIsland");
+    expect(runtimeSource).toContain("onRecoverableError");
+    expect(runtimeSource).toContain("data-mandu-hydrating");
+    expect(runtimeSource).toContain("data-mandu-render-mode");
+    expect(runtimeSource).toContain("data-mandu-recoverable-error");
+    expect(runtimeSource).toContain("pointerdown");
+  });
+});

package/src/bundler/build.ts

@@ -1,4 +1,4 @@
-import type * as __ManduPluginsReactCompilerTypes0 from "./plugins/react-compiler";
+import type * as __ManduPluginsReactCompilerTypes0 from "./plugins/react-compiler";
 /**
  * Mandu Client Bundler 📦
  * Bun.build 기반 클라이언트 번들 빌드
@@ -65,9 +65,9 @@ function manduDefaultPlugins(options: BundlerOptions): BunPlugin[] {
  * this; SSR builds use `manduDefaultPlugins()` directly because React
  * Compiler offers zero benefit for one-shot HTML rendering.
  */
-function manduClientPlugins(options: BundlerOptions): BunPlugin[] {
-  const base = manduDefaultPlugins(options);
-  if (options.reactCompiler?.enabled !== true) return base;
+function manduClientPlugins(options: BundlerOptions): BunPlugin[] {
+  const base = manduDefaultPlugins(options);
+  if (options.reactCompiler?.enabled !== true) return base;
   // Lazy import to avoid pulling the react-compiler module into every
   // build graph — SSR / non-client paths never touch this branch.
   const { reactCompiler } = require("./plugins/react-compiler") as typeof __ManduPluginsReactCompilerTypes0;
@@ -75,41 +75,41 @@ function manduClientPlugins(options: BundlerOptions): BunPlugin[] {
     ...base,
     reactCompiler({
       reactCompilerConfig: options.reactCompiler.compilerConfig,
-    }),
-  ];
-}
-
-function resolveBundlerMode(options: BundlerOptions): "development" | "production" {
-  return options.mode ?? (process.env.NODE_ENV === "production" ? "production" : "development");
-}
-
-function isDevelopmentBuild(options: BundlerOptions): boolean {
-  return resolveBundlerMode(options) === "development";
-}
-
-function shouldMinify(options: BundlerOptions): boolean {
-  return options.minify ?? (resolveBundlerMode(options) === "production");
-}
-
-function shouldSplitChunks(options: BundlerOptions): boolean {
-  return options.splitting ?? (resolveBundlerMode(options) === "production");
-}
-
-function nodeEnvDefine(options: BundlerOptions): string {
-  return JSON.stringify(resolveBundlerMode(options));
-}
-
-function resolveClientOutDir(rootDir: string, outDir?: string): string {
-  const defaultOutDir = path.join(rootDir, ".mandu/client");
-  if (!outDir) return defaultOutDir;
-
-  const resolvedOutDir = path.isAbsolute(outDir) ? outDir : path.resolve(rootDir, outDir);
-  if (path.normalize(resolvedOutDir) === path.normalize(path.join(rootDir, ".mandu"))) {
-    return defaultOutDir;
-  }
-
-  return resolvedOutDir;
-}
+    }),
+  ];
+}
+
+function resolveBundlerMode(options: BundlerOptions): "development" | "production" {
+  return options.mode ?? (process.env.NODE_ENV === "production" ? "production" : "development");
+}
+
+function isDevelopmentBuild(options: BundlerOptions): boolean {
+  return resolveBundlerMode(options) === "development";
+}
+
+function shouldMinify(options: BundlerOptions): boolean {
+  return options.minify ?? (resolveBundlerMode(options) === "production");
+}
+
+function shouldSplitChunks(options: BundlerOptions): boolean {
+  return options.splitting ?? (resolveBundlerMode(options) === "production");
+}
+
+function nodeEnvDefine(options: BundlerOptions): string {
+  return JSON.stringify(resolveBundlerMode(options));
+}
+
+function resolveClientOutDir(rootDir: string, outDir?: string): string {
+  const defaultOutDir = path.join(rootDir, ".mandu/client");
+  if (!outDir) return defaultOutDir;
+
+  const resolvedOutDir = path.isAbsolute(outDir) ? outDir : path.resolve(rootDir, outDir);
+  if (path.normalize(resolvedOutDir) === path.normalize(path.join(rootDir, ".mandu"))) {
+    return defaultOutDir;
+  }
+
+  return resolvedOutDir;
+}
 
 /**
  * Scan for *.island.tsx / *.island.ts files across hydrated route directories.
@@ -262,20 +262,20 @@ async function buildPerIslandBundle(
   // Phase 7.1 B-1/B-4: wire Bun's native React Fast Refresh transform +
   // Mandu's boundary injection plugin — but only in dev. Production
   // bundles stay clean of `$RefreshReg$` / `$RefreshSig$` stubs.
-  const isDev = isDevelopmentBuild(options);
+  const isDev = isDevelopmentBuild(options);
   try {
     await Bun.write(entryPath, generateIslandEntry(entry.name, entry.filePath));
     const result = await safeBuild({
       entrypoints: [entryPath],
       outdir: outDir,
       naming: outputName,
-      minify: shouldMinify(options),
+      minify: shouldMinify(options),
       sourcemap: options.sourcemap ? "external" : "none",
       target: "browser",
       ...(isDev ? { reactFastRefresh: true } : {}),
       plugins: [...manduClientPlugins(options), ...(isDev ? [fastRefreshPlugin()] : [])],
       external: ["react", "react-dom", "react-dom/client", ...(options.external || [])],
-      define: { "process.env.NODE_ENV": nodeEnvDefine(options), ...options.define },
+      define: { "process.env.NODE_ENV": nodeEnvDefine(options), ...options.define },
     });
     await fs.unlink(entryPath).catch(() => {});
     if (!result.success) {
@@ -1267,12 +1267,12 @@ async function buildRouterRuntime(
       entrypoints: [routerPath],
       outdir: outDir,
       naming: outputName,
-      minify: shouldMinify(options),
+      minify: shouldMinify(options),
       sourcemap: options.sourcemap ? "external" : "none",
       target: "browser",
       plugins: manduDefaultPlugins(options),
       define: {
-        "process.env.NODE_ENV": nodeEnvDefine(options),
+        "process.env.NODE_ENV": nodeEnvDefine(options),
         ...options.define,
       },
     });
@@ -1343,13 +1343,13 @@ async function buildRuntime(
       entrypoints: [runtimePath],
       outdir: outDir,
       naming: outputName,
-      minify: shouldMinify(options),
+      minify: shouldMinify(options),
       sourcemap: options.sourcemap ? "external" : "none",
       target: "browser",
       external: ["react", "react-dom", "react-dom/client"],
       plugins: manduDefaultPlugins(options),
       define: {
-        "process.env.NODE_ENV": nodeEnvDefine(options),
+        "process.env.NODE_ENV": nodeEnvDefine(options),
         ...options.define,
       },
     });
@@ -1504,7 +1504,7 @@ async function buildVendorShims(
   // Phase 7.1 B-2: dev-only Fast Refresh shims. In production we skip
   // them entirely so `react-refresh/runtime` is never bundled and the
   // attack surface / bundle size regressions stay zero for deploys.
-  const isDev = isDevelopmentBuild(options);
+  const isDev = isDevelopmentBuild(options);
 
   const shims: Array<{ name: string; source: string; key: VendorShimKey; cacheId: string }> = [
     { name: "_react", source: generateReactShimSource(), key: "react", cacheId: "react" },
@@ -1632,13 +1632,13 @@ async function buildVendorShims(
         entrypoints: [srcPath],
         outdir: outDir,
         naming: outputName,
-        minify: shouldMinify(options),
+        minify: shouldMinify(options),
         sourcemap: options.sourcemap ? "external" : "none",
         target: "browser",
         external: shimExternal,
         plugins: manduDefaultPlugins(options),
         define: {
-          "process.env.NODE_ENV": nodeEnvDefine(options),
+          "process.env.NODE_ENV": nodeEnvDefine(options),
           ...options.define,
         },
       });
@@ -1728,7 +1728,7 @@ async function buildIsland(
 
   // Phase 7.1 B-1/B-4: wire native Fast Refresh transform + Mandu's
   // boundary injection plugin. Dev-only; prod bundles remain clean.
-  const isDev = isDevelopmentBuild(options);
+  const isDev = isDevelopmentBuild(options);
   try {
     // 엔트리 래퍼 생성
     await Bun.write(entryPath, generateIslandEntry(route.id, clientModulePath));
@@ -1739,15 +1739,15 @@ async function buildIsland(
       entrypoints: [entryPath],
       outdir: outDir,
       naming: options.splitting ? "[name]-[hash].js" : outputName,
-      minify: shouldMinify(options),
+      minify: shouldMinify(options),
       sourcemap: options.sourcemap ? "external" : "none",
       target: "browser",
-      splitting: shouldSplitChunks(options),
+      splitting: shouldSplitChunks(options),
       ...(isDev ? { reactFastRefresh: true } : {}),
       plugins: [...manduClientPlugins(options), ...(isDev ? [fastRefreshPlugin()] : [])],
       external: ["react", "react-dom", "react-dom/client", ...(options.external || [])],
       define: {
-        "process.env.NODE_ENV": nodeEnvDefine(options),
+        "process.env.NODE_ENV": nodeEnvDefine(options),
         ...options.define,
       },
     });
@@ -1941,13 +1941,13 @@ export async function buildClientBundles(
       errors.push(`onBundleComplete[${e.source}]: ${e.error.message}`);
     }
   };
-  const env = resolveBundlerMode(options);
+  const env = resolveBundlerMode(options);
 
   // 1. Hydration이 필요한 라우트 필터링
   const hydratedRoutes = getHydratedRoutes(manifest);
 
   // 2. 출력 디렉토리 생성 (항상 필요 - 매니페스트 저장용)
-  const outDir = resolveClientOutDir(rootDir, options.outDir);
+  const outDir = resolveClientOutDir(rootDir, options.outDir);
   await fs.mkdir(outDir, { recursive: true });
 
   // Hydration 라우트가 없어도 빈 매니페스트를 저장해야 함