@mandujs/core 0.53.2 → 0.54.0

package/src/runtime/ssr.ts

@@ -772,10 +772,11 @@ export function renderToHTML(element: ReactElement, options: SSROptions = {}): s
     ? generateFastRefreshPreambleTag(isDev, bundleManifest, resolvedCspNonce)
     : "";
 
-  // Issue #191 — DevTools 번들 (~1.15 MB) 주입 결정.
-  //   - 기본: island 이 하나라도 있을 때만 주입. Pure-SSR 페이지는 0 bytes 다운로드.
-  //   - `devtools === true`  → 강제 주입 (SSR-only 프로젝트에서 Kitchen panel 원할 때)
-  //   - `devtools === false` → 강제 스킵 (island 프로젝트에서도 Kitchen 비활성화)
+  // Issue #191 + #259 — DevTools 번들 (~1.15 MB) 주입 결정.
+  //   - 기본 (dev only): 항상 주입. SSR-only 랜딩에서도 Kitchen 패널 사용 가능.
+  //   - `devtools === true`  → 강제 주입 (의미 변화 없음)
+  //   - `devtools === false` → 강제 스킵 (필요 시 1.15 MB 절약)
+  // 프로덕션 빌드는 `isDev` 가드로 0 bytes 보장.
   // Cache-bust 은 `manifest.buildTime` 우선, 없으면 `Date.now()`.
   let devtoolsScript = "";
   if (isDev && shouldInjectDevtools(devtools, bundleManifest)) {
@@ -1039,27 +1040,27 @@ window.__MANDU_HMR_PORT__ = ${hmrPort};
 }
 
 /**
- * Issue #191 — Determine whether the dev-only `_devtools.js` bundle
- * (~1.15 MB React dev runtime + Kitchen panel) should be injected
- * into the HTML response.
+ * Issue #191 + #259 — Determine whether the dev-only `_devtools.js`
+ * bundle (~1.15 MB React dev runtime + Kitchen panel) should be injected
+ * into the HTML response. The caller gates with `isDev`, so this only
+ * affects dev-mode responses (prod always skips, regardless of the
+ * decision below).
  *
  * Decision table (`devtools` option × manifest shape):
  *
- *   | `devtools`  | hasIslands | inject? | rationale                   |
- *   |-------------|------------|---------|-----------------------------|
- *   | `true`      | any        | YES     | explicit opt-in             |
- *   | `false`     | any        | NO      | explicit opt-out            |
- *   | `undefined` | true       | YES     | default, hydration runtime  |
- *   | `undefined` | false      | NO      | pure-SSR — save 1.15 MB     |
- *   | `undefined` | no manifest| NO      | nothing to hydrate anyway   |
+ *   | `devtools`  | hasIslands | inject? | rationale                    |
+ *   |-------------|------------|---------|------------------------------|
+ *   | `true`      | any        | YES     | explicit opt-in              |
+ *   | `false`     | any        | NO      | explicit opt-out             |
+ *   | `undefined` | true       | YES     | default, hydration runtime   |
+ *   | `undefined` | false      | YES     | dev DX: Kitchen on SSR pages |
+ *   | `undefined` | no manifest| YES     | dev DX: Kitchen pre-build    |
  *
- * `hasIslands` is derived from the existing manifest shape rather than
- * a new field, so no bundler-side change is required:
- *   - `manifest.islands` is populated only when per-island code
- *     splitting produced at least one bundle (build.ts:1654).
- *   - `manifest.bundles` entries exist only for routes where
- *     `needsHydration()` is true (build.ts:70 filter).
- * Either non-empty ⇒ some route on this server hydrates ⇒ devtools useful.
+ * #259 reverted the original #191 default (skip when no islands): SSR-only
+ * landing/marketing pages are the exact place where Kitchen network/error
+ * panels are most needed, and the 1.15 MB cost only applies in dev — prod
+ * builds never emit `_devtools.js`. Users who explicitly want the old
+ * behavior on a per-app basis can still set `dev.devtools: false`.
  *
  * @internal Exported via `_testOnly_shouldInjectDevtools` below so
  * `tests/runtime/devtools-inject.test.ts` can table-test the matrix
@@ -1067,19 +1068,11 @@ window.__MANDU_HMR_PORT__ = ${hmrPort};
  */
 function shouldInjectDevtools(
   devtools: boolean | undefined,
-  manifest: BundleManifest | undefined,
+  _manifest: BundleManifest | undefined,
 ): boolean {
-  // Explicit overrides take absolute precedence.
   if (devtools === true) return true;
   if (devtools === false) return false;
-
-  // Default behavior: inject only when there is at least one island.
-  if (!manifest) return false;
-  const hasIslandsMap =
-    manifest.islands && Object.keys(manifest.islands).length > 0;
-  const hasBundles =
-    manifest.bundles && Object.keys(manifest.bundles).length > 0;
-  return Boolean(hasIslandsMap || hasBundles);
+  return true;
 }
 
 /**

package/src/runtime/streaming-ssr.ts

@@ -80,10 +80,10 @@ export interface StreamingError {
 export interface StreamingMetrics {
   /** Shell ready까지 걸린 시간 (ms) */
   shellReadyTime: number;
-  /** All ready까지 걸린 시간 (ms) */
-  allReadyTime: number;
-  /** Deferred chunk 개수 */
-  deferredChunkCount: number;
+  /** All ready까지 걸린 시간 (ms) */
+  allReadyTime: number;
+  /** Deferred chunk 개수 */
+  deferredChunkCount: number;
   /** 에러 발생 여부 */
   hasError: boolean;
   /** 시작 시간 */
@@ -202,7 +202,7 @@ export interface StreamingSSROptions {
 }
 
 /**
- * Issue #191 — Streaming-SSR mirror of `ssr.ts:shouldInjectDevtools`.
+ * Issue #191 + #259 — Streaming-SSR mirror of `ssr.ts:shouldInjectDevtools`.
  * Kept in sync manually (tiny pure function, not worth a cross-module
  * runtime import — the ssr.ts → streaming-ssr.ts re-export direction
  * means a circular import here would force a refactor of the whole
@@ -211,16 +211,11 @@ export interface StreamingSSROptions {
  */
 function shouldInjectDevtoolsStreaming(
   devtools: boolean | undefined,
-  manifest: BundleManifest | undefined,
+  _manifest: BundleManifest | undefined,
 ): boolean {
   if (devtools === true) return true;
   if (devtools === false) return false;
-  if (!manifest) return false;
-  const hasIslandsMap =
-    manifest.islands && Object.keys(manifest.islands).length > 0;
-  const hasBundles =
-    manifest.bundles && Object.keys(manifest.bundles).length > 0;
-  return Boolean(hasIslandsMap || hasBundles);
+  return true;
 }
 
 /**
@@ -778,10 +773,10 @@ function generateHTMLTailContent(options: StreamingSSROptions): string {
     scripts.push(generateHMRScript(hmrPort));
   }
 
-  // 11. Issue #191 — DevTools 번들 (~1.15 MB) 주입 결정.
-  //   - 기본: manifest 에 island/bundle 이 있을 때만 주입 (pure-SSR 페이지는 스킵).
-  //   - `devtools === true`  → 강제 주입 (SSR-only 프로젝트에서 Kitchen 원할 때).
-  //   - `devtools === false` → 강제 스킵.
+  // 11. Issue #191 + #259 — DevTools 번들 (~1.15 MB) 주입 결정.
+  //   - 기본 (dev only): 항상 주입. SSR-only 랜딩에서도 Kitchen 사용 가능.
+  //   - `devtools === false` → 강제 스킵 (필요 시 1.15 MB 절약).
+  //   - 프로덕션 빌드는 `isDev` 가드로 0 bytes 보장.
   //   - Cache-bust (`?v=buildTime`) 로 HMR 후 stale 방지.
   if (isDev && shouldInjectDevtoolsStreaming(devtools, bundleManifest)) {
     scripts.push(generateStreamingDevtoolsScript(bundleManifest));
@@ -1001,9 +996,9 @@ export async function renderToStream(
 
   // 메트릭 수집
   const metrics: StreamingMetrics = {
-    shellReadyTime: 0,
-    allReadyTime: 0,
-    deferredChunkCount: 0,
+    shellReadyTime: 0,
+    allReadyTime: 0,
+    deferredChunkCount: 0,
     hasError: false,
     startTime: Date.now(),
   };
@@ -1379,9 +1374,9 @@ export async function renderWithDeferredData(
   const encoder = new TextEncoder();
   const startTime = Date.now();
 
-  // 준비된 deferred 스크립트를 담을 배열 (mutable)
-  const readyScripts: string[] = [];
-  let allDeferredSettled = false;
+  // 준비된 deferred 스크립트를 담을 배열 (mutable)
+  const readyScripts: string[] = [];
+  let allDeferredSettled = false;
 
   // 1. Deferred promises 병렬 시작 (막지 않음!)
   const deferredEntries = Object.entries(deferredPromises);
@@ -1395,11 +1390,11 @@ export async function renderWithDeferredData(
             );
             const data = await Promise.race([promise, timeoutPromise]);
 
-            // 스크립트 생성 및 추가
-            const script = generateDeferredDataScript(routeId, key, data);
-            readyScripts.push(script);
-
-            if (isDev) {
+            // 스크립트 생성 및 추가
+            const script = generateDeferredDataScript(routeId, key, data);
+            readyScripts.push(script);
+
+            if (isDev) {
               console.log(`[Mandu Streaming] Deferred ready: ${key} (${Date.now() - startTime}ms)`);
             }
           } catch (error) {
@@ -1473,22 +1468,22 @@ export async function renderWithDeferredData(
 
         // 최종 메트릭 보고 (injectedCount가 실제 메트릭)
         if (onMetrics && baseMetrics) {
-          onMetrics({
-            ...baseMetrics,
-            deferredChunkCount: injectedCount,
-            allReadyTime: Date.now() - startTime,
-          });
+          onMetrics({
+            ...baseMetrics,
+            deferredChunkCount: injectedCount,
+            allReadyTime: Date.now() - startTime,
+          });
         }
 
         controller.close();
       } catch (error) {
         controller.error(error);
       }
-    },
-    cancel() {
-      void reader.cancel();
-    },
-  });
+    },
+    cancel() {
+      void reader.cancel();
+    },
+  });
 
   // Phase 7.2 R1 Agent C (H1): if the base stream produced a CSP
   // nonce during shell emission, forward the matching header on the

package/src/runtime/trace.ts

@@ -1,144 +1,144 @@
-/**
- * Mandu Trace 🧭
- * Lifecycle 단계별 추적 (옵션)
- */
-
-import type { ManduContext } from "../filling/context";
-
-export type TraceEvent =
-  | "request"
-  | "parse"
-  | "transform"
-  | "beforeHandle"
-  | "handle"
-  | "afterHandle"
-  | "mapResponse"
-  | "afterResponse"
-  | "error";
-
-export type TracePhase = "begin" | "end" | "error";
-
-export interface TraceEntry {
-  event: TraceEvent;
-  phase: TracePhase;
-  time: number;
-  name?: string;
-  error?: string;
-}
-
-export interface TraceCollector {
-  records: TraceEntry[];
-}
-
-export interface TraceReportEntry {
-  event: TraceEvent;
-  name?: string;
-  start: number;
-  end: number;
-  duration: number;
-}
-
-export interface TraceReport {
-  entries: TraceReportEntry[];
-  errors: TraceEntry[];
-}
-
-export const TRACE_KEY = "__mandu_trace";
-
-const now = (): number => {
-  if (typeof performance !== "undefined" && typeof performance.now === "function") {
-    return performance.now();
-  }
-  return Date.now();
-};
-
-export function enableTrace(ctx: ManduContext): TraceCollector {
-  const existing = ctx.get<TraceCollector>(TRACE_KEY);
-  if (existing) return existing;
-  const collector: TraceCollector = { records: [] };
-  ctx.set(TRACE_KEY, collector);
-  return collector;
-}
-
-export function getTrace(ctx: ManduContext): TraceCollector | undefined {
-  return ctx.get<TraceCollector>(TRACE_KEY);
-}
-
-/**
- * Build a normalized trace report with durations
- */
-export function buildTraceReport(collector: TraceCollector): TraceReport {
-  const entries: TraceReportEntry[] = [];
-  const errors: TraceEntry[] = [];
-  const stacks = new Map<string, TraceEntry[]>();
-
-  for (const record of collector.records) {
-    if (record.phase === "error") {
-      errors.push(record);
-      continue;
-    }
-
-    const key = `${record.event}:${record.name ?? ""}`;
-    if (record.phase === "begin") {
-      const stack = stacks.get(key) ?? [];
-      stack.push(record);
-      stacks.set(key, stack);
-      continue;
-    }
-
-    if (record.phase === "end") {
-      const stack = stacks.get(key);
-      const begin = stack?.pop();
-      if (!begin) continue;
-      entries.push({
-        event: record.event,
-        name: record.name,
-        start: begin.time,
-        end: record.time,
-        duration: record.time - begin.time,
-      });
-    }
-  }
-
-  return { entries, errors };
-}
-
-/**
- * Convert trace report to JSON string
- */
-export function formatTraceReport(report: TraceReport): string {
-  return JSON.stringify(report, null, 2);
-}
-
-export interface Tracer {
-  enabled: boolean;
-  begin: (event: TraceEvent, name?: string) => () => void;
-  error: (event: TraceEvent, err: unknown, name?: string) => void;
-}
-
-const NOOP_TRACER: Tracer = {
-  enabled: false,
-  begin: () => () => {},
-  error: () => {},
-};
-
-export function createTracer(ctx: ManduContext, enabled?: boolean): Tracer {
-  const shouldEnable = Boolean(enabled) || ctx.has(TRACE_KEY);
-  if (!shouldEnable) return NOOP_TRACER;
-
-  const collector = enableTrace(ctx);
-
-  return {
-    enabled: true,
-    begin: (event, name) => {
-      collector.records.push({ event, phase: "begin", time: now(), name });
-      return () => {
-        collector.records.push({ event, phase: "end", time: now(), name });
-      };
-    },
-    error: (event, err, name) => {
-      const message = err instanceof Error ? err.message : String(err);
-      collector.records.push({ event, phase: "error", time: now(), name, error: message });
-    },
-  };
-}
+/**
+ * Mandu Trace 🧭
+ * Lifecycle 단계별 추적 (옵션)
+ */
+
+import type { ManduContext } from "../filling/context";
+
+export type TraceEvent =
+  | "request"
+  | "parse"
+  | "transform"
+  | "beforeHandle"
+  | "handle"
+  | "afterHandle"
+  | "mapResponse"
+  | "afterResponse"
+  | "error";
+
+export type TracePhase = "begin" | "end" | "error";
+
+export interface TraceEntry {
+  event: TraceEvent;
+  phase: TracePhase;
+  time: number;
+  name?: string;
+  error?: string;
+}
+
+export interface TraceCollector {
+  records: TraceEntry[];
+}
+
+export interface TraceReportEntry {
+  event: TraceEvent;
+  name?: string;
+  start: number;
+  end: number;
+  duration: number;
+}
+
+export interface TraceReport {
+  entries: TraceReportEntry[];
+  errors: TraceEntry[];
+}
+
+export const TRACE_KEY = "__mandu_trace";
+
+const now = (): number => {
+  if (typeof performance !== "undefined" && typeof performance.now === "function") {
+    return performance.now();
+  }
+  return Date.now();
+};
+
+export function enableTrace(ctx: ManduContext): TraceCollector {
+  const existing = ctx.get<TraceCollector>(TRACE_KEY);
+  if (existing) return existing;
+  const collector: TraceCollector = { records: [] };
+  ctx.set(TRACE_KEY, collector);
+  return collector;
+}
+
+export function getTrace(ctx: ManduContext): TraceCollector | undefined {
+  return ctx.get<TraceCollector>(TRACE_KEY);
+}
+
+/**
+ * Build a normalized trace report with durations
+ */
+export function buildTraceReport(collector: TraceCollector): TraceReport {
+  const entries: TraceReportEntry[] = [];
+  const errors: TraceEntry[] = [];
+  const stacks = new Map<string, TraceEntry[]>();
+
+  for (const record of collector.records) {
+    if (record.phase === "error") {
+      errors.push(record);
+      continue;
+    }
+
+    const key = `${record.event}:${record.name ?? ""}`;
+    if (record.phase === "begin") {
+      const stack = stacks.get(key) ?? [];
+      stack.push(record);
+      stacks.set(key, stack);
+      continue;
+    }
+
+    if (record.phase === "end") {
+      const stack = stacks.get(key);
+      const begin = stack?.pop();
+      if (!begin) continue;
+      entries.push({
+        event: record.event,
+        name: record.name,
+        start: begin.time,
+        end: record.time,
+        duration: record.time - begin.time,
+      });
+    }
+  }
+
+  return { entries, errors };
+}
+
+/**
+ * Convert trace report to JSON string
+ */
+export function formatTraceReport(report: TraceReport): string {
+  return JSON.stringify(report, null, 2);
+}
+
+export interface Tracer {
+  enabled: boolean;
+  begin: (event: TraceEvent, name?: string) => () => void;
+  error: (event: TraceEvent, err: unknown, name?: string) => void;
+}
+
+const NOOP_TRACER: Tracer = {
+  enabled: false,
+  begin: () => () => {},
+  error: () => {},
+};
+
+export function createTracer(ctx: ManduContext, enabled?: boolean): Tracer {
+  const shouldEnable = Boolean(enabled) || ctx.has(TRACE_KEY);
+  if (!shouldEnable) return NOOP_TRACER;
+
+  const collector = enableTrace(ctx);
+
+  return {
+    enabled: true,
+    begin: (event, name) => {
+      collector.records.push({ event, phase: "begin", time: now(), name });
+      return () => {
+        collector.records.push({ event, phase: "end", time: now(), name });
+      };
+    },
+    error: (event, err, name) => {
+      const message = err instanceof Error ? err.message : String(err);
+      collector.records.push({ event, phase: "error", time: now(), name, error: message });
+    },
+  };
+}