@mandujs/core 0.53.1 → 0.53.3

package/src/resource/generator-repo.ts

@@ -35,7 +35,7 @@
  *     return {
  *       async findById(id): User | null { ... },
  *       async findMany(limit = 100, offset = 0): User[] { ... },
- *       async create(row): User { ... },   // PG/SQLite: RETURNING *; MySQL: INSERT + SELECT
+ *       async create(row): User { ... },   // PG/SQLite: RETURNING *; MySQL: INSERT + re-select
  *       async update(id, patch): User | null { ... },
  *       async delete(id): boolean { ... },
  *     };
@@ -65,7 +65,7 @@ import type { ParsedResource } from "./parser";
 import type { ResourceField } from "./schema";
 import { quoteIdent } from "./ddl/emit";
 import { toSnakeCase } from "./ddl/snapshot";
-import { asPersistence, type ExtendedResourcePersistence } from "./ddl/persistence-types";
+import { asPersistence, type ExtendedResourcePersistence, type FieldOverride } from "./ddl/persistence-types";
 import type { SqlProvider } from "./ddl/types";
 
 // ============================================
@@ -172,9 +172,10 @@ function renderRepoFile(
   const primaryKeyColumn = columns.find((c) => c.primary)?.column ?? "id";
   const primaryKeyField = columns.find((c) => c.primary)?.field ?? "id";
   const insertColumns = columns.filter((c) => !c.omitOnInsert);
+  const createInputType = createMethodInputType(pascalName, columns);
 
   // Quoted identifiers — precomputed so each builder reads cleanly.
-  const q = (name: string) => quoteIdent(name, provider);
+  const q = (name: string) => escapeSqlTemplateText(quoteIdent(name, provider));
   const qTable = q(table);
 
   // Column list for SELECT: we don't use `*` because aliasing
@@ -194,7 +195,7 @@ function renderRepoFile(
   const body = [
     findByIdMethod(pascalName, qTable, selectList, q, primaryKeyColumn, primaryKeyField),
     findManyMethod(pascalName, qTable, selectList),
-    createMethod(pascalName, table, qTable, selectList, insertColumns, primaryKeyColumn, primaryKeyField, q, provider),
+    createMethod(pascalName, table, qTable, selectList, insertColumns, createInputType, primaryKeyColumn, primaryKeyField, q, provider),
     updateMethod(pascalName, table, qTable, selectList, columns, primaryKeyColumn, primaryKeyField, q, provider),
     deleteMethod(pascalName, qTable, q, primaryKeyColumn, primaryKeyField, provider),
   ].join(",\n\n");
@@ -232,7 +233,7 @@ function renderHeader(
 // - The repo never constructs a Db itself — callers (slots, scripts) pass
 //   in either \`ctx.deps.db\` or a module-level singleton.
 // - Provider-specific SQL (INSERT ... RETURNING * on PG/SQLite vs
-//   INSERT + SELECT LAST_INSERT_ID on MySQL) is resolved at generation
+//   INSERT + re-select on MySQL) is resolved at generation
 //   time; the generated file has one code path per provider.
 `;
 }
@@ -348,6 +349,7 @@ function createMethod(
   qTable: string,
   selectList: string,
   insertColumns: ResolvedColumn[],
+  createInputType: string,
   pkColumn: string,
   pkField: string,
   q: (n: string) => string,
@@ -371,7 +373,7 @@ function createMethod(
      * Insert a new row and return the inserted record. Errors from
      * constraint violations (UNIQUE, NOT NULL, FK) bubble unchanged.
      */
-    async create(input: Omit<${pascalName}, "${pkField}">): Promise<${pascalName}> {
+    async create(input: ${createInputType}): Promise<${pascalName}> {
       const row = await db.one<${pascalName}>\`
         INSERT INTO ${qTable} (${columnList})
         VALUES (${valuePlaceholders})
@@ -382,17 +384,20 @@ function createMethod(
     }`;
   }
 
-  // MySQL: no RETURNING. INSERT then SELECT by LAST_INSERT_ID() OR by the
-  // primary key if caller provided one. For v1 LCD we use a post-INSERT
-  // SELECT that matches on the primary-key the caller supplied; if the
-  // caller omitted it (AUTO_INCREMENT), we fall back to LAST_INSERT_ID().
+  const mysqlLookup = insertColumns.some((c) => c.field === pkField)
+    ? `${q(pkColumn)} = \${input.${pkField}}`
+    : `${q(pkColumn)} = LAST_INSERT_ID()`;
+
+  // MySQL: no RETURNING. INSERT then SELECT by the supplied primary key when
+  // the caller provides it; if the primary key is DB-generated, fall back to
+  // LAST_INSERT_ID().
   return `    /**
      * Insert a new row and return the inserted record via a follow-up SELECT.
      * MySQL lacks RETURNING; the generator uses LAST_INSERT_ID() when the
      * primary key is server-generated, otherwise it re-selects by the
      * provided primary key value.
      */
-    async create(input: Omit<${pascalName}, "${pkField}">): Promise<${pascalName}> {
+    async create(input: ${createInputType}): Promise<${pascalName}> {
       await db\`
         INSERT INTO ${qTable} (${columnList})
         VALUES (${valuePlaceholders})
@@ -400,7 +405,7 @@ function createMethod(
       const row = await db.one<${pascalName}>\`
         SELECT ${selectList}
         FROM ${qTable}
-        WHERE ${q(pkColumn)} = LAST_INSERT_ID()
+        WHERE ${mysqlLookup}
       \`;
       if (!row) throw new Error("${tableName} create: follow-up SELECT returned no row");
       return row;
@@ -541,14 +546,7 @@ function resolveColumns(
     const primary = declaredPkMatch || fieldLevelPk;
     if (primary) pkCount++;
 
-    // Omit PK from INSERT list only when:
-    //   - it's a UUID with a DB-side default (we don't know this at
-    //     generation time for all providers); OR
-    //   - it's an integer and the user didn't explicitly opt in.
-    // Safe default: let the user supply the PK. The generated
-    // `Omit<T, pkField>` on `create` means the caller CAN'T pass it
-    // anyway, so we omit PK from the insert column list unconditionally.
-    const omitOnInsert = primary;
+    const omitOnInsert = primary && hasDbDefault(field, override);
 
     columns.push({ field: fieldKey, column, primary, omitOnInsert });
   }
@@ -575,6 +573,28 @@ function resolveDeclaredPrimaryKey(
   return declared[0];
 }
 
+function createMethodInputType(
+  pascalName: string,
+  columns: ResolvedColumn[],
+): string {
+  const omittedFields = columns
+    .filter((c) => c.omitOnInsert)
+    .map((c) => JSON.stringify(c.field));
+  if (omittedFields.length === 0) return pascalName;
+  return `Omit<${pascalName}, ${omittedFields.join(" | ")}>`;
+}
+
+function hasDbDefault(
+  field: ResourceField,
+  override: FieldOverride | undefined,
+): boolean {
+  return override?.default !== undefined || field.default !== undefined;
+}
+
+function escapeSqlTemplateText(text: string): string {
+  return text.replace(/`/g, "\\`");
+}
+
 function resolveTableName(
   resource: ParsedResource,
   persistence: ExtendedResourcePersistence,

package/src/runtime/ssr.ts

@@ -772,10 +772,11 @@ export function renderToHTML(element: ReactElement, options: SSROptions = {}): s
     ? generateFastRefreshPreambleTag(isDev, bundleManifest, resolvedCspNonce)
     : "";
 
-  // Issue #191 — DevTools 번들 (~1.15 MB) 주입 결정.
-  //   - 기본: island 이 하나라도 있을 때만 주입. Pure-SSR 페이지는 0 bytes 다운로드.
-  //   - `devtools === true`  → 강제 주입 (SSR-only 프로젝트에서 Kitchen panel 원할 때)
-  //   - `devtools === false` → 강제 스킵 (island 프로젝트에서도 Kitchen 비활성화)
+  // Issue #191 + #259 — DevTools 번들 (~1.15 MB) 주입 결정.
+  //   - 기본 (dev only): 항상 주입. SSR-only 랜딩에서도 Kitchen 패널 사용 가능.
+  //   - `devtools === true`  → 강제 주입 (의미 변화 없음)
+  //   - `devtools === false` → 강제 스킵 (필요 시 1.15 MB 절약)
+  // 프로덕션 빌드는 `isDev` 가드로 0 bytes 보장.
   // Cache-bust 은 `manifest.buildTime` 우선, 없으면 `Date.now()`.
   let devtoolsScript = "";
   if (isDev && shouldInjectDevtools(devtools, bundleManifest)) {
@@ -1039,27 +1040,27 @@ window.__MANDU_HMR_PORT__ = ${hmrPort};
 }
 
 /**
- * Issue #191 — Determine whether the dev-only `_devtools.js` bundle
- * (~1.15 MB React dev runtime + Kitchen panel) should be injected
- * into the HTML response.
+ * Issue #191 + #259 — Determine whether the dev-only `_devtools.js`
+ * bundle (~1.15 MB React dev runtime + Kitchen panel) should be injected
+ * into the HTML response. The caller gates with `isDev`, so this only
+ * affects dev-mode responses (prod always skips, regardless of the
+ * decision below).
  *
  * Decision table (`devtools` option × manifest shape):
  *
- *   | `devtools`  | hasIslands | inject? | rationale                   |
- *   |-------------|------------|---------|-----------------------------|
- *   | `true`      | any        | YES     | explicit opt-in             |
- *   | `false`     | any        | NO      | explicit opt-out            |
- *   | `undefined` | true       | YES     | default, hydration runtime  |
- *   | `undefined` | false      | NO      | pure-SSR — save 1.15 MB     |
- *   | `undefined` | no manifest| NO      | nothing to hydrate anyway   |
+ *   | `devtools`  | hasIslands | inject? | rationale                    |
+ *   |-------------|------------|---------|------------------------------|
+ *   | `true`      | any        | YES     | explicit opt-in              |
+ *   | `false`     | any        | NO      | explicit opt-out             |
+ *   | `undefined` | true       | YES     | default, hydration runtime   |
+ *   | `undefined` | false      | YES     | dev DX: Kitchen on SSR pages |
+ *   | `undefined` | no manifest| YES     | dev DX: Kitchen pre-build    |
  *
- * `hasIslands` is derived from the existing manifest shape rather than
- * a new field, so no bundler-side change is required:
- *   - `manifest.islands` is populated only when per-island code
- *     splitting produced at least one bundle (build.ts:1654).
- *   - `manifest.bundles` entries exist only for routes where
- *     `needsHydration()` is true (build.ts:70 filter).
- * Either non-empty ⇒ some route on this server hydrates ⇒ devtools useful.
+ * #259 reverted the original #191 default (skip when no islands): SSR-only
+ * landing/marketing pages are the exact place where Kitchen network/error
+ * panels are most needed, and the 1.15 MB cost only applies in dev — prod
+ * builds never emit `_devtools.js`. Users who explicitly want the old
+ * behavior on a per-app basis can still set `dev.devtools: false`.
  *
  * @internal Exported via `_testOnly_shouldInjectDevtools` below so
  * `tests/runtime/devtools-inject.test.ts` can table-test the matrix
@@ -1067,19 +1068,11 @@ window.__MANDU_HMR_PORT__ = ${hmrPort};
  */
 function shouldInjectDevtools(
   devtools: boolean | undefined,
-  manifest: BundleManifest | undefined,
+  _manifest: BundleManifest | undefined,
 ): boolean {
-  // Explicit overrides take absolute precedence.
   if (devtools === true) return true;
   if (devtools === false) return false;
-
-  // Default behavior: inject only when there is at least one island.
-  if (!manifest) return false;
-  const hasIslandsMap =
-    manifest.islands && Object.keys(manifest.islands).length > 0;
-  const hasBundles =
-    manifest.bundles && Object.keys(manifest.bundles).length > 0;
-  return Boolean(hasIslandsMap || hasBundles);
+  return true;
 }
 
 /**

package/src/runtime/streaming-ssr.ts

@@ -80,10 +80,10 @@ export interface StreamingError {
 export interface StreamingMetrics {
   /** Shell ready까지 걸린 시간 (ms) */
   shellReadyTime: number;
-  /** All ready까지 걸린 시간 (ms) */
-  allReadyTime: number;
-  /** Deferred chunk 개수 */
-  deferredChunkCount: number;
+  /** All ready까지 걸린 시간 (ms) */
+  allReadyTime: number;
+  /** Deferred chunk 개수 */
+  deferredChunkCount: number;
   /** 에러 발생 여부 */
   hasError: boolean;
   /** 시작 시간 */
@@ -202,7 +202,7 @@ export interface StreamingSSROptions {
 }
 
 /**
- * Issue #191 — Streaming-SSR mirror of `ssr.ts:shouldInjectDevtools`.
+ * Issue #191 + #259 — Streaming-SSR mirror of `ssr.ts:shouldInjectDevtools`.
  * Kept in sync manually (tiny pure function, not worth a cross-module
  * runtime import — the ssr.ts → streaming-ssr.ts re-export direction
  * means a circular import here would force a refactor of the whole
@@ -211,16 +211,11 @@ export interface StreamingSSROptions {
  */
 function shouldInjectDevtoolsStreaming(
   devtools: boolean | undefined,
-  manifest: BundleManifest | undefined,
+  _manifest: BundleManifest | undefined,
 ): boolean {
   if (devtools === true) return true;
   if (devtools === false) return false;
-  if (!manifest) return false;
-  const hasIslandsMap =
-    manifest.islands && Object.keys(manifest.islands).length > 0;
-  const hasBundles =
-    manifest.bundles && Object.keys(manifest.bundles).length > 0;
-  return Boolean(hasIslandsMap || hasBundles);
+  return true;
 }
 
 /**
@@ -778,10 +773,10 @@ function generateHTMLTailContent(options: StreamingSSROptions): string {
     scripts.push(generateHMRScript(hmrPort));
   }
 
-  // 11. Issue #191 — DevTools 번들 (~1.15 MB) 주입 결정.
-  //   - 기본: manifest 에 island/bundle 이 있을 때만 주입 (pure-SSR 페이지는 스킵).
-  //   - `devtools === true`  → 강제 주입 (SSR-only 프로젝트에서 Kitchen 원할 때).
-  //   - `devtools === false` → 강제 스킵.
+  // 11. Issue #191 + #259 — DevTools 번들 (~1.15 MB) 주입 결정.
+  //   - 기본 (dev only): 항상 주입. SSR-only 랜딩에서도 Kitchen 사용 가능.
+  //   - `devtools === false` → 강제 스킵 (필요 시 1.15 MB 절약).
+  //   - 프로덕션 빌드는 `isDev` 가드로 0 bytes 보장.
   //   - Cache-bust (`?v=buildTime`) 로 HMR 후 stale 방지.
   if (isDev && shouldInjectDevtoolsStreaming(devtools, bundleManifest)) {
     scripts.push(generateStreamingDevtoolsScript(bundleManifest));
@@ -1001,9 +996,9 @@ export async function renderToStream(
 
   // 메트릭 수집
   const metrics: StreamingMetrics = {
-    shellReadyTime: 0,
-    allReadyTime: 0,
-    deferredChunkCount: 0,
+    shellReadyTime: 0,
+    allReadyTime: 0,
+    deferredChunkCount: 0,
     hasError: false,
     startTime: Date.now(),
   };
@@ -1379,9 +1374,9 @@ export async function renderWithDeferredData(
   const encoder = new TextEncoder();
   const startTime = Date.now();
 
-  // 준비된 deferred 스크립트를 담을 배열 (mutable)
-  const readyScripts: string[] = [];
-  let allDeferredSettled = false;
+  // 준비된 deferred 스크립트를 담을 배열 (mutable)
+  const readyScripts: string[] = [];
+  let allDeferredSettled = false;
 
   // 1. Deferred promises 병렬 시작 (막지 않음!)
   const deferredEntries = Object.entries(deferredPromises);
@@ -1395,11 +1390,11 @@ export async function renderWithDeferredData(
             );
             const data = await Promise.race([promise, timeoutPromise]);
 
-            // 스크립트 생성 및 추가
-            const script = generateDeferredDataScript(routeId, key, data);
-            readyScripts.push(script);
-
-            if (isDev) {
+            // 스크립트 생성 및 추가
+            const script = generateDeferredDataScript(routeId, key, data);
+            readyScripts.push(script);
+
+            if (isDev) {
               console.log(`[Mandu Streaming] Deferred ready: ${key} (${Date.now() - startTime}ms)`);
             }
           } catch (error) {
@@ -1473,22 +1468,22 @@ export async function renderWithDeferredData(
 
         // 최종 메트릭 보고 (injectedCount가 실제 메트릭)
         if (onMetrics && baseMetrics) {
-          onMetrics({
-            ...baseMetrics,
-            deferredChunkCount: injectedCount,
-            allReadyTime: Date.now() - startTime,
-          });
+          onMetrics({
+            ...baseMetrics,
+            deferredChunkCount: injectedCount,
+            allReadyTime: Date.now() - startTime,
+          });
         }
 
         controller.close();
       } catch (error) {
         controller.error(error);
       }
-    },
-    cancel() {
-      void reader.cancel();
-    },
-  });
+    },
+    cancel() {
+      void reader.cancel();
+    },
+  });
 
   // Phase 7.2 R1 Agent C (H1): if the base stream produced a CSP
   // nonce during shell emission, forward the matching header on the