@malloydata/malloy 0.0.94-dev231006134059 → 0.0.94-dev231007180531

package/dist/dialect/dialect.d.ts

@@ -37,6 +37,7 @@ export declare abstract class Dialect {
     abstract supportsQualify: boolean;
     abstract supportsSafeCast: boolean;
     abstract supportsNesting: boolean;
+    cantPartitionWindowFunctionsOnExpressions: boolean;
     abstract getGlobalFunctionDef(name: string): DialectFunctionOverloadDef[] | undefined;
     abstract quoteTablePath(tablePath: string): string;
     abstract sqlGroupSetTable(groupSetCount: number): string;

package/dist/dialect/dialect.js

@@ -52,6 +52,13 @@ function qtz(qi) {
 }
 exports.qtz = qtz;
 class Dialect {
+    constructor() {
+        // -- we should add flags with default values from now on so as to not break
+        // dialects outside our repository
+        //
+        // StandardSQL dialects can't partition on expression in window functions
+        this.cantPartitionWindowFunctionsOnExpressions = false;
+    }
     sqlFinalStage(_lastStageName, _fields) {
         throw new Error('Dialect has no final Stage but called Anyway');
     }

package/dist/dialect/standardsql/standardsql.d.ts

@@ -20,6 +20,7 @@ export declare class StandardSQLDialect extends Dialect {
     supportsQualify: boolean;
     supportsSafeCast: boolean;
     supportsNesting: boolean;
+    cantPartitionWindowFunctionsOnExpressions: boolean;
     quoteTablePath(tablePath: string): string;
     sqlGroupSetTable(groupSetCount: number): string;
     sqlAnyValue(groupSet: number, fieldName: string): string;

package/dist/dialect/standardsql/standardsql.js

@@ -92,6 +92,7 @@ class StandardSQLDialect extends dialect_1.Dialect {
         this.supportsQualify = true;
         this.supportsSafeCast = true;
         this.supportsNesting = true;
+        this.cantPartitionWindowFunctionsOnExpressions = true;
         this.keywords = `
   ALL
   AND

package/dist/model/malloy_query.js

@@ -1476,7 +1476,7 @@ class QueryQuery extends QueryField {
         for (const expr of e) {
             if ((0, malloy_types_1.isFunctionCallFragment)(expr) &&
                 (0, malloy_types_1.expressionIsAnalytic)(expr.overload.returnType.expressionType) &&
-                this.parent.dialect.name === 'standardsql') {
+                this.parent.dialect.cantPartitionWindowFunctionsOnExpressions) {
                 // force the use of a lateral_join_bag
                 resultStruct.root().isComplexQuery = true;
                 resultStruct.root().queryUsesPartitioning = true;
@@ -2060,7 +2060,7 @@ class QueryQuery extends QueryField {
                 if (fi.fieldUsage.type === 'result') {
                     const exp = fi.getSQL();
                     if (isScalarField(fi.f)) {
-                        if (this.parent.dialect.name === 'standardsql' &&
+                        if (this.parent.dialect.cantPartitionWindowFunctionsOnExpressions &&
                             this.rootResult.queryUsesPartitioning) {
                             // BigQuery can't partition aggregate function except when the field has no
                             //  expression.  Additionally it can't partition by floats.  We stuff expressions

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@malloydata/malloy",
-  "version": "0.0.94-dev231006134059",
+  "version": "0.0.94-dev231007180531",
   "license": "MIT",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",