@malloydata/malloy 0.0.435 → 0.0.436

package/dist/lang/ast/view-elements/refine-utils.js

@@ -33,6 +33,7 @@ function refine(logTo, refineTo, refineFrom) {
             if (from.orderBy !== undefined && !from.defaultOrderBy) {
                 if (to.orderBy === undefined || to.defaultOrderBy) {
                     to.orderBy = from.orderBy;
+                    delete to.defaultOrderBy;
                 }
                 else {
                     logTo.logError('ordering-overridden-in-refinement', 'refinement cannot override existing ordering');

package/dist/lang/composite-source-utils.js

@@ -28,6 +28,7 @@ exports.pathBegins = pathBegins;
 exports.hasCompositesAnywhere = hasCompositesAnywhere;
 exports.logCompositeError = logCompositeError;
 const malloy_filter_1 = require("@malloydata/malloy-filter");
+const sql_compiled_1 = require("../model/sql_compiled");
 const malloy_types_1 = require("../model/malloy_types");
 const utils_1 = require("./utils");
 const utils_2 = require("../model/utils");
@@ -1214,9 +1215,12 @@ function computeQueryGivenUsage(pipeline) {
     return result;
 }
 // Returns every given a SourceDef references — its own filterList plus any
-// givens hiding inside an embedded Query. The single point of knowledge for
-// "where can a Query embed in a SourceDef" — when a future SourceDef variant
-// grows an embedded Query, teach this helper.
+// givens hiding inside an embedded Query. For a persistable source the
+// embedded part is `givenUsageOfRelation` (model/sql_compiled.ts), which is
+// also what persistence keys a table on; the filterList is added here because
+// a query over the source applies it, but a table built from the source does
+// not. When a future SourceDef variant grows an embedded Query, teach that
+// helper or this one.
 //
 // Composite sources: composite-source support across the codebase is
 // partial; the givens work isn't chasing it. The `composite` arm here is
@@ -1226,23 +1230,12 @@ function computeQueryGivenUsage(pipeline) {
 // reaches here (e.g. composites in join positions if/when those work),
 // the conservative union over all branches is the safe fallback.
 function givenUsageOfSource(sd) {
-    var _a, _b, _c;
+    var _a;
     const fromFilters = ((_a = sd.filterList) !== null && _a !== void 0 ? _a : []).flatMap(f => (0, malloy_types_1.givenUsageFrom)(f.refSummary));
     switch (sd.type) {
         case 'query_source':
-            return [...fromFilters, ...((_b = sd.query.givenUsage) !== null && _b !== void 0 ? _b : [])];
-        case 'sql_select': {
-            const fromSegments = ((_c = sd.selectSegments) !== null && _c !== void 0 ? _c : []).flatMap(seg => {
-                var _a;
-                if ((0, malloy_types_1.isSegmentSQL)(seg))
-                    return [];
-                if ((0, malloy_types_1.isSegmentSource)(seg))
-                    return givenUsageOfSource(seg);
-                // Remaining variant of SQLPhraseSegment is `Query`
-                return (_a = seg.givenUsage) !== null && _a !== void 0 ? _a : [];
-            });
-            return [...fromFilters, ...fromSegments];
-        }
+        case 'sql_select':
+            return [...fromFilters, ...(0, sql_compiled_1.givenUsageOfRelation)(sd)];
         case 'composite':
             return [
                 ...fromFilters,

package/dist/lang/parse-log.d.ts

@@ -64,6 +64,17 @@ type MessageParameterTypes = {
     'nesting-unsupported': {
         dialect: string;
     };
+    'boolean-value-unsupported': {
+        dialect: string;
+        where: string;
+        hint: string;
+    };
+    'wildcard-omits-boolean': {
+        dialect: string;
+        wildcard: string;
+        name: string;
+        hint: string;
+    };
     'nested-multi-stage-unsupported': {
         dialect: string;
     };
@@ -297,6 +308,7 @@ type MessageParameterTypes = {
     'export-name-not-exportable': string;
     'duplicate-export-name': string;
     'unsatisfied-given-in-query': string;
+    'unsatisfied-given-in-persist-source': string;
     'given-alias-collision': string;
     'failed-to-compute-output-schema': string;
     'invalid-timeframe-for-time-offset': string;

package/dist/lang/parse-log.js

@@ -56,6 +56,8 @@ exports.MESSAGE_FORMATTERS = {
     }),
     'experimental-dialect-not-enabled': e => `Requires compiler flag '##! experimental.dialect.${e.dialect}'`,
     'nesting-unsupported': e => `'${e.dialect}' does not support nested queries`,
+    'boolean-value-unsupported': e => `'${e.dialect}' does not support a boolean ${e.where}; ${e.hint}`,
+    'wildcard-omits-boolean': e => `'${e.name}' is left out of '${e.wildcard}': '${e.dialect}' does not support a boolean as a result column; ${e.hint}`,
     'nested-multi-stage-unsupported': e => `'${e.dialect}' does not support a multi-stage pipeline ('->') in a nested query`,
     'nested-projection-limit-unsupported': e => `'${e.dialect}' does not support 'limit:' on a nested 'select:'`,
     'pick-missing-else': "pick incomplete, missing 'else'",

package/dist/lang/test/test-translator.d.ts

@@ -29,6 +29,7 @@ export declare const aTableDef: TableSourceDef;
 export declare const db2TableDef: TableSourceDef;
 export declare const bqTableDef: SourceDef;
 export declare const pgTableDef: SourceDef;
+export declare const mssqlTableDef: SourceDef;
 /**
  * A TestTranlator never actually talks to connection, instead uses
  * some mocked schema definitions.
@@ -69,7 +70,7 @@ export interface TestTranslatorOptions {
 }
 /**
  * Every connection name a test mentions resolves to a dialect, as it would
- * through a host's connection lookup: the four listed below to theirs, and
+ * through a host's connection lookup: the five listed below to theirs, and
  * any other name to `TEST_DIALECT`.
  */
 declare class TestConnectionDialectZone extends Zone<string> {

package/dist/lang/test/test-translator.js

@@ -5,7 +5,7 @@
  * SPDX-License-Identifier: MIT
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.BetaExpression = exports.TestTranslator = exports.TestChildTranslator = exports.mockSchema = exports.pgTableDef = exports.bqTableDef = exports.db2TableDef = exports.aTableDef = exports.TEST_DIALECT = void 0;
+exports.BetaExpression = exports.TestTranslator = exports.TestChildTranslator = exports.mockSchema = exports.mssqlTableDef = exports.pgTableDef = exports.bqTableDef = exports.db2TableDef = exports.aTableDef = exports.TEST_DIALECT = void 0;
 exports.pretty = pretty;
 exports.humanify = humanify;
 exports.getExplore = getExplore;
@@ -194,6 +194,16 @@ exports.pgTableDef = {
     connection: '_pg_',
     fields: baseFields,
 };
+// SQL Server has no boolean values (booleanType 'none'), so no column of
+// its table is a boolean
+exports.mssqlTableDef = {
+    type: 'table',
+    name: 'aTable',
+    dialect: 'sqlserver',
+    tablePath: 'aTable',
+    connection: '_mssql_',
+    fields: baseFields.filter(f => f.name !== 'abool'),
+};
 /**
  * A TestTranlator never actually talks to connection, instead uses
  * some mocked schema definitions.
@@ -203,6 +213,7 @@ exports.mockSchema = [
     exports.db2TableDef,
     exports.bqTableDef,
     exports.pgTableDef,
+    exports.mssqlTableDef,
     {
         type: 'table',
         name: 'carriers',
@@ -339,7 +350,7 @@ exports.TestChildTranslator = TestChildTranslator;
 const testURI = 'internal://test/langtests/root.malloy';
 /**
  * Every connection name a test mentions resolves to a dialect, as it would
- * through a host's connection lookup: the four listed below to theirs, and
+ * through a host's connection lookup: the five listed below to theirs, and
  * any other name to `TEST_DIALECT`.
  */
 class TestConnectionDialectZone extends zone_1.Zone {
@@ -357,7 +368,7 @@ class TestTranslator extends parse_malloy_1.MalloyTranslator {
         this.testSrc = testSrc;
         this.connectionDialectZone = new TestConnectionDialectZone();
         /*
-         * There are four connections:
+         * There are five connections:
          *   _db_  - duckdb dialect, with the following tables ...
          *      aTable, malloytest.carriers, malloytest.flights, malloytest.airports
          *   _db2_ - duckdb dialect, with one table, aTable. A second connection
@@ -366,6 +377,8 @@ class TestTranslator extends parse_malloy_1.MalloyTranslator {
          *      aTable
          *   _pg_  - postgres dialect, with one table
          *      aTable
+         *   _mssql_ - sqlserver dialect, which has no boolean values, with one
+         *      table, aTable
          *
          * The "aTable" table is a mocked table with one column of each type.
          * The _bq_ version does not have the timestamptz column, and when
@@ -394,6 +407,7 @@ class TestTranslator extends parse_malloy_1.MalloyTranslator {
                 _db2_: { type: 'connection', name: '_db2_' },
                 _bq_: { type: 'connection', name: '_bq_' },
                 _pg_: { type: 'connection', name: '_pg_' },
+                _mssql_: { type: 'connection', name: '_mssql_' },
                 a: { ...exports.aTableDef, primaryKey: 'astr', name: 'a' },
                 b: { ...exports.aTableDef, primaryKey: 'astr', name: 'b' },
                 bq_a: { ...exports.bqTableDef, primaryKey: 'astr', name: 'bq_a' },
@@ -451,6 +465,7 @@ class TestTranslator extends parse_malloy_1.MalloyTranslator {
         this.connectionDialectZone.define('_db2_', exports.TEST_DIALECT);
         this.connectionDialectZone.define('_bq_', 'standardsql');
         this.connectionDialectZone.define('_pg_', 'postgres');
+        this.connectionDialectZone.define('_mssql_', 'sqlserver');
         for (const flag of (_e = options.compilerFlags) !== null && _e !== void 0 ? _e : []) {
             this.compilerFlagSrc.push(`##! ${flag}\n`);
         }
@@ -658,10 +673,29 @@ function makeModelFunc(options) {
         const { prefix, wrap, ...ttOptions } = options;
         return {
             ...ms,
+            // A marked location is where the mark sits in the whole source, after
+            // the prefix. A wrap could put the code anywhere, so marks stay as
+            // they are.
+            locations: wrap ? ms.locations : ms.locations.map(l => after(prefix, l)),
             translator: new TestTranslator((prefix !== null && prefix !== void 0 ? prefix : '') + (wrap ? wrap(ms.code) : ms.code), ttOptions),
         };
     };
 }
+function after(prefix, l) {
+    if (!prefix)
+        return l;
+    const lines = prefix.split('\n');
+    const dLine = lines.length - 1;
+    const dChar = lines[dLine].length;
+    const shift = (p) => ({
+        line: p.line + dLine,
+        character: p.line === 0 ? p.character + dChar : p.character,
+    });
+    return {
+        ...l,
+        range: { start: shift(l.range.start), end: shift(l.range.end) },
+    };
+}
 function makeExprFunc(model, sourceName = 'ab', options = {}) {
     return function expr(unmarked, ...marked) {
         const ms = markSource(unmarked, ...marked);

package/dist/model/expression_compiler.js

@@ -109,7 +109,7 @@ function compileExpr(resultSet, context, expr, state = new utils_1.GenerateState
         return expr;
     }
     const sql = (() => {
-        var _a;
+        var _a, _b;
         switch (expr.node) {
             case 'field':
                 return generateFieldFragment(resultSet, context, expr, state);
@@ -176,7 +176,7 @@ function compileExpr(resultSet, context, expr, state = new utils_1.GenerateState
             // Malloy inequality comparisons always return a boolean
             case '!=': {
                 const notEqual = `${expr.kids.left.sql}!=${expr.kids.right.sql}`;
-                return `COALESCE(${notEqual},true)`;
+                return context.dialect.sqlNullIsTrue(notEqual);
             }
             case 'and':
             case 'or':
@@ -192,13 +192,13 @@ function compileExpr(resultSet, context, expr, state = new utils_1.GenerateState
                 // null binding collapses to empty-set semantics — not the SQL
                 // `IN (NULL)` shape, which has confusing NULL-membership rules.
                 if (bound.node === 'null') {
-                    return expr.not ? 'TRUE' : 'FALSE';
+                    return context.dialect.sqlBoolean(expr.not);
                 }
                 if (bound.node !== 'arrayLiteral') {
                     throw new Error(`Internal compiler error: 'inGiven' bound to '${bound.node}', expected 'arrayLiteral'. The translator should have rejected a non-array given here.`);
                 }
                 if (bound.kids.values.length === 0) {
-                    return expr.not ? 'TRUE' : 'FALSE';
+                    return context.dialect.sqlBoolean(expr.not);
                 }
                 const elemSqls = bound.kids.values.map(v => exprToSQL(resultSet, context, v, state));
                 const verb = expr.not ? 'NOT IN' : 'IN';
@@ -210,13 +210,14 @@ function compileExpr(resultSet, context, expr, state = new utils_1.GenerateState
                 const compare = expr.kids.right.node === 'stringLiteral'
                     ? context.dialect.sqlLike(likeIt, (_a = expr.kids.left.sql) !== null && _a !== void 0 ? _a : '', expr.kids.right.literal)
                     : `${expr.kids.left.sql} ${likeIt} ${expr.kids.right.sql}`;
-                return expr.node === 'like' ? compare : `COALESCE(${compare},true)`;
+                return expr.node === 'like'
+                    ? compare
+                    : context.dialect.sqlNullIsTrue(compare);
             }
             case '()':
                 return `(${expr.e.sql})`;
             case 'not':
-                // Malloy not operator always returns a boolean
-                return `COALESCE(NOT ${expr.e.sql},TRUE)`;
+                return context.dialect.sqlNot((_b = expr.e.sql) !== null && _b !== void 0 ? _b : '');
             case 'unary-':
                 return `-${expr.e.sql}`;
             case 'is-null':

package/dist/model/filter_compilers.js

@@ -34,13 +34,13 @@ function unlike(disLiked, x) {
 // The `none` filter ("always false") compiles to a constant, independent of
 // column type or value; `not none` is "always true". Shared by the top-level
 // guard and every per-type compiler so the constant lives in one place.
-function noneToSQL(not) {
-    return not ? 'true' : 'false';
+function noneToSQL(not, d) {
+    return d.sqlBoolean(not === true);
 }
 exports.FilterCompilers = {
     compile(t, c, x, d, qi = {}) {
         if (c === null) {
-            return 'true';
+            return d.sqlBoolean(true);
         }
         // `none` is the always-false filter (companion to the empty/`null` filter,
         // which is always-true above). It compiles to a constant independent of
@@ -48,7 +48,7 @@ exports.FilterCompilers = {
         // also the primary path for boolean, whose compiler has no switch and
         // would otherwise route `none` through the null/false truth-table.
         if (c.operator === 'none') {
-            return noneToSQL(c.not);
+            return noneToSQL(c.not, d);
         }
         if (t === 'string' && (0, malloy_filter_1.isStringFilter)(c)) {
             return exports.FilterCompilers.stringCompile(c, x, d);
@@ -102,7 +102,7 @@ exports.FilterCompilers = {
             case 'null':
                 return nc.not ? `${x} IS NOT NULL` : `${x} IS NULL`;
             case 'none':
-                return noneToSQL(nc.not);
+                return noneToSQL(nc.not, d);
             case '()': {
                 const wrapped = '(' + exports.FilterCompilers.numberCompile(nc.expr, x, d) + ')';
                 return nc.not ? `NOT ${wrapped}` : wrapped;
@@ -135,7 +135,7 @@ exports.FilterCompilers = {
             // Normally intercepted by compile()'s top-level guard; handled here too so
             // booleanCompile is self-safe (this if-chain has no default, and `none`
             // must not fall through to the null/false truth-table below).
-            return noneToSQL(bc.not);
+            return noneToSQL(bc.not, d);
         }
         else if (bc.operator === '=true') {
             return bc.not ? `NOT ${px}` : x;
@@ -172,7 +172,7 @@ exports.FilterCompilers = {
             case 'null':
                 return sc.not ? `${x} IS NOT NULL` : `${x} IS NULL`;
             case 'none':
-                return noneToSQL(sc.not);
+                return noneToSQL(sc.not, d);
             case 'empty':
                 return sc.not ? `COALESCE(${x},'') != ''` : `COALESCE(${x},'') = ''`;
             case '=': {
@@ -267,7 +267,7 @@ exports.FilterCompilers = {
                     }
                 }
                 if ((includeEmpty && excludeEmpty) || (includeNull && excludeNull)) {
-                    return 'false';
+                    return d.sqlBoolean(false);
                 }
                 let includeSQL = '';
                 if (includes.length > 0 || includeNull || includeEmpty) {
@@ -298,7 +298,7 @@ exports.FilterCompilers = {
                         ? `(${includeSQL}) AND (${excludeSQL})`
                         : includeSQL;
                 }
-                return excludeSQL !== '' ? excludeSQL : 'true';
+                return excludeSQL !== '' ? excludeSQL : d.sqlBoolean(true);
             }
         }
     },
@@ -331,7 +331,7 @@ class TemporalFilterCompiler {
         if (this.timetype !== 'date') {
             return timeSQL;
         }
-        return this.d.sqlCast({}, {
+        const toDate = {
             node: 'cast',
             e: {
                 node: 'genericSQLExpr',
@@ -342,7 +342,8 @@ class TemporalFilterCompiler {
             srcType: { type: 'timestamp' },
             dstType: { type: 'date' },
             safe: false,
-        });
+        };
+        return this.d.sqlTimeCast(this.qi, toDate);
     }
     compile(tc) {
         const x = this.expr;
@@ -421,7 +422,7 @@ class TemporalFilterCompiler {
             case 'null':
                 return tc.not ? `${x} IS NOT NULL` : `${x} IS NULL`;
             case 'none':
-                return noneToSQL(tc.not);
+                return noneToSQL(tc.not, this.d);
             case '()': {
                 const wrapped = '(' + this.compile(tc.expr) + ')';
                 return tc.not ? `NOT ${wrapped}` : wrapped;

package/dist/model/given_binding.d.ts

@@ -27,3 +27,11 @@ export declare function resolveSuppliedGivens(supplied: Record<string, GivenValu
  * `resolveGiven`), which needs no ordering.
  */
 export declare function evaluateInlineGivens(bound: Map<GivenID, Expr>, modelDef: ModelDef | undefined): Map<GivenID, Expr>;
+/**
+ * Binds the givens a compile runs under: the supplied values, then each
+ * `inline` given's default folded against them. Queries and persistence builds
+ * both bind here, so the same values always compile to the same SQL and a
+ * persisted table's key is the key a query recomputes. Undefined when nothing
+ * binds, which the compiler reads as "no givens".
+ */
+export declare function bindGivens(supplied: Record<string, GivenValue> | undefined, modelDef: ModelDef | undefined): Map<GivenID, Expr> | undefined;

package/dist/model/given_binding.js

@@ -7,6 +7,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.lookupGivenValue = lookupGivenValue;
 exports.resolveSuppliedGivens = resolveSuppliedGivens;
 exports.evaluateInlineGivens = evaluateInlineGivens;
+exports.bindGivens = bindGivens;
 const luxon_1 = require("luxon");
 const closest_match_1 = require("../util/closest_match");
 const inline_expr_1 = require("./inline_expr");
@@ -106,6 +107,18 @@ function evaluateInlineGivens(bound, modelDef) {
     }
     return bound;
 }
+/**
+ * Binds the givens a compile runs under: the supplied values, then each
+ * `inline` given's default folded against them. Queries and persistence builds
+ * both bind here, so the same values always compile to the same SQL and a
+ * persisted table's key is the key a query recomputes. Undefined when nothing
+ * binds, which the compiler reads as "no givens".
+ */
+function bindGivens(supplied, modelDef) {
+    const bound = resolveSuppliedGivens(supplied, modelDef);
+    evaluateInlineGivens(bound, modelDef);
+    return bound.size > 0 ? bound : undefined;
+}
 function valueToExpr(path, type, value) {
     var _a, _b;
     if (value === null) {

package/dist/model/index.d.ts

@@ -7,7 +7,7 @@ export { getResultStructDefForQuery, getResultStructDefForView, } from './query_
 export { indent, composeSQLExpr, makeDigest, mkModelDef, mkModelID, pathToKey, typeDefToString, } from './utils';
 export { getModelAnnotations } from './annotation_utils';
 export { constantExprToSQL } from './constant_expression_compiler';
-export { getCompiledSQL, buildIdOptions } from './sql_compiled';
+export { getCompiledSQL, buildIdOptions, givenUsageOfRelation, } from './sql_compiled';
 export type { BuildIdOptions } from './sql_compiled';
 export { MalloyCompileError } from './malloy_compile_error';
 export { mkSourceID, mkBuildID, mkQuerySourceDef, mkSQLSourceDef, mkTableSourceDef, resolveSourceID, resolveSourceRef, sourceNamespaceReference, registerSource, hasSourceRegistryEntry, } from './source_def_utils';

package/dist/model/index.js

@@ -18,7 +18,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
     for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.hasSourceRegistryEntry = exports.registerSource = exports.sourceNamespaceReference = exports.resolveSourceRef = exports.resolveSourceID = exports.mkTableSourceDef = exports.mkSQLSourceDef = exports.mkQuerySourceDef = exports.mkBuildID = exports.mkSourceID = exports.MalloyCompileError = exports.buildIdOptions = exports.getCompiledSQL = exports.constantExprToSQL = exports.getModelAnnotations = exports.typeDefToString = exports.pathToKey = exports.mkModelID = exports.mkModelDef = exports.makeDigest = exports.composeSQLExpr = exports.indent = exports.getResultStructDefForView = exports.getResultStructDefForQuery = exports.QueryModel = exports.QueryQuery = exports.QueryStruct = exports.QueryField = void 0;
+exports.hasSourceRegistryEntry = exports.registerSource = exports.sourceNamespaceReference = exports.resolveSourceRef = exports.resolveSourceID = exports.mkTableSourceDef = exports.mkSQLSourceDef = exports.mkQuerySourceDef = exports.mkBuildID = exports.mkSourceID = exports.MalloyCompileError = exports.givenUsageOfRelation = exports.buildIdOptions = exports.getCompiledSQL = exports.constantExprToSQL = exports.getModelAnnotations = exports.typeDefToString = exports.pathToKey = exports.mkModelID = exports.mkModelDef = exports.makeDigest = exports.composeSQLExpr = exports.indent = exports.getResultStructDefForView = exports.getResultStructDefForQuery = exports.QueryModel = exports.QueryQuery = exports.QueryStruct = exports.QueryField = void 0;
 __exportStar(require("./malloy_types"), exports);
 const query_node_1 = require("./query_node");
 Object.defineProperty(exports, "QueryField", { enumerable: true, get: function () { return query_node_1.QueryField; } });
@@ -52,6 +52,7 @@ Object.defineProperty(exports, "constantExprToSQL", { enumerable: true, get: fun
 var sql_compiled_1 = require("./sql_compiled");
 Object.defineProperty(exports, "getCompiledSQL", { enumerable: true, get: function () { return sql_compiled_1.getCompiledSQL; } });
 Object.defineProperty(exports, "buildIdOptions", { enumerable: true, get: function () { return sql_compiled_1.buildIdOptions; } });
+Object.defineProperty(exports, "givenUsageOfRelation", { enumerable: true, get: function () { return sql_compiled_1.givenUsageOfRelation; } });
 var malloy_compile_error_1 = require("./malloy_compile_error");
 Object.defineProperty(exports, "MalloyCompileError", { enumerable: true, get: function () { return malloy_compile_error_1.MalloyCompileError; } });
 var source_def_utils_1 = require("./source_def_utils");

package/dist/model/sql_compiled.d.ts

@@ -1,4 +1,4 @@
-import type { PrepareResultOptions, SQLSourceDef, SQLPhraseSegment, PersistableSourceDef, Query, VirtualMap } from './malloy_types';
+import type { Expr, GivenID, GivenUsage, PrepareResultOptions, SQLSourceDef, SQLPhraseSegment, PersistableSourceDef, Query, VirtualMap } from './malloy_types';
 /**
  * Callback type for compiling a Query to SQL.
  * opts is optional - omit for "full SQL" (BuildID computation),
@@ -19,31 +19,23 @@ export declare function getCompiledSQL(src: SQLSourceDef, opts: PrepareResultOpt
 /** Expand SQL text and interpolations for schema discovery or execution. */
 export declare function expandSQLSegments(segments: SQLPhraseSegment[], opts: PrepareResultOptions, compileQuery: CompileQueryCallback): string;
 /**
- * The options a BuildID's SQL is compiled under — everything the builder and
- * the compiler must both know, and nothing else.
+ * What a BuildID's SQL is generated under: everything that changes what the
+ * SQL computes and that the builder and the compiler can both know.
  *
- * Narrow on purpose. A BuildID must not depend on what has already been built
- * or build order would change the key, so this type cannot express a manifest;
+ * No manifest. A BuildID must not depend on what has already been built, or
+ * build order would change the key, so this type cannot carry one;
  * `mkBuildTargets` takes it for the same reason.
+ *
+ * `virtualMap` decides which table a virtual source reads. `resolvedGivens`
+ * is the value of every given the SQL reads, supplied or defaulted; both sides
+ * produce it through `bindGivens`, so equal values give the same key and
+ * different values give different keys.
  */
 export interface BuildIdOptions {
     virtualMap?: VirtualMap;
+    resolvedGivens?: Map<GivenID, Expr>;
 }
-/**
- * Project compile options down to what a BuildID is computed under.
- *
- * `virtualMap` decides which table a virtual source reads, so it changes the
- * SQL and has to be in the key; the builder supplies its own.
- *
- * `resolvedGivens` is deliberately absent even though it also changes the SQL.
- * The builder has no way to produce one — `Runtime.getBuildTargets` takes no
- * givens and `PersistSource.getSQL` never resolves them — so including it makes
- * the two sides disagree: the compiler folds `$IS_ADMIN` to a literal while the
- * builder re-derives it from the declaration and emits `'admin'='admin'`. Both
- * sides therefore compile givens the same way, by not resolving them. The
- * consequence — a source whose SQL depends on a supplied given cannot be
- * persisted, and says so badly — is #3041.
- */
+/** Project compile options down to what a BuildID is computed under. */
 export declare function buildIdOptions(opts: PrepareResultOptions): BuildIdOptions;
 /**
  * Ask the manifest what table backs a persistable source.
@@ -57,6 +49,13 @@ export declare function buildIdOptions(opts: PrepareResultOptions): BuildIdOptio
  *         undefined when the caller should emit the source's own SQL.
  */
 export declare function persistedTableFor(source: PersistableSourceDef, opts: PrepareResultOptions, compileQuery: CompileQueryCallback): string | undefined;
+/**
+ * The givens a persisted source's SQL reads — the relation, not the source.
+ * A `where:` added by `extend` is applied by the query that reads the table,
+ * so it is not here, and a given used only there does not split the table by
+ * value. Mirrors `getSourceSQL`: what that compiles, this reports on.
+ */
+export declare function givenUsageOfRelation(source: PersistableSourceDef): GivenUsage;
 /**
  * Get the SQL for a PersistableSourceDef.
  *

package/dist/model/sql_compiled.js

@@ -8,6 +8,7 @@ exports.getCompiledSQL = getCompiledSQL;
 exports.expandSQLSegments = expandSQLSegments;
 exports.buildIdOptions = buildIdOptions;
 exports.persistedTableFor = persistedTableFor;
+exports.givenUsageOfRelation = givenUsageOfRelation;
 exports.getSourceSQL = getSourceSQL;
 const malloy_types_1 = require("./malloy_types");
 const source_def_utils_1 = require("./source_def_utils");
@@ -50,23 +51,9 @@ function expandSegment(segment, opts, compileQuery) {
     // Query segment
     return expandQuery(segment, opts, compileQuery);
 }
-/**
- * Project compile options down to what a BuildID is computed under.
- *
- * `virtualMap` decides which table a virtual source reads, so it changes the
- * SQL and has to be in the key; the builder supplies its own.
- *
- * `resolvedGivens` is deliberately absent even though it also changes the SQL.
- * The builder has no way to produce one — `Runtime.getBuildTargets` takes no
- * givens and `PersistSource.getSQL` never resolves them — so including it makes
- * the two sides disagree: the compiler folds `$IS_ADMIN` to a literal while the
- * builder re-derives it from the declaration and emits `'admin'='admin'`. Both
- * sides therefore compile givens the same way, by not resolving them. The
- * consequence — a source whose SQL depends on a supplied given cannot be
- * persisted, and says so badly — is #3041.
- */
+/** Project compile options down to what a BuildID is computed under. */
 function buildIdOptions(opts) {
-    return { virtualMap: opts.virtualMap };
+    return { virtualMap: opts.virtualMap, resolvedGivens: opts.resolvedGivens };
 }
 /**
  * Ask the manifest what table backs a persistable source.
@@ -100,12 +87,37 @@ function persistedTableFor(source, opts, compileQuery) {
         const named = source.sourceID
             ? `Persisted source '${source.sourceID}'`
             : 'Persisted source';
+        const perValue = givenUsageOfRelation(source).length > 0
+            ? ' This source reads givens, and no table was built for the given ' +
+                'values this query supplies.'
+            : '';
         const base = `${named} not found in manifest (buildId: ${buildId}); ` +
-            'strict manifest mode forbids fallback to live compilation.';
+            'strict manifest mode forbids fallback to live compilation.' +
+            perValue;
         throw new malloy_compile_error_1.MalloyCompileError(buildManifest.loadError ? `${base}\n  ${buildManifest.loadError}` : base, 'runtime-manifest-strict-miss', source.location);
     }
     return undefined;
 }
+/**
+ * The givens a persisted source's SQL reads — the relation, not the source.
+ * A `where:` added by `extend` is applied by the query that reads the table,
+ * so it is not here, and a given used only there does not split the table by
+ * value. Mirrors `getSourceSQL`: what that compiles, this reports on.
+ */
+function givenUsageOfRelation(source) {
+    var _a, _b;
+    if (source.type === 'query_source') {
+        return (_a = source.query.givenUsage) !== null && _a !== void 0 ? _a : [];
+    }
+    return ((_b = source.selectSegments) !== null && _b !== void 0 ? _b : []).flatMap(segment => {
+        var _a;
+        if ((0, malloy_types_1.isSegmentSQL)(segment))
+            return [];
+        if ((0, malloy_types_1.isSegmentSource)(segment))
+            return givenUsageOfRelation(segment);
+        return (_a = segment.givenUsage) !== null && _a !== void 0 ? _a : [];
+    });
+}
 /**
  * Expand a PersistableSourceDef as a `%{ }` segment.
  * Always returns a subquery form: (SELECT * FROM table) or (inline SQL)

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const MALLOY_VERSION = "0.0.435";
+export declare const MALLOY_VERSION = "0.0.436";

package/dist/version.js

@@ -2,5 +2,5 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.MALLOY_VERSION = void 0;
 // generated with 'generate-version-file' script; do not edit manually
-exports.MALLOY_VERSION = '0.0.435';
+exports.MALLOY_VERSION = '0.0.436';
 //# sourceMappingURL=version.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@malloydata/malloy",
-  "version": "0.0.435",
+  "version": "0.0.436",
   "license": "MIT",
   "exports": {
     ".": "./dist/index.js",
@@ -51,9 +51,9 @@
     "generate-version-file": "VERSION=$(npm pkg get version --workspaces=false | tr -d \\\")\necho \"// generated with 'generate-version-file' script; do not edit manually\\nexport const MALLOY_VERSION = '$VERSION';\" > src/version.ts"
   },
   "dependencies": {
-    "@malloydata/malloy-filter": "0.0.435",
-    "@malloydata/malloy-interfaces": "0.0.435",
-    "@malloydata/malloy-tag": "0.0.435",
+    "@malloydata/malloy-filter": "0.0.436",
+    "@malloydata/malloy-interfaces": "0.0.436",
+    "@malloydata/malloy-tag": "0.0.436",
     "@noble/hashes": "^1.8.0",
     "antlr4ts": "^0.5.0-alpha.4",
     "assert": "^2.0.0",